Re: [Freeipa-devel] [PATCH] 21 Fix directory manager password validation in ipa-nis-manage

2011-06-13 Thread Martin Kosek
On Mon, 2011-06-13 at 12:32 +0200, Jan Cholasta wrote: > On 9.6.2011 14:50, Martin Kosek wrote: > > On Wed, 2011-06-08 at 15:21 +0200, Jan Cholasta wrote: > >> https://fedorahosted.org/freeipa/ticket/1283 > >> https://fedorahosted.org/freeipa/ticket/1284 > >> > >> Honza > > > > Patch works fine, bu

Re: [Freeipa-devel] [PATCH] 21 Fix directory manager password validation in ipa-nis-manage

2011-06-13 Thread Jan Cholasta
On 9.6.2011 14:50, Martin Kosek wrote: On Wed, 2011-06-08 at 15:21 +0200, Jan Cholasta wrote: https://fedorahosted.org/freeipa/ticket/1283 https://fedorahosted.org/freeipa/ticket/1284 Honza Patch works fine, but I'd like to improve code quality a bit. Please don't call sys.exit() from get_dir

Re: [Freeipa-devel] [PATCH] 21 Fix directory manager password validation in ipa-nis-manage

2011-06-09 Thread Martin Kosek
On Wed, 2011-06-08 at 15:21 +0200, Jan Cholasta wrote: > https://fedorahosted.org/freeipa/ticket/1283 > https://fedorahosted.org/freeipa/ticket/1284 > > Honza Patch works fine, but I'd like to improve code quality a bit. Please don't call sys.exit() from get_dirman_password(). It doesn't make rea

[Freeipa-devel] [PATCH] 21 Fix directory manager password validation in ipa-nis-manage

2011-06-08 Thread Jan Cholasta
https://fedorahosted.org/freeipa/ticket/1283 https://fedorahosted.org/freeipa/ticket/1284 Honza -- Jan Cholasta >From 7567db4bedc08ce4d649f33d7d37af7970a32145 Mon Sep 17 00:00:00 2001 From: Jan Cholasta Date: Wed, 8 Jun 2011 14:39:50 +0200 Subject: [PATCH] Fix directory manager password validat