Re: [Freeipa-devel] [PATCH] 591 improve error reporting when adding/removing members

2010-10-28 Thread Rob Crittenden

Adam Young wrote:

On 10/28/2010 02:43 PM, Rob Crittenden wrote:

Return reason for failure when updating group membership fails.

We used to return a list of dns that failed to be added. We now return
a list of tuples instead. The tuple looks like (dn, reason) where
reason is the exception that was returned.

Also made the label we use for failures to be singular instead of
plural since we now print them out individually instead of as
comma-separated.

https://fedorahosted.org/freeipa/ticket/270

$ ipa group-add-member --users=tuser9,tuser1 --groups=g1 g1
Group name: g1
Description: g1
GID: 1332445043
Member users: tuser1
Failed members:
user: tuser9: no such entry
user: tuser1: This entry is already a member of the group
group: g1: A group may not be added as a member of itself
-
Number of members added 0
-

rob


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

ACK


rebased and pushed to master

___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel


Re: [Freeipa-devel] [PATCH] 591 improve error reporting when adding/removing members

2010-10-28 Thread Adam Young

On 10/28/2010 02:43 PM, Rob Crittenden wrote:

Return reason for failure when updating group membership fails.

We used to return a list of dns that failed to be added. We now return 
a list of tuples instead. The tuple looks like (dn, reason) where 
reason is the exception that was returned.


Also made the label we use for failures to be singular instead of 
plural since we now print them out individually instead of as 
comma-separated.


https://fedorahosted.org/freeipa/ticket/270

$ ipa group-add-member --users=tuser9,tuser1 --groups=g1 g1
   Group name: g1
   Description: g1
   GID: 1332445043
   Member users: tuser1
   Failed members:
 user: tuser9: no such entry
 user: tuser1: This entry is already a member of the group
 group: g1: A group may not be added as a member of itself
-
Number of members added 0
-

rob


___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

ACK
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel

[Freeipa-devel] [PATCH] 591 improve error reporting when adding/removing members

2010-10-28 Thread Rob Crittenden

Return reason for failure when updating group membership fails.

We used to return a list of dns that failed to be added. We now return a 
list of tuples instead. The tuple looks like (dn, reason) where reason 
is the exception that was returned.


Also made the label we use for failures to be singular instead of plural 
since we now print them out individually instead of as comma-separated.


https://fedorahosted.org/freeipa/ticket/270

$ ipa group-add-member --users=tuser9,tuser1 --groups=g1 g1
   Group name: g1
   Description: g1
   GID: 1332445043
   Member users: tuser1
   Failed members:
 user: tuser9: no such entry
 user: tuser1: This entry is already a member of the group
 group: g1: A group may not be added as a member of itself
-
Number of members added 0
-

rob



rcrit-freeipa-591-fail.patch
Description: application/mbox
___
Freeipa-devel mailing list
Freeipa-devel@redhat.com
https://www.redhat.com/mailman/listinfo/freeipa-devel