Re: [Freeipa-devel] [PATCH 0307] Server Install: print message that client is being installed
On 09/11/2015 04:00 PM, Simo Sorce wrote: On Fri, 2015-09-11 at 14:49 +0200, Martin Basti wrote: On 09/03/2015 03:56 PM, Simo Sorce wrote: On Thu, 2015-09-03 at 15:32 +0200, Martin Basti wrote: On 09/03/2015 02:42 PM, Simo Sorce wrote: On Thu, 2015-09-03 at 10:19 +0200, Martin Basti wrote: On 09/02/2015 06:00 PM, Simo Sorce wrote: On Wed, 2015-09-02 at 17:57 +0200, Martin Basti wrote: Client installation is done as "Restarting web server". This step deserve own message. Patch attached I've seen various cases like this. And I can't understand why these steps aren't embedded in the actual instance install steps that need the restart (which implicitly also provide a message). In the promotion patchset I did move steps like this into the proper instances, so I would prefer you do the same with the install path as that is more appropriate. Simo. We need restart httpd after CA, DNS(optional) installation, so thats why it is outside of httpd instance. You need to restart httpd always after CA install as it changes the proxy settings, but why do you need to restart it after DNS installation ? It is needed due changes in resolv.conf (I think it is fine to restart it twice if it is really needed after DNS change). IMO it is waste of time to restart httpd twice in one minute Can we resolve this in 4.4, where might be place to finish improvements in installer? (If this is not blocking replica promotion) Ok, it is not important enough to waste time now. Simo. Can be this patch pushed to master then? Yes Pushed to master: 7f0076b9a5f2aced1f27b976217309be2eec0b1c -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0307] Server Install: print message that client is being installed
On Fri, 2015-09-11 at 14:49 +0200, Martin Basti wrote: > > On 09/03/2015 03:56 PM, Simo Sorce wrote: > > On Thu, 2015-09-03 at 15:32 +0200, Martin Basti wrote: > >> On 09/03/2015 02:42 PM, Simo Sorce wrote: > >>> On Thu, 2015-09-03 at 10:19 +0200, Martin Basti wrote: > On 09/02/2015 06:00 PM, Simo Sorce wrote: > > On Wed, 2015-09-02 at 17:57 +0200, Martin Basti wrote: > >> Client installation is done as "Restarting web server". This step > >> deserve own message. > >> > >> Patch attached > > I've seen various cases like this. And I can't understand why these > > steps aren't embedded in the actual instance install steps that need the > > restart (which implicitly also provide a message). > > > > In the promotion patchset I did move steps like this into the proper > > instances, so I would prefer you do the same with the install path as > > that is more appropriate. > > > > Simo. > > > We need restart httpd after CA, DNS(optional) installation, so thats why > it is outside of httpd instance. > >>> You need to restart httpd always after CA install as it changes the > >>> proxy settings, but why do you need to restart it after DNS > >>> installation ? > >> It is needed due changes in resolv.conf > >>> (I think it is fine to restart it twice if it is really needed after DNS > >>> change). > >> IMO it is waste of time to restart httpd twice in one minute > >> > >> Can we resolve this in 4.4, where might be place to finish improvements > >> in installer? (If this is not blocking replica promotion) > > Ok, it is not important enough to waste time now. > > > > Simo. > > > > Can be this patch pushed to master then? Yes -- Simo Sorce * Red Hat, Inc * New York -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0307] Server Install: print message that client is being installed
On 09/03/2015 03:56 PM, Simo Sorce wrote: On Thu, 2015-09-03 at 15:32 +0200, Martin Basti wrote: On 09/03/2015 02:42 PM, Simo Sorce wrote: On Thu, 2015-09-03 at 10:19 +0200, Martin Basti wrote: On 09/02/2015 06:00 PM, Simo Sorce wrote: On Wed, 2015-09-02 at 17:57 +0200, Martin Basti wrote: Client installation is done as "Restarting web server". This step deserve own message. Patch attached I've seen various cases like this. And I can't understand why these steps aren't embedded in the actual instance install steps that need the restart (which implicitly also provide a message). In the promotion patchset I did move steps like this into the proper instances, so I would prefer you do the same with the install path as that is more appropriate. Simo. We need restart httpd after CA, DNS(optional) installation, so thats why it is outside of httpd instance. You need to restart httpd always after CA install as it changes the proxy settings, but why do you need to restart it after DNS installation ? It is needed due changes in resolv.conf (I think it is fine to restart it twice if it is really needed after DNS change). IMO it is waste of time to restart httpd twice in one minute Can we resolve this in 4.4, where might be place to finish improvements in installer? (If this is not blocking replica promotion) Ok, it is not important enough to waste time now. Simo. Can be this patch pushed to master then? Martin^2 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0307] Server Install: print message that client is being installed
On Thu, 2015-09-03 at 15:32 +0200, Martin Basti wrote: > > On 09/03/2015 02:42 PM, Simo Sorce wrote: > > On Thu, 2015-09-03 at 10:19 +0200, Martin Basti wrote: > >> On 09/02/2015 06:00 PM, Simo Sorce wrote: > >>> On Wed, 2015-09-02 at 17:57 +0200, Martin Basti wrote: > Client installation is done as "Restarting web server". This step > deserve own message. > > Patch attached > >>> I've seen various cases like this. And I can't understand why these > >>> steps aren't embedded in the actual instance install steps that need the > >>> restart (which implicitly also provide a message). > >>> > >>> In the promotion patchset I did move steps like this into the proper > >>> instances, so I would prefer you do the same with the install path as > >>> that is more appropriate. > >>> > >>> Simo. > >>> > >> We need restart httpd after CA, DNS(optional) installation, so thats why > >> it is outside of httpd instance. > > You need to restart httpd always after CA install as it changes the > > proxy settings, but why do you need to restart it after DNS > > installation ? > It is needed due changes in resolv.conf > > > > (I think it is fine to restart it twice if it is really needed after DNS > > change). > IMO it is waste of time to restart httpd twice in one minute > > Can we resolve this in 4.4, where might be place to finish improvements > in installer? (If this is not blocking replica promotion) Ok, it is not important enough to waste time now. Simo. -- Simo Sorce * Red Hat, Inc * New York -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0307] Server Install: print message that client is being installed
On 09/03/2015 02:42 PM, Simo Sorce wrote: On Thu, 2015-09-03 at 10:19 +0200, Martin Basti wrote: On 09/02/2015 06:00 PM, Simo Sorce wrote: On Wed, 2015-09-02 at 17:57 +0200, Martin Basti wrote: Client installation is done as "Restarting web server". This step deserve own message. Patch attached I've seen various cases like this. And I can't understand why these steps aren't embedded in the actual instance install steps that need the restart (which implicitly also provide a message). In the promotion patchset I did move steps like this into the proper instances, so I would prefer you do the same with the install path as that is more appropriate. Simo. We need restart httpd after CA, DNS(optional) installation, so thats why it is outside of httpd instance. You need to restart httpd always after CA install as it changes the proxy settings, but why do you need to restart it after DNS installation ? It is needed due changes in resolv.conf (I think it is fine to restart it twice if it is really needed after DNS change). IMO it is waste of time to restart httpd twice in one minute Can we resolve this in 4.4, where might be place to finish improvements in installer? (If this is not blocking replica promotion) Martin^2 Client install has no own step yet, it is just call of ipa-client-install. This is fine, ipa-client-install is another ball of wax. Simo. -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0307] Server Install: print message that client is being installed
On Thu, 2015-09-03 at 10:19 +0200, Martin Basti wrote: > On 09/02/2015 06:00 PM, Simo Sorce wrote: > > On Wed, 2015-09-02 at 17:57 +0200, Martin Basti wrote: > >> Client installation is done as "Restarting web server". This step > >> deserve own message. > >> > >> Patch attached > > I've seen various cases like this. And I can't understand why these > > steps aren't embedded in the actual instance install steps that need the > > restart (which implicitly also provide a message). > > > > In the promotion patchset I did move steps like this into the proper > > instances, so I would prefer you do the same with the install path as > > that is more appropriate. > > > > Simo. > > > > We need restart httpd after CA, DNS(optional) installation, so thats why > it is outside of httpd instance. You need to restart httpd always after CA install as it changes the proxy settings, but why do you need to restart it after DNS installation ? (I think it is fine to restart it twice if it is really needed after DNS change). > Client install has no own step yet, it is just call of ipa-client-install. This is fine, ipa-client-install is another ball of wax. Simo. -- Simo Sorce * Red Hat, Inc * New York -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0307] Server Install: print message that client is being installed
On 09/02/2015 06:00 PM, Simo Sorce wrote: On Wed, 2015-09-02 at 17:57 +0200, Martin Basti wrote: Client installation is done as "Restarting web server". This step deserve own message. Patch attached I've seen various cases like this. And I can't understand why these steps aren't embedded in the actual instance install steps that need the restart (which implicitly also provide a message). In the promotion patchset I did move steps like this into the proper instances, so I would prefer you do the same with the install path as that is more appropriate. Simo. We need restart httpd after CA, DNS(optional) installation, so thats why it is outside of httpd instance. Client install has no own step yet, it is just call of ipa-client-install. Martin^2 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
Re: [Freeipa-devel] [PATCH 0307] Server Install: print message that client is being installed
On Wed, 2015-09-02 at 17:57 +0200, Martin Basti wrote: > Client installation is done as "Restarting web server". This step > deserve own message. > > Patch attached I've seen various cases like this. And I can't understand why these steps aren't embedded in the actual instance install steps that need the restart (which implicitly also provide a message). In the promotion patchset I did move steps like this into the proper instances, so I would prefer you do the same with the install path as that is more appropriate. Simo. -- Simo Sorce * Red Hat, Inc * New York -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [PATCH 0307] Server Install: print message that client is being installed
Client installation is done as "Restarting web server". This step
deserve own message.
Patch attached
From 9f2cf83cf9673a40d7a094a411c242eef34e8d98 Mon Sep 17 00:00:00 2001
From: Martin Basti
Date: Wed, 2 Sep 2015 12:00:51 +0200
Subject: [PATCH] Server Install: print message that client is being installed
IPA client is installed on server side during "Restarting web server"
step, which lasts too long. This commit explicitly print message that
IPA client is being installed.
---
ipaserver/install/server/install.py| 1 +
ipaserver/install/server/replicainstall.py | 1 +
2 files changed, 2 insertions(+)
diff --git a/ipaserver/install/server/install.py b/ipaserver/install/server/install.py
index 0277ab91c01ac737bd3820800d1190ef06bdf23d..e1218dc5ce83834ef21825ebf78c3d1929b362bf 100644
--- a/ipaserver/install/server/install.py
+++ b/ipaserver/install/server/install.py
@@ -879,6 +879,7 @@ def install(installer):
ds.change_admin_password(admin_password)
# Call client install script
+service.print_msg("Configuring client side components")
try:
args = [paths.IPA_CLIENT_INSTALL, "--on-master", "--unattended",
"--domain", domain_name, "--server", host_name,
diff --git a/ipaserver/install/server/replicainstall.py b/ipaserver/install/server/replicainstall.py
index 0cadf73740cbf498c60a0439e656978e0fbf6938..10839d31a9bdef061e8184056540e170b3a7a243 100644
--- a/ipaserver/install/server/replicainstall.py
+++ b/ipaserver/install/server/replicainstall.py
@@ -624,6 +624,7 @@ def install(installer):
http.restart()
# Call client install script
+service.print_msg("Configuring client side components")
try:
args = [paths.IPA_CLIENT_INSTALL, "--on-master", "--unattended",
"--domain", config.domain_name, "--server", config.host_name,
--
2.4.3
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
