[Freeipa-devel] [freeipa PR#84] Removed update_from_dict function from ldapupdate (comment)
rcritten commented on a pull request """ For the record this test used to pass. Don't blame the test when the code it is testing was changed. """ See the full comment at https://github.com/freeipa/freeipa/pull/84#issuecomment-247329152 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#84] Removed update_from_dict function from ldapupdate (comment)
stlaz commented on a pull request """ Well, I did fix the test, then. I can imagine the function being pretty handy as a library function although it'd better be used in the future. What infuriates me is the fact that the test might have never worked (well, at least year and a half, but my guess is never) and nobody really cared. """ See the full comment at https://github.com/freeipa/freeipa/pull/84#issuecomment-247309050 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#84] Removed update_from_dict function from ldapupdate (comment)
abbra commented on a pull request """ Update plugins are higher level of abstraction. They use ipaserver.install.ldapupdate.LDAPUpdate which provides both .update() and .update_from_dict() methods. Update plugins can produce dictionaries. With the change in this pull request they will have to always write down dynamic update content to files first and then run LDAPUpdate.update() with those files. Or re-implement .update_from_dict(). That's why I gave a NACK -- consider this coming from the work I'm doing right now to create documentation for external plugins. It is silly to remove function only to introduce it back. """ See the full comment at https://github.com/freeipa/freeipa/pull/84#issuecomment-247307982 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
[Freeipa-devel] [freeipa PR#84] Removed update_from_dict function from ldapupdate (comment)
mbasti-rh commented on a pull request """ Shouldn't external plugins use update files or update plugins as IPA does? We don't have any guaranteed internal API for anything, we don't have any document about external plugins, we don't have prepared any API for 3rd party plugins. We just have your POC 3rd party plugin. Unless there is no design document with serious investigation and agreed workflow how to work with 3rd party plugins, provided stable well tested API for 3rd party plugins (not just internal API that may and will change), then "is a handy" is not valid argument for me. I don't remember that we did freeze our internal API, so 3rd party plugins will fail with any change there. """ See the full comment at https://github.com/freeipa/freeipa/pull/84#issuecomment-247302163 -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
