Re: [Freeipa-devel] patch acceptance criteria

2015-12-08 Thread Rob Crittenden
Petr Spacek wrote: > On 4.12.2015 14:42, Rob Crittenden wrote: >> Lukas Slebodnik wrote: On (03/12/15 09:59), Rob Crittenden wrote: >> Lukas Slebodnik wrote: On (02/12/15 13:14), Rob Crittenden wrote: >> Is it still mandatory that tests pass the unit tests before

Re: [Freeipa-devel] patch acceptance criteria

2015-12-08 Thread Petr Spacek
On 4.12.2015 14:42, Rob Crittenden wrote: > Lukas Slebodnik wrote: >> > On (03/12/15 09:59), Rob Crittenden wrote: >>> >> Lukas Slebodnik wrote: >>> On (02/12/15 13:14), Rob Crittenden wrote: > Is it still mandatory that tests pass the unit tests before > acceptance? >>

Re: [Freeipa-devel] patch acceptance criteria

2015-12-04 Thread Petr Vobornik
On 12/02/2015 07:14 PM, Rob Crittenden wrote: Is it still mandatory that tests pass the unit tests before acceptance? I've seen a number of cases over the past couple of months where a change goes through then shortly afterward a patch to fix the tests. IMHO this should be caught in advance. Thi

Re: [Freeipa-devel] patch acceptance criteria

2015-12-04 Thread Rob Crittenden
Lukas Slebodnik wrote: > On (03/12/15 09:59), Rob Crittenden wrote: >> Lukas Slebodnik wrote: >>> On (02/12/15 13:14), Rob Crittenden wrote: Is it still mandatory that tests pass the unit tests before acceptance? >>> Unit test could be executed as part of "%check" phase in spec files. >>> I re

Re: [Freeipa-devel] patch acceptance criteria

2015-12-04 Thread Lukas Slebodnik
On (03/12/15 09:59), Rob Crittenden wrote: >Lukas Slebodnik wrote: >> On (02/12/15 13:14), Rob Crittenden wrote: >>> Is it still mandatory that tests pass the unit tests before acceptance? >> Unit test could be executed as part of "%check" phase in spec files. >> I recently added C-base unit tests

Re: [Freeipa-devel] patch acceptance criteria

2015-12-03 Thread Jakub Hrozek
On Thu, Dec 03, 2015 at 09:59:46AM -0500, Rob Crittenden wrote: > Lukas Slebodnik wrote: > > On (02/12/15 13:14), Rob Crittenden wrote: > >> Is it still mandatory that tests pass the unit tests before acceptance? > > Unit test could be executed as part of "%check" phase in spec files. > > I recentl

Re: [Freeipa-devel] patch acceptance criteria

2015-12-03 Thread Rob Crittenden
Petr Spacek wrote: > On 3.12.2015 16:07, Rob Crittenden wrote: >> Petr Spacek wrote: >>> On 3.12.2015 15:34, Rob Crittenden wrote: Martin Kosek wrote: > On 12/03/2015 09:08 AM, Petr Spacek wrote: >> On 2.12.2015 19:14, Rob Crittenden wrote: >>> Is it still mandatory that tests pass

Re: [Freeipa-devel] patch acceptance criteria

2015-12-03 Thread Petr Spacek
On 3.12.2015 16:07, Rob Crittenden wrote: > Petr Spacek wrote: >> On 3.12.2015 15:34, Rob Crittenden wrote: >>> Martin Kosek wrote: On 12/03/2015 09:08 AM, Petr Spacek wrote: > On 2.12.2015 19:14, Rob Crittenden wrote: >> Is it still mandatory that tests pass the unit tests before acce

Re: [Freeipa-devel] patch acceptance criteria

2015-12-03 Thread Rob Crittenden
Petr Spacek wrote: > On 3.12.2015 15:34, Rob Crittenden wrote: >> Martin Kosek wrote: >>> On 12/03/2015 09:08 AM, Petr Spacek wrote: On 2.12.2015 19:14, Rob Crittenden wrote: > Is it still mandatory that tests pass the unit tests before acceptance? > I've seen a number of cases over th

Re: [Freeipa-devel] patch acceptance criteria

2015-12-03 Thread Lukas Slebodnik
On (03/12/15 15:53), Petr Spacek wrote: >On 3.12.2015 15:34, Rob Crittenden wrote: >> Martin Kosek wrote: >>> On 12/03/2015 09:08 AM, Petr Spacek wrote: On 2.12.2015 19:14, Rob Crittenden wrote: > Is it still mandatory that tests pass the unit tests before acceptance? > I've seen a num

Re: [Freeipa-devel] patch acceptance criteria

2015-12-03 Thread Rob Crittenden
Lukas Slebodnik wrote: > On (02/12/15 13:14), Rob Crittenden wrote: >> Is it still mandatory that tests pass the unit tests before acceptance? > Unit test could be executed as part of "%check" phase in spec files. > I recently added C-base unit tests there. > > I was not bale to run "make tests" t

Re: [Freeipa-devel] patch acceptance criteria

2015-12-03 Thread Petr Spacek
On 3.12.2015 15:34, Rob Crittenden wrote: > Martin Kosek wrote: >> On 12/03/2015 09:08 AM, Petr Spacek wrote: >>> On 2.12.2015 19:14, Rob Crittenden wrote: Is it still mandatory that tests pass the unit tests before acceptance? I've seen a number of cases over the past couple of months wh

Re: [Freeipa-devel] patch acceptance criteria

2015-12-03 Thread Rob Crittenden
Martin Kosek wrote: > On 12/03/2015 09:08 AM, Petr Spacek wrote: >> On 2.12.2015 19:14, Rob Crittenden wrote: >>> Is it still mandatory that tests pass the unit tests before acceptance? >>> I've seen a number of cases over the past couple of months where a >>> change goes through then shortly after

Re: [Freeipa-devel] patch acceptance criteria

2015-12-03 Thread Lukas Slebodnik
On (02/12/15 13:14), Rob Crittenden wrote: >Is it still mandatory that tests pass the unit tests before acceptance? Unit test could be executed as part of "%check" phase in spec files. I recently added C-base unit tests there. I was not bale to run "make tests" there because many tests failed. If

Re: [Freeipa-devel] patch acceptance criteria

2015-12-03 Thread Martin Kosek
On 12/03/2015 09:08 AM, Petr Spacek wrote: > On 2.12.2015 19:14, Rob Crittenden wrote: >> Is it still mandatory that tests pass the unit tests before acceptance? >> I've seen a number of cases over the past couple of months where a >> change goes through then shortly afterward a patch to fix the te

Re: [Freeipa-devel] patch acceptance criteria

2015-12-03 Thread Petr Spacek
On 2.12.2015 19:14, Rob Crittenden wrote: > Is it still mandatory that tests pass the unit tests before acceptance? > I've seen a number of cases over the past couple of months where a > change goes through then shortly afterward a patch to fix the tests. > IMHO this should be caught in advance. >

[Freeipa-devel] patch acceptance criteria

2015-12-02 Thread Rob Crittenden
Is it still mandatory that tests pass the unit tests before acceptance? I've seen a number of cases over the past couple of months where a change goes through then shortly afterward a patch to fix the tests. IMHO this should be caught in advance. Things slip through and goodness knows I've acked m