Re: [Freeipa-devel] [PATCH] 0062, 63: webui: Add button for 'server-del' command

2016-06-30 Thread Petr Vobornik
On 06/30/2016 01:57 PM, Pavel Vomacka wrote: > > > On 06/29/2016 05:42 PM, Petr Vobornik wrote: >> On 06/24/2016 12:40 PM, Pavel Vomacka wrote: >>> Hello, >>> >>> please review attached patches, they add 'Delete Server' button. >>> >> 1. there is a whitespace warning while applying patch 63. >> >

Re: [Freeipa-devel] [PATCH] 0062, 63: webui: Add button for 'server-del' command

2016-06-30 Thread Pavel Vomacka
On 06/29/2016 05:42 PM, Petr Vobornik wrote: On 06/24/2016 12:40 PM, Pavel Vomacka wrote: Hello, please review attached patches, they add 'Delete Server' button. 1. there is a whitespace warning while applying patch 63. 2. It breaks expectation of no_init. Instead of var that = IPA.deta

Re: [Freeipa-devel] [PATCH] 0062, 63: webui: Add button for 'server-del' command

2016-06-29 Thread Petr Vobornik
On 06/24/2016 12:40 PM, Pavel Vomacka wrote: > Hello, > > please review attached patches, they add 'Delete Server' button. > 1. there is a whitespace warning while applying patch 63. 2. It breaks expectation of no_init. Instead of var that = IPA.details_facet(spec); Use var that = IPA.detai