Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-05 Thread Martin Kosek
On 12/05/2014 01:46 PM, Petr Vobornik wrote: On 12/04/2014 07:15 PM, Nathaniel McCallum wrote: On Thu, 2014-12-04 at 14:56 +0100, Petr Vobornik wrote: On 2.12.2014 20:57, Nathaniel McCallum wrote: Works fine. python part of 0004: ACK, but VERSION needs to be updated before push 0005: ACK

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-05 Thread Petr Vobornik
On 12/04/2014 07:15 PM, Nathaniel McCallum wrote: On Thu, 2014-12-04 at 14:56 +0100, Petr Vobornik wrote: On 2.12.2014 20:57, Nathaniel McCallum wrote: Works fine. python part of 0004: ACK, but VERSION needs to be updated before push 0005: ACK Fixed and rebased. Patch numbers have changed

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-04 Thread Nathaniel McCallum
On Thu, 2014-12-04 at 14:56 +0100, Petr Vobornik wrote: > On 2.12.2014 20:57, Nathaniel McCallum wrote: > > The attached patches I think have a much better overall aesthetic. Now > > patch 0004 introduces only two new commands: > > * otpconfig-mod > > * otpconfig-show > > > > Under the covers, a si

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-04 Thread Petr Vobornik
On 2.12.2014 20:57, Nathaniel McCallum wrote: I'm little confused with a state of reviews. Thierry were some of the patches ACKed in different threads or are they under review (I'm not reviewing DS plugin parts)? Patches 0001, 0002, 0003 are ACKed by Thierry, but not merged. They can and shoul

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-03 Thread Nathaniel McCallum
On Wed, 2014-12-03 at 14:43 +0100, Martin Kosek wrote: > On 12/02/2014 08:57 PM, Nathaniel McCallum wrote: > > On Tue, 2014-11-18 at 20:26 +0100, Petr Vobornik wrote: > >> On 13.11.2014 08:53, Martin Kosek wrote: > >>> On 11/13/2014 08:51 AM, Nathaniel McCallum wrote: > On Thu, 2014-11-13 at 0

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-03 Thread Martin Kosek
On 12/02/2014 08:57 PM, Nathaniel McCallum wrote: > On Tue, 2014-11-18 at 20:26 +0100, Petr Vobornik wrote: >> On 13.11.2014 08:53, Martin Kosek wrote: >>> On 11/13/2014 08:51 AM, Nathaniel McCallum wrote: On Thu, 2014-11-13 at 08:48 +0100, Martin Kosek wrote: > On 11/12/2014 11:37 PM, Nat

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-02 Thread Nathaniel McCallum
On Tue, 2014-12-02 at 12:20 -0500, Nathaniel McCallum wrote: > On Tue, 2014-12-02 at 17:56 +0100, Petr Vobornik wrote: > > On 12/02/2014 05:39 PM, thierry bordaz wrote: > > > On 12/02/2014 05:24 PM, Nathaniel McCallum wrote: > > >> On Tue, 2014-12-02 at 17:12 +0100, Martin Kosek wrote: > > >>> On 1

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-02 Thread Nathaniel McCallum
On Tue, 2014-12-02 at 17:56 +0100, Petr Vobornik wrote: > On 12/02/2014 05:39 PM, thierry bordaz wrote: > > On 12/02/2014 05:24 PM, Nathaniel McCallum wrote: > >> On Tue, 2014-12-02 at 17:12 +0100, Martin Kosek wrote: > >>> On 12/02/2014 04:56 PM, Nathaniel McCallum wrote: > On Tue, 2014-12-02

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-02 Thread Petr Vobornik
On 12/02/2014 05:39 PM, thierry bordaz wrote: On 12/02/2014 05:24 PM, Nathaniel McCallum wrote: On Tue, 2014-12-02 at 17:12 +0100, Martin Kosek wrote: On 12/02/2014 04:56 PM, Nathaniel McCallum wrote: On Tue, 2014-12-02 at 14:05 +0100, thierry bordaz wrote: On 11/12/2014 11:37 PM, Nathaniel M

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-02 Thread thierry bordaz
On 12/02/2014 05:24 PM, Nathaniel McCallum wrote: On Tue, 2014-12-02 at 17:12 +0100, Martin Kosek wrote: On 12/02/2014 04:56 PM, Nathaniel McCallum wrote: On Tue, 2014-12-02 at 14:05 +0100, thierry bordaz wrote: On 11/12/2014 11:37 PM, Nathaniel McCallum wrote: On Mon, 2014-11-10 at 08:28 +0

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-02 Thread Nathaniel McCallum
On Tue, 2014-12-02 at 17:12 +0100, Martin Kosek wrote: > On 12/02/2014 04:56 PM, Nathaniel McCallum wrote: > > On Tue, 2014-12-02 at 14:05 +0100, thierry bordaz wrote: > >> On 11/12/2014 11:37 PM, Nathaniel McCallum wrote: > >> > >>> On Mon, 2014-11-10 at 08:28 +0100, Martin Kosek wrote: > On

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-02 Thread Martin Kosek
On 12/02/2014 04:56 PM, Nathaniel McCallum wrote: > On Tue, 2014-12-02 at 14:05 +0100, thierry bordaz wrote: >> On 11/12/2014 11:37 PM, Nathaniel McCallum wrote: >> >>> On Mon, 2014-11-10 at 08:28 +0100, Martin Kosek wrote: On 11/07/2014 04:44 PM, Petr Vobornik wrote: > On 7.11.2014 08:58,

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-02 Thread Nathaniel McCallum
On Mon, 2014-12-01 at 17:46 +0100, thierry bordaz wrote: > On 11/12/2014 11:37 PM, Nathaniel McCallum wrote: > > > On Mon, 2014-11-10 at 08:28 +0100, Martin Kosek wrote: > > > On 11/07/2014 04:44 PM, Petr Vobornik wrote: > > > > On 7.11.2014 08:58, Martin Kosek wrote: > > > > > On 11/04/2014 05:17

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-02 Thread thierry bordaz
On 11/12/2014 11:37 PM, Nathaniel McCallum wrote: On Mon, 2014-11-10 at 08:28 +0100, Martin Kosek wrote: On 11/07/2014 04:44 PM, Petr Vobornik wrote: On 7.11.2014 08:58, Martin Kosek wrote: On 11/04/2014 05:17 PM, Nathaniel McCallum wrote: On Wed, 2014-10-29 at 09:34 -0400, Nathaniel McCallum

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-12-01 Thread thierry bordaz
On 11/12/2014 11:37 PM, Nathaniel McCallum wrote: On Mon, 2014-11-10 at 08:28 +0100, Martin Kosek wrote: On 11/07/2014 04:44 PM, Petr Vobornik wrote: On 7.11.2014 08:58, Martin Kosek wrote: On 11/04/2014 05:17 PM, Nathaniel McCallum wrote: On Wed, 2014-10-29 at 09:34 -0400, Nathaniel McCallum

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-11-25 Thread thierry bordaz
On 11/18/2014 08:26 PM, Petr Vobornik wrote: On 13.11.2014 08:53, Martin Kosek wrote: On 11/13/2014 08:51 AM, Nathaniel McCallum wrote: On Thu, 2014-11-13 at 08:48 +0100, Martin Kosek wrote: On 11/12/2014 11:37 PM, Nathaniel McCallum wrote: On Mon, 2014-11-10 at 08:28 +0100, Martin Kosek wrot

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-11-18 Thread Petr Vobornik
On 13.11.2014 08:53, Martin Kosek wrote: On 11/13/2014 08:51 AM, Nathaniel McCallum wrote: On Thu, 2014-11-13 at 08:48 +0100, Martin Kosek wrote: On 11/12/2014 11:37 PM, Nathaniel McCallum wrote: On Mon, 2014-11-10 at 08:28 +0100, Martin Kosek wrote: On 11/07/2014 04:44 PM, Petr Vobornik wrot

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-11-12 Thread Martin Kosek
On 11/13/2014 08:51 AM, Nathaniel McCallum wrote: > On Thu, 2014-11-13 at 08:48 +0100, Martin Kosek wrote: >> On 11/12/2014 11:37 PM, Nathaniel McCallum wrote: >>> On Mon, 2014-11-10 at 08:28 +0100, Martin Kosek wrote: On 11/07/2014 04:44 PM, Petr Vobornik wrote: > On 7.11.2014 08:58, Mart

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-11-12 Thread Nathaniel McCallum
On Thu, 2014-11-13 at 08:48 +0100, Martin Kosek wrote: > On 11/12/2014 11:37 PM, Nathaniel McCallum wrote: > > On Mon, 2014-11-10 at 08:28 +0100, Martin Kosek wrote: > >> On 11/07/2014 04:44 PM, Petr Vobornik wrote: > >>> On 7.11.2014 08:58, Martin Kosek wrote: > On 11/04/2014 05:17 PM, Nathan

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-11-12 Thread Martin Kosek
On 11/12/2014 11:37 PM, Nathaniel McCallum wrote: > On Mon, 2014-11-10 at 08:28 +0100, Martin Kosek wrote: >> On 11/07/2014 04:44 PM, Petr Vobornik wrote: >>> On 7.11.2014 08:58, Martin Kosek wrote: On 11/04/2014 05:17 PM, Nathaniel McCallum wrote: > On Wed, 2014-10-29 at 09:34 -0400, Nath

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-11-09 Thread Martin Kosek
On 11/07/2014 04:44 PM, Petr Vobornik wrote: > On 7.11.2014 08:58, Martin Kosek wrote: >> On 11/04/2014 05:17 PM, Nathaniel McCallum wrote: >>> On Wed, 2014-10-29 at 09:34 -0400, Nathaniel McCallum wrote: On Wed, 2014-10-29 at 12:21 +0100, Petr Viktorin wrote: > On 10/29/2014 10:37 AM, Mar

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-11-07 Thread thierry bordaz
On 11/07/2014 05:40 PM, Nathaniel McCallum wrote: On Fri, 2014-11-07 at 15:02 +0100, thierry bordaz wrote: On 11/04/2014 05:17 PM, Nathaniel McCallum wrote: On Wed, 2014-10-29 at 09:34 -0400, Nathaniel McCallum wrote: On Wed, 2014-10-29 at 12:21 +0100, Petr Viktorin wrote: On 10/29/2014 10:3

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-11-07 Thread Nathaniel McCallum
On Fri, 2014-11-07 at 15:02 +0100, thierry bordaz wrote: > On 11/04/2014 05:17 PM, Nathaniel McCallum wrote: > > > On Wed, 2014-10-29 at 09:34 -0400, Nathaniel McCallum wrote: > > > On Wed, 2014-10-29 at 12:21 +0100, Petr Viktorin wrote: > > > > On 10/29/2014 10:37 AM, Martin Kosek wrote: > > > >

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-11-07 Thread Petr Vobornik
On 7.11.2014 08:58, Martin Kosek wrote: On 11/04/2014 05:17 PM, Nathaniel McCallum wrote: On Wed, 2014-10-29 at 09:34 -0400, Nathaniel McCallum wrote: On Wed, 2014-10-29 at 12:21 +0100, Petr Viktorin wrote: On 10/29/2014 10:37 AM, Martin Kosek wrote: On 10/28/2014 09:59 PM, Nathaniel McCallum

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-11-07 Thread thierry bordaz
On 11/04/2014 05:17 PM, Nathaniel McCallum wrote: On Wed, 2014-10-29 at 09:34 -0400, Nathaniel McCallum wrote: On Wed, 2014-10-29 at 12:21 +0100, Petr Viktorin wrote: On 10/29/2014 10:37 AM, Martin Kosek wrote: On 10/28/2014 09:59 PM, Nathaniel McCallum wrote: On Thu, 2014-10-23 at 18:07 -040

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-11-07 Thread Martin Kosek
On 11/04/2014 05:17 PM, Nathaniel McCallum wrote: On Wed, 2014-10-29 at 09:34 -0400, Nathaniel McCallum wrote: On Wed, 2014-10-29 at 12:21 +0100, Petr Viktorin wrote: On 10/29/2014 10:37 AM, Martin Kosek wrote: On 10/28/2014 09:59 PM, Nathaniel McCallum wrote: On Thu, 2014-10-23 at 18:07 -040

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-11-06 Thread Nathaniel McCallum
On Tue, 2014-11-04 at 11:17 -0500, Nathaniel McCallum wrote: > On Wed, 2014-10-29 at 09:34 -0400, Nathaniel McCallum wrote: > > On Wed, 2014-10-29 at 12:21 +0100, Petr Viktorin wrote: > > > On 10/29/2014 10:37 AM, Martin Kosek wrote: > > > > On 10/28/2014 09:59 PM, Nathaniel McCallum wrote: > > > >

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-11-04 Thread Nathaniel McCallum
On Wed, 2014-10-29 at 09:34 -0400, Nathaniel McCallum wrote: > On Wed, 2014-10-29 at 12:21 +0100, Petr Viktorin wrote: > > On 10/29/2014 10:37 AM, Martin Kosek wrote: > > > On 10/28/2014 09:59 PM, Nathaniel McCallum wrote: > > >> On Thu, 2014-10-23 at 18:07 -0400, Nathaniel McCallum wrote: > > >>>

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-10-29 Thread Nathaniel McCallum
On Wed, 2014-10-29 at 12:21 +0100, Petr Viktorin wrote: > On 10/29/2014 10:37 AM, Martin Kosek wrote: > > On 10/28/2014 09:59 PM, Nathaniel McCallum wrote: > >> On Thu, 2014-10-23 at 18:07 -0400, Nathaniel McCallum wrote: > >>> This patch gives the administrator variables to control the size of > >

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-10-29 Thread Petr Viktorin
On 10/29/2014 10:37 AM, Martin Kosek wrote: On 10/28/2014 09:59 PM, Nathaniel McCallum wrote: On Thu, 2014-10-23 at 18:07 -0400, Nathaniel McCallum wrote: This patch gives the administrator variables to control the size of the authentication and synchronization windows for OTP tokens. https://

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-10-29 Thread Martin Kosek
On 10/28/2014 09:59 PM, Nathaniel McCallum wrote: > On Thu, 2014-10-23 at 18:07 -0400, Nathaniel McCallum wrote: >> This patch gives the administrator variables to control the size of >> the authentication and synchronization windows for OTP tokens. >> >> https://fedorahosted.org/freeipa/ticket/451

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-10-28 Thread Nathaniel McCallum
On Thu, 2014-10-23 at 18:07 -0400, Nathaniel McCallum wrote: > This patch gives the administrator variables to control the size of > the authentication and synchronization windows for OTP tokens. > > https://fedorahosted.org/freeipa/ticket/4511 > > NOTE: There is one known issue with this patch w

Re: [Freeipa-devel] [PATCH 0074] Make token window sizes configurable

2014-10-24 Thread Nathaniel McCallum
On Thu, 2014-10-23 at 18:07 -0400, Nathaniel McCallum wrote: > This patch gives the administrator variables to control the size of > the authentication and synchronization windows for OTP tokens. > > https://fedorahosted.org/freeipa/ticket/4511 > > NOTE: There is one known issue with this patch w