Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-23 Thread Tomas Babej
> One more point: > > +if domain_level > MIN_DOMAIN_LEVEL: > +raise RuntimeError( > +UNSUPPORTED_DOMAIN_LEVEL_TEMPLATE.format( > > It is kind of weird that error happens if domain level is greater than some > minimal value. Better naming is badly needed. >

Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-22 Thread Martin Basti
On 22.10.2015 14:29, Petr Spacek wrote: On 22.10.2015 14:24, Tomas Babej wrote: On 10/22/2015 02:15 PM, Petr Spacek wrote: On 20.10.2015 17:47, Martin Babinsky wrote: +def check_domainlevel(self, api): +domain_level = dsinstance.get_domain_level(api) +if domain_level >

Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-22 Thread Petr Spacek
On 20.10.2015 17:47, Martin Babinsky wrote: > +def check_domainlevel(self, api): > +domain_level = dsinstance.get_domain_level(api) > +if domain_level > MIN_DOMAIN_LEVEL: > +raise RuntimeError( > +UNSUPPORTED_DOMAIN_LEVEL_TEMPLATE.format( > +

Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-22 Thread Petr Spacek
On 22.10.2015 14:24, Tomas Babej wrote: > > > On 10/22/2015 02:15 PM, Petr Spacek wrote: >> On 20.10.2015 17:47, Martin Babinsky wrote: >>> +def check_domainlevel(self, api): >>> +domain_level = dsinstance.get_domain_level(api) >>> +if domain_level > MIN_DOMAIN_LEVEL: >>> +

Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-22 Thread Tomas Babej
On 10/22/2015 02:15 PM, Petr Spacek wrote: > On 20.10.2015 17:47, Martin Babinsky wrote: >> +def check_domainlevel(self, api): >> +domain_level = dsinstance.get_domain_level(api) >> +if domain_level > MIN_DOMAIN_LEVEL: >> +raise RuntimeError( >> +

Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-20 Thread Martin Babinsky
On 10/19/2015 04:51 PM, Martin Babinsky wrote: On 10/19/2015 02:47 PM, Martin Basti wrote: On 15.10.2015 16:29, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5175 NACK with domain level 0 ipa-replica-prepare ipa.ipaserver.install.ipa_replica_prepare.ReplicaPrepare:

Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-20 Thread Martin Babinsky
On 10/20/2015 04:27 PM, Martin Babinsky wrote: On 10/19/2015 04:51 PM, Martin Babinsky wrote: On 10/19/2015 02:47 PM, Martin Basti wrote: On 15.10.2015 16:29, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5175 NACK with domain level 0 ipa-replica-prepare

Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-19 Thread Martin Basti
On 15.10.2015 16:29, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5175 NACK with domain level 0 ipa-replica-prepare ipa.ipaserver.install.ipa_replica_prepare.ReplicaPrepare: DEBUG: File "/usr/lib/python2.7/site-packages/ipapython/admintool.py", line 169, in execute

Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-19 Thread Martin Babinsky
On 10/15/2015 04:29 PM, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5175 Updated patch attached -- Martin^3 Babinsky From aa899aa5f9d9f55c1f3dcaebf79c3460f937815b Mon Sep 17 00:00:00 2001 From: Martin Babinsky Date: Thu, 15 Oct 2015 16:07:48 +0200

Re: [Freeipa-devel] [PATCH 0086] disable ipa-replica prepare in non-zero domain levels

2015-10-19 Thread Martin Babinsky
On 10/19/2015 02:47 PM, Martin Basti wrote: On 15.10.2015 16:29, Martin Babinsky wrote: https://fedorahosted.org/freeipa/ticket/5175 NACK with domain level 0 ipa-replica-prepare ipa.ipaserver.install.ipa_replica_prepare.ReplicaPrepare: DEBUG: File