Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised
On Wed, 2007-07-11 at 12:21 -0600, Levi Pearson wrote: On Thu, 2007-06-28 at 16:47 -0600, Levi Pearson wrote: On Thu, 2007-06-28 at 15:33 -0700, Al Chu wrote: Hey Levi, One other additional note. I added several debug flags into the library. It may be worth adding it into your code to help us figure out the problem. Passing IPMICONSOLE_DEBUG_FILE to engine_init() will output debug info into files in /tmp. Al I'll try enabling the debugging and figuring out what's really going on when I get a chance to work with this some more, probably on Monday. --Levi Aha. I feel sheepish. Things do in fact work as they're supposed to when they get called. It turns out that the code in conman was following a different path than I thought, and the call to shut down the ipmiconsole engine wasn't happening. Sorry for the trouble! Hehe. No prob. Glad it's working for you now. Looking forward to seeing your patch on the Conman mailing list. Al --Levi -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised
On Thu, 2007-06-28 at 08:42 -0700, Al Chu wrote: Hey Levi, Thanks for noticing this. I'm guessing that the implementation changed awhile back and I forgot to change the comments. I need to look at the code again the refresh my memory on how best to implement this. Looking at ipmiconsole (the tool, not the lib) it seems neither ipmiconsole_ctx_destroy() or ipmiconsole_engine_teardown() block. I actually spin waiting for ipmiconsole_ctx_destroy() to return a non-zero value back to me. I'll modify the comments for now, and add blocking equivalents into my TODO. Is this something that's needed soon on your end? Al Actually, although I thought ipmiconsole_engine_teardown() would disconnect all the sessions, calling ipmi_ctx_destroy() in a spin-loop after tearing the engine down never seems to indicate success. Oh well, I'll figure something out. --Levi ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised
On Thu, 2007-06-28 at 10:23 -0600, Levi Pearson wrote: On Thu, 2007-06-28 at 08:42 -0700, Al Chu wrote: Hey Levi, Thanks for noticing this. I'm guessing that the implementation changed awhile back and I forgot to change the comments. I need to look at the code again the refresh my memory on how best to implement this. Looking at ipmiconsole (the tool, not the lib) it seems neither ipmiconsole_ctx_destroy() or ipmiconsole_engine_teardown() block. I actually spin waiting for ipmiconsole_ctx_destroy() to return a non-zero value back to me. I'll modify the comments for now, and add blocking equivalents into my TODO. Is this something that's needed soon on your end? Al Actually, although I thought ipmiconsole_engine_teardown() would disconnect all the sessions, calling ipmi_ctx_destroy() in a spin-loop after tearing the engine down never seems to indicate success. Oh well, I'll figure something out. --Levi Now this is a bug. I will look into this one. Al -- Albert Chu [EMAIL PROTECTED] 925-422-5311 Computer Scientist High Performance Systems Division Lawrence Livermore National Laboratory ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
Re: [Freeipmi-devel] ipmiconsole_engine_teardown does not seem to block as advertised
On Thu, 2007-06-28 at 15:33 -0700, Al Chu wrote: Hey Levi, One other additional note. I added several debug flags into the library. It may be worth adding it into your code to help us figure out the problem. Passing IPMICONSOLE_DEBUG_FILE to engine_init() will output debug info into files in /tmp. Al I'll try enabling the debugging and figuring out what's really going on when I get a chance to work with this some more, probably on Monday. --Levi ___ Freeipmi-devel mailing list Freeipmi-devel@gnu.org http://lists.gnu.org/mailman/listinfo/freeipmi-devel
