Re: [Chillispot] Correction of Reply Messages

2007-03-12 Thread Alan DeKok
[EMAIL PROTECTED] wrote:
 I think that this is a trivial bug:
...
 It sends reset parameter instead of (?)check name parameter in the reply.
 You should report it.

  The reset is often monthly or daily, in which case the message
makes sense.

  Sending the check name wouldn't make sense, as it's internal to the
RADIUS server.

  Ideally, the message should be configurable.

  Alan DeKok.
--
  http://deployingradius.com   - The web site of the book
  http://deployingradius.com/blog/ - The blog
- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


Re: [Chillispot] Correction of Reply Messages

2007-03-12 Thread tnt
Oh, I see. So the script works as it should but the people complain that
the message doesn't sound  right when never is there. You could put
an if there to send the message without the parameter for never and
as it is for others, but if configurable message is in the pipeline it
probably isn't worth the bother.

Ivan Kalik
Kalik Informatika ISP


Dana 12/3/2007, Alan DeKok [EMAIL PROTECTED] piše:

[EMAIL PROTECTED] wrote:
 I think that this is a trivial bug:

 It sends reset parameter instead of (?)check name parameter in the reply.
 You should report it.

  The reset is often monthly or daily, in which case the message
makes sense.

  Sending the check name wouldn't make sense, as it's internal to the
RADIUS server.

  Ideally, the message should be configurable.

  Alan DeKok.
--
  http://deployingradius.com   - The web site of the book
  http://deployingradius.com/blog/ - The blog
-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html



- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


Re: [Chillispot] Correction of Reply Messages

2007-03-12 Thread Internet-Wifi Operador
I give to you a fast solution to show the message that you want, otherwise 
edit the module, rewrite and compile it.




Fabián






From: [EMAIL PROTECTED]
Reply-To: FreeRadius users mailing list 
freeradius-users@lists.freeradius.org

To: FreeRadius users mailing list freeradius-users@lists.freeradius.org
Subject: Re: [Chillispot] Correction of Reply Messages
Date: Mon, 12 Mar 2007 14:41:15 +0100

Oh, I see. So the script works as it should but the people complain that
the message doesn't sound  right when never is there. You could put
an if there to send the message without the parameter for never and
as it is for others, but if configurable message is in the pipeline it
probably isn't worth the bother.

Ivan Kalik
Kalik Informatika ISP


Dana 12/3/2007, Alan DeKok [EMAIL PROTECTED] pi¹e:

[EMAIL PROTECTED] wrote:
 I think that this is a trivial bug:

 It sends reset parameter instead of (?)check name parameter in the 
reply.

 You should report it.

  The reset is often monthly or daily, in which case the message
makes sense.

  Sending the check name wouldn't make sense, as it's internal to the
RADIUS server.

  Ideally, the message should be configurable.

  Alan DeKok.
--
  http://deployingradius.com   - The web site of the book
  http://deployingradius.com/blog/ - The blog
-
List info/subscribe/unsubscribe? See 
http://www.freeradius.org/list/users.html




-
List info/subscribe/unsubscribe? See 
http://www.freeradius.org/list/users.html


_
Get a FREE Web site, company branded e-mail and more from Microsoft Office 
Live! http://clk.atdmt.com/MRT/go/mcrssaub0050001411mrt/direct/01/


- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Re: [Chillispot] Correction of Reply Messages

2007-03-10 Thread tnt
I think that this is a trivial bug:

sqlcounter noresetcounter {
counter-name = Max-All-Session-Time
check-name = Max-All-Session
sqlmod-inst = sql
key = User-Name
reset = never
query = SELECT SUM(AcctSessionTime) FROM radacct WHERE
UserName='%{%k}'
}

It sends reset parameter instead of (?)check name parameter in the reply.
You should report it.

There should be something else (? %S if there is one) instead of %s here:

 snprintf(msg, sizeof(msg), Your maximum %s usage time has been
reached, data-reset);

Ivan Kalik
Kalik Informatika ISP



Dana 10/3/2007, PD [EMAIL PROTECTED] piše:

Thx Brad...

But... our FR installation is came from FBSD ports, not self compiling.
How to apply yr patch ?

Cheers

PD

On 3/10/2007, Brad Evans [EMAIL PROTECTED] wrote:

Hi,

Check out the FreeRadius forum at www.chillispot.org - there is a
patch there which allows you to specify custom reply messge text.

Cheers

PD wrote:
 Dear all,

 Sorry for cross post... since I doubt about which area of this question.

 I just create one account call test for duration 300 second / 5 minutes.
 After the maximum time reached, I logged by the system out. When I try
 to log in again, the reply message display is Your maximum never usage
 time has been reached

 Seems that I have some correction for the message (take out never), but I
 do not know how to do it.

 Can some one let me know where to edit the above reply message ?

 TIA

 PD


-
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html



- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html


Re: [Chillispot] Correction of Reply Messages

2007-03-10 Thread Internet-Wifi Operador
I don´t understand what you want exactly, but if want change the message, 
You can check the reply message in your hostspotlogin.cgi or php script, so 
when receibe

if ($msg ==Your maximum) $msg = The message you want
echo $msg;

That is did.
Sorry if not you what you are looking for, but my english is too bad.


From: [EMAIL PROTECTED]
Reply-To: FreeRadius users mailing list 
freeradius-users@lists.freeradius.org

To: FreeRadius users mailing list freeradius-users@lists.freeradius.org
Subject: Re: [Chillispot] Correction of Reply Messages
Date: Sat, 10 Mar 2007 11:39:19 +0100

I think that this is a trivial bug:

sqlcounter noresetcounter {
counter-name = Max-All-Session-Time
check-name = Max-All-Session
sqlmod-inst = sql
key = User-Name
reset = never
query = SELECT SUM(AcctSessionTime) FROM radacct WHERE
UserName='%{%k}'
}

It sends reset parameter instead of (?)check name parameter in the reply.
You should report it.

There should be something else (? %S if there is one) instead of %s here:

 snprintf(msg, sizeof(msg), Your maximum %s usage time has been
reached, data-reset);

Ivan Kalik
Kalik Informatika ISP



Dana 10/3/2007, PD [EMAIL PROTECTED] pi¹e:

Thx Brad...

But... our FR installation is came from FBSD ports, not self compiling.
How to apply yr patch ?

Cheers

PD

On 3/10/2007, Brad Evans [EMAIL PROTECTED] wrote:

Hi,

Check out the FreeRadius forum at www.chillispot.org - there is a
patch there which allows you to specify custom reply messge text.

Cheers

PD wrote:
 Dear all,

 Sorry for cross post... since I doubt about which area of this 
question.


 I just create one account call test for duration 300 second / 5 
minutes.

 After the maximum time reached, I logged by the system out. When I try
 to log in again, the reply message display is Your maximum never 
usage

 time has been reached

 Seems that I have some correction for the message (take out never), 
but I

 do not know how to do it.

 Can some one let me know where to edit the above reply message ?

 TIA

 PD


-
List info/subscribe/unsubscribe? See 
http://www.freeradius.org/list/users.html




-
List info/subscribe/unsubscribe? See 
http://www.freeradius.org/list/users.html


_
Find what you need at prices you’ll love. Compare products and save at MSN® 
Shopping. 
http://shopping.msn.com/default/shp/?ptnrid=37,ptnrdata=24102tcode=T001MSN20A0701


- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html

Re: [Chillispot] Correction of Reply Messages

2007-03-10 Thread tnt
It will (probably) work for someone with ChilliSpot, but the problem in
Freeradius will remain. I am pointing out the line in rlm_sqlcounter.c
code which is quite likely the reason for the error. If someone
fixes this module this problem will be resolved for everybody in new
Freeradius versions. I hope that the idea is to fix the bug when you
find one.

Ivan Kalik
Kalik Informatika ISP

Dana 10/3/2007, Internet-Wifi Operador [EMAIL PROTECTED]
piše:

I don´t understand what you want exactly, but if want change the message,
You can check the reply message in your hostspotlogin.cgi or php script, so
when receibe
if ($msg ==Your maximum) $msg = The message you want
echo $msg;

That is did.
Sorry if not you what you are looking for, but my english is too bad.

From: [EMAIL PROTECTED]
Reply-To: FreeRadius users mailing list
freeradius-users@lists.freeradius.org
To: FreeRadius users mailing list freeradius-users@lists.freeradius.org
Subject: Re: [Chillispot] Correction of Reply Messages
Date: Sat, 10 Mar 2007 11:39:19 +0100

I think that this is a trivial bug:

sqlcounter noresetcounter {
counter-name = Max-All-Session-Time
check-name = Max-All-Session
sqlmod-inst = sql
key = User-Name
reset = never
query = SELECT SUM(AcctSessionTime) FROM radacct WHERE
UserName='%{%k}'
}

It sends reset parameter instead of (?)check name parameter in the reply.
You should report it.

There should be something else (? %S if there is one) instead of %s here:

  snprintf(msg, sizeof(msg), Your maximum %s usage time has been
reached, data-reset);

Ivan Kalik
Kalik Informatika ISP



Dana 10/3/2007, PD [EMAIL PROTECTED] piše:

 Thx Brad...
 
 But... our FR installation is came from FBSD ports, not self compiling.
 How to apply yr patch ?
 
 Cheers
 
 PD
 
 On 3/10/2007, Brad Evans [EMAIL PROTECTED] wrote:
 
 Hi,
 
 Check out the FreeRadius forum at www.chillispot.org - there is a
 patch there which allows you to specify custom reply messge text.
 
 Cheers
 
 PD wrote:
  Dear all,
 
  Sorry for cross post... since I doubt about which area of this
question.
 
  I just create one account call test for duration 300 second / 5
minutes.
  After the maximum time reached, I logged by the system out. When I try
  to log in again, the reply message display is Your maximum never
usage
  time has been reached
 
  Seems that I have some correction for the message (take out never),
but I
  do not know how to do it.
 
  Can some one let me know where to edit the above reply message ?
 
  TIA
 
  PD
 
 
 -
 List info/subscribe/unsubscribe? See
http://www.freeradius.org/list/users.html
 
 

-
List info/subscribe/unsubscribe? See
http://www.freeradius.org/list/users.html

_
Find what you need at prices you#65533;ll love. Compare products and save at 
MSNŽ
Shopping.
http://shopping.msn.com/default/shp/?ptnrid=37,ptnrdata=24102tcode=T001MSN20A0701




- 
List info/subscribe/unsubscribe? See http://www.freeradius.org/list/users.html