Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-16 Thread FORT David
Le 16/03/2015 11:46, Thomas Calderon a écrit : > Hi, > > I have removed the previous branch and started from scratch using GSSAPI > documentation only. > Therefore, I would dare to say that there shouldn't be licensing issues if > this gets merged when it is more mature (NTLM fallback, etc). > The

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-16 Thread Marc-André Moreau
Hi Thomas, Excellent! Thank you for your cooperation on this. I look forward to having Kerberos support in FreeRDP. Best regards, -Marc-Andre On Mon, Mar 16, 2015 at 6:46 AM, Thomas Calderon wrote: > Hi, > > I have removed the previous branch and started from scratch using GSSAPI > documentati

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-16 Thread Thomas Calderon
Hi, I have removed the previous branch and started from scratch using GSSAPI documentation only. Therefore, I would dare to say that there shouldn't be licensing issues if this gets merged when it is more mature (NTLM fallback, etc). The new code is available at [1]. I took the time to test it wi

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-14 Thread Marc-André Moreau
Hi Thomas, I am on your side and I wish to have Kerberos support in FreeRDP as well. I took a quick look at the functions in kerberos_gss.c and some of it still bothers me. The idea is to have the code written the way you would have written it if you hadn't taken some bits, as tiny as they may app

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-14 Thread Peter Astrand
On Fri, 13 Mar 2015, Marc-André Moreau wrote: Hi Vincent, Is there a particular reason why keyboard mapping fails in a thinlinc environment? I just took a quick look at the modifications you made on that branch, and it looks like you are dynamically loading the keymap files from thinlinc and

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-14 Thread Thomas Calderon
Hi, Thank you for the reply. On Fri, Mar 13, 2015 at 8:17 PM, Marc-André Moreau < marcandre.mor...@gmail.com> wrote: > Hi, > > Code reuse is acceptable within the same project or with code of the same > license, but the last thing we want is reusing code with licensing we don't > want, like rdes

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-13 Thread Vincent Sourin
Le 13/03/2015 22:35, Marc-André Moreau a écrit : > Hi Vincent, Hello Marc-André, Peter, > > Is there a particular reason why keyboard mapping fails in a thinlinc > environment? No I don't really know why keyboard mapping is faulty with FreeRDP in a thinlinc environment. Maybe because of the use o

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-13 Thread Marc-André Moreau
Hi Vincent, Is there a particular reason why keyboard mapping fails in a thinlinc environment? I just took a quick look at the modifications you made on that branch, and it looks like you are dynamically loading the keymap files from thinlinc and adding support for thinlinc-specific keyboard map n

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-13 Thread Vincent Sourin
Hi Everyone, I allow myself to use this thread because I have also a question regarding licensing. In my company, we use ThinLinc (https://www.cendio.com/). This software is shipped with rdesktop but we want to use FreeRDP instead. As in a thinlinc environment we've some problems with non-us k

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-13 Thread Marc-André Moreau
Hi, Code reuse is acceptable within the same project or with code of the same license, but the last thing we want is reusing code with licensing we don't want, like rdesktop. I understand it may look logical since the amount of code appears too small and too simple to be copyrightable, but as you

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-13 Thread Thomas Calderon
Hi, I have improved the Poc to include David's comments. The Kerberos code path can be activated using the following flag "-DWITH_GSSAPI=ON". Using this option replaces the NTLM provider in the Negotiate SSP, there is no fallback mechanism. I also tested that the code compiles and works with Heim

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-12 Thread FORT David
Le 12/03/2015 21:55, Thomas Calderon a écrit : > Hi, > > The code ported from rdsektop is minimal and isolated in kerberos_gss.c, it > consists of wrappers around GSSAPI to be precise. I was just trying to > apply code reuse. > I can easily rewrite it to have the same functionality so that there is

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-12 Thread Thomas Calderon
Hi, The code ported from rdsektop is minimal and isolated in kerberos_gss.c, it consists of wrappers around GSSAPI to be precise. I was just trying to apply code reuse. I can easily rewrite it to have the same functionality so that there is no licensing issues. Is that something that could be acc

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-12 Thread Marc-André Moreau
Thanks Peter for pointing it out, I was going to point it out myself. Thomas, for obvious reasons we cannot consider accepting such a contribution in the FreeRDP project, as by your own words it is based on code taken from rdesktop. Kerberos support in FreeRDP would be nice, but it cannot be imple

Re: [FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-12 Thread Peter Astrand
On Thu, 12 Mar 2015, Thomas Calderon wrote: > I have started working on a PoC to support Kerberos authentication for > FreeRDP clients. > The GSSAPI code was ported from the rdesktop project that has support for > Kerberos client authentication. Please note that due to the different licenses, it

[FreeRDP-devel] Support for Kerberos client authentication in FreeRDP

2015-03-12 Thread Thomas Calderon
Hi, I have started working on a PoC to support Kerberos authentication for FreeRDP clients. The modifications to the current NLA code are minimal. However, I have a couple of questions regarding how the Negotiate SSP and NLA are currently implemented within FreeRDP. First, the glue for trying K