Re: [FreeRDP-devel] XDamage with Shadow Server

2014-11-01 Thread Bernhard Miklautz
Hi there, On Sat, Nov 01, 2014 at 09:46:39AM -0400, Marc-André Moreau wrote: > RDP has no message to notify multiple connected clients of cursor movements, > as > cursor movements are driven by the client, not the other way around. This > means that even if the cursor image itself can be remoted,

Re: [FreeRDP-devel] XDamage with Shadow Server

2014-11-01 Thread Marc-André Moreau
Hi Ryan, Now that you point out what the cause of the issue is, it makes sense. I had to add cursor blending support for a customer requirement to correctly handle multiple users connected at the same time on the same session. RDP has no message to notify multiple connected clients of cursor movem

Re: [FreeRDP-devel] XDamage with Shadow Server

2014-10-30 Thread Ryan Bair
The regions under the mouse cursor are being updated at full blast. I believe the issue is in x11_shadow_blend_cursor, disabling it drastically reduces bandwidth usage. I'm suspecting the cursor is being added to the image and then compared against the next frame which does not have the cursor trig

Re: [FreeRDP-devel] XDamage with Shadow Server

2014-10-25 Thread Marc-André Moreau
Hi Ryan, In certain cases xdamage can return useful information, but to be 100% certain we would still need to use it as a hint and perform comparison on the next and previous frame to detect regions that have truly changed. If you want to use it, I've got nothing against it, it's just a matter of

Re: [FreeRDP-devel] XDamage with Shadow Server

2014-10-24 Thread Ryan Bair
Thank you Marc, useful information. I did some exploring with XDamage today and the information returned seems sane on my setup (Intel hd3000, gnome-shell/mutter, Fedora 20). I might do some exploring and make it an opt-in feature. I noticed on master that my WAN upstream (all 1Mbit of it) is bei

Re: [FreeRDP-devel] XDamage with Shadow Server

2014-10-24 Thread Marc-André Moreau
Hi Ryan, xdamage usage is currently disabled in the X11 shadow server subsystem because it is not working correctly. In the vast majority of modern X11 environments, xdamage is totally useless and reports the entire screen as being invalidated on every pixel change. This happens with compositing w

[FreeRDP-devel] XDamage with Shadow Server

2014-10-23 Thread Ryan Bair
I found some unused code which makes use of XDamage but is no longer used. There are two commits that removed the functionality: https://github.com/FreeRDP/FreeRDP/commit/d9d9bf36094ba41e0d52defa18b8b424ef3d0e83#diff-2db5bd5d07a97902247410cfb1d7c8a1 https://github.com/FreeRDP/FreeRDP/commit/fdab8