Re: [fricas-devel] [PATCH] add a new interface for partialFraction;

2016-10-22 Thread Waldek Hebisch
oldk1331 wrote: > > Another angle to see this problem: > > In theory, every Euclidean domain is a unique factorization > domain, but in FriCAS, it's not. > > In an email one year ago, there's discussion about it: > https://groups.google.com/forum/#!topic/fricas-devel/mMmm9zmC7io > > > There

Re: [fricas-devel] [PATCH] add a new interface for partialFraction;

2016-10-22 Thread oldk1331
Another angle to see this problem: In theory, every Euclidean domain is a unique factorization domain, but in FriCAS, it's not. In an email one year ago, there's discussion about it: https://groups.google.com/forum/#!topic/fricas-devel/mMmm9zmC7io > There are principal ideal domains where all

Re: [fricas-devel] [PATCH] add a new interface for partialFraction;

2016-10-18 Thread oldk1331
> ATM I am undecided. I am not sure if changing 'up' to 'UP' is > really an improvement. OTOH there are several uses of 'pretend'... I think types should all be capitalized, and changing UP to a macro is better. As for the usage of pretend, the whole PartialFractionPackage still looks

Re: [fricas-devel] [PATCH] add a new interface for partialFraction;

2016-10-18 Thread Waldek Hebisch
> > Any update on this patch? > > On Thu, Oct 13, 2016 at 8:58 PM, oldk1331 wrote: > > A little more misc fixes and improvements for pfr.spad: > > > > https://github.com/oldk1332/fricas/commit/57f913c588bbdb970f50305ccb72e912586fcb2b.patch > > > > It's not included in the

Re: [fricas-devel] [PATCH] add a new interface for partialFraction; doc fix

2016-10-18 Thread oldk1331
Any update on this patch? On Thu, Oct 13, 2016 at 8:58 PM, oldk1331 wrote: > A little more misc fixes and improvements for pfr.spad: > > https://github.com/oldk1332/fricas/commit/57f913c588bbdb970f50305ccb72e912586fcb2b.patch > > It's not included in the patch, but maybe it's

Re: [fricas-devel] [PATCH] add a new interface for partialFraction; doc fix

2016-10-13 Thread oldk1331
A little more misc fixes and improvements for pfr.spad: https://github.com/oldk1332/fricas/commit/57f913c588bbdb970f50305ccb72e912586fcb2b.patch It's not included in the patch, but maybe it's better to replace "nil()" with "[]"? -- You received this message because you are subscribed to the

Re: [fricas-devel] [PATCH] add a new interface for partialFraction; doc fix

2016-10-12 Thread oldk1331
Updated patch: https://github.com/oldk1332/fricas/commit/b0fb558ecee4b387d45b7c210841003ebc832bb6.patch > It seems that we can add new funtion directly to PartialFraction, > without creating a new package. Fixed. > I am doing such things in lazy way: if looking at code there > may be doubt

Re: [fricas-devel] [PATCH] add a new interface for partialFraction; doc fix

2016-10-12 Thread Waldek Hebisch
oldk1331 wrote: > > https://github.com/oldk1332/fricas/commit/a7e1be2d9bbf176d8b97aa0e4d8d382417ada1b6.patch It seems that we can add new funtion directly to PartialFraction, without creating a new package. > > > Futhermore, I want to remove the "global type declaration" > of a,b,r,n in

[fricas-devel] [PATCH] add a new interface for partialFraction; doc fix

2016-10-11 Thread oldk1331
https://github.com/oldk1332/fricas/commit/a7e1be2d9bbf176d8b97aa0e4d8d382417ada1b6.patch Futhermore, I want to remove the "global type declaration" of a,b,r,n in PartialFraction, opinions? After this patch, some examples: (1) -> partialFraction(1/18) 14 (1) ─ - ──