Re: CVS renato: Removed the warning about the obsolete option -blackout.
On Sun, Jul 09, 2006 at 01:00:08AM +0100, seventh guardian wrote: On 7/9/06, Dominik Vogt [EMAIL PROTECTED] wrote: Well, we have been very *very* conservative in the past about backwards compatibility - and that patch breaks it. It's no longer possible to start fvwm with -blackout. I don't think this is the right time to remove it. Of course it's obsolete and useless, but in the 2.x series we tried to keep compatibility as much as possible. The ominous 3.0 release (which is meant to remove a lot of old and obsolete stuff) would be the place to clean everything up. Well, it wasn't even useful to 2.4, and I doubt people would keep configs from pre-2.4.. So I thought it wouldn't matter. My fault. Sometimes it is surprising how long it can take until everybody has switched to a more recent release. Some people stick to 2.2.x for no other reason than that it is smaller. How can I reverse the change? With a bit of CVS magic. First, find out the revision numbers of the changed files before and after the change. For example, for fvwm.c do $ cvs log -N fvwm.c ... revision 1.375 date: 2006/07/07 23:34:31; author: renato; state: Exp; lines: +0 -8 Removed the warning about the obsolete option -blackout. Removed its reference from the manual. revision 1.374 ... (The relevant numbers are 1.374 and 1.375 here). Next, generate a patch for that change: $ cvs diff -u -r 1.374 -r 1.375 fvwm.c blackout.patch (Double check that the patch contains only the changes you want to reverse; edit the patch file if necessary). Finally reverse-apply the patch: $ patch -p0 -R blackout.patch Repeat this for all affected files. Well, although I've now done the change myself locally, I leave it to you as it is a good practive for using cvs :-) -- While you're at it you can change the warning (and todo-3.0 file) to inform the user that -blackout *will* be removed in 3.0. I'm still a bit overwelmed by the commit access, so I triple-check (instead of double-check) what I do :) ... Sorry, you're right.. Won't happen again :) There's really no reason to feel disheartened. I appreciate your work very much and other surely do too. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
Re: CVS renato: Removed the warning about the obsolete option -blackout.
On 7/9/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Sun, Jul 09, 2006 at 01:00:08AM +0100, seventh guardian wrote: On 7/9/06, Dominik Vogt [EMAIL PROTECTED] wrote: Well, we have been very *very* conservative in the past about backwards compatibility - and that patch breaks it. It's no longer possible to start fvwm with -blackout. I don't think this is the right time to remove it. Of course it's obsolete and useless, but in the 2.x series we tried to keep compatibility as much as possible. The ominous 3.0 release (which is meant to remove a lot of old and obsolete stuff) would be the place to clean everything up. Well, it wasn't even useful to 2.4, and I doubt people would keep configs from pre-2.4.. So I thought it wouldn't matter. My fault. Sometimes it is surprising how long it can take until everybody has switched to a more recent release. Some people stick to 2.2.x for no other reason than that it is smaller. How can I reverse the change? With a bit of CVS magic. First, find out the revision numbers of the changed files before and after the change. For example, for fvwm.c do $ cvs log -N fvwm.c ... revision 1.375 date: 2006/07/07 23:34:31; author: renato; state: Exp; lines: +0 -8 Removed the warning about the obsolete option -blackout. Removed its reference from the manual. revision 1.374 ... (The relevant numbers are 1.374 and 1.375 here). Next, generate a patch for that change: $ cvs diff -u -r 1.374 -r 1.375 fvwm.c blackout.patch (Double check that the patch contains only the changes you want to reverse; edit the patch file if necessary). Finally reverse-apply the patch: $ patch -p0 -R blackout.patch Repeat this for all affected files. Well, although I've now done the change myself locally, I leave it to you as it is a good practive for using cvs :-) Ok, done. Thanks for the tip :) -- While you're at it you can change the warning (and todo-3.0 file) to inform the user that -blackout *will* be removed in 3.0. Done. I've also added the the info about its future removal to the manual (hope it's ok). Cheers, Renato I'm still a bit overwelmed by the commit access, so I triple-check (instead of double-check) what I do :) ... Sorry, you're right.. Won't happen again :) There's really no reason to feel disheartened. I appreciate your work very much and other surely do too. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFEsMFJmeSprTOr4tgRAjAsAKCNDMZXYYvLWDBa5bv0Dd/Cacbx1QCghVlJ MYfu0Uj0Wl3JmlIiK+4Cgik= =NOZ/ -END PGP SIGNATURE-
Re: CVS renato: Removed the warning about the obsolete option -blackout.
On Fri, Jul 07, 2006 at 06:34:31PM -0500, fvwm-workers wrote: CVSROOT: /home/cvs/fvwm Module name: fvwm Changes by: renato 06/07/07 18:34:31 Modified files: . : ChangeLog fvwm : fvwm.1.in fvwm.c Log message: Removed the warning about the obsolete option -blackout. Removed its reference from the manual. Um, why? We've never had any 'secret' features (at least not on purpose). Every option is documented, even if it's frowned upon. Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
Re: CVS renato: Removed the warning about the obsolete option -blackout.
On 7/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Fri, Jul 07, 2006 at 06:34:31PM -0500, fvwm-workers wrote: CVSROOT: /home/cvs/fvwm Module name: fvwm Changes by: renato 06/07/07 18:34:31 Modified files: . : ChangeLog fvwm : fvwm.1.in fvwm.c Log message: Removed the warning about the obsolete option -blackout. Removed its reference from the manual. Um, why? We've never had any 'secret' features (at least not on purpose). Every option is documented, even if it's frowned upon. The -blackout code was removed a long time ago. The warning I refer to was put there by you in 1999 (pre-2.4) so that people who used to start fvwm with the -blackout option could still do it, even if it didn't do nothing. There was really no option -blackout, fvwm just accepted it and said it doesnt do nothing anymore, instead of refusing to start. It's there (the warning) since 1999, so I guess no one needs that anymore.. Cheers, Renato Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFEr5hHmeSprTOr4tgRArLlAKCGMrl4JT7tV0SAvv3hKQqd8Qd0HwCbBu3t 5adq7LfT20dzmR9KI9PxpDI= =od5t -END PGP SIGNATURE-
Re: CVS renato: Removed the warning about the obsolete option -blackout.
On 7/8/06, seventh guardian [EMAIL PROTECTED] wrote: On 7/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Fri, Jul 07, 2006 at 06:34:31PM -0500, fvwm-workers wrote: CVSROOT: /home/cvs/fvwm Module name: fvwm Changes by: renato 06/07/07 18:34:31 Modified files: . : ChangeLog fvwm : fvwm.1.in fvwm.c Log message: Removed the warning about the obsolete option -blackout. Removed its reference from the manual. Um, why? We've never had any 'secret' features (at least not on purpose). Every option is documented, even if it's frowned upon. The -blackout code was removed a long time ago. The warning I refer to was put there by you in 1999 (pre-2.4) so that people who used to start fvwm with the -blackout option could still do it, even if it didn't do nothing. There was really no option -blackout, fvwm just accepted it and said it doesnt do nothing anymore, instead of refusing to start. It's there (the warning) since 1999, so I guess no one needs that anymore.. I'm still a bit overwelmed by the commit access, so I triple-check (instead of double-check) what I do :) From ChangeLog-pre2.4: 1999-07-08 Dominik Vogt dominik(dot)vogt(at)gmx(dot)de (...) * fvwm/fvwm.h: * fvwm/builtins.c (do_recapture): * fvwm/fvwm.c: removed the 'blackout' code completely (...) Cheers Renato Cheers, Renato Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFEr5hHmeSprTOr4tgRArLlAKCGMrl4JT7tV0SAvv3hKQqd8Qd0HwCbBu3t 5adq7LfT20dzmR9KI9PxpDI= =od5t -END PGP SIGNATURE-
Re: CVS renato: Removed the warning about the obsolete option -blackout.
On Sat, Jul 08, 2006 at 11:48:43PM +0100, seventh guardian wrote: On 7/8/06, seventh guardian [EMAIL PROTECTED] wrote: On 7/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Fri, Jul 07, 2006 at 06:34:31PM -0500, fvwm-workers wrote: CVSROOT: /home/cvs/fvwm Module name: fvwm Changes by: renato 06/07/07 18:34:31 Modified files: . : ChangeLog fvwm : fvwm.1.in fvwm.c Log message: Removed the warning about the obsolete option -blackout. Removed its reference from the manual. Um, why? We've never had any 'secret' features (at least not on purpose). Every option is documented, even if it's frowned upon. The -blackout code was removed a long time ago. The warning I refer to was put there by you in 1999 (pre-2.4) so that people who used to start fvwm with the -blackout option could still do it, even if it didn't do nothing. There was really no option -blackout, fvwm just accepted it and said it doesnt do nothing anymore, instead of refusing to start. It's there (the warning) since 1999, so I guess no one needs that anymore.. Well, we have been very *very* conservative in the past about backwards compatibility - and that patch breaks it. It's no longer possible to start fvwm with -blackout. I don't think this is the right time to remove it. Of course it's obsolete and useless, but in the 2.x series we tried to keep compatibility as much as possible. The ominous 3.0 release (which is meant to remove a lot of old and obsolete stuff) would be the place to clean everything up. I'm still a bit overwelmed by the commit access, so I triple-check (instead of double-check) what I do :) Well, I certainly don't want to discourage you from doing usefull work, but please don't become too eager committing potentially harmful changes without discussing them. Compatibility is a sensitive issue, and we have spent lots of time thinking about the right way to go. (The fact that most of us don't have time to write patches nowadays does not mean we don't have the time to argue about patches ;-) ) Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] signature.asc Description: Digital signature
Re: CVS renato: Removed the warning about the obsolete option -blackout.
On 7/9/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Sat, Jul 08, 2006 at 11:48:43PM +0100, seventh guardian wrote: On 7/8/06, seventh guardian [EMAIL PROTECTED] wrote: On 7/8/06, Dominik Vogt [EMAIL PROTECTED] wrote: On Fri, Jul 07, 2006 at 06:34:31PM -0500, fvwm-workers wrote: CVSROOT: /home/cvs/fvwm Module name: fvwm Changes by: renato 06/07/07 18:34:31 Modified files: . : ChangeLog fvwm : fvwm.1.in fvwm.c Log message: Removed the warning about the obsolete option -blackout. Removed its reference from the manual. Um, why? We've never had any 'secret' features (at least not on purpose). Every option is documented, even if it's frowned upon. The -blackout code was removed a long time ago. The warning I refer to was put there by you in 1999 (pre-2.4) so that people who used to start fvwm with the -blackout option could still do it, even if it didn't do nothing. There was really no option -blackout, fvwm just accepted it and said it doesnt do nothing anymore, instead of refusing to start. It's there (the warning) since 1999, so I guess no one needs that anymore.. Well, we have been very *very* conservative in the past about backwards compatibility - and that patch breaks it. It's no longer possible to start fvwm with -blackout. I don't think this is the right time to remove it. Of course it's obsolete and useless, but in the 2.x series we tried to keep compatibility as much as possible. The ominous 3.0 release (which is meant to remove a lot of old and obsolete stuff) would be the place to clean everything up. Well, it wasn't even useful to 2.4, and I doubt people would keep configs from pre-2.4.. So I thought it wouldn't matter.. My fault. How can I reverse the change? I'm still a bit overwelmed by the commit access, so I triple-check (instead of double-check) what I do :) Well, I certainly don't want to discourage you from doing usefull work, but please don't become too eager committing potentially harmful changes without discussing them. Compatibility is a sensitive issue, and we have spent lots of time thinking about the right way to go. (The fact that most of us don't have time to write patches nowadays does not mean we don't have the time to argue about patches ;-) ) Sorry, you're right.. Won't happen again :) Cheers, Renato Ciao Dominik ^_^ ^_^ -- Dominik Vogt, [EMAIL PROTECTED] -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.1 (GNU/Linux) iD8DBQFEsEPbmeSprTOr4tgRAvijAKDUpJbB6gS+oF8zoklKwBVhJsH/rACfV5Bv Ab6/ggXU2ocAevGUMFiCoJk= =KPUA -END PGP SIGNATURE-
CVS renato: Removed the warning about the obsolete option -blackout.
CVSROOT:/home/cvs/fvwm Module name:fvwm Changes by: renato 06/07/07 18:34:31 Modified files: . : ChangeLog fvwm : fvwm.1.in fvwm.c Log message: Removed the warning about the obsolete option -blackout. Removed its reference from the manual.