Re: [galaxy-dev] worflow editor is slow with a large amount of steps

2013-10-21 Thread James Taylor
On Mon, Oct 21, 2013 at 4:08 AM, Bjoern Gruening
 wrote:
> one of our users has created a large workflow with > 300 steps. Yes he
> really loves Galaxy :)
> Unfortunately, its not possible to use the graphical user interface
> anymore with so many steps. You can't connect boxes and scrolling is
> also slow.

Can you do any javascript profiling to see where the time is being
spent. If I had to guess, I would say the inability to connect is due
to the search through all possible inputs to highlight the connectable
ones in green. You could just disable that if the workflow has more
than say 50 steps, and switch to just checking on hover.

(but that's just a guess)

The workflow editor doesn't use any library beyond jquery, all the
relevant code to this problem should be in:
static/scripts/galaxy.workflow_editor.canvas.js

--
James Taylor, Associate Professor, Biology/CS, Emory University
___
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  http://lists.bx.psu.edu/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/


Re: [galaxy-dev] worflow editor is slow with a large amount of steps

2013-10-21 Thread Saket Choudhary
Hi Bjoern,

On 21 October 2013 14:11, Bjoern Gruening  wrote:
> Hi Saket,
>
>>
>> On 21 October 2013 13:38, Bjoern Gruening  wrote:
>> > Hi,
>> >
>> > one of our users has created a large workflow with > 300 steps. Yes he
>> > really loves Galaxy :)
>> > Unfortunately, its not possible to use the graphical user interface
>> > anymore with so many steps. You can't connect boxes and scrolling is
>> > also slow.
>> >
>> > It there any hint how to solve, any workflow redesign already planned or
>> > in preparation? I would spend some time in improving it if it's worth.
>> > Any pointer to the used Javascript library, or is that mainly solved
>> > with the "workflow in a workflow" GSOC project that was merged recently.
>> >
>>
>> My GSoC project is still under review, pending pull
>> request:https://bitbucket.org/galaxy/galaxy-central/pull-request/229/nested-workflows
>
> thanks for the update. Lets cross the fingers that it gets merged :)
>
>> If loading 300 steps all at once is the only culprit, the 'nested
>> workflows' should be able to address the problem. I do not have any
>> benchmarking stats though.
>
> Great! Do you have any other ideas how to speed it up a little bit.
> Which JS library is used internally? I think most of the issue is due to
> slow rendering.
>

It is mostly jquery. Have a look at:
static/scripts/galaxy.workflows.js

If I am correct, this is where all the editor actions are processed.
The editor template is at :
templates/webapps/galaxy/workflow/editor.mako

Thanks,
Saket

> Cheers,
> Bjoern
>
>> Saket
>>
>> > Trello card is here:
>> > https://trello.com/c/dgVrxrHC
>> >
>> > Cheers,
>> > Bjoern
>> >
>> > ___
>> > Please keep all replies on the list by using "reply all"
>> > in your mail client.  To manage your subscriptions to this
>> > and other Galaxy lists, please use the interface at:
>> >   http://lists.bx.psu.edu/
>> >
>> > To search Galaxy mailing lists use the unified search at:
>> >   http://galaxyproject.org/search/mailinglists/
>
>
>
___
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  http://lists.bx.psu.edu/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/


Re: [galaxy-dev] worflow editor is slow with a large amount of steps

2013-10-21 Thread Bjoern Gruening
Hi Saket,

> 
> On 21 October 2013 13:38, Bjoern Gruening  wrote:
> > Hi,
> >
> > one of our users has created a large workflow with > 300 steps. Yes he
> > really loves Galaxy :)
> > Unfortunately, its not possible to use the graphical user interface
> > anymore with so many steps. You can't connect boxes and scrolling is
> > also slow.
> >
> > It there any hint how to solve, any workflow redesign already planned or
> > in preparation? I would spend some time in improving it if it's worth.
> > Any pointer to the used Javascript library, or is that mainly solved
> > with the "workflow in a workflow" GSOC project that was merged recently.
> >
> 
> My GSoC project is still under review, pending pull
> request:https://bitbucket.org/galaxy/galaxy-central/pull-request/229/nested-workflows

thanks for the update. Lets cross the fingers that it gets merged :)

> If loading 300 steps all at once is the only culprit, the 'nested
> workflows' should be able to address the problem. I do not have any
> benchmarking stats though.

Great! Do you have any other ideas how to speed it up a little bit.
Which JS library is used internally? I think most of the issue is due to
slow rendering.

Cheers,
Bjoern

> Saket
> 
> > Trello card is here:
> > https://trello.com/c/dgVrxrHC
> >
> > Cheers,
> > Bjoern
> >
> > ___
> > Please keep all replies on the list by using "reply all"
> > in your mail client.  To manage your subscriptions to this
> > and other Galaxy lists, please use the interface at:
> >   http://lists.bx.psu.edu/
> >
> > To search Galaxy mailing lists use the unified search at:
> >   http://galaxyproject.org/search/mailinglists/



___
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  http://lists.bx.psu.edu/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/


Re: [galaxy-dev] worflow editor is slow with a large amount of steps

2013-10-21 Thread Saket Choudhary
Hi Bjoern,



On 21 October 2013 13:38, Bjoern Gruening  wrote:
> Hi,
>
> one of our users has created a large workflow with > 300 steps. Yes he
> really loves Galaxy :)
> Unfortunately, its not possible to use the graphical user interface
> anymore with so many steps. You can't connect boxes and scrolling is
> also slow.
>
> It there any hint how to solve, any workflow redesign already planned or
> in preparation? I would spend some time in improving it if it's worth.
> Any pointer to the used Javascript library, or is that mainly solved
> with the "workflow in a workflow" GSOC project that was merged recently.
>

My GSoC project is still under review, pending pull
request:https://bitbucket.org/galaxy/galaxy-central/pull-request/229/nested-workflows

If loading 300 steps all at once is the only culprit, the 'nested
workflows' should be able to address the problem. I do not have any
benchmarking stats though.

Saket

> Trello card is here:
> https://trello.com/c/dgVrxrHC
>
> Cheers,
> Bjoern
>
> ___
> Please keep all replies on the list by using "reply all"
> in your mail client.  To manage your subscriptions to this
> and other Galaxy lists, please use the interface at:
>   http://lists.bx.psu.edu/
>
> To search Galaxy mailing lists use the unified search at:
>   http://galaxyproject.org/search/mailinglists/
___
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  http://lists.bx.psu.edu/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/


[galaxy-dev] worflow editor is slow with a large amount of steps

2013-10-21 Thread Bjoern Gruening
Hi,

one of our users has created a large workflow with > 300 steps. Yes he
really loves Galaxy :)
Unfortunately, its not possible to use the graphical user interface
anymore with so many steps. You can't connect boxes and scrolling is
also slow.

It there any hint how to solve, any workflow redesign already planned or
in preparation? I would spend some time in improving it if it's worth.
Any pointer to the used Javascript library, or is that mainly solved
with the "workflow in a workflow" GSOC project that was merged recently.

Trello card is here:
https://trello.com/c/dgVrxrHC

Cheers,
Bjoern

___
Please keep all replies on the list by using "reply all"
in your mail client.  To manage your subscriptions to this
and other Galaxy lists, please use the interface at:
  http://lists.bx.psu.edu/

To search Galaxy mailing lists use the unified search at:
  http://galaxyproject.org/search/mailinglists/