Re: [Galette-devel] Hello Galette
Hi Johan, good afternoon Sorry for the late reply. I am currently looking busy arranging my life in London. I had time to do a quick check to your last commits. I do not know if I needed to but I clicked to the approve button, I guess that sends some kind of notification to you. I also added a comment asking about the tool to use to correct all the coding styles. I will continue working on that later on with the translation, css and more functionalities. Many thanks for your support, great job ! Marc, ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel
Re: [Galette-devel] Hello Galette
Hello Marc, Le 03/09/2013 16:19, Marc Andreu a écrit : Hi Johan, good afternoon Sorry for the late reply. I am currently looking busy arranging my life in London. No problem, really. I've been myself pretty busy :) I had time to do a quick check to your last commits. I do not know if I needed to but I clicked to the approve button, I guess that sends some kind of notification to you. Yep, I've received notifications. That's not required to approve, I was not aware such an option exists (that is a good point for bitbucket anyways!). I also added a comment asking about the tool to use to correct all the coding styles. OK, I'll answer you there. I will continue working on that later on with the translation, css and more functionalities. Good luck :) Many thanks for your support, great job ! My pleasure, that was really not a huge work ;) See ya, -- Johan signature.asc Description: OpenPGP digital signature ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel
Re: [Galette-devel] Hello Galette
Hi Marc, Le 14/08/2013 15:29, Marc Andreu Fernandez a écrit : Hello Johan and team, good afternoon. I finally finished the Import Google Contacts plugin. You can try and review from https://bitbucket.org/trashy/galette-import-google-contacts/commits/53cb762040da208e620fae7abc569caa6d9544aa I configured my eclipse with the php code snifer to follow the pear coding standards. Let me know if there is still something not good about styles, its first time to use this. There is a small Readme.txt file with the basic details you need to know in order to configure the google authentication details. I've checked out your changes, but I've not tested the import itself (no time for this for now). I've made some changes I've commited on the bitbucket repo, commit message and changes themselves should be self explanatory ;) One think I was trying to do while cleaning the code was to write some unit tests using Atoum. The only test that its working is the HelloWorld sample test of Atoum tutorial :-) . I had issues with the required_once, namespaces and file locations as I tried to put classes into /classes but it did not work. If you could help the to setup a simple test for the GoogleContcatsClient.php could be very useful for me to cover as much code as possible with proper test cases. Well... Unit tests are not really working into Galette, due to some coding issues (globals for example). So, do not expect tests to run if you rely on an existing Galette class for now :( Also, nothing is really done for plugins unit testing; only plugins detection is done in the core of Galette. I'll try to take a look on that when I'll have some free time, but I'm pretty sure that will not work until some heay changes has been made on core itself. Another issue that I had is about running the plugin a second time. When an adherent already exists the check function, of the Adherent class, fails and I am not able to add more data to that adherent. Is there any way to check the import values are correct for an already existing member? That could allow this plugin to do proper synchronization from Gmail to Galette. Its in my TODO list, but any help on this could be very useful as well. I do not see anything really wrong so far (that does not mean nothing is ;)). I'll take a look when I can test the whole thing. Thank you, -- Johan signature.asc Description: OpenPGP digital signature ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel
Re: [Galette-devel] Hello Galette
Hello Johan and team, good afternoon. I finally finished the Import Google Contacts plugin. You can try and review from https://bitbucket.org/trashy/galette-import-google-contacts/commits/53cb762040da208e620fae7abc569caa6d9544aa I configured my eclipse with the php code snifer to follow the pear coding standards. Let me know if there is still something not good about styles, its first time to use this. There is a small Readme.txt file with the basic details you need to know in order to configure the google authentication details. One think I was trying to do while cleaning the code was to write some unit tests using Atoum. The only test that its working is the HelloWorld sample test of Atoum tutorial :-) . I had issues with the required_once, namespaces and file locations as I tried to put classes into /classes but it did not work. If you could help the to setup a simple test for the GoogleContcatsClient.php could be very useful for me to cover as much code as possible with proper test cases. Another issue that I had is about running the plugin a second time. When an adherent already exists the check function, of the Adherent class, fails and I am not able to add more data to that adherent. Is there any way to check the import values are correct for an already existing member? That could allow this plugin to do proper synchronization from Gmail to Galette. Its in my TODO list, but any help on this could be very useful as well. The HTML and CSS are basic, no styles for now. If I have time later on I will work on that. Please send me any further suggestion or comment in order to improve this plugin. Many thanks, kind regards Marc Andreu, ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel
Re: [Galette-devel] Hello Galette
Hi Johan, good afternoon Many thanks for your help, I will work on it soon and let you know. Can I commit changes to that GIT repo that you created? Kind regards, Marc, ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel
Re: [Galette-devel] Hello Galette
Cool, many thanks. Have a good weekend. On 19 July 2013 20:57, Johan Cwiklinski jo...@x-tnd.be wrote: Le 19/07/2013 21:51, Marc Andreu Fernandez a écrit : Hello Johan, I just created one, its marcandreuf. I've gave you write access on that repository :) Happy hacking ;) -- Johan ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel -- - Marc Andreu Fernàndez. - ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel
Re: [Galette-devel] Hello Galette
Le 19/07/2013 21:51, Marc Andreu Fernandez a écrit : Hello Johan, I just created one, its marcandreuf. I've gave you write access on that repository :) Happy hacking ;) -- Johan signature.asc Description: OpenPGP digital signature ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel
Re: [Galette-devel] Hello Galette
Hi Marc,
Le 18/07/2013 22:21, Marc Andreu Fernandez a écrit :
With the help of Melissa's Aeroclub plugin and the Paypal plugin and the
Plugin docs (which are not quite easy to follow using Google Tranlator ;-) )
:)
* Do I need any content in the lang folder? For now I do not want to
translate anything until I am sure that it works. I will try later on this
part if it is optional.
No, translations are not required for anything in Galette to work. Just
take care to use _T(My string) in PHP files and {_T string=My
string} in templates files instead of just My strind, and to write
all strings in english :)
* I do not have SQL tables to create for now, do I need to create empty
files?
No. The only file that is really required for a plugin to work is the
_defile.php with the appropriate content.
Yo do not even need to create empty folders for lang, sql and so on if
you do not need them (well, in the present case, lang will be needed in
the future, but not sql).
* Do I need a template file for each PHP plugin file? For example
adherentTest.tpl? Any documentation about how to create those templates? Is
it using any framework technology? I do not have CSS or JS for now, can I
use default styles?
No, one tpl file per template was just the way Galette used to do that
(well, that is no longer true for each of them).
The only point is that templates must be used to display content to user.
Templating system used is Smarty 3 (http://www.smarty.net/).
You are not required to add any CSS or JS, just use Galette ones :)
As for JS, note that we're using JQuery, and JQueryUI. All UI plugins
are not loaded per default.
For example, to use JQueryUI dialog plugin, you will have to use:
$tpl-assign('require_dialog', true);
That will load required files for that part.
* The only file that I have for now is the adherentTest.php. That code is
extracted from Melissa plugin import.php file as she told me. For now I
only need to make sure that that code complies and runs. I mean, it stores
a sample user into DB with all required fields. I have the PHP code to
connect google and fetch all the data that I need, I will add later once I
am sure that I reused the import.php code properly as a plugin in Galette.
And please help me to review the few files of the plugin, the define.php,
menu.tpl, etc... I am not 100% about some content the I added.
Any comment or review will be very helpful because I am getting some errors
and I am a bit lost.
First, a note: please do not use tabs but spaces in your Galette code
(to suit coding standards), as my editors are configured to display
coding standards issues, that is the first thing I change every time I
open a file :)
And if you plan to work on main Galette code in the future, note that
coding standard must be followed (I spent hours and hours to make the
entire code compliant).
I've quickly edited your code to fix some issues. You can retrieve the
modified version from a Git repo:
https://bitbucket.org/trashy/galette-import-google-contacts/overview
Well, some notes:
- take care of path. You get numerous spaces in your paths (ie. .. /
instead of ../ or xyz.php instead of xyz.php) - see
https://bitbucket.org/trashy/galette-import-google-contacts/commits/7a0e4b5ea3404423c8db45804488783ab75227a5.
- the name of the plugin in the _define.php fle is used for display, you
can use something that is more easy to read - see
https://bitbucket.org/trashy/galette-import-google-contacts/commits/fa8383a477dd3291392862573751c7a1761dcdcf
- the path you have to use in menu.tpl is related to name:
galette_{plugin_normalized_name}_path. Normalized name is just plugin
name, lower case, and with spaces replaced by _ - see
https://bitbucket.org/trashy/galette-import-google-contacts/commits/db830a865a8346a025754fdd4a749f7677fc1dbc.
- avoid using existing variables names in configuration files. i'm a bit
unsure that will really break something for now, but... Just make vars
spécific to plugin; it' way more safe ;) - see
https://bitbucket.org/trashy/galette-import-google-contacts/commits/4f61b7493676b27c4e7f6b9dd767eb08fef09edc
OK, after those changes, I got the new entry in the menu, with the
correct path to get plugin.
I had to make one change to get it working, as it (see
https://bitbucket.org/trashy/galette-import-google-contacts/commits/0fbd536744311bd1671724cc3144d45f4f4ca14e).
That is a Galette bug since a default status is initialized when
object is instanciated, but not in the same property used for storage...
Creation and modification dates are not the work of a plugin.
Passwords may no longer be required.
Well, you used required fields from Galette, that can be changed from
the interface. I'm not sure an import plugin should use them since they
are only user configuration; and do not reflect what is *really*
required for Galette to work as expected.
So, see
Re: [Galette-devel] Hello Galette
Hello Johan, team, good afternoon All right, sorry I will clean emails from now on :-) First milestone about gmail import. I attached the php script that I have until now, it is work in progress, I will clean code later. The idea is to connect to gmail through Oauth 2.0 and to use the Google Contacts API v3 https://developers.google.com/google-apps/contacts/v3/. I have been fighting 3 days to undestand google api and to get it working :-) I am able to get data now from google. My idea now is to present this data in a table format, using a Galette table style. Allow delete and edit rows/values and store temporal data into JSON object. Then add a submit button to process the import job, which will be doing sql inserts reusing the same query (or similar) of the add Member form in Galette. Do you think this could be integrated into Galette, any suggestion about how to develop this? Should I create a plugin? Any docs about how to create a plugin? Any help will be really good to speed up this. Johan: goobook was good, but my server does not have python :-( and using Google API I can use PHP like Galette. I thouhg it could be better to integrate with Galette? Many thanks guys, have a good afternoon. Marc, attachment: contacts.php ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel
Re: [Galette-devel] Hello Galette
Hi, Le 08/07/2013 19:56, Marc Andreu Fernandez a écrit : Do you think this could be integrated into Galette, any suggestion about how to develop this? Should I create a plugin? Any docs about how to create a plugin? Here is the documentation for plugins : http://galette.tuxfamily.org/documentation/fr/development/plugins.html It's in french only. But it's pretty easy to understand how it works. I can help you if you want. You may download one of the existing plugin to understand how it works. Maybe Paypal plugin ? http://galette.tuxfamily.org/documentation/fr/plugins/paypal.html Regards, Mélissa ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel
Re: [Galette-devel] Hello Galette
Hi Marc, Le 08/07/2013 19:56, Marc Andreu Fernandez a écrit : [...] Do you think this could be integrated into Galette, any suggestion about how to develop this? Should I create a plugin? Any docs about how to create a plugin? I did not realize that you will integrate that work into Galette... Until 0.7.4, there is a Gogole PHP API (http://code.google.com/p/google-api-php-client/) integrated to Galette, but it has been removed in the develop branch. It was only used to retrieve Google+ posts from Galette page, and I've decided to drop that (along with twitter post, which now need very much work even if it's public posts...). I'm not very fan of Google globally, and I'd prefer not to integrate Google related services in Galette main code. As far as I understand, the goal here is only to retrieve contacts from a google account, and integrate them into Galette. I think a plugin is a very good option. Johan: goobook was good, but my server does not have python :-( and using Google API I can use PHP like Galette. I thouhg it could be better to integrate with Galette? Indeed, python is not a googd solution for Galette :) But I had in mind you only want to import your contacts once ;) Regards, -- Johan signature.asc Description: OpenPGP digital signature ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel
Re: [Galette-devel] Hello Galette
Hello team, Could you help me to contact Melissa Djebel? I can find her name in the email list history but not her email address. Many thanks, Marc, On 4 July 2013 17:06, Marc Andreu Fernandez marcandr...@gmail.com wrote: Hello Andre, Many thanks I will try to find Melissa :-) Anyway if you could send me the PHP code I think it could help me as well. Thanks a lot, best regards Marc, On 4 July 2013 15:57, andre.tis...@numericable.com andre.tis...@numericable.com wrote: Hi Marc, Try to contact Melissa Djebel (I think you can find its address in the mailing list history) : she had built for me an add-in for managing an aircraft association, with an import of members from a back office application. Otherwise, I can send you the PHP file of this part : no use of SQL injection, but use the Galette native clesses. regards Original email: - From: Marc Andreu Fernandez marcandr...@gmail.com Date: Thu, 4 Jul 2013 11:38:19 +0200 To: jo...@x-tnd.be, galette-devel@gna.org Subject: Re: [Galette-devel] Hello Galette Hello Johan, good morning Many thanks for your help, I will start working on the import from google as we have now all contacte there. Very good to know you are there to help :-) Have a good day, Marc, On 4 July 2013 07:50, Johan Cwiklinski jo...@x-tnd.be wrote: Hello Marc, I'm Johan, the Galette leader and main developer since 2007. Le 03/07/2013 19:13, Marc Andreu Fernandez a écrit : Hello team, good afternoon I am Marc Andreu, PHP and Java developer. I am currently doing some support for a Non-Profit organization. Your application Galette is very good and exactly what we need for our group. I managed to install and run the application without problems. Glad to hear that :) I would like to start as a contributor and develop some parts that we need in order to start using your application. In order to start I only need to import all contacts that we have now in a gmail account to the Galette DB. Do you have anything similar already done or something that I can reuse? If not, could you help me to point out how I could do it? I will do an investigation about how to do it, but if you could give me some tips, it could be great, something like, what minimum data in DB I should import in order to make it consistent. Is it ok if I only add data to the table galette_adherents? I've never heard of Google import into Galette but there are various possibilities to export data from google accounts, and after that it should be possible to import data directly in the database. For the export part, a friend of mine tell me about goobook he uses for its mutt contacts, maybe it will be possible to use that for the export? For the import, yes, galette_adherents will be enought to start. At the moment, I cannot say exactly which data are required, that is something I have to document for the CSV import whish. As you can parametize fields that are required, there should be only a few fields. Maybe you should ask the question on the galette-users mailing list, I know there are several people who have worked on that recently, they maybe can help you (they are french, but helping you in english would not be a problem I guess ;)). Later on I would like to work on translation, I would like to translate all the application into Catalan and Spanish. Could you give me some tips about how to setup a new languange package? That would be great :) In the past, there was a Spanish translation; but I removed it since it was not maintained (no changes beetween 2007 and december 2011 unfortunately). When you'll be ready to start translating, just ask me, I'll create the required files. For now, I'm the only one working on the project and its translations, but I've submitted it on transifex (https://www.transifex.com/projects/p/galette/). You'll have the choice using transifex or to translate .po files directly, at your option. I'd love to see Galette translated in other languages, I was unsure non franch non profit organizations really can use it, but I now know they can. I do not know French, unfortunately, however I hope to be able to understand the code and use google translator when possible. I can write down documentation in english only. Since I've take project ownership, all users and contributors were french, and so, I had no reason to write docs in english, but that is not a problem. The main work would be to translate existing documentation in english. Also, all bugs, evolutions and whishes are now french only on the tracker (http://redmine.ulysses.fr/projects/galette/issues), using english other there will not be a problem. Be sure I'll help you begin with the project, just note that my work and familial obligations take me much time, I'm not always as responsive
Re: [Galette-devel] Hello Galette
Hi Marc, Le 04/07/2013 17:12, Marc Andreu Fernandez a écrit : Could you help me to contact Melissa Djebel? I can find her name in the email list history but not her email address. Indeed, mail address are not displayed in the history; but she did answer here, so it is ok ;) Do not forget to clean mail when you answer, to avoid reaching limits (on both lists, mails must be 15Ko max); I receive notifications for that only once a day. Regards, -- Johan signature.asc Description: OpenPGP digital signature ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel
Re: [Galette-devel] Hello Galette
Hello Marc, You can have a look at my project: https://galetteaeroclub.codeplex.com/ It's only in french. You can find in file import.php from line 185 to line 263 my code to import members into galette. Regards Le 04/07/2013 15:57, andre.tis...@numericable.com a écrit : Hi Marc, Try to contact Melissa Djebel (I think you can find its address in the mailing list history) : she had built for me an add-in for managing an aircraft association, with an import of members from a back office application. Otherwise, I can send you the PHP file of this part : no use of SQL injection, but use the Galette native clesses. regards Original email: - From: Marc Andreu Fernandez marcandr...@gmail.com Date: Thu, 4 Jul 2013 11:38:19 +0200 To: jo...@x-tnd.be, galette-devel@gna.org Subject: Re: [Galette-devel] Hello Galette Hello Johan, good morning Many thanks for your help, I will start working on the import from google as we have now all contacte there. Very good to know you are there to help :-) Have a good day, Marc, On 4 July 2013 07:50, Johan Cwiklinski jo...@x-tnd.be wrote: Hello Marc, I'm Johan, the Galette leader and main developer since 2007. Le 03/07/2013 19:13, Marc Andreu Fernandez a écrit : Hello team, good afternoon I am Marc Andreu, PHP and Java developer. I am currently doing some support for a Non-Profit organization. Your application Galette is very good and exactly what we need for our group. I managed to install and run the application without problems. Glad to hear that :) I would like to start as a contributor and develop some parts that we need in order to start using your application. In order to start I only need to import all contacts that we have now in a gmail account to the Galette DB. Do you have anything similar already done or something that I can reuse? If not, could you help me to point out how I could do it? I will do an investigation about how to do it, but if you could give me some tips, it could be great, something like, what minimum data in DB I should import in order to make it consistent. Is it ok if I only add data to the table galette_adherents? I've never heard of Google import into Galette but there are various possibilities to export data from google accounts, and after that it should be possible to import data directly in the database. For the export part, a friend of mine tell me about goobook he uses for its mutt contacts, maybe it will be possible to use that for the export? For the import, yes, galette_adherents will be enought to start. At the moment, I cannot say exactly which data are required, that is something I have to document for the CSV import whish. As you can parametize fields that are required, there should be only a few fields. Maybe you should ask the question on the galette-users mailing list, I know there are several people who have worked on that recently, they maybe can help you (they are french, but helping you in english would not be a problem I guess ;)). Later on I would like to work on translation, I would like to translate all the application into Catalan and Spanish. Could you give me some tips about how to setup a new languange package? That would be great :) In the past, there was a Spanish translation; but I removed it since it was not maintained (no changes beetween 2007 and december 2011 unfortunately). When you'll be ready to start translating, just ask me, I'll create the required files. For now, I'm the only one working on the project and its translations, but I've submitted it on transifex (https://www.transifex.com/projects/p/galette/). You'll have the choice using transifex or to translate .po files directly, at your option. I'd love to see Galette translated in other languages, I was unsure non franch non profit organizations really can use it, but I now know they can. I do not know French, unfortunately, however I hope to be able to understand the code and use google translator when possible. I can write down documentation in english only. Since I've take project ownership, all users and contributors were french, and so, I had no reason to write docs in english, but that is not a problem. The main work would be to translate existing documentation in english. Also, all bugs, evolutions and whishes are now french only on the tracker (http://redmine.ulysses.fr/projects/galette/issues), using english other there will not be a problem. Be sure I'll help you begin with the project, just note that my work and familial obligations take me much time, I'm not always as responsive as I'd like to be ;-) Thank you for your interest in Galette, Regards, -- Johan ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel ___ Galette-devel mailing list Galette-devel@gna.org https://mail.gna.org/listinfo/galette-devel
