Re: [PATCH stable-2.16 4/7] Make finalize_migration_{src,dst} 'atomic'

2016-10-13 Thread 'Brian Foley' via ganeti-devel
On Thu, Oct 13, 2016 at 01:16:39PM +0100, Viktor Bachraty wrote: >On Thu, Oct 13, 2016 at 12:48 PM, 'Brian Foley' via ganeti-devel ><[1]ganeti-devel@googlegroups.com> wrote: > > On Fri, Oct 07, 2016 at 08:38:02PM +0100, 'Viktor Bachraty' via > ganeti-devel wrote: > This

Re: [PATCH stable-2.16 4/7] Make finalize_migration_{src,dst} 'atomic'

2016-10-13 Thread 'Viktor Bachraty' via ganeti-devel
On Thu, Oct 13, 2016 at 12:48 PM, 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com> wrote: > On Fri, Oct 07, 2016 at 08:38:02PM +0100, 'Viktor Bachraty' via > ganeti-devel wrote: > > This should definitely help cleaning up after migrates. LGTM modulo nits > below. > > >

Re: [PATCH stable-2.16 4/7] Make finalize_migration_{src,dst} 'atomic'

2016-10-13 Thread 'Brian Foley' via ganeti-devel
On Fri, Oct 07, 2016 at 08:38:02PM +0100, 'Viktor Bachraty' via ganeti-devel wrote: This should definitely help cleaning up after migrates. LGTM modulo nits below. > FinalizeMigrationSource and FinalizeMigrationDst should compose an > 'atomic' operation consisting of 2 idempotent steps, that