Re: Issue 1175 in ganeti: ext3 filesystem hardcoded in fstab of import script

2016-06-10 Thread ganeti
Comment #6 on issue 1175 by hostingn...@gmail.com: ext3 filesystem hardcoded in fstab of import script https://code.google.com/p/ganeti/issues/detail?id=1175 @ius... thanks for the tip but backports packages are not considered as stable, hence "backports", and as such I do not want such

Re: [MERGE] stable-2.17 to master

2016-06-10 Thread 'Iustin Pop' via ganeti-devel
2016-06-10 16:25 GMT+02:00 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com>: > commit 7eb49311e18865db76c4e8da5eb4b2e166db2d55 > Merge: a32eb3c 17a1c27 > Author: Brian Foley > Date: Fri Jun 10 15:20:33 2016 +0100 > > Merge branch 'stable-2.17' > > *

[MERGE] stable-2.17 to master

2016-06-10 Thread 'Brian Foley' via ganeti-devel
commit 7eb49311e18865db76c4e8da5eb4b2e166db2d55 Merge: a32eb3c 17a1c27 Author: Brian Foley Date: Fri Jun 10 15:20:33 2016 +0100 Merge branch 'stable-2.17' * stable-2.17 * stable-2.16 Fix optimisation: Correctly extract secondary node

Re: [MERGE] stable-2.16 to stable-2.17

2016-06-10 Thread 'Iustin Pop' via ganeti-devel
2016-06-10 15:40 GMT+02:00 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com>: > commit b462d8c77bff0789e8a951288dea34226ab8b6d7 > Merge: 20c24a8 90281b4 > Author: Brian Foley > Date: Fri Jun 10 14:35:13 2016 +0100 > > Merge branch 'stable-2.16' into

Re: Issue 1175 in ganeti: ext3 filesystem hardcoded in fstab of import script

2016-06-10 Thread ganeti
Comment #5 on issue 1175 by ius...@google.com: ext3 filesystem hardcoded in fstab of import script https://code.google.com/p/ganeti/issues/detail?id=1175 @hosting: FYI, there's a newer package in jeesie-backports; I'd recommend using that. -- You received this message because this

[MERGE] stable-2.16 to stable-2.17

2016-06-10 Thread 'Brian Foley' via ganeti-devel
commit b462d8c77bff0789e8a951288dea34226ab8b6d7 Merge: 20c24a8 90281b4 Author: Brian Foley Date: Fri Jun 10 14:35:13 2016 +0100 Merge branch 'stable-2.16' into stable-2.17 * stable-2.16 Fix optimisation: Correctly extract secondary node Tune

Re: [MERGE] stable-2.15 to stable 2.16

2016-06-10 Thread 'Iustin Pop' via ganeti-devel
2016-06-10 15:28 GMT+02:00 'Brian Foley' via ganeti-devel < ganeti-devel@googlegroups.com>: > commit 5785f214a9e728465a4bfc1aef7ded306225cfa2 > Merge: 40cd52f 2429235 > Author: Brian Foley > Date: Fri Jun 10 14:23:10 2016 +0100 > > Merge branch 'stable-2.15' into

[MERGE] stable-2.15 to stable 2.16

2016-06-10 Thread 'Brian Foley' via ganeti-devel
commit 5785f214a9e728465a4bfc1aef7ded306225cfa2 Merge: 40cd52f 2429235 Author: Brian Foley Date: Fri Jun 10 14:23:10 2016 +0100 Merge branch 'stable-2.15' into stable-2.16 * stable-2.15 Fixup compatibility with GHC 7.4/base 4.5 Signed-off-by:

Re: [PATCH stable-2.15] Fixup compatibility with GHC 7.4/base 4.5

2016-06-10 Thread 'Brian Foley' via ganeti-devel
On Fri, Jun 10, 2016 at 01:51:56PM +0200, 'Iustin Pop' via ganeti-devel wrote: > It looks like commit c429dd26 introduced the use of > atomicModifyIORef', which is only present in base 4.6 (GHC 7.6). > Let's fix that by importing the actual implementation of said function > from base 4.6 in case

[PATCH stable-2.15] Fixup compatibility with GHC 7.4/base 4.5

2016-06-10 Thread 'Iustin Pop' via ganeti-devel
It looks like commit c429dd26 introduced the use of atomicModifyIORef', which is only present in base 4.6 (GHC 7.6). Let's fix that by importing the actual implementation of said function from base 4.6 in case we're running with earlier versions. Signed-off-by: Iustin Pop ---

Re: [PATCH master] Fixup compatibility with GHC 7.4/base 4.5

2016-06-10 Thread 'Iustin Pop' via ganeti-devel
On Fri, Jun 10, 2016 at 12:07:45PM +0100, Brian Foley wrote: > On Fri, Jun 10, 2016 at 12:33:23PM +0200, 'Iustin Pop' via ganeti-devel wrote: > > On Fri, Jun 10, 2016 at 12:30:03PM +0200, Iustin Pop wrote: > > > It looks like commit c429dd26 introduced the use of atomicModifyIORef', > > > which >

Re: [PATCH master] Fixup compatibility with GHC 7.4/base 4.5

2016-06-10 Thread 'Brian Foley' via ganeti-devel
On Fri, Jun 10, 2016 at 12:33:23PM +0200, 'Iustin Pop' via ganeti-devel wrote: > On Fri, Jun 10, 2016 at 12:30:03PM +0200, Iustin Pop wrote: > > It looks like commit c429dd26 introduced the use of atomicModifyIORef', > > which > > is only present in base 4.6 (GHC 7.6). Let's temporarily fix that

Re: [PATCH master 8/8] Ignore another bug in System.Time.diffClockTimes

2016-06-10 Thread 'Brian Foley' via ganeti-devel
On Thu, Jun 09, 2016 at 11:13:58PM +0200, Iustin Pop wrote: > From: Iustin Pop > > Reading the source for that function is scary: it uses local time conversions > in the context of what should be absolute (not local) time, so of course it > has > daylight savings time issues.

Re: [PATCH master 7/8] Replace getNode with getNodeByUuid in certain cases

2016-06-10 Thread 'Brian Foley' via ganeti-devel
On Thu, Jun 09, 2016 at 11:13:57PM +0200, Iustin Pop wrote: > From: Iustin Pop > > Do this in cases where this should already be the case: > - some functions are explicitly denoted to take UUIDs (documentation/parameter > name) > - some functions (e.g. clusterMasterNode,

Re: [PATCH master 6/8] Rework getInstDisks/getInstDisksFromObj

2016-06-10 Thread 'Brian Foley' via ganeti-devel
On Thu, Jun 09, 2016 at 11:13:56PM +0200, Iustin Pop wrote: > From: Iustin Pop > > The function getInstDisksFromObj takes an Instance object, extracts its uuids, > and passes that to getInstDisks. This function then looks up the given UUID in > the configuration, retrieves the

Re: [PATCH master] Fixup compatibility with GHC 7.4/base 4.5

2016-06-10 Thread 'Iustin Pop' via ganeti-devel
On Fri, Jun 10, 2016 at 12:30:03PM +0200, Iustin Pop wrote: > It looks like commit c429dd26 introduced the use of atomicModifyIORef', which > is only present in base 4.6 (GHC 7.6). Let's temporarily fix that by adding a > small compat layer (which undoes the optimisations of using strict on 7.4,

Re: [PATCH master 4/8] Split getInstance into *ByUuid and *ByPartialName

2016-06-10 Thread 'Iustin Pop' via ganeti-devel
On Fri, Jun 10, 2016 at 11:28:16AM +0100, Brian Foley wrote: > On Thu, Jun 09, 2016 at 11:13:54PM +0200, Iustin Pop wrote: > > From: Iustin Pop > > > > This function (and getNode, next patch) were two pain points when I tried to > > convert UUIDs to another type, since they're

[PATCH master] Fixup compatibility with GHC 7.4/base 4.5

2016-06-10 Thread 'Iustin Pop' via ganeti-devel
It looks like commit c429dd26 introduced the use of atomicModifyIORef', which is only present in base 4.6 (GHC 7.6). Let's temporarily fix that by adding a small compat layer (which undoes the optimisations of using strict on 7.4, but at least it works), until we decide to officially drop support

Re: [PATCH master 5/8] Split getNode into *ByUuid and *ByPartialName

2016-06-10 Thread 'Brian Foley' via ganeti-devel
On Thu, Jun 09, 2016 at 11:13:55PM +0200, Iustin Pop wrote: > From: Iustin Pop > > This follows the getInstance changes, with the same rationale. > > Signed-off-by: Iustin Pop LGTM

Re: [PATCH master 4/8] Split getInstance into *ByUuid and *ByPartialName

2016-06-10 Thread 'Brian Foley' via ganeti-devel
On Thu, Jun 09, 2016 at 11:13:54PM +0200, Iustin Pop wrote: > From: Iustin Pop > > This function (and getNode, next patch) were two pain points when I tried to > convert UUIDs to another type, since they're called via a single type > (currently String) that wants to dispatch

Re: [PATCH master 3/8] Switch TagSet from type synonim to a newtype

2016-06-10 Thread 'Brian Foley' via ganeti-devel
On Thu, Jun 09, 2016 at 11:13:53PM +0200, Iustin Pop wrote: > From: Iustin Pop > > This started from the fact that recent QuickCheck declares itself an arbitrary > instance "(Arbitrary a) => Arbitrary (Set a)", which conflicts with our > slightly more specific instance. The

Re: [PATCH master 2/8] Slightly improve the JSScheduler/prop_jobFiltering test

2016-06-10 Thread 'Brian Foley' via ganeti-devel
On Thu, Jun 09, 2016 at 11:13:52PM +0200, Iustin Pop wrote: > From: Iustin Pop > > For some reason, this test doesn't pass on Debian unstable. I don't know if it > passes on other versions of QuickCheck, but upon investigation, I think it was > always broken, but the use of

Re: [PATCH master 1/8] Fixup cabal dependencies relations

2016-06-10 Thread 'Viktor Bachraty' via ganeti-devel
LGTM On Thu, Jun 9, 2016 at 10:13 PM, Iustin Pop wrote: > From: Iustin Pop > > In Haskell world (at least as far as I know), dependencies of type "<= > A.B.C" > are rarely used, because incrementing the fourth version component (i.e. D > in > A.B.C.D)

Re: [PATCH master 3/3] Fix KVM pinning tests to not depend on the local machine

2016-06-10 Thread 'Viktor Bachraty' via ganeti-devel
On Fri, Jun 10, 2016 at 10:02 AM, Iustin Pop wrote: > 2016-06-10 10:58 GMT+02:00 Viktor Bachraty : > >> >> On Thu, Jun 9, 2016 at 11:33 PM, Iustin Pop wrote: >> >>> From: Iustin Pop >>> >>> Commit 8b2ec2f added

Re: [PATCH master 2/3] Don't use inexistent mock.assert_called_once()

2016-06-10 Thread 'Viktor Bachraty' via ganeti-devel
LGTM, thanks for catching this bug! On Thu, Jun 9, 2016 at 11:33 PM, Iustin Pop wrote: > From: Iustin Pop > > Old versions of mock were not strict, thus allowing to call any method on > mocked objects, without complaining. More recent mock versions are >

Re: [PATCH master 1/3] Support python-mock versions later than about 1.1

2016-06-10 Thread 'Viktor Bachraty' via ganeti-devel
LGTM On Thu, Jun 9, 2016 at 11:33 PM, Iustin Pop wrote: > From: Iustin Pop > > It seems the two alternatives for python-mock's way of patching objects > are not > enough; more recent versions have patch.object, so let's support that as > well. > I think

Re: [PATCH master 3/3] Fix KVM pinning tests to not depend on the local machine

2016-06-10 Thread 'Iustin Pop' via ganeti-devel
2016-06-10 10:58 GMT+02:00 Viktor Bachraty : > > On Thu, Jun 9, 2016 at 11:33 PM, Iustin Pop wrote: > >> From: Iustin Pop >> >> Commit 8b2ec2f added unittests for KVM pinning, but it introduced a >> non-obvious >> local dependency in

Re: [PATCH master 3/3] Fix KVM pinning tests to not depend on the local machine

2016-06-10 Thread 'Viktor Bachraty' via ganeti-devel
On Thu, Jun 9, 2016 at 11:33 PM, Iustin Pop wrote: > From: Iustin Pop > > Commit 8b2ec2f added unittests for KVM pinning, but it introduced a > non-obvious > local dependency in the tests: the CPU_PINNING_OFF calls work by looking > at the > (current)