Re: [PATCHv3][PING] Enable -fsanitize-recover for KASan

2014-09-30 Thread Yury Gribov
On 09/30/2014 04:24 AM, Konstantin Serebryany wrote: On Mon, Sep 29, 2014 at 4:26 PM, Alexey Samsonov samso...@google.com wrote: I don't think we ever going to support recovery for regular ASan (Kostya, correct me if I'm wrong). I hope so too. Another point is that with

Re: Fix libgomp crash without TLS (PR42616)

2014-09-30 Thread Varvara Rainchik
Corrected patch: call pthread_setspecific (gomp_tls_key, NULL) in gomp_thread_start if HAVE_TLS is not defined. 2014-09-19 Varvara Rainchik varvara.rainc...@intel.com * libgomp.h (gomp_thread): For non TLS case create thread data. * team.c (non_tls_thread_data_destructor,

Re: [PATCHv3][PING] Enable -fsanitize-recover for KASan

2014-09-30 Thread Yury Gribov
On 09/30/2014 09:40 AM, Jakub Jelinek wrote: On Mon, Sep 29, 2014 at 05:24:02PM -0700, Konstantin Serebryany wrote: I don't think we ever going to support recovery for regular ASan (Kostya, correct me if I'm wrong). I hope so too. Another point is that with

Re: [PATCH v2] Fix signed integer overflow in gcc/data-streamer.c

2014-09-30 Thread Markus Trippelsdorf
On 2014.09.28 at 14:57 +0200, Markus Trippelsdorf wrote: On 2014.09.28 at 14:36 +0200, Steven Bosscher wrote: Can you use HOST_WIDE_INT_1U for this? Sure. Thanks for the suggestion. (Fix now resembles similar idiom in data-streamer-in.c) I checked in the fix as obvious. -- Markus

Re: [PATCHv3][PING] Enable -fsanitize-recover for KASan

2014-09-30 Thread Yury Gribov
On 09/30/2014 10:56 AM, Yury Gribov wrote: On 09/30/2014 04:24 AM, Konstantin Serebryany wrote: On Mon, Sep 29, 2014 at 4:26 PM, Alexey Samsonov samso...@google.com wrote: I don't think we ever going to support recovery for regular ASan (Kostya, correct me if I'm wrong). I hope so too.

Infrastructure for forward propagation of polymorphic call contexts

2014-09-30 Thread Jan Hubicka
Hi, this patch adds interface for froward propagation of polymorphic contexts. The API is as follow: - OFFSET_BY that allows to change offset of context (to support ipa-prop ancestor functions), - MAKE_SPECULATIVE to kill non-speculative info when we can not keep track of dynamic type

Re: Fix for FAIL: tmpdir-gcc.dg-struct-layout-1/t028 c_compat_x_tst.o compile, (internal compiler error)

2014-09-30 Thread Richard Sandiford
David Sherwood david.sherw...@arm.com writes: @@ -1859,9 +1861,11 @@ static basic_block curr_bb; /* This recursive function creates allocnos corresponding to pseudo-registers containing in X. True OUTPUT_P means that X is - a lvalue. */ + a lvalue. The 'parent' parameter

Re: Fix for FAIL: tmpdir-gcc.dg-struct-layout-1/t028 c_compat_x_tst.o compile, (internal compiler error)

2014-09-30 Thread Andreas Schwab
Richard Sandiford richard.sandif...@arm.com writes: @@ -315,7 +318,7 @@ struct ira_allocno number (0, ...) - 2. Value -1 is used for allocnos spilled by the reload (at this point pseudo-register has only one allocno) which did not get stack slot yet. */ - short int

Re: [Patch] Cleanup widest_int_mode_for_size

2014-09-30 Thread James Greenhalgh
*ping* Thanks, James On Tue, Sep 23, 2014 at 10:17:21AM +0100, James Greenhalgh wrote: Hi, The comment on widest_int_mode_for_size claims that it returns the widest integer mode no wider than size. The implementation looks more like it finds the widest integer mode smaller than size.

Re: [PATCH, ARM]Option support to new ARM MCU Cortex-M7

2014-09-30 Thread Ramana Radhakrishnan
On Wed, Sep 24, 2014 at 6:17 AM, Terry Guo terry@arm.com wrote: Hi there, The attached patch intends to provide option support to newly announced core Cortex-M7 and related FPU: http://www.arm.com/about/newsroom/arm-supercharges-mcu-market-with-high-perf ormance-cortex-m7-processor.php

Re: [fortran,patch] Forbid assignment of different character kinds

2014-09-30 Thread Tobias Burnus
FX wrote: Now, here's a tiny patch to silence the related warning in PR36534. I also remove the condition on gfc_current_form != FORM_FIXED, as diagnostics should be emitted based on language/pedantic options, not source form. Looks good to me. However: In the test case, could you also add a

[COMMITTED][shrink-wrap] should not sink instructions which may cause trap ?

2014-09-30 Thread Jiong Wang
On 30/09/14 05:26, Jeff Law wrote: On 09/29/14 12:06, Jiong Wang wrote: thanks for pointing this out, patch updated. re-tested, pass x86-64 bootstrap and no regression on check-gcc/g++. pass aarch64-none-elf cross check also. ok for trunk? Yes this is fine. committed as 215709. BTW,

RE: [PATCH] Fix PR preprocessor/58893 access to uninitialized memory

2014-09-30 Thread Bernd Edlinger
Hi Jeff, On Mon, 29 Sep 2014 22:40:58, Jeff Law wrote: On 09/27/14 03:53, Bernd Edlinger wrote: Comment before this change. Someone not familiar with this code is going to have no idea why these two lines exist. Ok, I added a comment now, do you like it? Yes. Please try to include a

[PATCH RFC]Pair load store instructions using a generic scheduling fusion pass

2014-09-30 Thread Bin Cheng
Hi, Last time I posted the patch pairing consecutive load/store instructions on ARM, the patch got some review comments. The most important one, as suggested by Jeff and Mike, is about to do the load/store pairing using existing scheduling facility. In the initial investigation, I cleared up

Re: Fix libgomp crash without TLS (PR42616)

2014-09-30 Thread Jakub Jelinek
On Tue, Sep 30, 2014 at 11:03:47AM +0400, Varvara Rainchik wrote: Corrected patch: call pthread_setspecific (gomp_tls_key, NULL) in gomp_thread_start if HAVE_TLS is not defined. 2014-09-19 Varvara Rainchik varvara.rainc...@intel.com * libgomp.h (gomp_thread): For non TLS case

[PATCH GCC]Improve candidate selecting in IVOPT

2014-09-30 Thread Bin Cheng
Hi, As analyzed in PR62178, IVOPT can't find the optimal iv set for that case. The problem with current heuristic algorithm is it only replaces candidate with ones not in current solution one by one, starting from small solution. This patch adds another heuristic which starts from assigning the

[PATCH, i386]: Enable reminder{sd,df,xf} and fmod{sf,df,xf} only for flag_finite_math_only.

2014-09-30 Thread Uros Bizjak
Hello! According to C99, reminder function returns: If x or y is a NaN, a NaN is returned. If x is an infinity, and y is not a NaN, a domain error occurs, and a NaN is returned. If y is zero, and x is not a NaN, a domain error occurs, and a NaN is returned. and fmod

Re: [PATCH 1/n] OpenMP 4.0 offloading infrastructure

2014-09-30 Thread Jakub Jelinek
On Fri, Sep 26, 2014 at 04:36:21PM +0400, Ilya Verbin wrote: 2014-09-26 Bernd Schmidt ber...@codesourcery.com Thomas Schwinge tho...@codesourcery.com Ilya Verbin ilya.ver...@intel.com Andrey Turetskiy andrey.turets...@intel.com * configure:

Re: [debug-early] rearrange some checks in gen_subprogram_die

2014-09-30 Thread Richard Biener
On Mon, Sep 29, 2014 at 8:54 PM, Aldy Hernandez al...@redhat.com wrote: I'm rearranging some code in Michael's original patch to minimize the difference with mainline. It seems that the check for DECL_STRUCT_FUNCTION (decl)-gimple_df, was merely a check to see if we had already set the FDE

Re: [PATCH][PING] PR62120

2014-09-30 Thread Ilya Tocar
Ping. On 15 Sep 18:43, Ilya Tocar wrote: On 01 Sep 18:38, Ilya Tocar wrote: Please mention the PR in the ChangeLog entry and add some testcases (can be gcc.target/i386/, but we should have it tested). Does this change anything on say register short sil __asm (sil); in 32-bit mode

[patch] fix expand_builtin_init_dwarf_reg_sizes wrt register spans

2014-09-30 Thread Olivier Hainque
Hello, Exception propagation has been failing for a while for the SPE/e500 family of powerpc targets. The issue boils down to an assert failure through: uw_init_context_1 () ... _Unwind_SetSpColumn (context, outer_cfa, sp_slot); then _Unwind_SetSpColumn () ... int size

[ping*2] define CROSS = @CROSS@ in gcc/Makefile.in

2014-09-30 Thread Olivier Hainque
Hello, ping on https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00056.html Thanks in advance, With Kind Regards, Olivier On Sep 1, 2014, at 17:26 , Olivier Hainque hain...@adacore.com wrote: Hello, This patch is necessary for proper operation of a piece of the Ada Makefile fragment which

Re: [PATCH][PING] PR62120

2014-09-30 Thread Jakub Jelinek
On Tue, Sep 30, 2014 at 02:44:21PM +0400, Ilya Tocar wrote: 2014-09-15 Ilya Tocar ilya.to...@intel.com PR middle-end/62120 * varasm.c (decode_reg_name_and_count): Check availability for registers from ADDITIONAL_REGISTER_NAMES. Testsuite/ 2014-09-15

Re: [Patch, Fortran] Add CO_BROADCAST

2014-09-30 Thread Dominique d'Humières
This is what I have committed as r215715: Index: gcc/testsuite/ChangeLog === --- gcc/testsuite/ChangeLog (revision 215714) +++ gcc/testsuite/ChangeLog (working copy) @@ -1,3 +1,7 @@ +2014-30-09 Dominique d'Humieres

Re: Fix for FAIL: tmpdir-gcc.dg-struct-layout-1/t028 c_compat_x_tst.o compile, (internal compiler error)

2014-09-30 Thread Richard Sandiford
Andreas Schwab sch...@suse.de writes: Richard Sandiford richard.sandif...@arm.com writes: @@ -315,7 +318,7 @@ struct ira_allocno number (0, ...) - 2. Value -1 is used for allocnos spilled by the reload (at this point pseudo-register has only one allocno) which did not get

Re: [PATCH 1/n] OpenMP 4.0 offloading infrastructure

2014-09-30 Thread Thomas Schwinge
Hi! On Fri, 26 Sep 2014 16:36:21 +0400, Ilya Verbin iver...@gmail.com wrote: --- a/gcc/Makefile.in +++ b/gcc/Makefile.in @@ -58,6 +58,7 @@ build=@build@ host=@host@ target=@target@ target_noncanonical:=@target_noncanonical@ +real_target_noncanonical:=@real_target_noncanonical@ #

Re: [PATCH 2/n] OpenMP 4.0 offloading infrastructure: LTO streaming

2014-09-30 Thread Thomas Schwinge
Hi! As just discussed for the libgcc changes in http://news.gmane.org/find-root.php?message_id=%3C87d2ad73ze.fsf%40schwinge.name%3E, just some suggestions regarding the terminology, where I think that the term »target« might be confusing in comments or symbols' names. That is, in the following,

Re: Fix for FAIL: tmpdir-gcc.dg-struct-layout-1/t028 c_compat_x_tst.o compile, (internal compiler error)

2014-09-30 Thread Andreas Schwab
Richard Sandiford richard.sandif...@arm.com writes: Andreas Schwab sch...@suse.de writes: Richard Sandiford richard.sandif...@arm.com writes: @@ -315,7 +318,7 @@ struct ira_allocno number (0, ...) - 2. Value -1 is used for allocnos spilled by the reload (at this point

Re: [PATCH, i386]: Enable reminder{sd,df,xf} and fmod{sf,df,xf} only for flag_finite_math_only.

2014-09-30 Thread FX
The patch will be committed to mainline and other release branches. Thanks! FX

[c++-concepts] function concepts with deduced return type

2014-09-30 Thread Andrew Sutton
Do not allow. Return type deduction only happens during instantiation, and concepts are never instantiated. Therefore, we can't find the return type of a function concept until you try to normalize the return expression. 2014-09-25 Andrew Sutton andrew.n.sut...@gmail.com Explicitly

Re: [Patch AArch64] Fix extended register width

2014-09-30 Thread Marcus Shawcroft
On 22 September 2014 19:41, Carrot Wei car...@google.com wrote: Hi The extended register width in add/adds/sub/subs/cmp instructions is not always the same as target register, it depends on both target register width and extension type. But in current implementation the extended register

[PATCH 1/2] PR 63340: Avoid harmful union classes in ira-costs.c

2014-09-30 Thread Richard Sandiford
This patch is the first of two to fix PR 63340, which is an ia64 regression caused by: 2014-09-22 Richard Sandiford richard.sandif...@arm.com * hard-reg-set.h: Include hash-table.h. (target_hard_regs): Add a finalize method and a x_simplifiable_subregs field. *

[PATCH 2/2] PR 63340: Avoid harmful union classes in ira-costs.c

2014-09-30 Thread Richard Sandiford
This part of the patch actually fixes the PR. It takes the reginfo.c invalid mode changes into account when computing the cost classes, rather than when using them. The code in the first patch then ensures that we don't add X_AND_Y_REGS to the cost classes if only X or Y allow the required mode

Re: Move tail merging pass forward

2014-09-30 Thread Dominique Dhumieres
testcase in PR35545 shows case where profile feedback infrastructure ... The test g++.dg/tree-prof/pr35545.C yields UNRESOLVED: g++.dg/tree-prof/pr35545.C scan-ipa-dump-not optimized OBJ_TYPE_REF The following patch --- ../_clean/gcc/testsuite/g++.dg/tree-prof/pr35545.C 2014-09-27

Re: [AArch64] Wire up vqdmullh_laneq_s16 and vqdmullh_laneq_s32

2014-09-30 Thread Marcus Shawcroft
On 24 September 2014 16:06, James Greenhalgh james.greenha...@arm.com wrote: Hi, As per the subject line this patch adds support for two arm_neon.h intrinsics that we had missed. We also need to fix the signature of vqdmulls_lane_s32, which is an obvious extension to this patch while we

[C++ Patch PING] Re: [PATCH] make excessive template instantiation depth a fatal error

2014-09-30 Thread Paolo Carlini
Hi all, hi Jason, On 08/24/2014 12:11 PM, Manuel López-Ibáñez wrote: PING: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg01709.html Today, I picked this unreviewed patch prepared by Manuel back in August and trivially completed it by adjusting the testcases (all the tweaks seem the expected

Re: Fix for FAIL: tmpdir-gcc.dg-struct-layout-1/t028 c_compat_x_tst.o compile, (internal compiler error)

2014-09-30 Thread Richard Earnshaw
On 30/09/14 12:51, Andreas Schwab wrote: Richard Sandiford richard.sandif...@arm.com writes: Andreas Schwab sch...@suse.de writes: Richard Sandiford richard.sandif...@arm.com writes: @@ -315,7 +318,7 @@ struct ira_allocno number (0, ...) - 2. Value -1 is used for allocnos spilled by

Re: [Patch, Fortran] Add CO_BROADCAST

2014-09-30 Thread James Greenhalgh
On Tue, Sep 30, 2014 at 11:59:16AM +0100, Dominique d'Humières wrote: This is what I have committed as r215715: Index: gcc/testsuite/ChangeLog === --- gcc/testsuite/ChangeLog (revision 215714) +++ gcc/testsuite/ChangeLog

Re: [PATCH] PR63404, gcc 5 miscompiles linux block layer

2014-09-30 Thread Richard Earnshaw
On 29/09/14 19:32, Richard Henderson wrote: On 09/29/2014 11:12 AM, Jiong Wang wrote: +inline rtx single_set_no_clobber_use (const rtx_insn *insn) +{ + if (!INSN_P (insn)) +return NULL_RTX; + + if (GET_CODE (PATTERN (insn)) == SET) +return PATTERN (insn); + + /* Defer to the

Re: [C++ Patch PING] Re: [PATCH] make excessive template instantiation depth a fatal error

2014-09-30 Thread Paolo Carlini
... forgot to attach the complete patch ;) Paolo. Index: cp/cp-tree.h === --- cp/cp-tree.h(revision 215710) +++ cp/cp-tree.h(working copy) @@ -5418,7 +5418,6 @@ extern const char

Re: [Patch ARM-AArch64/testsuite v2 01/21] Neon intrinsics execution tests initial framework.

2014-09-30 Thread Christophe Lyon
On 10 July 2014 12:12, Marcus Shawcroft marcus.shawcr...@gmail.com wrote: On 1 July 2014 11:05, Christophe Lyon christophe.l...@linaro.org wrote: * documentation (README) * dejanu driver (neon-intrinsics.exp) * support macros (arm-neon-ref.h, compute-ref-data.h) * Tests for 3 intrinsics:

Re: Enable TBAA on anonymous types with LTO

2014-09-30 Thread Jason Merrill
On 09/29/2014 11:36 AM, Jan Hubicka wrote: If C++ FE sets canonical type always to main variant, it should work. Is it always the case? No. For a compound type like a pointer or function the canonical type strips all typedefs, but a main variant does not. namespace { struct

Re: [PATCH] PR63404, gcc 5 miscompiles linux block layer

2014-09-30 Thread Jiong Wang
On 30/09/14 05:21, Jeff Law wrote: On 09/29/14 13:24, Jiong Wang wrote: I don't think so. from the x86-64 bootstrap, there is no regression on the number of functions shrink-wrapped. actually speaking, previously only single mov dest, src handled, so the disallowing USE/CLOBBER will not

Re: [C++ Patch PING] Re: [PATCH] make excessive template instantiation depth a fatal error

2014-09-30 Thread Jason Merrill
OK. Jason

Re: Fix libgomp crash without TLS (PR42616)

2014-09-30 Thread Richard Henderson
On 09/30/2014 02:52 AM, Jakub Jelinek wrote: On Tue, Sep 30, 2014 at 11:03:47AM +0400, Varvara Rainchik wrote: Corrected patch: call pthread_setspecific (gomp_tls_key, NULL) in gomp_thread_start if HAVE_TLS is not defined. 2014-09-19 Varvara Rainchik varvara.rainc...@intel.com *

Re: [PATCH, rs6000] Generate LE code for vec_lvsl and vec_lvsr that is compatible with BE code

2014-09-30 Thread Segher Boessenkool
On Mon, Sep 29, 2014 at 05:26:14PM -0500, Bill Schmidt wrote: The method used in this patch is to perform a byte-reversal of the result of the lvsl/lvsr. This is accomplished by loading the vector char constant {0,1,...,15}, which will appear in the register from left to right as

[PATCH 3/n] OpenMP 4.0 offloading infrastructure: offload tables

2014-09-30 Thread Ilya Verbin
Hello, This patch creates 2 vectors with decls: offload_funcs and offload_vars. libgomp will use addresses from these arrays to look up offloaded code. During the compilation they are outputted to: * .gnu.offload_lto_offload_table section as IR for offload compiler; * .gnu.lto_offload_table

Re: [PATCH C++] - SD-6 Implementation Part 1 - __has_include.

2014-09-30 Thread Jason Merrill
On 09/29/2014 11:18 AM, Ed Smith-Rowland wrote: + /* Nonzero to prevent macro expansion. */ + unsigned char in__has_include__; I don't see anything checking this flag to prevent macro expansion. Does the comment just need a change? + /* Binary literals and variable length arrays

Re: [C++ Patch PING] Re: [PATCH] make excessive template instantiation depth a fatal error

2014-09-30 Thread Manuel López-Ibáñez
I don't want to cause you more work Paolo, but perhaps this should be documented in https://gcc.gnu.org/gcc-5/changes.html. ? Something like: * Excessive template instantiation depth is now a fatal error. This prevents excessive diagnostics that usually do not help to identify the problem.

Re: [PATCH][AArch64] LR register not used in leaf functions

2014-09-30 Thread Jiong Wang
On 27/09/14 22:20, Kugan wrote: On 23/09/14 01:58, Jiong Wang wrote: On 22/09/14 16:43, Kugan wrote: AArch64 has the same issue ARM had where the LR register was not used in leaf functions. This was reported in https://gcc.gnu.org/bugzilla/show_bug.cgi?id=42017. In AArch64, this test-case

Re: [debug-early] rearrange some checks in gen_subprogram_die

2014-09-30 Thread Aldy Hernandez
On 09/30/14 03:23, Richard Biener wrote: On Mon, Sep 29, 2014 at 8:54 PM, Aldy Hernandez al...@redhat.com wrote: I'm rearranging some code in Michael's original patch to minimize the difference with mainline. It seems that the check for DECL_STRUCT_FUNCTION (decl)-gimple_df, was merely a check

[PATCH] gcc.c-torture/ cleanup

2014-09-30 Thread Marek Polacek
I did this as a part of preparing the testsuite to cope with the (possible) gnu11 default. But I think it's a reasonable cleanup on its own. With gnu11, we'd start to warn about defaulting to int, missing function declarations, and functions without return type. I added -fgnu89-inline when a

Re: [PATCH, rs6000] Generate LE code for vec_lvsl and vec_lvsr that is compatible with BE code

2014-09-30 Thread Bill Schmidt
On Tue, 2014-09-30 at 09:50 -0500, Segher Boessenkool wrote: On Mon, Sep 29, 2014 at 05:26:14PM -0500, Bill Schmidt wrote: The method used in this patch is to perform a byte-reversal of the result of the lvsl/lvsr. This is accomplished by loading the vector char constant {0,1,...,15},

Re: [Bug libstdc++/62313] Data race in debug iterators

2014-09-30 Thread Jonathan Wakely
On 26/09/14 11:05 +0100, Jonathan Wakely wrote: On 26/09/14 00:00 +0200, François Dumont wrote: Apart from those minor adjustments I think this looks good, but I'd like to know that it has been tested with -fsanitize=thread, even if only lightly tested. Hi Dmitry, who reported the bug,

Re: [libstdc++] Refactor python/hook.in

2014-09-30 Thread Jonathan Wakely
On 29/09/14 14:11 +0100, Jonathan Wakely wrote: On 29/09/14 06:02 -0700, Siva Chandra wrote: The attached patch refactors python/hook.in so that there are no individual function calls to load pretty printers and xmethods. This was suggested by Tom here:

Re: [PATCH v2] Fix signed integer overflow in gcc/data-streamer.c

2014-09-30 Thread Diego Novillo
On Tue, Sep 30, 2014 at 3:09 AM, Markus Trippelsdorf mar...@trippelsdorf.de wrote: On 2014.09.28 at 14:57 +0200, Markus Trippelsdorf wrote: On 2014.09.28 at 14:36 +0200, Steven Bosscher wrote: Can you use HOST_WIDE_INT_1U for this? Sure. Thanks for the suggestion. (Fix now resembles

Re: [C++ Patch PING] Re: [PATCH] make excessive template instantiation depth a fatal error

2014-09-30 Thread Paolo Carlini
Hi, On 09/30/2014 04:51 PM, Manuel López-Ibáñez wrote: I don't want to cause you more work Paolo, but perhaps this should be documented in https://gcc.gnu.org/gcc-5/changes.html. ? Something like: * Excessive template instantiation depth is now a fatal error. This prevents excessive

[PATCH, committed] PR 63410: Fix missing plugin headers

2014-09-30 Thread David Malcolm
We install the header pass_manager.h, but it can't be included by a plugin, since it includes pass-instances.def, and we don't current install that. Similarly, the installed header pretty-print.h now uses wide-int-print.h, but the latter isn't installed. FWIW, both of these issues prevent

Re: [PATCH, rs6000] Generate LE code for vec_lvsl and vec_lvsr that is compatible with BE code

2014-09-30 Thread Segher Boessenkool
On Tue, Sep 30, 2014 at 10:24:23AM -0500, Bill Schmidt wrote: On Tue, 2014-09-30 at 09:50 -0500, Segher Boessenkool wrote: On Mon, Sep 29, 2014 at 05:26:14PM -0500, Bill Schmidt wrote: The method used in this patch is to perform a byte-reversal of the result of the lvsl/lvsr. This is

Re: Fix for FAIL: tmpdir-gcc.dg-struct-layout-1/t028 c_compat_x_tst.o compile, (internal compiler error)

2014-09-30 Thread Joseph S. Myers
On Tue, 30 Sep 2014, Richard Earnshaw wrote: GCC is written in C++ these days, so technically, you need the C++ standard :-) And, while C++14 requires plain int bit-fields to be signed, GCC is written in C++98/C++03. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH, rs6000] Generate LE code for vec_lvsl and vec_lvsr that is compatible with BE code

2014-09-30 Thread Bill Schmidt
On Tue, 2014-09-30 at 11:04 -0500, Segher Boessenkool wrote: On Tue, Sep 30, 2014 at 10:24:23AM -0500, Bill Schmidt wrote: On Tue, 2014-09-30 at 09:50 -0500, Segher Boessenkool wrote: On Mon, Sep 29, 2014 at 05:26:14PM -0500, Bill Schmidt wrote: The method used in this patch is to

C++ PATCH to use CONVERT_EXPR for dummy objects

2014-09-30 Thread Jason Merrill
A recent question from richi about the C++ FE's use of NOP_EXPR and CONVERT_EXPR led me to switch these functions to use CONVERT_EXPR instead, since we don't want STRIP_NOPS to remove them. Tested x86_64-pc-linux-gnu, applying to trunk. commit e1215a9814036a16bb97609e97c3402b9b78c84c Author:

Re: Enable TBAA on anonymous types with LTO

2014-09-30 Thread Jan Hubicka
On 09/29/2014 11:36 AM, Jan Hubicka wrote: If C++ FE sets canonical type always to main variant, it should work. Is it always the case? No. For a compound type like a pointer or function the canonical type strips all typedefs, but a main variant does not. namespace {

Re: [PATCH] PR63404, gcc 5 miscompiles linux block layer

2014-09-30 Thread Jeff Law
On 09/30/14 08:37, Jiong Wang wrote: On 30/09/14 05:21, Jeff Law wrote: On 09/29/14 13:24, Jiong Wang wrote: I don't think so. from the x86-64 bootstrap, there is no regression on the number of functions shrink-wrapped. actually speaking, previously only single mov dest, src handled, so the

Re: [PATCH] Fix PR preprocessor/58893 access to uninitialized memory

2014-09-30 Thread Jeff Law
On 09/30/14 03:01, Bernd Edlinger wrote: Sigh. Yea, I guess if we're hitting the allocator insanely hard, scrubbing memory might turn out to slow things down in a significant way. Or it may simply be the case that we're using free'd memory in some way and with the MALLOC_PERTURB changes we're in

Re: [PATCH] PR63404, gcc 5 miscompiles linux block layer

2014-09-30 Thread Jeff Law
On 09/30/14 08:15, Richard Earnshaw wrote: I think part of the problem is in the naming of single_set(). From the name it's not entirely obvious to users that this includes insns that clobber registers or which write other registers that are unused after that point. I've previously had to fix

[PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Evgeny Stupachenko
Hi, Patch resubmitted from https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01400.html The patch fix PR62128 and gcc.target/i386/pr52252-atom.c in core-avx2 make check. The test in pr62128 is exactly TEST 22 from gcc.dg/torture/vshuf-v32qi.c. It will check if the pattern is correct or not. The

Re: [PATCH] gcc.c-torture/ cleanup

2014-09-30 Thread Jeff Law
On 09/30/14 09:22, Marek Polacek wrote: I did this as a part of preparing the testsuite to cope with the (possible) gnu11 default. But I think it's a reasonable cleanup on its own. With gnu11, we'd start to warn about defaulting to int, missing function declarations, and functions without

Re: [ping*2] define CROSS = @CROSS@ in gcc/Makefile.in

2014-09-30 Thread Jeff Law
On 09/30/14 04:48, Olivier Hainque wrote: Hello, ping on https://gcc.gnu.org/ml/gcc-patches/2014-09/msg00056.html Thanks in advance, With Kind Regards, Olivier On Sep 1, 2014, at 17:26 , Olivier Hainque hain...@adacore.com wrote: Hello, This patch is necessary for proper operation of a

Re: [PATCH] PR63404, gcc 5 miscompiles linux block layer

2014-09-30 Thread Richard Earnshaw
On 30/09/14 17:45, Jeff Law wrote: On 09/30/14 08:15, Richard Earnshaw wrote: I think part of the problem is in the naming of single_set(). From the name it's not entirely obvious to users that this includes insns that clobber registers or which write other registers that are unused after

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread H.J. Lu
On Tue, Sep 30, 2014 at 9:47 AM, Evgeny Stupachenko evstu...@gmail.com wrote: Hi, Patch resubmitted from https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01400.html The patch fix PR62128 and gcc.target/i386/pr52252-atom.c in core-avx2 make check. The test in pr62128 is exactly TEST 22 from

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Uros Bizjak
On Tue, Sep 30, 2014 at 6:47 PM, Evgeny Stupachenko evstu...@gmail.com wrote: Patch resubmitted from https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01400.html The patch fix PR62128 and gcc.target/i386/pr52252-atom.c in core-avx2 make check. The test in pr62128 is exactly TEST 22 from

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Jakub Jelinek
On Tue, Sep 30, 2014 at 10:03:05AM -0700, H.J. Lu wrote: On Tue, Sep 30, 2014 at 9:47 AM, Evgeny Stupachenko evstu...@gmail.com wrote: Hi, Patch resubmitted from https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01400.html The patch fix PR62128 and gcc.target/i386/pr52252-atom.c in

C++ PATCHes to add __is_trivially_*

2014-09-30 Thread Jason Merrill
Ville asked for help with the necessary compiler intrinsics for the is_trivially_* C++11 library traits. The first patch cleans up a few oddities I noticed with the existing intrinsics. __is_convertible_to was never implemented and isn't needed. There's no need for a second grokdeclarator

Re: [PATCHv3][PING] Enable -fsanitize-recover for KASan

2014-09-30 Thread Alexey Samsonov
On Tue, Sep 30, 2014 at 12:07 AM, Yury Gribov y.gri...@samsung.com wrote: On 09/30/2014 09:40 AM, Jakub Jelinek wrote: On Mon, Sep 29, 2014 at 05:24:02PM -0700, Konstantin Serebryany wrote: I don't think we ever going to support recovery for regular ASan (Kostya, correct me if I'm wrong).

Re: C++ PATCHes to add __is_trivially_*

2014-09-30 Thread Paolo Carlini
Hi, On 09/30/2014 07:13 PM, Jason Merrill wrote: Ville asked for help with the necessary compiler intrinsics for the is_trivially_* C++11 library traits. The first patch cleans up a few oddities I noticed with the existing intrinsics. __is_convertible_to was never implemented and isn't

Re: [PATCHv3][PING] Enable -fsanitize-recover for KASan

2014-09-30 Thread Jakub Jelinek
On Tue, Sep 30, 2014 at 10:26:39AM -0700, Alexey Samsonov wrote: I think we can summarize: * the current option -fsanitize-recover is misleading; it's really -fubsan-recover * we need a way to selectively enable/disable recovery for different sanitizers The most promininet solution

Re: [PATCHv3][PING] Enable -fsanitize-recover for KASan

2014-09-30 Thread Alexey Samsonov
On Tue, Sep 30, 2014 at 10:33 AM, Jakub Jelinek ja...@redhat.com wrote: On Tue, Sep 30, 2014 at 10:26:39AM -0700, Alexey Samsonov wrote: I think we can summarize: * the current option -fsanitize-recover is misleading; it's really -fubsan-recover * we need a way to selectively

Re: [PATCHv3][PING] Enable -fsanitize-recover for KASan

2014-09-30 Thread Jakub Jelinek
On Tue, Sep 30, 2014 at 10:36:34AM -0700, Alexey Samsonov wrote: Would we accept -fsanitize-recover=undefined -fno-sanitize-recover=signed-integer-overflow as recovering everything but signed integer overflows, i.e. the decision whether to recover a particular call would check similar

Re: [Bug libstdc++/62313] Data race in debug iterators

2014-09-30 Thread François Dumont
I forgot to check pretty printer tests indeed, I will. François On 30/09/2014 17:32, Jonathan Wakely wrote: On 26/09/14 11:05 +0100, Jonathan Wakely wrote: On 26/09/14 00:00 +0200, François Dumont wrote: Apart from those minor adjustments I think this looks good, but I'd like to know that

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Uros Bizjak
On Tue, Sep 30, 2014 at 7:06 PM, Uros Bizjak ubiz...@gmail.com wrote: On Tue, Sep 30, 2014 at 6:47 PM, Evgeny Stupachenko evstu...@gmail.com wrote: Patch resubmitted from https://gcc.gnu.org/ml/gcc-patches/2014-09/msg01400.html The patch fix PR62128 and gcc.target/i386/pr52252-atom.c in

Re: [PATCH] Redesign jump threading profile updates

2014-09-30 Thread Teresa Johnson
On Mon, Sep 29, 2014 at 9:33 PM, Jeff Law l...@redhat.com wrote: On 09/29/14 08:19, Teresa Johnson wrote: Just an update - I found some good test cases by compiling the c-torture tests with profile feedback with and without my patch. But in the cases I pulled out I saw that there were still

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Uros Bizjak
On Tue, Sep 30, 2014 at 8:08 PM, Uros Bizjak ubiz...@gmail.com wrote: On Tue, Sep 30, 2014 at 7:06 PM, Uros Bizjak ubiz...@gmail.com wrote: On Tue, Sep 30, 2014 at 6:47 PM, Evgeny Stupachenko evstu...@gmail.com wrote: Patch resubmitted from

Re: [PATCH] PR63404, gcc 5 miscompiles linux block layer

2014-09-30 Thread Jiong Wang
2014-09-30 17:30 GMT+01:00 Jeff Law l...@redhat.com: On 09/30/14 08:37, Jiong Wang wrote: On 30/09/14 05:21, Jeff Law wrote: On 09/29/14 13:24, Jiong Wang wrote: I don't think so. from the x86-64 bootstrap, there is no regression on the number of functions shrink-wrapped. actually

[debug-early] do not add location info/etc to abstract instances

2014-09-30 Thread Aldy Hernandez
Hi Jason. As discussed on IRC, DIEs of abstract instances of functions (those tagged with DW_AT_inline), cannot include information that would be different between an abstract inline and an out-of-line copy. This, as well as (seeming) gdb snafus regarding abstract origins, was the reason I

Re: [PATCH, committed] PR 63410: Fix missing plugin headers

2014-09-30 Thread Mike Stump
On Sep 30, 2014, at 8:45 AM, David Malcolm dmalc...@redhat.com wrote: We install the header pass_manager.h, but it can't be included by a plugin, since it includes pass-instances.def, and we don't current install that. Similarly, the installed header pretty-print.h now uses

Re: Fix for FAIL: tmpdir-gcc.dg-struct-layout-1/t028 c_compat_x_tst.o compile, (internal compiler error)

2014-09-30 Thread Mike Stump
On Sep 30, 2014, at 9:15 AM, Joseph S. Myers jos...@codesourcery.com wrote: On Tue, 30 Sep 2014, Richard Earnshaw wrote: GCC is written in C++ these days, so technically, you need the C++ standard :-) And, while C++14 requires plain int bit-fields to be signed, GCC is written in

Re: __intN patch 3/5: main __int128 - __intN conversion.

2014-09-30 Thread DJ Delorie
Joseph S. Myers jos...@codesourcery.com wrote: The non-C++/libstdc++ parts are OK with those changes. Jonathan Wakely jwak...@redhat.com wrote: * libstdc++-v3/ * src/c++11/limits.cc: Add support for __intN types. * include/std/type_traits: Likewise. * include/std/limits:

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Evgeny Stupachenko
What happens when shift == 16? We emit just gen_avx2_permv2ti. We don't need additional palignr. On Tue, Sep 30, 2014 at 9:06 PM, Uros Bizjak ubiz...@gmail.com wrote: On Tue, Sep 30, 2014 at 6:47 PM, Evgeny Stupachenko evstu...@gmail.com wrote: Patch resubmitted from

Re: [PR libfortran/62768] Handle filenames with embedded nulls

2014-09-30 Thread Janne Blomqvist
On Thu, Sep 18, 2014 at 11:33 PM, Hans-Peter Nilsson h...@bitrange.com wrote: On Thu, 18 Sep 2014, Janne Blomqvist wrote: If you look back at the patch I posted, there's a typo. :-} Duly warned about, but I'd rather expect the build to fail. Yes, strange that it didn't fail. There's no

Re: [PATCH] PR63404, gcc 5 miscompiles linux block layer

2014-09-30 Thread Steven Bosscher
On Tue, Sep 30, 2014 at 6:51 PM, Richard Earnshaw wrote: It's not just clobbers; it ignores patterns like (parallel [(set (a) (...) (set (b) (...)]) [(reg_note (reg_unused(b))] Which is probably fine before register allocation but definitely something you have to think about

Re: [Bug libstdc++/62313] Data race in debug iterators

2014-09-30 Thread François Dumont
Hi I prefer to submit this patch to you cause I am not very comfortable with Python stuff. I simply rely on Python cast feature. It doesn't really matter but is it going to simply consider the debug iterator as a normal one or is it going through the C++ explicit cast operator on

Re: [Patch AArch64] Fix extended register width

2014-09-30 Thread Eric Christopher
On Tue, Sep 30, 2014 at 5:57 AM, Marcus Shawcroft marcus.shawcr...@gmail.com wrote: On 22 September 2014 19:41, Carrot Wei car...@google.com wrote: Hi The extended register width in add/adds/sub/subs/cmp instructions is not always the same as target register, it depends on both target

Re: [PATCH, rs6000] Generate LE code for vec_lvsl and vec_lvsr that is compatible with BE code

2014-09-30 Thread Segher Boessenkool
On Tue, Sep 30, 2014 at 11:18:39AM -0500, Bill Schmidt wrote: I meant generating a sequence that just falls out as you want it after optimisation. E.g. lvsr;vnot;vand(splat8(31));vperm can have the vand absorbed by the vperm. But that splat is nasty when not optimised away :-(

Re: [PATCH RFC]Pair load store instructions using a generic scheduling fusion pass

2014-09-30 Thread Mike Stump
On Sep 30, 2014, at 2:22 AM, Bin Cheng bin.ch...@arm.com wrote: Then I decided to take one step forward to introduce a generic instruction fusion infrastructure in GCC, because in essence, load/store pair is nothing different with other instruction fusion, all these optimizations want is to

[Patch, libgfortran, committed] Fix -Wmaybe-uninitialized warnings

2014-09-30 Thread Janne Blomqvist
Hi, I compiled libgfortran with -Werror, and fixed the fallout with the attached patch. Committed r215742 as obvious. 2014-10-01 Janne Blomqvist j...@gcc.gnu.org * intrinsics/pack_generic.c (pack_s_internal): Fix -Wmaybe-uninitialized warning. * m4/unpack.m4

Re: [PATCH X86, PR62128] Rotate pattern for AVX2

2014-09-30 Thread Evgeny Stupachenko
expand_vselect for some reason ignores the expander. Does it work with expanders? The comment talks about insn only: /* Construct (set target (vec_select op0 (parallel perm))) and return true if that's a valid instruction in the active ISA. */ On Tue, Sep 30, 2014 at 10:21 PM, Uros Bizjak

Re: [PATCH GCC]Improve candidate selecting in IVOPT

2014-09-30 Thread Sebastian Pop
Bin Cheng wrote: Hi, As analyzed in PR62178, IVOPT can't find the optimal iv set for that case. The problem with current heuristic algorithm is it only replaces candidate with ones not in current solution one by one, starting from small solution. This patch adds another heuristic which starts

Re: C++ PATCHes to add __is_trivially_*

2014-09-30 Thread Ville Voutilainen
Ville asked for help with the necessary compiler intrinsics for the is_trivially_* C++11 library traits. The first patch cleans up a few oddities I noticed with the Great. I think this can be as well marked as PR c++/26099. There's also PR c++/63362. The intrinsics still fail to support

Re: __intN patch 3/5: main __int128 - __intN conversion.

2014-09-30 Thread Jonathan Wakely
On 30/09/14 15:37 -0400, DJ Delorie wrote: Joseph S. Myers jos...@codesourcery.com wrote: The non-C++/libstdc++ parts are OK with those changes. Jonathan Wakely jwak...@redhat.com wrote: * libstdc++-v3/ * src/c++11/limits.cc: Add support for __intN types. * include/std/type_traits:

  1   2   >