[C PATCH] Don't leak C_MAYBE_CONST_EXPRs into fold() (PR c/68412)

2015-11-18 Thread Marek Polacek
Since C++ delayed folding, warn_tautological_cmp needs to fold its arguments. But sometimes this function gets C_MAYBE_CONST_EXPR from the C FE, and fold() duly ICEs. I was torn if I should just return from warn_tautological_cmp and not warn when it gets C_MAYBE_CONST_EXPR as an argument, or if I

Re: teach delay folding in c++ about OACC_LOOPs

2015-11-18 Thread Nathan Sidwell
On 11/18/15 10:14, Cesar Philippidis wrote: Jason, Your recent delay folding patch broke libgomp.oacc-c++/loop-auto-1.c. It looks like you forgot to handle OACC_LOOP in cp_fold_r. You probably didn't notice this because Nathan committed his auto acc loop patch just before you applied your

RE: [PATCH 1/4 v2][AArch64] Generalize CCMP support

2015-11-18 Thread Wilco Dijkstra
Bernd Schmidt wrote: > Sent: 17 November 2015 22:16 > To: Wilco Dijkstra; gcc-patches@gcc.gnu.org > Subject: Re: [PATCH 1/4][AArch64] Generalize CCMP support > > On 11/13/2015 05:02 PM, Wilco Dijkstra wrote: > > * gcc/ccmp.c (expand_ccmp_expr): Extract cmp_code from return > value > > of > >

Re: [PATCH 1/4 v2][AArch64] Generalize CCMP support

2015-11-18 Thread Bernd Schmidt
On 11/17/2015 07:35 PM, Wilco Dijkstra wrote: I've updated the comments and documentation, see below. I hope it makes sense now - returning rtx that computes the same value as the tree expression we're emitting is the most useful thing one can do. The target-independent part is ok. Note that

Re: [gomp4.1] Handle linear clause modifiers in declare simd

2015-11-18 Thread Ilya Verbin
Hi! On Wed, Jul 01, 2015 at 12:55:38 +0200, Jakub Jelinek wrote: > I've committed following patch, which per the new ABI additions > mangles and handles the various new linear clause modifiers in > declare simd functions. The vectorizer side is not done yet, > > [...] > > @@ -14195,12 +14216,25

Re: [PATCH] Add clang-format config to contrib folder

2015-11-18 Thread Jeff Law
On 11/18/2015 10:34 AM, Manuel López-Ibáñez wrote: Which is a sad demonstration of how the refusal of GCC's FEs being re-used for other purposes by GNU tools (and others) was and is a mistake, and it is leading to GNU tools being replaced by LLVM-based ones (ultimately affecting GCC and GDB

Re: [gomp4.1] Handle linear clause modifiers in declare simd

2015-11-18 Thread Jakub Jelinek
On Wed, Nov 18, 2015 at 08:30:53PM +0300, Ilya Verbin wrote: > Could you please point to where the new ABI additions are documented? > I can't find R/L/U parameter types in [1] and [2]. > > [1] > https://sourceware.org/glibc/wiki/libmvec?action=AttachFile=view=VectorABI.txt > [2]

Re: [Patch,testsuite]: Fix the tree-ssa/split-path-1.c testcase

2015-11-18 Thread Jeff Law
On 11/18/2015 07:21 AM, Ajit Kumar Agarwal wrote: Hello Jeff: Please ignore my previous mails as they bounced back. Sorry for that. I have fixed the problem with the testcase. The splitting path optimization remains intact. Attached is the patch. The problem was related to the testcase as

Re: [PATCH] Add clang-format config to contrib folder

2015-11-18 Thread Jeff Law
On 11/18/2015 07:10 AM, Martin Liška wrote: Hello. Following patch adds a clang-format config file that should respect the GNU coding standards. As the file is not part of build process, I hope the patch can be applied even though we've just skipped to stage3? The patch adds a hunk to

Re: [PATCH] Add clang-format config to contrib folder

2015-11-18 Thread Manuel López-Ibáñez
On 18/11/15 17:05, Jeff Law wrote: As we've been continuously converting our source base to C++, the clang-format should provide better results than a collection of regular expressions (check_GNU_style.sh). As a reference file I attach gcc/tree-ssa-uninit.c file. Feel free to comment the

Re: [C PATCH] Don't leak C_MAYBE_CONST_EXPRs into fold() (PR c/68412)

2015-11-18 Thread Marek Polacek
On Wed, Nov 18, 2015 at 05:24:34PM +0100, Bernd Schmidt wrote: > That seems to change the behaviour of the code though. Most of the code in > warn_tautological_cmp only looks at the unfolded form. Are you sure this is > safe, for example wrt. the from_macro_expansion_at tests or the >

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-18 Thread Jeff Law
On 11/18/2015 07:23 AM, Martin Liška wrote: On 11/13/2015 08:19 PM, Jeff Law wrote: On 11/13/2015 09:58 AM, Martin Liška wrote: On 11/13/2015 05:32 PM, Jeff Law wrote: On 11/13/2015 05:50 AM, Martin Liška wrote: Hello. Patch survives regbootstrap on x86_64-linux-gnu. Ready for trunk?

Re: [PATCH, VECTOR ABI] Add __attribute__((__simd__)) to GCC.

2015-11-18 Thread Jeff Law
On 11/18/2015 07:11 AM, Kirill Yukhin wrote: Hello Andreas, Devid. On 18 Nov 10:45, Andreas Schwab wrote: Kirill Yukhin writes: diff --git a/gcc/testsuite/c-c++-common/attr-simd.c b/gcc/testsuite/c-c++-common/attr-simd.c new file mode 100644 index 000..b4eda34

Re: libgomp: Compile-time error for non-portable gomp_mutex_t initialization

2015-11-18 Thread Ilya Verbin
On Fri, Sep 25, 2015 at 17:28:25 +0200, Jakub Jelinek wrote: > On Fri, Sep 25, 2015 at 05:04:47PM +0200, Thomas Schwinge wrote: > > On Thu, 26 Mar 2015 23:41:30 +0300, Ilya Verbin wrote: > > > On Thu, Mar 26, 2015 at 13:09:19 +0100, Jakub Jelinek wrote: > > > > the current code

Re: [patch] Fix PR middle-end/65958

2015-11-18 Thread Eric Botcazou
> Ah. I think the patch is good and we should reflect this in the > documentation. OK, will do, thanks. -- Eric Botcazou

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-18 Thread Bernhard Reutner-Fischer
On November 18, 2015 9:30:23 AM GMT+01:00, Richard Biener wrote: >On Tue, 17 Nov 2015, Tom de Vries wrote: > >> On 17/11/15 16:18, Richard Biener wrote: >> > > > IMHO autopar needs to handle induction itself. >> > > > >> > > >I'm not sure what you mean. Could you elaborate?

PR 68393: Handle SUBREG_PROMOTED_VAR_P in expand_direct_optab_fn

2015-11-18 Thread Richard Sandiford
Do the usual dance when assigning to SUBREG_PROMOTED_VAR_P destinations: first convert to the outer mode, then extend to the inner mode. This fixes the powerpc64le bootstrap failure reported in PR 68393. Tested that it fixes the powerpc64le-linux-gnu breakage. Also tested on x86_64-linux-gnu and

Re: [patch] Fix PR middle-end/65958

2015-11-18 Thread Richard Biener
On Wed, Nov 18, 2015 at 3:28 PM, Eric Botcazou wrote: >> Looks good to me. I also found the Arrays of Variable Length section >> in extend.texi which also refers to alloca as doing the same. We may >> want to add a note there that you should not mix both and that only >>

Re: [PATCH][ARM] PR 68149 Fix ICE in unaligned_loaddi split

2015-11-18 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01253.html Thanks, Kyrill On 10/11/15 17:32, Kyrill Tkachov wrote: Hi all, This ICE in this PR occurs when we're trying to split unaligned_loaddi into two SImode unaligned loads. The problem is in the addressing mode. When reload was

Re: [0/7] Type promotion pass and elimination of zext/sext

2015-11-18 Thread Richard Biener
On Wed, Nov 18, 2015 at 3:04 PM, Richard Biener wrote: > On Sat, Nov 14, 2015 at 2:15 AM, Kugan > wrote: >> >> Attached is the latest version of the patch. With the patches >> 0001-Add-new-SEXT_EXPR-tree-code.patch, >>

Re: [C PATCH] Don't leak C_MAYBE_CONST_EXPRs into fold() (PR c/68412)

2015-11-18 Thread Marek Polacek
On Wed, Nov 18, 2015 at 05:03:48PM +0100, Marek Polacek wrote: > Since C++ delayed folding, warn_tautological_cmp needs to fold its arguments. > But sometimes this function gets C_MAYBE_CONST_EXPR from the C FE, and fold() > duly ICEs. > > I was torn if I should just return from

Re: [gomp4] OpenACC async clause regressions

2015-11-18 Thread Tom de Vries
On 22/10/15 20:27, Thomas Schwinge wrote: diff --cc libgomp/testsuite/libgomp.oacc-c-c++-common/asyncwait-1.c index d478ce2,22cef6d..f3b490a --- libgomp/testsuite/libgomp.oacc-c-c++-common/asyncwait-1.c +++ libgomp/testsuite/libgomp.oacc-c-c++-common/asyncwait-1.c @@@ -1,4 -1,4 +1,6 @@@ /* {

Re: POWERPC64_TOC_POINTER_ALIGNMENT

2015-11-18 Thread David Edelsohn
On Tue, Nov 17, 2015 at 9:32 PM, Alan Modra wrote: > On Tue, Nov 17, 2015 at 07:53:18PM -0500, Michael Meissner wrote: >> Here is the temporary patch I'm using to get past rs6000.c. But I suspect >> the >> TOC alignment should never be 256. > > Yes, it should be. Recent GNU

teach delay folding in c++ about OACC_LOOPs

2015-11-18 Thread Cesar Philippidis
Jason, Your recent delay folding patch broke libgomp.oacc-c++/loop-auto-1.c. It looks like you forgot to handle OACC_LOOP in cp_fold_r. You probably didn't notice this because Nathan committed his auto acc loop patch just before you applied your patch. I'm not sure why only that test is affected

Re: [PATCH][ARM] Do not expand movmisalign pattern if not in 32-bit mode

2015-11-18 Thread Kyrill Tkachov
Ping. https://gcc.gnu.org/ml/gcc-patches/2015-11/msg01392.html Thanks, Kyrill On 11/11/15 16:10, Kyrill Tkachov wrote: Hi all, The attached testcase ICEs when compiled with -march=armv6k -mthumb -Os or any march for which -mthumb gives Thumb1: error: unrecognizable insn: } ^ (insn 13 12

Re: [PATCH PR52272]Be smart when adding iv candidates

2015-11-18 Thread Bernd Schmidt
On 11/10/2015 11:19 AM, Bin.Cheng wrote: On Tue, Nov 10, 2015 at 6:06 PM, Bernd Schmidt wrote: Multi-line expressions should be wrapped in parentheses so that emacs/indent can format them automatically. Two sets of parens are needed for this. Operators should then line up

Re: [C PATCH] Don't leak C_MAYBE_CONST_EXPRs into fold() (PR c/68412)

2015-11-18 Thread Bernd Schmidt
On 11/18/2015 05:16 PM, Marek Polacek wrote: Actually, no, I think we should do this instead. +++ gcc/c-family/c-common.c @@ -1924,7 +1924,7 @@ warn_tautological_cmp (location_t loc, enum tree_code code, tree lhs, tree rhs) /* We do not warn for constants because they are typical of macro

[PATCH 2/4 v2][AArch64] Add support for FCCMP

2015-11-18 Thread Wilco Dijkstra
(v2 version removes 4 enums) This patch adds support for FCCMP. This is trivial with the new CCMP representation - remove the restriction of FP in ccmp.c and add FCCMP patterns. Add a test to ensure FCCMP/FCCMPE are emitted as expected. OK for commit? ChangeLog: 2015-11-18 Wilco Dijkstra

[PATCH 4/4 v2][AArch64] Cost CCMP instruction sequences to choose better expand order

2015-11-18 Thread Wilco Dijkstra
(v2 cleans up enum use) This patch adds CCMP selection based on rtx costs. This is based on Jiong's already approved patch https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01434.html with some minor refactoring and enum cleanup plus the tests updated. OK for commit? ChangeLog: 2015-11-13 Jiong

Re: [1/2] OpenACC routine support

2015-11-18 Thread Cesar Philippidis
On 11/10/2015 12:16 AM, Jakub Jelinek wrote: > On Mon, Nov 09, 2015 at 09:28:47PM -0800, Cesar Philippidis wrote: >> Here's the patch that Nathan was referring to. I ended up introducing a >> boolean variable named first in the various functions which call >> finalize_oacc_routines. The problem

[Ada] Fix ICE on on indirect renaming of address at -O

2015-11-18 Thread Eric Botcazou
Addresses cannot be directly subject to a renaming, but they can nevertheless be renamed through a constant and thus need to be dealt with as other rvalues. Tested on x86_64-suse-linux, applied on the mainline. 2015-11-18 Eric Botcazou * gcc-interface/decl.c

[nvptx] SESE region optimization

2015-11-18 Thread Nathan Sidwell
I've applied this to trunk, it adds the SESE region neutering from the gomp4 branch. The general idea is that when neutering partitioned execution, one can skip from the entry of an SESE region straight to its exit, rather than do each block in the region individually. Finding the regions

[Ada] Fix stack usage increase for renaming of indexed component

2015-11-18 Thread Eric Botcazou
This fixes an oversight in the new fold_constant_decl_in_expr function, which causes the code generated by the compiler for the renaming of an indexed component whose prefix is a constant object and whose index is not to use significantly more stack than needed. Tested on x86_64-suse-linux,

Re: [PATCH] PR fortran/59910 -- structure constructor in DATA statement

2015-11-18 Thread Jerry DeLisle
On 11/17/2015 12:34 PM, Steve Kargl wrote: > Here's what looks like a fairly simple patch, but it leads > to a question. Why does gfortran not try to reduce the > components in a structure constructor in general? I've > hidden the gfc_reduce_init_expr() behind a check for a > DATA statement,

Re: Re: OpenACC declare directive updates

2015-11-18 Thread Cesar Philippidis
On 11/08/2015 08:53 PM, James Norris wrote: > The attached patch and ChangeLog reflect the updates from your > review: https://gcc.gnu.org/ml/gcc-patches/2015-11/msg00714.html > and Cesar's review: > https://gcc.gnu.org/ml/gcc-patches/2015-11/msg00885.html. > > With the changes made in this

Re: Remove noce_mem_write_may_trap_or_fault_p in ifcvt

2015-11-18 Thread Bernd Schmidt
Ok, so this is a thorny problem. I thought I had a solution, and I'll start by describing it, but in the end I think it doesn't actually work. On 11/06/2015 10:09 PM, Jeff Law wrote: On 11/06/2015 12:30 PM, Bernd Schmidt wrote: Well, I think if MEM_READONLY_P is insufficient (and I guess

Re: [patch, avr] Add new Atmel AVR devices

2015-11-18 Thread Denis Chertykov
2015-11-18 9:36 GMT+03:00 Sivanupandi, Pitchumani : > Attached patch adds new Atmel devices to avr-gcc. > If Ok, could someone commit please? I do not have commit access. > > Regards, > Pitchumani > > gcc/ChangeLog > > 2015-11-18 Pitchumani Sivanupandi

Re: [PATCH] Avoid useless work in loop vectorization

2015-11-18 Thread Alan Lawrence
On 13/11/15 08:41, Richard Biener wrote: Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2015-11-13 Richard Biener * tree-vect-loop.c (vect_analyze_loop_2): Add fatal parameter. Signal fatal failure if early checks fail.

[PATCH] [4.9] Re: [PATCH][5] Backport ISL 0.15 support

2015-11-18 Thread Matthias Klose
On 12.10.2015 12:58, Richard Biener wrote: This backports the patch to allow bootstrapping with ISL 0.15 to the GCC 5 branch (the GCC 4.9 branch will require backporting of some dependencies). I don't think so. 4.8 and 4.9 don't use as much ISL code as 5 does. I had a look at the backport

Re: [PATCH] PR fortran/59910 -- structure constructor in DATA statement

2015-11-18 Thread Steve Kargl
On Tue, Nov 17, 2015 at 05:01:42PM -0800, Steve Kargl wrote: > On Tue, Nov 17, 2015 at 04:36:01PM -0800, Steve Kargl wrote: > > On Wed, Nov 18, 2015 at 12:24:29AM +0100, Dominique d'Humières wrote: > > > > ??? but I suspect gfc_reduce_init_expr() > > > > may be useful for PARAMETER statements as

RE: [gomp4.1] Handle linear clause modifiers in declare simd

2015-11-18 Thread Tian, Xinmin
Yes, I will send the updated version to Jakub when I come back from SC15. I am updating it based on discussion with Jakub. Thanks, Xinmin -Original Message- From: Jakub Jelinek [mailto:ja...@redhat.com] Sent: Wednesday, November 18, 2015 9:41 AM To: Ilya Verbin; Tian, Xinmin Cc:

[nios2, committed] remove duplicates in || expression

2015-11-18 Thread Sandra Loosemore
I've checked in this patch to fix PR 68410. David, thanks for pointing out the think-o here. -Sandra 2015-11-18 Sandra Loosemore PR target/68410 * config/nios2/nios2.c (cdx_and_immed): Remove duplicate tests from || expression. Index: gcc/config/nios2/nios2.c

Re: [PATCHES, PING*5] Enhance standard DWARF for Ada

2015-11-18 Thread Jason Merrill
On 10/20/2015 04:13 PM, Pierre-Marie de Rodat wrote: Sorry about the slow review on these patches. In future please feel free to ping me as often as once a week. + /* DWARF operations all work on signed integers. Note that this will no longer be the case in DWARF 5, where stack elements

Re: [patch] FreeBSD x86_64/i386 apply r125920

2015-11-18 Thread Andreas Tobler
On 16.11.15 23:20, Andreas Tobler wrote: Hi all, I'm going to apply the below patch to trunk if there are no objections. There are no regressions. From our pov, we should be in sync with Linux here. Also, I'm going to push this one out to 5.x after one week. Committed on trunk as r230565

[PATCH] Fix declaration of pthread-structs in s-osinte-rtems.ads (ada/68169)

2015-11-18 Thread Jan Sommer
Hello, The paperwork seems to have gone through. Here is the patch again for the 4.9.x, 5.x and trunk respectively. I just pulled the head of the corresponding branches and created a new diff, so it should apply properly. Best regards, JanIndex: gcc/ada/ChangeLog

[Ada] Crash on illegal use of limited view of classwide type

2015-11-18 Thread Arnaud Charlet
This patch fixes a compiler crash on an attempt to assign to a record component whose type is the limited view of a classwide type. Compiling gcc -c c3a1004e.adb must yield: c3a1004e.adb:9:07: invalid use of limited view of "Department'CLASS" --- limited with C3A1004E; package C3A1004D

[Ada] Better handling of invalid switches in GNAT.Command_Line

2015-11-18 Thread Arnaud Charlet
When the switch is ending with a '=', actual switches not followed with a space or '=' were raising Invalid_Parameter, which was mileading. This patch fixes this: exception Invalid_Switch is now raised and Full_Switch returns the full command line switch. Tested on x86_64-pc-linux-gnu, committed

[PATCH, PR target/68405, i386, committed] Add missing break

2015-11-18 Thread Ilya Enkovich
Hi, This patch adds missing break for ix86_expand_mask_vec_cmp. Bootstrapped and tested on x86_64-unknown-linux-gnu. Committed to trunk as obvious. Thanks, Ilya -- gcc/ 2015-11-18 Ilya Enkovich PR target/68405 * config/i386/i386.c

Re: [OpenACC 0/7] host_data construct

2015-11-18 Thread Julian Brown
On Thu, 12 Nov 2015 11:16:21 + Julian Brown wrote: > Here's a version of the patch which (hopefully) brings OpenACC on par > with OpenMP with respect to use_device/use_device_ptr variables. The > implementation is essentially the same now for OpenACC as for OpenMP >

Re: [patch] Fix PR middle-end/65958

2015-11-18 Thread Eric Botcazou
> Ok. I wonder if we document GCCs VLA implementation somewhere so we can add > a note on the interaction with alloca. I found this in 10.7.2 Blocks: "Variable-length arrays (VLAs) complicate this process, as their size often refers to variables initialized earlier in the block. To handle

[PATCH, PR tree-optimization/68327] Compute vectype for live phi nodes when copmputing VF

2015-11-18 Thread Ilya Enkovich
Hi, When we compute vectypes we skip non-relevant phi nodes. But we process non-relevant alive statements and thus may need vectype of non-relevant live phi node to compute mask vectype. This patch enables vectype computation for live phi nodes. Botostrapped and regtested on

Re: [PATCH] Fix debug fallout of proposed PR68162 fix

2015-11-18 Thread Marek Polacek
On Wed, Nov 18, 2015 at 09:50:26AM +0100, Richard Biener wrote: > --- gcc/dwarf2out.c (revision 230428) > +++ gcc/dwarf2out.c (working copy) > @@ -20784,9 +20784,10 @@ gen_type_die_with_usage (tree type, dw_d >/* We are going to output a DIE to represent the unqualified version > of

Re: [RFC PATCH] Do not sanitize left shifts for -fwrapv

2015-11-18 Thread Marek Polacek
On Tue, Nov 17, 2015 at 02:32:50PM +0100, Paolo Bonzini wrote: > Left shifts into the sign bit is a kind of overflow, and the > standard chooses to treat left shifts of negative values the > same way. > > However, the -fwrapv option modifies the language to one where > integers are defined as

[Ada] Concurrent constituents of a single protected/task type

2015-11-18 Thread Arnaud Charlet
This patch modifies the analysis of variable contracts to enforce the following SPARK RM rule: 9.3 - If a variable or a package which declares a state abstraction is declared immediately within the same declarative region as a single_task_declaration or a single_protected_declaration,

Re: [PATCH 1/5] [AARCH64]: Move #undef into .def files.

2015-11-18 Thread Marcus Shawcroft
On 17 November 2015 at 22:10, Andrew Pinski wrote: > > This moves the #undef from the header files to the .def files like was done > for builtins.def (https://gcc.gnu.org/ml/gcc-patches/2015-11/msg00662.html). > > OK? Bootstrapped and tested on aarch64-linux-gnu with no

[Ada] PR ada/66242 Finalization with restriction No_Exception_Propagation

2015-11-18 Thread Arnaud Charlet
This patch adds abort defer / undefer pairs for partial finalization due to failed initialization and as part of unchecked deallocation actions. The patch also suppresses the generation of exception variables and handlers related to finalization actions when restriction No_Exception_Propagation is

Re: vector lightweight debug mode

2015-11-18 Thread Jonathan Wakely
On 17/11/15 20:49 +0100, François Dumont wrote: On 16/11/2015 11:29, Jonathan Wakely wrote: Not doing the checks is also an option. That minimizes the cost :-) This is controlled by a macro, users already have this option. True, but we're talking about maybe enabling these checks by default

Re: [2/2] i386 ROP mitigation

2015-11-18 Thread Bernd Schmidt
On 11/16/2015 07:18 PM, Uros Bizjak wrote: On Fri, Nov 13, 2015 at 9:47 PM, Bernd Schmidt wrote: This adds a new -mmitigate-rop option to the i386 port. The idea is to mitigate against certain forms of attack called "return oriented programming" that some of our

Re: vector lightweight debug mode

2015-11-18 Thread Jonathan Wakely
On 18/11/15 12:27 +, Jonathan Wakely wrote: But my unproven assumption is that it's more common to use operator[] incorrectly, rather than pass invalid iterators to range insert, which is a relatively "advanced" operation. It's worth noting that the google/integration branch doesn't have

[PATCH] Fix PR67790

2015-11-18 Thread Richard Biener
This PR exposes an issue with how we deal with vectorization of reductions with minus (x -= ...). We do that by re-writing the IL to a plus and a new negate stmt. Unfortunately that messes up UIDs of stmts in the loop which are used for dominance checks by the vectorizer. I've tried using a

Re: [Patch, vrp] Allow VRP type conversion folding only for widenings upto word mode

2015-11-18 Thread Richard Biener
On Wed, 18 Nov 2015, Senthil Kumar Selvaraj wrote: > On Mon, Nov 16, 2015 at 10:02:15AM +0100, Richard Biener wrote: > > On Sat, 14 Nov 2015, Senthil Kumar Selvaraj wrote: > > > > > On Sat, Nov 14, 2015 at 09:57:40AM +0100, Richard Biener wrote: > > > > On November 14, 2015 9:49:28 AM GMT+01:00,

Re: Port libvtv to Solaris

2015-11-18 Thread Richard Biener
On Tue, Nov 17, 2015 at 9:09 PM, Jeff Law wrote: > On 11/17/2015 06:24 AM, Rainer Orth wrote: >> >> >> I'm still investigating what causes those timeouts, it seems to be a >> scalability issue in libc. >> >> While I realize that we are past stage1, maybe the fact that this patch

Re: RFA (GGC): PATCH to support GGC finalizers with PCH

2015-11-18 Thread Richard Biener
On Tue, Nov 17, 2015 at 8:46 PM, Jason Merrill wrote: > On 11/17/2015 09:39 AM, Richard Biener wrote: >> >> On Tue, Nov 17, 2015 at 3:09 PM, Jason Merrill wrote: >>> >>> While I was looking at the interaction of delayed folding with GGC, I >>> noticed that

[Ada] Crash on function returning limited view of class-wide type

2015-11-18 Thread Arnaud Charlet
THis patch fixes a compiler crash on a function that returns a class-wide type, when the type is first obtained by means of a limited view. The following must compile quietly: --- with New_Network; limited with New_Network.Bus; package Topology is type Vertex (Nb_Terminals :

[Ada] Normalize_Pathname with unresolved reference directory

2015-11-18 Thread Arnaud Charlet
This change removes an unnecessary limitation whereby Normalize_Pathname would not accept an unresolved path name as the reference directory, and would furthermore return incorrect results, rather than an error diagnostic, in the case where input did not comply with this limitation. The following

Re: [patch] Fix PR middle-end/65958

2015-11-18 Thread Richard Biener
On Wed, Nov 18, 2015 at 11:06 AM, Eric Botcazou wrote: > Hi, > > this is the underlying issue of PR middle-end/65958: the compiler generates > wrong code when alloca is used in conjunction with a VLA since the latter > causes the stack space allocated to the former to be

Re: [PATCH, VECTOR ABI] Add __attribute__((__simd__)) to GCC.

2015-11-18 Thread Andreas Schwab
r "in the same > function marked as a Cilk Plus" } */ FAIL: c-c++-common/attr-simd-3.c -std=gnu++11 (test for errors, line 5) FAIL: c-c++-common/attr-simd-3.c -std=gnu++11 (test for excess errors) Excess errors: /usr/local/gcc/gcc-20151118/gcc/testsuite/c-c++-common/attr-simd-

Re: Add gencfn-macros.c

2015-11-18 Thread Tom de Vries
On 07/11/15 13:35, Richard Sandiford wrote: This patch automatically generates case macros such as: CASE_CFN_SQRT for each {F,,L} floating-point built-in function and each {,L,LL,IMAX} integer built-in function. The macros match the same built-in functions as CASE_FLT_FN and CASE_INT_FN

[PATCH] Fix reassoci ICE (PR tree-optimization/68157)

2015-11-18 Thread Jakub Jelinek
Hi! attempt_builtin_powi and its caller does not set uids of the stmts it adds, which in some cases may lead to reassoc ICEs. Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for trunk/5.3? 2015-11-18 Jakub Jelinek PR tree-optimization/68157

Re: [PATCH] PR/67682, break SLP groups up if only some elements match

2015-11-18 Thread Richard Biener
On Tue, Nov 17, 2015 at 5:46 PM, Alan Lawrence wrote: > On 16/11/15 14:42, Christophe Lyon wrote: >> >> >> Hi Alan, >> >> I've noticed that this new test (gcc.dg/vect/bb-slp-subgroups-3.c) >> fails for armeb targets. >> I haven't had time to look at more details yet, but I

[Ada] Spurious visibility error with private subtye, inlining and instance

2015-11-18 Thread Arnaud Charlet
This patch fixes an oversight in the restoring of proper use visibility on the full view of a private subtype, when a use clause for the enclosing package appears before an instantiation of a child unit of the package, the instantiation is followed by a use of the private subtype, and the

[PATCH] Fix ICE with mangling aliases (PR c++/67354)

2015-11-18 Thread Jakub Jelinek
Hi! This is an attempt to fix an ICE on the following testcase. Normally (when !at_eof), note_mangling_alias just queues up the mangling aliases in a vector, but when maybe_thunk_body is called at_eof, it calls cdtor_comdat_group which mangles first the names of both the fns to determine the name

Re: [PATCH][RTL-ree] PR rtl-optimization/68194: Restrict copy instruction in presence of conditional moves

2015-11-18 Thread Kyrill Tkachov
On 17/11/15 23:11, Bernd Schmidt wrote: On 11/17/2015 02:03 PM, Kyrill Tkachov wrote: + || !reg_overlap_mentioned_p (tmp_reg, SET_SRC (PATTERN (cand->insn return false; Well, I think the statement we want to make is "return false from this function if the two expressions

Re: Incorrect code due to indirect tail call of varargs function with hard float ABI

2015-11-18 Thread Ramana Radhakrishnan
On 18/11/15 00:32, Kugan wrote: >> > Hi Ramana, >> > >> > Thanks for the review. I have opened a gcc bug-report for this. I tested >> > the attached patch for arm-none-linux-gnueabihf and >> > arm-none-linux-gnueabi with no new regressions. Is this OK? >> > >> > >> > Thanks, >> > Kugan >> >

Re: [PATCH][GCC][ARM] Disable neon testing for armv7-m

2015-11-18 Thread Andre Vieira
On 17/11/15 10:10, James Greenhalgh wrote: On Mon, Nov 16, 2015 at 01:15:32PM +, Andre Vieira wrote: On 16/11/15 12:07, James Greenhalgh wrote: On Mon, Nov 16, 2015 at 10:49:11AM +, Andre Vieira wrote: Hi, This patch changes the target support mechanism to make it recognize any

Re: [PATCH, 10/16] Add pass_oacc_kernels pass group in passes.def

2015-11-18 Thread Richard Biener
On Tue, 17 Nov 2015, Tom de Vries wrote: > On 17/11/15 16:18, Richard Biener wrote: > > > > IMHO autopar needs to handle induction itself. > > > > > > > >I'm not sure what you mean. Could you elaborate? Autopar handles > > > induction > > > >variables, but it doesn't handle exit phis reading the

Re: [PATCH, VECTOR ABI] Add __attribute__((__simd__)) to GCC.

2015-11-18 Thread Andreas Schwab
Kirill Yukhin writes: > diff --git a/gcc/testsuite/c-c++-common/attr-simd.c > b/gcc/testsuite/c-c++-common/attr-simd.c > new file mode 100644 > index 000..b4eda34 > --- /dev/null > +++ b/gcc/testsuite/c-c++-common/attr-simd.c > @@ -0,0 +1,32 @@ > +/* { dg-do compile

[Ada] Undefined symbols with pragma Initialize_Scalars

2015-11-18 Thread Arnaud Charlet
This patch modifies the generation of a constrained array subtype for an object declaration to use an external name. This ensures that a reference to the array subtype bounds are consistent when compiling with various switches and pragmas such as Initialize_Scalars. No simple reproducer possible.

[Ada] Malformed argument with pragma Refined_State

2015-11-18 Thread Arnaud Charlet
This patch modifies the grammars of pragmas Abstract_State, Depends, Global, Initializes, Refined_Depends, Refined_Global and Refined_State to explicitly request a single argument. No need for a test as this is a documentation enhancement. Tested on x86_64-pc-linux-gnu, committed on trunk

[PATCH] Fix debug fallout of proposed PR68162 fix

2015-11-18 Thread Richard Biener
The following patch makes sure we still emit a DW_TAG_typedef for the element typedef in gcc.dg/debug/dwarf2/pr47939-4.c after a change to how the C frontend structures the variant chain of arrays. It makes dwarf2out _not_ re-build the variant for arrays (like it does for vectors). Patch was

[patch] Fix PR middle-end/65958

2015-11-18 Thread Eric Botcazou
Hi, this is the underlying issue of PR middle-end/65958: the compiler generates wrong code when alloca is used in conjunction with a VLA since the latter causes the stack space allocated to the former to be wrongly reclaimed. So the proposed fix is not to reclaim any stack space in this case.

[PATCH][4.9] Backport fix for PR sanitizer/64820.

2015-11-18 Thread Maxim Ostapenko
Hi, this small patch fixes the logic in ASan vs SSP interaction to provide correct "size" parameter to asan_stack_malloc_[N] routines. With current logic, we would have assertion failure in libsanitizer in UAR mode on 32-bit targets due to wrong granularity of resulting addr + size address.

[Ada] Missing error on volatile return type of non-volatile function

2015-11-18 Thread Arnaud Charlet
This patch modifies the predicate which determines whether a function is volatile to correctly recognize a protected function. -- Source -- -- vol_func.ads package Vol_Func with SPARK_Mode is protected type Prot is end Prot; type Vol_Typ is null record with

Re: [PATCH] Fix reassoci ICE (PR tree-optimization/68157)

2015-11-18 Thread Richard Biener
On Wed, 18 Nov 2015, Jakub Jelinek wrote: > Hi! > > attempt_builtin_powi and its caller does not set uids of the stmts it adds, > which in some cases may lead to reassoc ICEs. > Fixed thusly, bootstrapped/regtested on x86_64-linux and i686-linux, ok for > trunk/5.3? Ok. Thanks, Richard. >

[Ada] State refinement predicates for GNATprove

2015-11-18 Thread Arnaud Charlet
This patch implements two predicates that allow for state revinement queries while ignoring the region over which a state refinement is visible. No test possible as this requires an external client of the compiler. Tested on x86_64-pc-linux-gnu, committed on trunk 2015-11-18 Hristian Kirtchev

Re: [patch] Fix PR middle-end/65958

2015-11-18 Thread Eric Botcazou
> Looks good to me. I also found the Arrays of Variable Length section > in extend.texi which also refers to alloca as doing the same. We may > want to add a note there that you should not mix both and that only > VLAs (when not mixed with alloca) are freed at scope boundary. It's already there

[PTX] OpenACC complex double reductions

2015-11-18 Thread Nathan Sidwell
Here's the version of the complex double reduction patch I've committed to trunk. There's no atomic cmp larger than 64 bits, so we have to do something else. I started with a patch to synthesize such an operation using a global lock, and fitted it into the current scheme. But that (a)

Re: [PATCH, PR tree-optimization/68327] Compute vectype for live phi nodes when copmputing VF

2015-11-18 Thread Ilya Enkovich
2015-11-18 16:44 GMT+03:00 Richard Biener : > On Wed, Nov 18, 2015 at 12:34 PM, Ilya Enkovich > wrote: >> Hi, >> >> When we compute vectypes we skip non-relevant phi nodes. But we process >> non-relevant alive statements and thus may need

[PATCH] Add clang-format config to contrib folder

2015-11-18 Thread Martin Liška
Hello. Following patch adds a clang-format config file that should respect the GNU coding standards. As the file is not part of build process, I hope the patch can be applied even though we've just skipped to stage3? The patch adds a hunk to Makefile which can create symlink to the root

Re: [PATCH, VECTOR ABI] Add __attribute__((__simd__)) to GCC.

2015-11-18 Thread Kirill Yukhin
Hello Andreas, Devid. On 18 Nov 10:45, Andreas Schwab wrote: > Kirill Yukhin writes: > > > diff --git a/gcc/testsuite/c-c++-common/attr-simd.c > > b/gcc/testsuite/c-c++-common/attr-simd.c > > new file mode 100644 > > index 000..b4eda34 > > --- /dev/null > > +++

RE: [Patch,testsuite]: Fix the tree-ssa/split-path-1.c testcase

2015-11-18 Thread Ajit Kumar Agarwal
Hello Jeff: Please ignore my previous mails as they bounced back. Sorry for that. I have fixed the problem with the testcase. The splitting path optimization remains intact. Attached is the patch. The problem was related to the testcase as the loop bound goes beyond the malloced array. There

RE: [Patch,tree-optimization]: Add new path Splitting pass on tree ssa representation

2015-11-18 Thread Ajit Kumar Agarwal
-Original Message- From: Tom de Vries [mailto:tom_devr...@mentor.com] Sent: Wednesday, November 18, 2015 1:14 PM To: Jeff Law; Richard Biener Cc: Ajit Kumar Agarwal; GCC Patches; Vinod Kathail; Shail Aditya Gupta; Vidhumouli Hunsigida; Nagaraju Mekala Subject: Re:

PPC bootstrap failure builtin clz

2015-11-18 Thread David Edelsohn
Richard, One of the patches in your recent series caused bootstrap failure on PPC: In file included from /nasfarm/edelsohn/src/src/libgcc/libgcov-driver.c:49:0: /nasfarm/edelsohn/src/src/libgcc/../gcc/gcov-io.c: In function 'gcov_do_dump':

[Ada] Crahs on indexing operation with named associations

2015-11-18 Thread Arnaud Charlet
This patch fixes a crash on a variable indexing operation appearing on the left-hand side of an assignment, when the index expressions are given by parameter associations. The following must compile quietly: gcc -c -gnatct test_indexing.adb --- with Ada.Text_IO; use Ada.Text_IO; with

RFC/RFA: Fix bug with REE optimization corrupting extended registers

2015-11-18 Thread Nick Clifton
Hi Guys, I recently discovered a bug in the current Redundant Extension Elimination optimization. If the candidate extension instruction increases the number of hard registers used, the pass does not check to see if these extra registers are live between the definition and the

Re: [PATCH] Fix memory leaks in tree-ssa-uninit.c

2015-11-18 Thread Martin Liška
On 11/13/2015 08:19 PM, Jeff Law wrote: > On 11/13/2015 09:58 AM, Martin Liška wrote: >> On 11/13/2015 05:32 PM, Jeff Law wrote: >>> On 11/13/2015 05:50 AM, Martin Liška wrote: Hello. Patch survives regbootstrap on x86_64-linux-gnu. Ready for trunk? Thanks,

Re: [PATCH] Add clang-format config to contrib folder

2015-11-18 Thread Markus Trippelsdorf
On 2015.11.18 at 15:37 +0100, Markus Trippelsdorf wrote: > On 2015.11.18 at 15:10 +0100, Martin Liška wrote: > > Hello. > > > > Following patch adds a clang-format config file that should respect the GNU > > coding standards. > > As the file is not part of build process, I hope the patch can be

Re: [patch] Fix PR middle-end/65958

2015-11-18 Thread Richard Biener
On Wed, Nov 18, 2015 at 12:12 PM, Eric Botcazou wrote: >> Ok. I wonder if we document GCCs VLA implementation somewhere so we can add >> a note on the interaction with alloca. > > I found this in 10.7.2 Blocks: > > "Variable-length arrays (VLAs) complicate this process, as

[PATCH] S/390: Clobber r1 in patterns resulting in pfpo instruction.

2015-11-18 Thread Dominik Vogt
The attached patch fixes the S/390 patterns using the "pfpo" instruction in s390.md. The instructions clobber r1, but the patterns did not reflect that. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany gcc/ChangeLog * config/s390/s390.md (GPR1_REGNUM): New constant.

[Ada] Freezing of contracts, Part_Of and current instance of a concurrent type

2015-11-18 Thread Arnaud Charlet
This patch addresses several areas: The freezing of contracts has been enhanced. A body continues to freeze the contract of the nearest enclosing package and now freezes the contracts of all eligible constructs in the same declarative list that precede the body. A concurrent constituent is no

  1   2   >