Re: [PATCH] do not take mutex in _Unwind_Find_registered_FDE if there is no registered objects

2016-07-27 Thread Gleb Natapov
On Wed, Jul 27, 2016 at 05:12:18PM -0600, Jeff Law wrote: > On 07/25/2016 07:44 AM, Gleb Natapov wrote: > > _Unwind_Find_FDE calls _Unwind_Find_registered_FDE and it takes lock even > > when there is no registered objects. As far as I see only statically > > linked applications call

Re: [PATCH] Fix wrong code on aarch64 due to paradoxical subreg

2016-07-27 Thread Bernd Edlinger
Am 27.07.2016 um 23:31 schrieb Jeff Law: > On 07/26/2016 11:32 AM, Bernd Edlinger wrote: >> Hi! >> >> As described in PR 71779 and PR 70903 we have a wrong code issue on >> aarch64 >> which is triggered by a paradoxical subreg that can be created in >> store_bit_field_using_insv when the target

Re: Init df for split pass since some target use REG_NOTE in split pattern

2016-07-27 Thread Kito Cheng
Hi Jeff: > This seems better suited as a generic optimization than hidden away in a > backend. > > AFAICT you're just noticing a word of the output operand is dead and eliding > the load/store for that word. > > In fact, I'm a bit surprised nothing has optimized this away by the time > reload/LRA

[gomp4] encode acc routine clauses inside fortran module files

2016-07-27 Thread Cesar Philippidis
This patch contains the following changes: * Enhance support for OpenACC routine clauses inside fortran module files. Also, allow the routine directive to be applied to intrinsic procedures. The trunk patch can be found here: https://gcc.gnu.org/ml/gcc-patches/2016-07/msg00063.html *

Re: [PATCH 1/3] make pattern_regs a vec

2016-07-27 Thread Trevor Saunders
On Wed, Jul 27, 2016 at 04:15:02PM -0600, Jeff Law wrote: > On 07/24/2016 03:10 PM, tbsaunde+...@tbsaunde.org wrote: > > From: Trevor Saunders > > > > gcc/ChangeLog: > > > > 2016-07-24 Trevor Saunders > > > > * store-motion.c (struct

PR fortran/71799 -- Patch

2016-07-27 Thread Steve Kargl
Probably committable under trivially correct. OK? 2016-07-22 Steven G. Kargl PR fortran/71799 * resolve.c(gfc_resolve_iterator): Failure of type conversion need not ICE. 2016-07-22 Steven G. Kargl PR fortran/71799

PR fortran/71859 -- Patch

2016-07-27 Thread Steve Kargl
Patch is self-explanatory. OK? 2016-07-26 Steven G. Kargl PR fortran/71859 * check.c(numeric_check): Prevent ICE. Issue error for invalid subroutine as an actual argument when numeric argument is expected. 2016-07-26 Steven G. Kargl

Re: [PATCH] do not take mutex in _Unwind_Find_registered_FDE if there is no registered objects

2016-07-27 Thread Jeff Law
On 07/25/2016 07:44 AM, Gleb Natapov wrote: _Unwind_Find_FDE calls _Unwind_Find_registered_FDE and it takes lock even when there is no registered objects. As far as I see only statically linked applications call __register_frame_info* functions, so for dynamically linked executables taking the

Re: [PATCH 1/3] (v2) On-demand locations within string-literals

2016-07-27 Thread Manuel López-Ibáñez
On 27 July 2016 at 15:30, David Malcolm wrote: >> Perhaps it could live for now in c-format.c, since it is the only >> place using it? > > Martin Sebor [CC-ed] wants to use it from the middle-end: > https://gcc.gnu.org/ml/gcc-patches/2016-07/msg01088.html > so it's unclear

Re: [PATCH 3/3] merge adjust_cost and adjust_cost_2 target hooks

2016-07-27 Thread Jeff Law
On 07/24/2016 03:10 PM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders gcc/ChangeLog: 2016-07-24 Trevor Saunders * config/alpha/alpha.c (alpha_adjust_cost): Adjust. * config/arm/arm-protos.h (struct

Re: [PATCH 1/3] make pattern_regs a vec

2016-07-27 Thread Jeff Law
On 07/24/2016 03:10 PM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders gcc/ChangeLog: 2016-07-24 Trevor Saunders * store-motion.c (struct st_expr): Make pattern_regs a vector. (extract_mentioned_regs): Append to

Re: [PATCH 2/3] haifa-sched.c: make twins a auto_vec

2016-07-27 Thread Jeff Law
On 07/24/2016 03:10 PM, tbsaunde+...@tbsaunde.org wrote: From: Trevor Saunders gcc/ChangeLog: 2016-07-24 Trevor Saunders * haifa-sched.c (add_to_speculative_block): Make twins a vector. OK. jeff

Re: RFC: Make diagnostics for C++ reference binding more consistent

2016-07-27 Thread Jason Merrill
On Wed, Jul 27, 2016 at 8:05 AM, Jonathan Wakely wrote: > Consider: > > template T declval(); > > int& r1 = declval(); > int&& r2 = declval(); > int& r3 = declval(); > > > This produces three quite different errors: > > > refs.cc:3:25: error: invalid

Re: [PATCH] Add mark_spam.py script

2016-07-27 Thread Jeff Law
On 07/26/2016 06:39 AM, Martin Liška wrote: Hello. This is python script that utilizes bugzilla API and marks PRs as spam: $ ./mark_spam.py --help usage: mark_spam.py [-h] [--verbose] api_key range Mark Bugzilla issues as spam. positional arguments: api_key API key range Range

Re: [PATCH] Do not allow make_compound_operation for vector mode, (PR70944)

2016-07-27 Thread Jeff Law
On 07/27/2016 07:46 AM, Martin Liška wrote: Hello. Following patch rejects compound operation manipulation for vector mode. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Ready to be installed? Martin

Re: Init df for split pass since some target use REG_NOTE in split pattern

2016-07-27 Thread Jeff Law
On 07/25/2016 08:31 PM, Kito Cheng wrote: Hi Jeff: Oop, patch in attachment, and I hit this bug in gcc.dg/torture/vshuf-v2di.c with our nds32 internal branch. Hi Richard: I think we really need reg dead note for some optimization, and btw, here is our split pattern: (define_split [(set

C PATCH for c/71853 (ICE with uninitialized memory on invalid)

2016-07-27 Thread Marek Polacek
This testcase was breaking because we were using uninitialized memory coming from c_expr in c_parser_switch_statement. There, in case we hadn't seen '(' after switch, we called c_finish_case with uninitialized CE. Fixed thus. Bootstrapped/regtested on x86_64-linux, ok for trunk? 2016-07-27

Re: [PATCH] Introduce no_profile_instrument_function attribute (PR gcov-profile/68025)

2016-07-27 Thread Jeff Law
On 07/27/2016 02:27 AM, Martin Liška wrote: Hi. As mentioned in the PR gcov-profile/68025, there's a request not to instrument some functions (e.g. a in linux kernel). Thus, I come with a new attribute no_profile_instrument_function which skips any profiling instrumentation. Patch can

Re: [PATCH] Fix wrong code on aarch64 due to paradoxical subreg

2016-07-27 Thread Jeff Law
On 07/26/2016 11:32 AM, Bernd Edlinger wrote: Hi! As described in PR 71779 and PR 70903 we have a wrong code issue on aarch64 which is triggered by a paradoxical subreg that can be created in store_bit_field_using_insv when the target has an EP_insv bitfield instruction. The attached patch

Re: [C++ PATCH] for PR72457

2016-07-27 Thread Jason Merrill
On Wed, Jul 27, 2016 at 2:50 AM, Markus Trippelsdorf wrote: > On 2016.07.23 at 22:55 -0400, Jason Merrill wrote: >> Using build_value_init in a base initialization is wrong, because it >> calls the complete object constructor and misses protected access. So >> let's

Re: [PATCH, 2 of 4], Enhance PowerPC vec_extract support for power8/power9 machines

2016-07-27 Thread Michael Meissner
Next patch in the vec_extract series. This patch adds support for vec_extract with a variable argument element number for vector double or vector long on 64-bit ISA 2.07 (power8) or ISA 3.0 (power9) systems. It needs 64-bit ISA 2.07 for the direct move support. I have tested this on a little

Re: [Bug tree-optimization] Fix for PR71994

2016-07-27 Thread Jeff Law
On 07/26/2016 06:10 PM, kugan wrote: Hi Jeff, Thanks for your comments. * tree-ssa-reassoc.c (maybe_optimize_range_tests): Check type compatibility. I'd kind of like to see some analysis of how we've got a bool here -- ISTM it ought to have been converted it to the type of the LHS

Re: Use correct location information for OpenACC shape and simple clauses in C/C++

2016-07-27 Thread David Malcolm
On Wed, 2016-07-27 at 17:17 +0200, Thomas Schwinge wrote: > Hi! > > I found that for a lot of OpenACC (and potentially also OpenMP) > clauses > (in C/C++ front ends; didn't look at Fortran), we use wrong location > information. The problem is that >

Re: [PATCH 2/3] Run profile feedback tests with autofdo

2016-07-27 Thread Jeff Law
On 07/25/2016 10:28 PM, Andi Kleen wrote: But it's not expected that it is not deterministic, so that it changes run to run. Do you see that? Or some other problem? Please describe it exactly. It definitely changes run to run for me. And do you have autofdo installed? (create_gcov) No. jeff

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-27 Thread Jeff Law
On 07/27/2016 10:52 AM, Marek Polacek wrote: This is what the new warning pointed out. I think all these are bugs. This patch has been tested on powerpc64le-unknown-linux-gnu, aarch64-linux-gnu, and x86_64-redhat-linux. 2016-07-27 Marek Polacek PR c/7652 gcc/

Re: Implement -Wimplicit-fallthrough: core

2016-07-27 Thread Jeff Law
On 07/27/2016 11:59 AM, Marek Polacek wrote: On Wed, Jul 27, 2016 at 11:04:04AM -0600, Martin Sebor wrote: Just a couple of minor things: +@cindex @code{fallthrough} statement attribute +The @code{fallthrough} attribute with a null statement serves as a +fallthrough statement. It hints to

Re: [PATCH] Remove BITS_PER_UNIT_LOG

2016-07-27 Thread Jeff Law
On 07/27/2016 01:38 PM, Bernd Edlinger wrote: Hi! I've noticed that there are two defines for log2 of BITS_PER_UNIT: BITS_PER_UNIT_LOG and LOG2_BITS_PER_UNIT. At least this wheel was apparently invented more than once :) Thus I'd say the most simple wheel will do for us as well. This patch

Re: [PATCH, 1 of 4 or 5], Enhance PowerPC vec_extract support for power8/power9 machines

2016-07-27 Thread Michael Meissner
On Wed, Jul 27, 2016 at 02:35:18PM -0500, Segher Boessenkool wrote: > Later patches have some testcases? Yes, as I said, since the first patch just changed the internal infrastructure to allow for variable vec_extracts (in patch #2), it didn't change any code. There will be new test cases for

[PATCH] Remove BITS_PER_UNIT_LOG

2016-07-27 Thread Bernd Edlinger
Hi! I've noticed that there are two defines for log2 of BITS_PER_UNIT: BITS_PER_UNIT_LOG and LOG2_BITS_PER_UNIT. At least this wheel was apparently invented more than once :) Thus I'd say the most simple wheel will do for us as well. This patch removes BITS_PER_UNIT_LOG as this is less often

Re: [PATCH, 1 of 4 or 5], Enhance PowerPC vec_extract support for power8/power9 machines

2016-07-27 Thread Segher Boessenkool
On Wed, Jul 27, 2016 at 10:32:21AM -0400, Michael Meissner wrote: > 2016-07-27 Michael Meissner > > * config/rs6000/vector.md (vec_extract): Change the calling > signature of rs6000_expand_vector_extract so that the element > number is a RTX

Re: Implement -Wimplicit-fallthrough: core

2016-07-27 Thread Marek Polacek
On Wed, Jul 27, 2016 at 11:04:04AM -0600, Martin Sebor wrote: > Just a couple of minor things: > > > +@cindex @code{fallthrough} statement attribute > > +The @code{fallthrough} attribute with a null statement serves as a > > +fallthrough statement. It hints to the compiler that a statement > >

Re: Implement -Wimplicit-fallthrough: core (take 2)

2016-07-27 Thread Marek Polacek
On Wed, Jul 27, 2016 at 06:46:33PM +0200, Marek Polacek wrote: > +static tree > +warn_implicit_fallthrough_r (gimple_stmt_iterator *gsi_p, bool > *handled_ops_p, > +struct walk_stmt_info *) Yes, bad formatting here. I'll fix. Marek

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-27 Thread Tom Tromey
> "Marek" == Marek Polacek writes: Marek> gcc/java/ Marek> * jcf-dump.c (print_constant): Add break. This bit is ok. Tom

[PATCH] testsuite/20_util/forward/1_neg.cc: Move dg-error to right line.

2016-07-27 Thread Jonathan Wakely
The dg-error was on the wrong line in this test. It happened to pass by chance because it was on line 31 and the error happened at location 30:31 so the column number matched the dg-error line number! Running with -fno-show-column caused it to fail. Splitting the expression into three lines

[committed] Move make_location from tree.h/c to input.h/c

2016-07-27 Thread David Malcolm
For some reason I added make_location and some related functions to tree.h/c, rather than to input.h/c. Move them there, so we can use them without requiring tree, and add some selftest coverage. Bootstrapped on x86_64-pc-linux-gnu. Committed to trunk as r238792. gcc/ChangeLog: *

Re: Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-27 Thread Mike Stump
On Jul 27, 2016, at 9:52 AM, Marek Polacek wrote: > > This is what the new warning pointed out. I think all these are bugs. > > --- gcc/libgo/runtime/heapdump.c > +++ gcc/libgo/runtime/heapdump.c > @@ -766,6 +766,7 @@ dumpefacetypes(void *obj __attribute__ ((unused)), >

Re: Implement -Wimplicit-fallthrough: core

2016-07-27 Thread Martin Sebor
Just a couple of minor things: +@cindex @code{fallthrough} statement attribute +The @code{fallthrough} attribute with a null statement serves as a +fallthrough statement. It hints to the compiler that a statement +that falls through to another case label, or user-defined label +in a switch

Re: Implement -Wimplicit-fallthrough: the rest

2016-07-27 Thread Marek Polacek
On Fri, Jul 22, 2016 at 01:27:51PM +0200, Bernd Schmidt wrote: > On 07/22/2016 01:15 PM, Jakub Jelinek wrote: > > > @@ -32335,6 +32341,7 @@ rs6000_handle_altivec_attribute (tree *node, > > > case V4SImode: case V8HImode: case V16QImode: case V4SFmode: > > > case V2DImode: case V2DFmode: > > >

Implement -Wimplicit-fallthrough (take 2): the rest

2016-07-27 Thread Marek Polacek
And this is the rest. Either I just adjusted a falls through comment, or I added __builtin_fallthrough (). These were the cases where I was fairly sure that the fall through is intentional. This patch has been tested on powerpc64le-unknown-linux-gnu, aarch64-linux-gnu, and x86_64-redhat-linux.

Implement -Wimplicit-fallthrough (take 2): questionable code

2016-07-27 Thread Marek Polacek
These are the cases where I wasn't sure if the falls through were intentional or not. This patch has been tested on powerpc64le-unknown-linux-gnu, aarch64-linux-gnu, and x86_64-redhat-linux. 2016-07-27 Marek Polacek PR c/7652 gcc/ * config/i386/i386.c

Re: [v3 PATCH] Implement std::string_view and P0254r2, Integrating std::string_view and std::string.

2016-07-27 Thread Jonathan Wakely
On 25/07/16 00:41 +0300, Ville Voutilainen wrote: Changelog as it was before, tested on Linux-x64. I haven't fixed all section references of string tests, and I haven't added section references to string_view tests, because they didn't have any. I also haven't added tests that test the various

Implement -Wimplicit-fallthrough (take 2): fix missing breaks

2016-07-27 Thread Marek Polacek
This is what the new warning pointed out. I think all these are bugs. This patch has been tested on powerpc64le-unknown-linux-gnu, aarch64-linux-gnu, and x86_64-redhat-linux. 2016-07-27 Marek Polacek PR c/7652 gcc/ * config/i386/i386.c

Re: Implement -Wimplicit-fallthrough: the rest

2016-07-27 Thread Marek Polacek
On Fri, Jul 22, 2016 at 01:15:41PM +0200, Jakub Jelinek wrote: > > @@ -32352,6 +32360,7 @@ rs6000_handle_altivec_attribute (tree *node, > >switch (mode) > > { > > case V8HImode: result = pixel_V8HI_type_node; > > + gcc_fallthrough (); > > default: break; > > } > >

[arm-embedded] Backport of resolution handling fix WRT incremental linking

2016-07-27 Thread Thomas Preudhomme
The following backport has been made from gcc-6-branch to ARM/embedded-5- branch in order to fix an ICE in LTO observed when running g++.dg/lto/20081219 testcase: 2016-07-27 Thomas Preud'homme Backport from mainline 2015-11-29 Jan Hubicka

Re: Implement -Wimplicit-fallthrough: core (take 2)

2016-07-27 Thread Marek Polacek
On Fri, Jul 22, 2016 at 01:06:41PM +0200, Jakub Jelinek wrote: > On Fri, Jul 22, 2016 at 12:44:07PM +0200, Marek Polacek wrote: > > --- gcc/gcc/cp/parser.h > > +++ gcc/gcc/cp/parser.h > > @@ -46,7 +46,7 @@ struct GTY (()) cp_token { > > Otherwise, this value is RID_MAX. */ > >

[PING] [PING] libgomp: In OpenACC testing, cycle though $offload_targets, and by default only build for the offload target that we're actually going to test

2016-07-27 Thread Thomas Schwinge
Hi! Ping. On Wed, 20 Jul 2016 13:52:20 +0200, I wrote: > Ping. > > On Wed, 13 Jul 2016 12:37:07 +0200, I wrote: > > As discussed before, "offloading compilation is slow; I suppose because > > of having to invoke several tools (LTO streaming -> mkoffload -> offload > > compilers, assemblers,

Use correct location information for OpenACC shape and simple clauses in C/C++

2016-07-27 Thread Thomas Schwinge
Hi! I found that for a lot of OpenACC (and potentially also OpenMP) clauses (in C/C++ front ends; didn't look at Fortran), we use wrong location information. The problem is that c_parser_oacc_all_clauses/c_parser_omp_all_clauses calls cp_parser_omp_clause_name to determine the pragma_omp_clause

[PATCH, 1 of 4 or 5], Enhance PowerPC vec_extract support for power8/power9 machines

2016-07-27 Thread Michael Meissner
These patches enhance the vec_extract built-in on modern PowerPC server systems. Currently, vec_extract is optimized for constant element numbers for vector double/vector long on any VSX system, and constant element numbers for vector char/vector short/vector int on ISA 3.0 (power9) systems. If

Re: [PATCH 1/3] (v2) On-demand locations within string-literals

2016-07-27 Thread David Malcolm
On Tue, 2016-07-26 at 19:05 +0100, Manuel López-Ibáñez wrote: > On 26/07/16 18:11, David Malcolm wrote: > > > gcc/ChangeLog: > > * gcc.c (cpp_options): Rename string to... > > (cpp_options_): ...this, to avoid clashing with struct in > > cpplib.h. > > It seems to me that you need

C++ PATCH for c++/71747 (ICE with self-referential partial specialization)

2016-07-27 Thread Jason Merrill
In this testcase, trying to match the partial specialization led to trying to match the partial specialization again, without hitting any instantiation that would have called push_tinst_level. So we should call it during this substitution, too. This requires passing the partial

Re: [PATCH 7/17][ARM] Add FP16 data movement instructions.

2016-07-27 Thread Ramana Radhakrishnan
On Mon, Jul 4, 2016 at 2:57 PM, Matthew Wahab wrote: > On 17/05/16 15:34, Matthew Wahab wrote: >> The ARMv8.2-A FP16 extension adds a number of instructions to support >> data movement for FP16 values. This patch adds these instructions to the >> backend, making them

Re: [PATCH 6/17][ARM] Add data processing intrinsics for float16_t.

2016-07-27 Thread Ramana Radhakrishnan
On Tue, May 17, 2016 at 3:31 PM, Matthew Wahab wrote: > The ACLE specifies a number of intrinsics for manipulating vectors > holding values in most of the integer and floating point type. These > include 16-bit integer types but not 16-bit floating point even though >

Re: [PATCH 5/17][ARM] Enable HI mode moves for floating point values.

2016-07-27 Thread Ramana Radhakrishnan
On Tue, May 17, 2016 at 3:29 PM, Matthew Wahab wrote: > The handling of 16-bit integer data-movement in the ARM backend doesn't > make full use of the VFP instructions when they are available, even when > the values are for use in VFP operations. > > This patch adds

[PATCH] Do not allow make_compound_operation for vector mode, (PR70944)

2016-07-27 Thread Martin Liška
Hello. Following patch rejects compound operation manipulation for vector mode. Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. Ready to be installed? Martin >From 5f7ae66453a1f7a1a2c44414b22c742d69670177 Mon Sep 17 00:00:00 2001 From: marxin Date:

Re: [PATCH 4/17][ARM] Define feature macros for FP16.

2016-07-27 Thread Ramana Radhakrishnan
On Tue, May 17, 2016 at 3:28 PM, Matthew Wahab wrote: > The FP16 extension introduced with the ARMv8.2-A architecture adds > instructions operating on FP16 values to the VFP and NEON instruction > sets. > > The patch adds the feature macro

Re: [PATCH 3/17][Testsuite] Add ARM support for ARMv8.2-A with FP16 arithmetic instructions.

2016-07-27 Thread Ramana Radhakrishnan
On Mon, Jul 4, 2016 at 2:49 PM, Matthew Wahab wrote: > On 17/05/16 15:26, Matthew Wahab wrote: >> The ARMv8.2-A FP16 extension adds to both the VFP and the NEON >> instruction sets. This patch adds support to the testsuite to select >> targets and set options for tests

Re: [PATCH 2/17][Testsuite] Add a selector for ARM FP16 alternative format support.

2016-07-27 Thread Ramana Radhakrishnan
On Tue, May 17, 2016 at 3:24 PM, Matthew Wahab wrote: > The ARMv8.2-A FP16 extension only supports the IEEE format for FP16 > data. It is not compatible with the option -mfp16-format=none nor with > the option -mfp16-format=alternative (selecting the ARM alternative

Re: [RFC] [2/2] divmod transform: override expand_divmod_libfunc for ARM and add test-cases

2016-07-27 Thread Ramana Radhakrishnan
On Wed, May 25, 2016 at 1:49 PM, Prathamesh Kulkarni wrote: > On 23 May 2016 at 14:28, Prathamesh Kulkarni > wrote: >> Hi, >> This patch overrides expand_divmod_libfunc for ARM port and adds test-cases. >> I separated the SImode

Re: [PATCH PR71734] Add missed check that reference defined inside loop.

2016-07-27 Thread Richard Biener
On Tue, Jul 26, 2016 at 5:49 PM, Yuri Rumyantsev wrote: > Hi Richard, > > It turned out that the patch proposed by you does not work properly > for nested loop. If we slightly change pr70729.cc to > (non-essential part is omitted > void inline Ss::foo (float w) > { > #pragma

RFC: Make diagnostics for C++ reference binding more consistent

2016-07-27 Thread Jonathan Wakely
Consider: template T declval(); int& r1 = declval(); int&& r2 = declval(); int& r3 = declval(); This produces three quite different errors: refs.cc:3:25: error: invalid initialization of non-const reference of type 'int&' from an rvalue of type 'int' int& r1 =

Re: [PR71078] x / abs(x) -> copysign (1.0, x)

2016-07-27 Thread Richard Biener
On Wed, 27 Jul 2016, Prathamesh Kulkarni wrote: > On 26 July 2016 at 17:41, Richard Biener wrote: > > On Mon, 25 Jul 2016, Prathamesh Kulkarni wrote: > > > >> Hi, > >> The attached patch tries to fix PR71078. > >> I am not sure if I have got the converts right. > >> I put

[PATCH] Remove gcc.dg/vect/costmodel/x86_64/costmodel-pr68961.c

2016-07-27 Thread Richard Biener
I forgot to remove this (now FAILing) testcase after the fwprop/simplify-rtx fix. Committed. 2016-07-27 Richard Biener * gcc.dg/vect/costmodel/x86_64/costmodel-pr68961.c: Remove.

Re: [PR71078] x / abs(x) -> copysign (1.0, x)

2016-07-27 Thread Prathamesh Kulkarni
On 26 July 2016 at 17:41, Richard Biener wrote: > On Mon, 25 Jul 2016, Prathamesh Kulkarni wrote: > >> Hi, >> The attached patch tries to fix PR71078. >> I am not sure if I have got the converts right. >> I put (convert? @0) and (convert1? (abs @1)) >> to match for cases when

[PATCH] Fix PR72517

2016-07-27 Thread Richard Biener
Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2016-07-27 Richard Biener PR tree-optimization/72517 * tree-vect-data-refs.c (vect_analyze_data_ref_dependences): Revert change to not compute read-read dependences. Index:

[PATCH] Fix signed/unsigned warning in predict.c

2016-07-27 Thread Richard Biener
Bootstrapped on x86_64-unknown-linux-gnu, applied. Richard. 2016-07-27 Richard Biener * predict.c (set_even_probabilities): Make nedges unsigned. Index: gcc/predict.c === --- gcc/predict.c

Re: [PATCH GCC]Vectorize possible infinite loop by loop versioning.

2016-07-27 Thread Richard Biener
On Tue, Jul 26, 2016 at 7:11 PM, Bin Cheng wrote: > Hi, > This patch vectorizes possible infinite loops by versioning. It analyzes > loops considered for vectorization using loop constraint facility which was > introduced by previous patch; then vectorizes the loop with

Re: [PATCH] Remove special streaming of builtins

2016-07-27 Thread Richard Biener
On Wed, 27 Jul 2016, Ilya Enkovich wrote: > 2016-07-26 22:52 GMT+03:00 Richard Biener : > > On July 26, 2016 7:26:46 PM GMT+02:00, "H.J. Lu" > > wrote: > >>On Mon, Jul 25, 2016 at 4:35 AM, Richard Biener > >>wrote: > >>> > >>> So I

Re: [Patch GCC]Support constraint flags in loop structure.

2016-07-27 Thread Richard Biener
On Tue, Jul 26, 2016 at 7:10 PM, Bin Cheng wrote: > Hi, > This patch adds support for constraint flags in loop structure. Different to > existing boolean flags which are set by niter analyzer, constraint flag is > mainly set by consumers and affects certain semantics of

Use "oacc kernels" attribute for OpenACC kernels (was: Mark oacc kernels fns)

2016-07-27 Thread Thomas Schwinge
Hi! On Mon, 25 Jan 2016 16:09:14 +0100, Jakub Jelinek wrote: > On Mon, Jan 25, 2016 at 10:06:50AM -0500, Nathan Sidwell wrote: > > On 01/04/16 10:39, Nathan Sidwell wrote: > > >There's currently no robust predicate to determine whether an oacc offload > > >function is for a

Re: [PATCH] Remove special streaming of builtins

2016-07-27 Thread Ilya Enkovich
2016-07-26 22:52 GMT+03:00 Richard Biener : > On July 26, 2016 7:26:46 PM GMT+02:00, "H.J. Lu" wrote: >>On Mon, Jul 25, 2016 at 4:35 AM, Richard Biener >>wrote: >>> >>> So I needed to fix that builtins appearing in BLOCK_VARs and the

Re: PING: new pass to warn on questionable uses of alloca() and VLAs

2016-07-27 Thread Rainer Orth
Hi Aldy, > Just in case this got lost in noise, since I know there was a lot of back > and forth between Martin Sebor and I. > > This is the last iteration. > > Tested on x86-64 Linux. > > OK for trunk? > > gcc/ > > * Makefile.in (OBJS): Add gimple-ssa-warn-walloca.o. > * passes.def:

PING: new pass to warn on questionable uses of alloca() and VLAs

2016-07-27 Thread Aldy Hernandez
Just in case this got lost in noise, since I know there was a lot of back and forth between Martin Sebor and I. This is the last iteration. Tested on x86-64 Linux. OK for trunk? gcc/ * Makefile.in (OBJS): Add gimple-ssa-warn-walloca.o. * passes.def: Add two instances of

Test cases to check OpenACC offloaded function's attributes and classification

2016-07-27 Thread Thomas Schwinge
Hi! OK for trunk? commit 8200af082db5438be18bc60f721fcf21641c0d86 Author: Thomas Schwinge Date: Tue Jul 26 17:18:21 2016 +0200 Test cases to check OpenACC offloaded function's attributes and classification gcc/testsuite/ *

Re: [PATCH] predict.c: merge multi-edges

2016-07-27 Thread Martin Liška
On 07/25/2016 07:52 PM, Jeff Law wrote: > Can you turn this into a test as well? > > With that change this patch is OK for the trunk. > > jeff Sure, thanks for the review. Installed as r238781. Martin >From e88a89a85f2d7b4d37d44397d2abe9775cb1cbfb Mon Sep 17 00:00:00 2001 From: marxin

Re: [PATCH 2/3] Run profile feedback tests with autofdo

2016-07-27 Thread Martin Liška
On 07/26/2016 06:28 AM, Andi Kleen wrote: > And do you have autofdo installed? (create_gcov) > > -Andi Ah, sorry for the false alarm, create_gcov is really missing on my distribution. Martin

[PATCH] Introduce no_profile_instrument_function attribute (PR gcov-profile/68025)

2016-07-27 Thread Martin Liška
Hi. As mentioned in the PR gcov-profile/68025, there's a request not to instrument some functions (e.g. a in linux kernel). Thus, I come with a new attribute no_profile_instrument_function which skips any profiling instrumentation. Patch can bootstrap on ppc64le-redhat-linux and survives

Re: Gimple loop splitting v2

2016-07-27 Thread Richard Biener
On Wed, Jul 27, 2016 at 8:17 AM, Andrew Pinski wrote: > On Tue, Jul 26, 2016 at 4:32 AM, Richard Biener > wrote: >> On Mon, Jul 25, 2016 at 10:57 PM, Andrew Pinski wrote: >>> On Wed, Dec 2, 2015 at 5:23 AM, Michael Matz

Re: [PATCH 2/2] Use static_assert for STATIC_ASSERT for C++11 onwards

2016-07-27 Thread Richard Biener
On Wed, Jul 27, 2016 at 1:19 AM, David Malcolm wrote: > C++11 has a > static_assert (COND, MESSAGE) > which gives more readable error messages for STATIC_ASSERT than our > current implementation. > > This patch makes us use it if __cplusplus >= 201103L > > There's also a

Re: [PATCH], Fix PR 71869, Correctly implement isgreater, etc. on PowerPC __float128

2016-07-27 Thread Richard Biener
On Tue, 26 Jul 2016, Segher Boessenkool wrote: > On Tue, Jul 26, 2016 at 08:04:32PM -0400, Michael Meissner wrote: > > > dg-do compile? That's not testing much then, as an executable test! > > > > Good catch. Hopefully, third time is a charm. I verified that changing the > > dg-do compile to

Re: [PATCH 1/2] Add a STATIC_ASSERT on sizeof (struct cp_token)

2016-07-27 Thread Andreas Schwab
On Mi, Jul 27 2016, David Malcolm wrote: > +/* The C++ frontend lexes everything first, and keeps the tokens > + in memory, so there are possibly millions of tokens in memory. > + > + Use a STATIC_ASSERT to ensure that we don't accidentally grow > + the structure. > +

[C++ PATCH] for PR72457

2016-07-27 Thread Markus Trippelsdorf
On 2016.07.23 at 22:55 -0400, Jason Merrill wrote: > Using build_value_init in a base initialization is wrong, because it > calls the complete object constructor and misses protected access. So > let's handle list-value-initialization in expand_aggr_init_1. > > Tested x86_64-pc-linux-gnu,

Re: Gimple loop splitting v2

2016-07-27 Thread Andrew Pinski
On Tue, Jul 26, 2016 at 4:32 AM, Richard Biener wrote: > On Mon, Jul 25, 2016 at 10:57 PM, Andrew Pinski wrote: >> On Wed, Dec 2, 2015 at 5:23 AM, Michael Matz wrote: >>> Hi, >>> >>> On Tue, 1 Dec 2015, Jeff Law wrote: >>> > So,