Re: [PATCH] avoid calling alloca(0)

2016-11-17 Thread Jakub Jelinek
On Thu, Nov 17, 2016 at 05:32:31PM -0700, Martin Sebor wrote: > >The point is warning on an alloca (0) may not be as clear cut as it > >might seem. It's probably a reasonable thing to do on the host, but on > >a target, which might be embedded and explicitly overriding the builtin > >alloca,

Re: [PATCH][2/2] GIMPLE Frontend, middle-end changes

2016-11-17 Thread Richard Biener
On Thu, 17 Nov 2016, Jeff Law wrote: > On 11/17/2016 01:20 AM, Richard Biener wrote: > > On Wed, 16 Nov 2016, Jeff Law wrote: > > > > > On 10/28/2016 05:51 AM, Richard Biener wrote: > > > > > > > > These are the middle-end changes and additions to the testsuite. > > > > > > > > They are pretty

RE: [Aarch64][PATCH] Improve Logical And Immediate Expressions

2016-11-17 Thread Michael Collison
James, I incorporated all your suggestions, and successfully bootstrapped and re-ran the testsuite. Okay for trunk? 2016-11-18 Michael Collison * config/aarch64/aarch64-protos.h (aarch64_and_split_imm1, aarch64_and_split_imm2)

Re: [PATCH] fix PR68468

2016-11-17 Thread Waldemar Brodkorb
Hi Jakub, Jakub Jelinek wrote, > On Wed, Nov 16, 2016 at 07:31:59AM +0100, Waldemar Brodkorb wrote: > > > On Wed, Nov 09, 2016 at 04:08:39PM +0100, Bernd Schmidt wrote: > > > > On 11/05/2016 06:14 PM, Waldemar Brodkorb wrote: > > > > >Hi, > > > > > > > > > >the following patch fixes PR68468. > >

Re: PING [PATCH] enable -fprintf-return-value by default

2016-11-17 Thread Sandra Loosemore
On 11/16/2016 09:49 AM, Martin Sebor wrote: I'm looking for an approval of the attached patch. I've adjusted the documentation based on Sandra's input (i.e., documented the negative of the option rather than the positive; thank you for the review, btw.) On 11/08/2016 08:13 PM, Martin Sebor

[PATCH] [AArch64] Fix PR78382

2016-11-17 Thread Hurugalawadi, Naveen
Hi, Please find attached the patch that fixes PR78382. The "SYMBOL_SMALL_TLSGD" was not handled for ILP32. Hence it generates error when compiled for ILP32. The attached patch adds the support and handles it properly as expected for ILP32. Please review the patch and let me know if its okay?

Go patch committed: Remove more diffs from gofrontend and GCC repos

2016-11-17 Thread Ian Lance Taylor
This patch to gcc/go/gofrontend and libgo removes the remaining extraneous differences between the GCC repo and gofrontend repo. A few files were somehow not deleted from the GCC repo. The aclocal.m4 file was changed recently, and gcc/go/gofrontend/lex.cc was changed a while back. This patch

libgo patch committed: Update configure, a few binary files

2016-11-17 Thread Ian Lance Taylor
This patch to libgo updates the configure script and a few binary files. The configure script was changed without going through the external repo in a way that somehow dropped the --with-system-libunwind argument and made a few other changes. This patch restores these changes. A few binary

Re: [PATCH] avoid calling alloca(0)

2016-11-17 Thread Martin Sebor
On 11/17/2016 05:32 PM, Martin Sebor wrote: On 11/17/2016 03:52 PM, Jeff Law wrote: On 11/17/2016 03:03 PM, Jakub Jelinek wrote: On Thu, Nov 17, 2016 at 01:56:03PM -0700, Jeff Law wrote: On 11/17/2016 11:24 AM, Jakub Jelinek wrote: On Thu, Nov 17, 2016 at 11:14:26AM -0700, Martin Sebor

Re: ubsan PATCH to fix compile-time hog with operator overloading (PR sanitizer/78208)

2016-11-17 Thread Marek Polacek
On Thu, Nov 17, 2016 at 09:10:51AM +0100, Jakub Jelinek wrote: > On Wed, Nov 16, 2016 at 04:29:05PM -0800, Marek Polacek wrote: > > Sorry. So consider the following: > > > > class S > > { > > virtual void foo () = 0; > > }; > > > > struct T { > > T << (const char *s); > > }; > > > > T t;

[PR78365] ICE in determine_value_range, at tree-ssa-loo p-niter.c:413

2016-11-17 Thread kugan
Hi, I was relying on ipa_get_callee_param_type to get type of parameter and then convert arguments to this type while computing jump functions. However, in cases like shown in PR78365, ipa_get_callee_param_type, instead of giving up, would return the wrong type. I think the current uses of

Re: [PATCH] avoid calling alloca(0)

2016-11-17 Thread Martin Sebor
On 11/17/2016 03:52 PM, Jeff Law wrote: On 11/17/2016 03:03 PM, Jakub Jelinek wrote: On Thu, Nov 17, 2016 at 01:56:03PM -0700, Jeff Law wrote: On 11/17/2016 11:24 AM, Jakub Jelinek wrote: On Thu, Nov 17, 2016 at 11:14:26AM -0700, Martin Sebor wrote: --- a/gcc/fortran/interface.c +++

libgo patch committed: Rewrite Go type to libffi type conversion in Go

2016-11-17 Thread Ian Lance Taylor
This patch to libgo rewrites the code that converts from a Go type to a libffi type in Go. As we move toward the Go 1.7 garbage collector, it's essential that all allocation of values that can contain Go pointers be done using the correct type descriptor. That is simplest if we do all such

Re: [PATCH] warn on overflow in calls to allocation functions (bugs 77531 and 78284)

2016-11-17 Thread Martin Sebor
Attached is an update to the patch that avoids duplicating the -Walloca-larger-than warnings. This version also avoids warning for calls with zero allocation size to functions declared with the returns_nonnull attribute (like libiberty's xmalloc). Since such functions cannot return null there's

[PR middle-end/38219] Don't test vrp47.c on m68k

2016-11-17 Thread Jeff Law
AFAICT the m68k was the last target needing twiddling to avoid unexpected failures on vrp47.c (from reading comments in the bz). The m68k (like others already mentioned) breaks the conditionals down rather than combining them into a logical with single compare/test. Fixed in the obvious

[PR target/47192] Avoid unsafe code motion in m68k epilogue

2016-11-17 Thread Jeff Law
Like so many ports, the m68k port forgot to emit a barrier prior to deallocation of the stack in its epilogue. As a result, a memory reference could schedule after the stack deallocation. That memory reference might refer to an object in the just allocated stack. If we get an interrupt

RE: [PATCH,testsuite] MIPS: Downgrade from R6 to R5 to prevent redundant testing of branch-cost-1.c.

2016-11-17 Thread Moore, Catherine
> gcc/testsuite/ChangeLog: > > 2016-11-15 Toma Tabacu > > * gcc.target/mips/branch-cost-1.c (dg-options): Use > (HAS_MOVN) instead > of isa>=4, in order to downgrade to R5. > > diff --git a/gcc/testsuite/gcc.target/mips/branch-cost-1.c >

Re: [PATCH] avoid calling alloca(0)

2016-11-17 Thread Jeff Law
On 11/17/2016 03:03 PM, Jakub Jelinek wrote: On Thu, Nov 17, 2016 at 01:56:03PM -0700, Jeff Law wrote: On 11/17/2016 11:24 AM, Jakub Jelinek wrote: On Thu, Nov 17, 2016 at 11:14:26AM -0700, Martin Sebor wrote: --- a/gcc/fortran/interface.c +++ b/gcc/fortran/interface.c @@ -2821,7 +2821,8 @@

Re: [PATCH] arc/nps400: New peephole2 pattern allow more cmem loads

2016-11-17 Thread Andrew Burgess
* Claudiu Zissulescu [2016-11-17 13:23:44 +]: > > > > Note on tests: It will be nice to add a test where the added > > > peephole kicks in. If you consider to add this test to the current > > > patch, please resubmit it. > > > > There were

C++ PATCH for c++/78193 (inherited ctor regression on sparc32)

2016-11-17 Thread Jason Merrill
The issue here was that we were still introducing extra temporaries of an empty class in a CALL_FROM_THUNK_P call to the inherited constructor. Tested x86_64-pc-linux-gnu, applying to trunk. commit 312678eec4a6dac8fe05e2ecfde60a717543ae76 Author: Jason Merrill Date: Thu Nov

Re: [PATCH] Enable Intel AVX512_4FMAPS and AVX512_4VNNIW instructions

2016-11-17 Thread H.J. Lu
On Thu, Nov 17, 2016 at 4:20 AM, Andrew Senkevich wrote: > 16 Ноя 2016 г. 19:21 пользователь "Bernd Schmidt" > написал: > > >> >> On 11/15/2016 05:31 PM, Andrew Senkevich wrote: >>> >>> 2016-11-15 17:56 GMT+03:00 Jeff Law :

Re: [PATCH] Follow-up patch on enabling new AVX512 instructions

2016-11-17 Thread H.J. Lu
On Thu, Nov 17, 2016 at 4:26 AM, Andrew Senkevich wrote: > 16 Ноя 2016 г. 23:45 пользователь "Uros Bizjak" написал: >> >> On Tue, Nov 15, 2016 at 10:50 PM, Andrew Senkevich >> wrote: >> > Hi, >> > >> > this is

Re: [PATCH] avoid calling alloca(0)

2016-11-17 Thread Jakub Jelinek
On Thu, Nov 17, 2016 at 01:56:03PM -0700, Jeff Law wrote: > On 11/17/2016 11:24 AM, Jakub Jelinek wrote: > >On Thu, Nov 17, 2016 at 11:14:26AM -0700, Martin Sebor wrote: > >>--- a/gcc/fortran/interface.c > >>+++ b/gcc/fortran/interface.c > >>@@ -2821,7 +2821,8 @@ compare_actual_formal

RE: [PATCH] MIPS: If a test in the MIPS testsuite requires standard library support check the sysroot supports the required test options.

2016-11-17 Thread Moore, Catherine
> -Original Message- > From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Matthew Fortune > Sent: Thursday, November 17, 2016 8:47 AM > To: Toma Tabacu ; Andrew Bennett > ; Moore, Catherine >

Re: [PATCH, rs6000] Add built-in support for vector compare listed in the ABI

2016-11-17 Thread Segher Boessenkool
Hi Carl, On Thu, Nov 17, 2016 at 01:19:57PM -0800, Carl E. Love wrote: > 2016-11-15 Carl Love Two spaces between your name and email address. > * gcc.target/powerpc/builtins-3.c : New file to test the new No space before colon. > built-ins for vecotr compare

C++ PATCH for c++/78124 (list-init and inherited ctor)

2016-11-17 Thread Jason Merrill
An inherited ctor makes the class non-aggregate. We weren't catching this before because we add the inheriting ctors after we set CLASSTYPE_NON_AGGREGATE, but it's easy enough to set it earlier, here. Tested x86_64-pc-linux-gnu, applying to trunk. commit d462f9acb6cdb05dcc49bee32f0741633de33aed

C++ PATCH for c++/68377 (parens in fold-expression)

2016-11-17 Thread Jason Merrill
finish_parenthesized_expr uses TREE_NO_WARNING to mark parenthesized expressions, so I think it's reasonable to use that to recognize them here. Tested x86_64-pc-linux-gnu, applying to trunk. commit 043b2830c4e296951a8209ade25b8d01394c7386 Author: Jason Merrill Date: Thu Nov

C++ PATCH for c++/78369 (ICE with {} default argument)

2016-11-17 Thread Jason Merrill
The C++17 copy elision code needed to handle CONSTRUCTORs. Tested x86_64-pc-linux-gnu, applying to trunk. commit 8b82502696188d92fc560cc55e0a564c507e6144 Author: Jason Merrill Date: Thu Nov 17 15:37:56 2016 -0500 PR c++/78369 - {} as default argument

[v3 PATCH] LWG 2766, LWG 2749

2016-11-17 Thread Ville Voutilainen
The first patch does everything but the container adaptor parts (which are wrong in the p/r) and the tuple part (which is icky). The second part does the tuple parts, and needs some serious RFC. I know it's ugly as sin, but it works. I don't think we should try to teach our tuple to give the right

Re: [PATCH] avoid calling alloca(0)

2016-11-17 Thread Jeff Law
On 11/17/2016 11:24 AM, Jakub Jelinek wrote: On Thu, Nov 17, 2016 at 11:14:26AM -0700, Martin Sebor wrote: --- a/gcc/fortran/interface.c +++ b/gcc/fortran/interface.c @@ -2821,7 +2821,8 @@ compare_actual_formal (gfc_actual_arglist **ap, gfc_formal_arglist *formal, for (f = formal; f; f =

Re: [PATCH fix PR71767 2/4 : Darwin configury] Arrange for ld64 to be detected as Darwin's linker

2016-11-17 Thread Jeff Law
On 11/08/2016 05:49 PM, Iain Sandoe wrote: On 8 Nov 2016, at 13:39, Mike Stump wrote: On Nov 8, 2016, at 1:05 PM, Iain Sandoe wrote: Simple for the simple case is already part of my patch, but capability for the expert and non-simple case is

[PATCH, rs6000] Add built-in support for vector compare listed in the ABI

2016-11-17 Thread Carl E. Love
GCC maintainers: The Power ABI document lists a number of built-ins that it is supposed to support. There are still some missing. This patch adds the built-in support for the following built-ins: vector bool char vec_cmpeq vector bool char vector bool char vector bool int

Re: [PATCH] libgcc/config/bfin: use the generic linker version information (PR74748)

2016-11-17 Thread Jeff Law
On 11/06/2016 09:39 AM, Waldemar Brodkorb wrote: Hi, This commit makes the Blackfin platform use the generic linker version information, rather than a completely duplicated file, specific for the Blackfin architecture. This is made possible using the newly introduced skip_underscore variable

Re: [PATCH] libgcc/mkmap-symver: support skip_underscore (PR74748)

2016-11-17 Thread Jeff Law
On 11/06/2016 09:32 AM, Waldemar Brodkorb wrote: Hi, Some platforms, such as Blackfin, have a special prefix for assembly symbols as opposed to C symbols. For this reason, a function named "foo()" in C will in fact be visible as a symbol called "_foo" in the ELF binary. The current linker

Re: [PATCH, wwwdocs] document changes appropriate for bug-fix releases

2016-11-17 Thread Jeff Law
On 11/05/2016 04:04 PM, Martin Sebor wrote: The patch below documents the rule of thumb for what changes are appropriate for bug-fix release branches that we discussed in the gcc-patches thread Re: relax rule for flexible array members in 6.x (78039 - fails to compile glibc tests)

[PATCH v3] bb-reorder: Improve compgotos pass (PR71785)

2016-11-17 Thread Segher Boessenkool
For code like the testcase in PR71785 GCC factors all the indirect branches to a single dispatcher that then everything jumps to. This is because having many indirect branches with each many jump targets does not scale in large parts of the compiler. Very late in the pass pipeline (right before

Re: [PATCH v2] bb-reorder: Improve compgotos pass (PR71785)

2016-11-17 Thread Segher Boessenkool
On Wed, Nov 16, 2016 at 11:52:23AM -0700, Jeff Law wrote: > >2016-10-30 Segher Boessenkool > > > > PR rtl-optimization/71785 > > * bb-reorder.c (duplicate_computed_gotos_find_candidates): New > > function, factored out from

Re: [PATCH, GCC/ARM 2/2, ping3] Allow combination of aprofile and rmprofile multilibs

2016-11-17 Thread Thomas Preudhomme
Ping? Best regards, Thomas On 08/11/16 13:36, Thomas Preudhomme wrote: Ping? Best regards, Thomas On 02/11/16 10:05, Thomas Preudhomme wrote: Ping? Best regards, Thomas On 24/10/16 09:07, Thomas Preudhomme wrote: Ping? Best regards, Thomas On 13/10/16 16:35, Thomas Preudhomme

Re: [PATCH, GCC/ARM 1/2, ping3] Add multilib support for embedded bare-metal targets

2016-11-17 Thread Thomas Preudhomme
Ping? Best regards, Thomas On 08/11/16 13:36, Thomas Preudhomme wrote: Ping? Best regards, Thomas On 02/11/16 10:05, Thomas Preudhomme wrote: Ping? Best regards, Thomas On 27/10/16 15:26, Thomas Preudhomme wrote: Hi Kyrill, On 27/10/16 10:45, Kyrill Tkachov wrote: Hi Thomas, On

Re: [PATCH, ARM/testsuite 6/7, ping3] Force soft float in ARMv6-M and ARMv8-M Baseline options

2016-11-17 Thread Thomas Preudhomme
Ping? Best regards, Thomas On 08/11/16 13:35, Thomas Preudhomme wrote: Ping, Best regards, Thomas On 02/11/16 10:04, Thomas Preudhomme wrote: Ping? Best regards, Thomas On 28/10/16 10:49, Thomas Preudhomme wrote: On 22/09/16 16:47, Richard Earnshaw (lists) wrote: On 22/09/16 15:51,

Re: [PATCH, GCC/ARM] Make arm_feature_set agree with type of FL_* macros

2016-11-17 Thread Thomas Preudhomme
On 17/11/16 09:10, Kyrill Tkachov wrote: On 16/11/16 18:09, Thomas Preudhomme wrote: Hi, I've rebased the patch to make arm_feature_set agree with type of FL_* macros on top of trunk rather than on top of the optional -mthumb patch. That involved doing the changes to

Re: [C++ Patch] PR 55080 (" -pedantic produces error: floating-point literal cannot appear in a constant-expression")

2016-11-17 Thread Jason Merrill
OK. On Thu, Nov 17, 2016 at 3:25 PM, Paolo Carlini wrote: > Hi, > > On 17/11/2016 18:14, Jason Merrill wrote: >> >> How about changing cp_parser_non_integral_constant_expression to issue >> a pedwarn instead of error for NIC_FLOAT? > > Indeed. And a relevant observation

Re: [C++ Patch] PR 55080 (" -pedantic produces error: floating-point literal cannot appear in a constant-expression")

2016-11-17 Thread Paolo Carlini
Hi, On 17/11/2016 18:14, Jason Merrill wrote: How about changing cp_parser_non_integral_constant_expression to issue a pedwarn instead of error for NIC_FLOAT? Indeed. And a relevant observation is that we don't pass NIC_FLOAT from anywhere else in the parser, please correct me if I'm wrong.

Re: [PATCH, GCC/ARM] Fix PR77933: stack corruption on ARM when using high registers and lr

2016-11-17 Thread Thomas Preudhomme
Hi Kyrill, I've committed the following updated patch where the test is restricted to Thumb execution mode and skipping it if not possible since -mtpcs-leaf-frame is only available in Thumb mode. I've considered the change obvious. *** gcc/ChangeLog *** 2016-11-08 Thomas Preud'homme

Re: [PATCH, GCC/ARM] Fix ICE when compiling empty FIQ interrupt handler in ARM mode

2016-11-17 Thread Thomas Preudhomme
Hi Christophe, On 17/11/16 13:36, Christophe Lyon wrote: On 16 November 2016 at 10:39, Kyrill Tkachov wrote: On 09/11/16 16:19, Thomas Preudhomme wrote: Hi, This patch fixes the following ICE when building when compiling an empty FIQ interrupt handler in ARM

Re: [Patch 3/5] OpenACC tile clause support, C/C++ front-end parts

2016-11-17 Thread Jason Merrill
On 11/17/2016 04:34 AM, Chung-Lin Tang wrote: + /* These clauses really need a positive integral constant expression, +but we don't have a predicate for that (yet). */ What do you mean? Don't you check this in finish_omp_clauses after the tsubst? Jason

Re: [PATCH] PR target/78101, Fix PowerPC power9-fusion support

2016-11-17 Thread Segher Boessenkool
Hi! On Thu, Nov 17, 2016 at 01:55:25PM -0500, Michael Meissner wrote: > Are these patches ok to change into the trunk? Since the bug shows up in GCC > 6.x, can I apply and submit these patches to the GCC 6.x branch? This is okay for trunk. Please watch that for regressions for a week or so

[committed] strncmp builtin expansion improvement

2016-11-17 Thread Aaron Sawdey
Committed to trunk as 242556 after removing the use->clobber change from cmpstrnsi and bootstrap/regtest. gcc/ChangeLog 2016-11-17  Aaron Sawdey   * config/i386/i386.md (cmpstrnsi): New test to bail out if neither string input is a string constant.

[PATCH] PR target/78101, Fix PowerPC power9-fusion support

2016-11-17 Thread Michael Meissner
This patch fixes the problem reported in PR 78101 where the power9-fusion support generates an insn that isn't matched: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78101 It also fixes the bug that Andrew Stubbs reported. https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01367.html There were two

Re: [PATCH] avoid calling alloca(0)

2016-11-17 Thread Jakub Jelinek
On Thu, Nov 17, 2016 at 11:14:26AM -0700, Martin Sebor wrote: > --- a/gcc/fortran/interface.c > +++ b/gcc/fortran/interface.c > @@ -2821,7 +2821,8 @@ compare_actual_formal (gfc_actual_arglist **ap, > gfc_formal_arglist *formal, >for (f = formal; f; f = f->next) > n++; > > - new_arg =

[PATCH] avoid calling alloca(0)

2016-11-17 Thread Martin Sebor
Testing my patch to warn on overflow in calls to allocation functions (bugs 77531 and 78284): https://gcc.gnu.org/ml/gcc-patches/2016-11/msg01672.html exposed a number of instances of alloca(0) calls in GCC sources. Besides this patch which enables the new warnings with -Wextra (the patch is

Re: Ping: Re: [PATCH 1/2] gcc: Remove unneeded global flag.

2016-11-17 Thread Jeff Law
On 11/16/2016 03:12 PM, Andrew Burgess wrote: * Mike Stump [2016-11-16 12:59:53 -0800]: On Nov 16, 2016, at 12:09 PM, Andrew Burgess wrote: My only remaining concern is the new tests, I've tried to restrict them to targets that I suspect

Re: Default associative containers constructors/destructor/assignment

2016-11-17 Thread Jonathan Wakely
On 28/10/16 21:42 +0200, François Dumont wrote: /** * @brief %Map move constructor. - * @param __x A %map of identical element and allocator types. * - * The newly-created %map contains the exact contents of @a __x. - * The contents of @a __x are a

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Segher Boessenkool
On Thu, Nov 17, 2016 at 04:50:46PM +, Kyrill Tkachov wrote: > >>Is loading/storing a pair as cheap as loading/storing a single register? > >>In that case you could shrink-wrap per pair of registers instead. > > > >I suppose it can vary by microarchitecture. For the purposes of codegen > >I'd

Re: [C++ Patch] PR 55080 (" -pedantic produces error: floating-point literal cannot appear in a constant-expression")

2016-11-17 Thread Jason Merrill
How about changing cp_parser_non_integral_constant_expression to issue a pedwarn instead of error for NIC_FLOAT? Jason

Re: [PATCH] Fix ICE in default_use_anchors_for_symbol_p (PR middle-end/78201)

2016-11-17 Thread Jeff Law
On 11/10/2016 10:00 AM, Jakub Jelinek wrote: Hi! On arm/aarch64 we ICE because some decls that make it here has non-NULL DECL_SIZE, which is a VAR_DECL rather than CONST_INT (or DECL_SIZE that doesn't fit into shwi would ICE similarly). While it is arguably a FE bug that it creates for VLA

Re: Import libcilkrts Build 4467 (PR target/68945)

2016-11-17 Thread Jeff Law
On 11/17/2016 09:56 AM, Ilya Verbin wrote: 2016-11-17 18:50 GMT+03:00 Rainer Orth : Rainer Orth writes: I happened to notice that my libcilkrts SPARC port has been applied upstream. So to reach closure on this issue for the GCC 7

Re: Import libcilkrts Build 4467 (PR target/68945)

2016-11-17 Thread Ilya Verbin
2016-11-17 18:50 GMT+03:00 Rainer Orth : > Rainer Orth writes: > >> I happened to notice that my libcilkrts SPARC port has been applied >> upstream. So to reach closure on this issue for the GCC 7 release, I'd >> like to import

Re: [fixincludes, v3] Don't define libstdc++-internal macros in Solaris 10+

2016-11-17 Thread Jonathan Wakely
On 03/11/16 15:11 +0100, Rainer Orth wrote: Fortunately, this is all easily fixed by wrapping the affected templates in a new macro. That's what this patch does. The new libstdc++ acinclude.m4 test may well need wording changes in comments etc. and can perhaps be shortened a bit, bit it worked

Re: [PR target/78213] Do not ICE on non-empty -fself-test

2016-11-17 Thread Aldy Hernandez
On 11/14/2016 08:18 AM, Bernd Schmidt wrote: On 11/11/2016 06:10 PM, Aldy Hernandez wrote: The problem in this PR is that -fself-test is being run on a non empty source file. This causes init_emit() to run, which sets: REG_POINTER (virtual_incoming_args_rtx) = 1; Setting REG_POINTER on

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Kyrill Tkachov
On 17/11/16 14:55, Kyrill Tkachov wrote: On 17/11/16 14:44, Segher Boessenkool wrote: Hi Kyrill, On Thu, Nov 17, 2016 at 02:22:08PM +, Kyrill Tkachov wrote: I ran SPEC2006 on a Cortex-A72. Overall scores were neutral but there were some interesting swings. 458.sjeng +1.45%

Patch ping: [PATCH] Fix ICE in default_use_anchors_for_symbol_p (PR middle-end/78201)

2016-11-17 Thread Jakub Jelinek
Hi! On Thu, Nov 10, 2016 at 06:00:29PM +0100, Jakub Jelinek wrote: > On arm/aarch64 we ICE because some decls that make it here has non-NULL > DECL_SIZE, which is a VAR_DECL rather than CONST_INT (or DECL_SIZE that > doesn't fit into shwi would ICE similarly). While it is arguably a FE bug >

Re: [Aarch64][PATCH] Improve Logical And Immediate Expressions

2016-11-17 Thread James Greenhalgh
On Thu, Oct 27, 2016 at 08:44:02PM +, Michael Collison wrote: > This patch is designed to improve code generation for "and" instructions with > certain immediate operands. > > For the following test case: > > int f2(int x) > { >x &= 0x0ff8; > >x &= 0xff001fff; > >return x;

Re: [patch, libfortran] Add AVX-specific matmul

2016-11-17 Thread Jakub Jelinek
On Thu, Nov 17, 2016 at 08:41:48AM +0100, Thomas Koenig wrote: > Am 17.11.2016 um 00:20 schrieb Jakub Jelinek: > >On Thu, Nov 17, 2016 at 12:03:18AM +0100, Thomas Koenig wrote: > >>>Don't you need to test in configure if the assembler supports AVX? > >>>Otherwise if somebody is bootstrapping gcc

Re: [PATCH] Fix PR78333

2016-11-17 Thread Christophe Lyon
On 17 November 2016 at 11:27, Christophe Lyon wrote: > On 17 November 2016 at 10:53, Richard Biener wrote: >> On Thu, 17 Nov 2016, Rainer Orth wrote: >> >>> Hi Richard, >>> >>> >> Probably providing dummy implemenations as in the original testcase

Fix PR rtl-optimization/78355

2016-11-17 Thread Eric Botcazou
As diagnosed by the submitter, LRA can generate unaligned accesses when SLOW_UNALIGNED_ACCESS is 1, for example when STRICT_ALIGNMENT is 1, because simplify_operand_subreg can wrongly reject aligned accesses when reloading SUBREGs of MEMs in favor of unaligned ones. The fix is to add the

Re: [PATCH 1/2] PR77822

2016-11-17 Thread Dominik Vogt
On Thu, Nov 17, 2016 at 04:53:03PM +0100, Dominik Vogt wrote: > The following two patches fix PR 77822 on s390x for gcc-7. As the > macro doing the argument range checks can be used on other targets > as well, I've put it in system.h (couldn't think of a better > place; maybe rtl.h?). > >

[committed] Fix locations within raw strings

2016-11-17 Thread David Malcolm
Whilst investigating PR preprocessor/78324 I noticed that the substring location code currently doesn't handle raw strings correctly, by not skipping the 'R', opening quote, delimiter and opening parenthesis. For example, an attempt to underline chars 4-7 with caret at 6 of this raw string yields

Re: [PATCH 2/2] PR77822

2016-11-17 Thread Dominik Vogt
On Thu, Nov 17, 2016 at 04:53:03PM +0100, Dominik Vogt wrote: > The following two patches fix PR 77822 on s390x for gcc-7. As the > macro doing the argument range checks can be used on other targets > as well, I've put it in system.h (couldn't think of a better > place; maybe rtl.h?). > >

[PATCH 0/2] PR77822

2016-11-17 Thread Dominik Vogt
The following two patches fix PR 77822 on s390x for gcc-7. As the macro doing the argument range checks can be used on other targets as well, I've put it in system.h (couldn't think of a better place; maybe rtl.h?). Bootstrapped on s390x biarch, regression tested on s390x biarch and s390, all on

Re: Import libcilkrts Build 4467 (PR target/68945)

2016-11-17 Thread Rainer Orth
Rainer Orth writes: > I happened to notice that my libcilkrts SPARC port has been applied > upstream. So to reach closure on this issue for the GCC 7 release, I'd > like to import upstream into mainline which seems to be covered by the > free-for-all clause in

Re: [C++ Patch] PR 55080 (" -pedantic produces error: floating-point literal cannot appear in a constant-expression")

2016-11-17 Thread Paolo Carlini
... oops, forgot about parser->non_integral_constant_expression_p. The version below, which I'm currently regtesting again, seems more correct. Thanks, Paolo. /// Index: cp/parser.c === --- cp/parser.c (revision

Re: [PATCH][2/2] GIMPLE Frontend, middle-end changes

2016-11-17 Thread Jeff Law
On 11/17/2016 01:20 AM, Richard Biener wrote: On Wed, 16 Nov 2016, Jeff Law wrote: On 10/28/2016 05:51 AM, Richard Biener wrote: These are the middle-end changes and additions to the testsuite. They are pretty self-contained, I've organized the changelog entries below in areas of changes:

Re: Fix PR78154

2016-11-17 Thread Jeff Law
On 11/17/2016 01:48 AM, Richard Biener wrote: On Wed, 16 Nov 2016, Jeff Law wrote: On 11/16/2016 05:17 PM, Martin Sebor wrote: (I've heard some noise in C++-land about making memcpy(0,0,0) valid, but that may have just been noise) We may have read the same discussion. It would make some

Re: PR78319

2016-11-17 Thread Jeff Law
On 11/17/2016 01:52 AM, Richard Biener wrote: On Thu, 17 Nov 2016, Prathamesh Kulkarni wrote: On 17 November 2016 at 03:20, Jeff Law wrote: On 11/16/2016 01:23 PM, Prathamesh Kulkarni wrote: Hi, As discussed in PR, this patch marks the test-case to xfail on arm-none-eabi.

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Kyrill Tkachov
On 17/11/16 15:01, Segher Boessenkool wrote: On Thu, Nov 17, 2016 at 02:55:20PM +, Kyrill Tkachov wrote: Overall, there's a slight improvement in SPECINT, even with the gobmk regression and a slightly larger improvement on SPECFP due to povray. And that is for only the "normal" GPRs, not

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Segher Boessenkool
On Thu, Nov 17, 2016 at 02:55:20PM +, Kyrill Tkachov wrote: > >>Overall, there's a slight improvement in SPECINT, even with the gobmk > >>regression and a slightly larger improvement > >>on SPECFP due to povray. > >And that is for only the "normal" GPRs, not LR or FP yet, right? > > This

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Kyrill Tkachov
On 17/11/16 14:44, Segher Boessenkool wrote: Hi Kyrill, On Thu, Nov 17, 2016 at 02:22:08PM +, Kyrill Tkachov wrote: I ran SPEC2006 on a Cortex-A72. Overall scores were neutral but there were some interesting swings. 458.sjeng +1.45% 471.omnetpp +2.19% 445.gobmk -2.01% On

Re: [patch, libfortran] Add AVX-specific matmul

2016-11-17 Thread Thomas Koenig
Well, here is a newer version of the patch. I wrote a few configure tests to check for AVX. This version hast the advantage that, if anybody uses 32-bit programs with AVX, they would also benefit. Jakub, would you be OK with that patch? I do not yet want to commit this because it needs more

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Segher Boessenkool
Hi Kyrill, On Thu, Nov 17, 2016 at 02:22:08PM +, Kyrill Tkachov wrote: > >>I ran SPEC2006 on a Cortex-A72. Overall scores were neutral but there > >>were > >>some interesting swings. > >>458.sjeng +1.45% > >>471.omnetpp +2.19% > >>445.gobmk -2.01% > >> >

Re: [PATCH] Fix PR77848

2016-11-17 Thread Bill Schmidt
> On Nov 17, 2016, at 3:42 AM, Richard Biener > wrote: > > On Thu, Nov 17, 2016 at 4:14 AM, Bill Schmidt > wrote: >> >> Yes, the new predicate works fine. New patch below, bootstrapped and tested >> on powerpc64le-unknown-linux-gnu,

Re: [PATCH][AArch64] Separate shrink wrapping hooks implementation

2016-11-17 Thread Kyrill Tkachov
On 14/11/16 14:25, Kyrill Tkachov wrote: On 11/11/16 15:31, Kyrill Tkachov wrote: On 11/11/16 10:17, Kyrill Tkachov wrote: On 10/11/16 23:39, Segher Boessenkool wrote: On Thu, Nov 10, 2016 at 02:42:24PM -0800, Andrew Pinski wrote: On Thu, Nov 10, 2016 at 6:25 AM, Kyrill Tkachov I ran

Re: [PATCH PR78114]Refine gfortran.dg/vect/fast-math-mgrid-resid.f

2016-11-17 Thread Bin.Cheng
On Thu, Nov 17, 2016 at 10:53 AM, Richard Biener wrote: > On Thu, Nov 17, 2016 at 11:26 AM, Bin.Cheng wrote: >> On Thu, Nov 17, 2016 at 8:32 AM, Richard Biener >> wrote: >>> On Wed, Nov 16, 2016 at 6:20 PM, Bin Cheng

Re: [patch,testsuite] Support dg-require-effective-target label_offsets.

2016-11-17 Thread Senthil Kumar Selvaraj
Georg-Johann Lay writes: > On 04.11.2016 06:18, Senthil Kumar Selvaraj wrote: >> >> Georg-Johann Lay writes: >>> State of matters is that Binutils support is missing, and if I understand >>> you >>> correctly, dg-require is not appropriate to factor out availability of such >>> features? >> >>

[patch,avr,committed] More use of CONST_INT_P, SUBREG_P.

2016-11-17 Thread Georg-Johann Lay
This is a no-op code clean-up that makes more use of SUBREG_P and CONST_INT_P if possible. Applied as obvious. Johann * config/avr/avr.c (avr_print_operand_address): Use CONST_INT_P if appropriate. (ashlqi3_out, ashlsi3_out, ashrqi3_out, ashrhi3_out): Same.

RE: [PATCH 2/2] [ARC] Update target specific tests.

2016-11-17 Thread Claudiu Zissulescu
> These entries should be going into the gcc/testsuite/ChangeLog file, > and so don't need the "testsuite/" prefix. > Ups :) Fix it. > Otherwise I'm happy for this to be merged. I've only skimmed the > change, but assuming you've run the tests this all seems good. Results of running arc.exp on

RE: [PATCH] MIPS: If a test in the MIPS testsuite requires standard library support check the sysroot supports the required test options.

2016-11-17 Thread Matthew Fortune
Toma Tabacu writes: > Hi, > > The patch below is a rebased version of Andrew's patch plus a few more changes > to test options. > > I have tested Andrew's patch by passing -msoft-float to the testsuite without > having a soft-float library available, and saw that the >

RE: [PATCH] [ARC] Add support for QuarkSE processor.

2016-11-17 Thread Claudiu Zissulescu
> > Looks fine. > Committed, thank you for your review, Claudiu

RE: [PATCH 4/4] [ARC] Fix compilation issue in pr71872.

2016-11-17 Thread Claudiu Zissulescu
> Looks fine. > > Thanks, > Andrew > Committed, thank you for your review, Claudiu

Re: [PATCH, GCC/ARM] Fix ICE when compiling empty FIQ interrupt handler in ARM mode

2016-11-17 Thread Christophe Lyon
On 16 November 2016 at 10:39, Kyrill Tkachov wrote: > > On 09/11/16 16:19, Thomas Preudhomme wrote: >> >> Hi, >> >> This patch fixes the following ICE when building when compiling an empty >> FIQ interrupt handler in ARM mode: >> >> empty_fiq_handler.c:5:1: error:

RE: [PATCH] arc/nps400: New peephole2 pattern allow more cmem loads

2016-11-17 Thread Claudiu Zissulescu
> > Note on tests: It will be nice to add a test where the added > > peephole kicks in. If you consider to add this test to the current > > patch, please resubmit it. > > There were cmem-bit-{1,2,3,4}.c added in that patch. All of which > fail for me without the peephole, and work with the

Re: [PATCH] arc/nps400: New peephole2 pattern allow more cmem loads

2016-11-17 Thread Andrew Burgess
* Claudiu Zissulescu [2016-11-17 13:02:02 +]: > Hi Andrew, > > Approved, please apply, but ... > > > +(define_peephole2 > > + [(set (match_operand:SI 0 "register_operand" "") > > +(sign_extend:SI > > + (match_operand:QI 1

Import libcilkrts Build 4467 (PR target/68945)

2016-11-17 Thread Rainer Orth
I happened to notice that my libcilkrts SPARC port has been applied upstream. So to reach closure on this issue for the GCC 7 release, I'd like to import upstream into mainline which seems to be covered by the free-for-all clause in https://gcc.gnu.org/svnwrite.html#policies, even though

RE: [PATCH] arc/nps400: New peephole2 pattern allow more cmem loads

2016-11-17 Thread Claudiu Zissulescu
Hi Andrew, Approved, please apply, but ... > +(define_peephole2 > + [(set (match_operand:SI 0 "register_operand" "") > +(sign_extend:SI > + (match_operand:QI 1 "any_mem_operand" ""))) > + (set (reg:CC_ZN CC_REG) > + (compare:CC_ZN (match_dup 0) > +

RE: [PATCH] MIPS: If a test in the MIPS testsuite requires standard library support check the sysroot supports the required test options.

2016-11-17 Thread Toma Tabacu
> From: gcc-patches-ow...@gcc.gnu.org [mailto:gcc-patches- > ow...@gcc.gnu.org] On Behalf Of Andrew Bennett > Sent: 03 November 2016 11:33 > To: Matthew Fortune; 'Moore, Catherine'; 'gcc-patches@gcc.gnu.org' > Subject: RE: [PATCH] MIPS: If a test in the MIPS testsuite requires standard > library

RE: [PATCH 1/4] [ARC] Various fixes.

2016-11-17 Thread Claudiu Zissulescu
Hi Andrew, Please ignore this patch for the time being. I would like to double check the add_n/sub_n patterns. Sorry for this detour, Claudiu > -Original Message- > From: Claudiu Zissulescu > Sent: Wednesday, November 16, 2016 11:18 AM > To: gcc-patches@gcc.gnu.org > Cc: Claudiu

[PATCH] Remove -ftree-loop-if-convert-stores

2016-11-17 Thread Richard Biener
This removes a no longer used option, whether we if-convert stores now depends on --param allow-store-data-races and/or the availability of masked stores. Bootstrapped on x86_64-unknown-linux-gnu, testing in progress. Richard. 2016-11-17 Richard Biener *

Re: [PATCH][AArch64] Expand DImode constant stores to two SImode stores when profitable

2016-11-17 Thread James Greenhalgh
On Tue, Nov 01, 2016 at 03:21:29PM +, Kyrill Tkachov wrote: > Here it is. > I've confirmed that it emits to STRs for 4 byte aligned stores when > -mtune=thunderx > and still generates STP for the other tunings, though now sched-fusion is > responsible for > merging them, which is ok by me. >

[PATCH] Fix PR78383 middle-end ICE

2016-11-17 Thread Richard Biener
The following fixes the ICE part of PR78383. We ICE when trying to turn a computed goto to a CFG edge when we know the label but that label is in another function (IPA propagation exposed this knowledge). The transform shows that we miss a DECL_NONLOCAL on the label because we happily

[C++ Patch] PR 55080 (" -pedantic produces error: floating-point literal cannot appear in a constant-expression")

2016-11-17 Thread Paolo Carlini
Hi, this rather old issue points out that, for the snippet below in the legacy -std=c++98 and -pedantic, we issue an hard error instead of a pedwarn - what we normally do, as clarified by Manuel. I guess we could imagine further clean-ups in this area but something as simple as the below

  1   2   >