C++ PATCH for c++/85215, C++17 ICE initializing from conversion function

2018-04-04 Thread Jason Merrill
conv_binds_ref_to_prvalue was expecting that if a user-defined conversion uses a conversion function returning a reference, the conversion will have reference type. This wasn't the case, because build_user_type_conversion_1 strips the reference from the return type to get the type of the

Re: [PATCH] c/55976 -Werror=return-type should error on returning a value from a void function

2018-04-04 Thread Martin Sebor
On 04/04/2018 05:50 PM, dave.pa...@oracle.com wrote: On 04/04/2018 10:58 AM, Martin Sebor wrote: On 04/04/2018 11:15 AM, Jakub Jelinek wrote: On Tue, Apr 03, 2018 at 01:36:13PM -0600, Martin Sebor wrote: On 04/03/2018 10:26 AM, dave.pa...@oracle.com wrote: This patch fixes handlng of

[C++ Patch] PR 84792 ("[6/7/8 Regression] ICE with broken typedef of a struct")

2018-04-04 Thread Paolo Carlini
Hi, I'm really happy to report that these 5 ugly lines are causing an actual bug. Seriously, not considering the formatting, the problem is that we really want to keep 'type' in sync, because we are using it below before returning. Note that we don't regress location-wise because either

C++ PATCH for c++/84938, ICE dividing by ~-1

2018-04-04 Thread Jason Merrill
set_up_extended_ref_temp does an abbreviated version of cp_finish_decl, which didn't include the call to cp_fully_fold that store_init_value does for user-declared variables. Adding that fixes this bug. Tested x86_64-pc-linux-gnu, applying to trunk. commit

C++ PATCH for c++/84936, ICE with unexpanded pack in mem-init

2018-04-04 Thread Jason Merrill
We already had code to deal with an unexpanded pack in the initializer, but not in the member designator. If we find one, let's pretend it was expanded. Tested x86_64-pc-linux-gnu, applying to trunk. commit cb6bcd45b6bd3c1edc44ad0fbe164135cb17467b Author: Jason Merrill Date:

Re: [PATCH] c/55976 -Werror=return-type should error on returning a value from a void function

2018-04-04 Thread dave . pagan
On 04/04/2018 10:58 AM, Martin Sebor wrote: On 04/04/2018 11:15 AM, Jakub Jelinek wrote: On Tue, Apr 03, 2018 at 01:36:13PM -0600, Martin Sebor wrote: On 04/03/2018 10:26 AM, dave.pa...@oracle.com wrote: This patch fixes handlng of -Werror=return-type. Currently, even with the flag specified,

Re: [wwwdocs] document new options in gcc-8/changes.html

2018-04-04 Thread Paolo Carlini
Hi Martin On 05/04/2018 00:28, Martin Sebor wrote: + implementations do suppresses the warning. suppress Paolo.

[PATCH] Add -fcf-protection -mcet to STAGE4_CFLAGS

2018-04-04 Thread H.J. Lu
Since profiledbootstrap uses STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use add STAGE4_CFLAGS += -fcf-protection -mcet to bootstrap-cet.mk to support profiledbootstrap with CET. OK for trunk? H.J. --- --- config/bootstrap-cet.mk | 3 ++- 1 file changed, 2 insertions(+), 1

Re: [wwwdocs] document new options in gcc-8/changes.html

2018-04-04 Thread Martin Sebor
Attached is an updated diff rebased on top of the latest revision of the file. This new version fixes the typos Paolo pointed out (thanks) and adds a few more options: -Wmissing-attributes, -Wif-not-aligned, and -Wpacked-not-aligned. I used a spell-checker this time to (hopefully) minimize the

[C++ PATCH] Implement P0961

2018-04-04 Thread Ville Voutilainen
Tested on Linux-PPC64. 2018-04-05 Ville Voutilainen gcc/cp Implement P0961 * decl.c (get_tuple_decomp_init): Check the templatedness of a member get. testsuite/ Implement P0961 * g++.dg/cpp1z/decomp10.C: Adjust. *

[PATCH] Fix BIT_FIELD_REF folding (PR middle-end/85195)

2018-04-04 Thread Jakub Jelinek
Hi! On the following testcase because of the SCCVN limit we end up with a weird, but valid, BIT_FIELD_REF - trying to extract V1TImode type out of a V1TImode SSA_NAME, with 128 bits width and offset 0 (just SSA_NAME move would be enough). Not trying to address why we create it, rather fix how we

Re: [wwwdocs] gcc-8/changes.html additions

2018-04-04 Thread Bernd Edlinger
On 04/04/18 22:11, Martin Sebor wrote: > On 04/04/2018 12:24 PM, Bernd Edlinger wrote: >> Hi, >> >> this adds a few gcc command line options to gcc-8/changes.html which >> I added for gcc-8. > > Just a couple of suggestions: > > 1) Use to render sizeof in monospace: > > +   

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-04 Thread Peter Bergner
On 4/4/18 2:23 PM, Richard Biener wrote: > On April 4, 2018 8:25:25 PM GMT+02:00, Peter Bergner > wrote: >>> Nobody mentioned if this was a regression or not, so I did some testing >>> and it ICEs on GCC 7 but not on GCC 6. Is it ok to back port to GCC 7 >>> assuming

Re: [PATCH, rs6000] Undefine vector, bool, pixel in xmmintrin.h

2018-04-04 Thread Bill Schmidt
On Apr 4, 2018, at 3:51 PM, Jakub Jelinek wrote: > > On Wed, Apr 04, 2018 at 03:47:18PM -0500, Bill Schmidt wrote: >>> If we (for GCC9?) want to create a spot for target C++ tests, we should >>> just add g++.target// directories and add all the needed infrastructure >>> for

Re: [PATCH, rs6000] Undefine vector, bool, pixel in xmmintrin.h

2018-04-04 Thread Bill Schmidt
> On Apr 4, 2018, at 3:53 AM, Jakub Jelinek wrote: > > On Sun, Apr 01, 2018 at 08:24:32PM -0500, Bill Schmidt wrote: >> I also updated the gcc.target/powerpc/powerpc.exp file to allow C++ >> tests to be placed in that directory (with a *.C suffix). > > I think this is wrong.

[C++ PATCH] Fix __builtin_constant_p constexpr handling (PR inline-asm/85172)

2018-04-04 Thread Jakub Jelinek
Hi! As the following testcases show, potential_constant_expression_1 for some builtins returns true no matter what their arguments contain (intentionally so); the problem is that we call unconditionally cxx_eval_constant_expression on those arguments and that creates a loophole; normally

Re: [wwwdocs] gcc-8/changes.html additions

2018-04-04 Thread Martin Sebor
On 04/04/2018 12:24 PM, Bernd Edlinger wrote: Hi, this adds a few gcc command line options to gcc-8/changes.html which I added for gcc-8. Just a couple of suggestions: 1) Use to render sizeof in monospace: + -Wsizeof-pointer-div warns for suspicious divisions + of two sizeof

Re: C++ PATCH for c++/84221, bogus -Wunused with unused attribute on template

2018-04-04 Thread Martin Sebor
On 04/04/2018 01:58 PM, Jason Merrill wrote: On Wed, Apr 4, 2018 at 3:52 PM, Martin Sebor wrote: On 04/04/2018 01:04 PM, Jason Merrill wrote: For bugs 54372 and 60063, we changed attributes used and unused to be applied immediately in a template even if what they apply to

Re: [wwwdocs] gcc-8/changes.html additions

2018-04-04 Thread Gerald Pfeifer
On Wed, 4 Apr 2018, Jakub Jelinek wrote: > Following patch documents store merging improvements, > -fsanitize=builtin, -fsanitize=pointer-overflow and C++2A progress. This is the week of release notes updates, it seems? :-) > +The undefined behavior sanitizer gained two new options included

Re: C++ PATCH for c++/84221, bogus -Wunused with unused attribute on template

2018-04-04 Thread Jason Merrill
On Wed, Apr 4, 2018 at 3:58 PM, Jason Merrill wrote: > On Wed, Apr 4, 2018 at 3:52 PM, Martin Sebor wrote: >> On 04/04/2018 01:04 PM, Jason Merrill wrote: >>> >>> For bugs 54372 and 60063, we changed attributes used and unused to be >>> applied immediately in

Re: C++ PATCH for c++/84221, bogus -Wunused with unused attribute on template

2018-04-04 Thread Jason Merrill
On Wed, Apr 4, 2018 at 3:52 PM, Martin Sebor wrote: > On 04/04/2018 01:04 PM, Jason Merrill wrote: >> >> For bugs 54372 and 60063, we changed attributes used and unused to be >> applied immediately in a template even if what they apply to is >> dependent, to avoid bogus warnings

Re: [wwwdocs]Mention -ftree-loop-distribution

2018-04-04 Thread Gerald Pfeifer
On Wed, 4 Apr 2018, Bin.Cheng wrote: > Thanks for the suggestions, attachment is the updated change. Ah, I thought (and would have been fine) you'd go ahead and commit with those changes. ;-) Yes, this is okay. Thanks, Gerald

Re: [PATCH 1/2] wwwdocs: Add bin/gcc-color-to-html.py

2018-04-04 Thread Gerald Pfeifer
On Wed, 4 Apr 2018, David Malcolm wrote: > I've committed it to CVS, with the following changes: Lovely, thank you! Gerald

Re: C++ PATCH for c++/84221, bogus -Wunused with unused attribute on template

2018-04-04 Thread Martin Sebor
On 04/04/2018 01:04 PM, Jason Merrill wrote: For bugs 54372 and 60063, we changed attributes used and unused to be applied immediately in a template even if what they apply to is dependent, to avoid bogus warnings from maybe_warn_unused_local_typedefs. But that's only an issue for TYPE_DECL, so

Re: [C++ PATCH] Fix __builtin_constant_p constexpr handling (PR inline-asm/85172)

2018-04-04 Thread Jason Merrill
OK. On Wed, Apr 4, 2018 at 3:39 PM, Jakub Jelinek wrote: > Hi! > > As the following testcases show, potential_constant_expression_1 for some > builtins returns true no matter what their arguments contain (intentionally > so); the problem is that we call unconditionally >

Re: [PATCH 1/2] wwwdocs: Add bin/gcc-color-to-html.py

2018-04-04 Thread David Malcolm
On Wed, 2018-04-04 at 21:01 +0200, Gerald Pfeifer wrote: > On Wed, 4 Apr 2018, David Malcolm wrote: > > Here's the new script I've been using for converting from > > diagnostic-color.c output to HTML spans that use gcc.css, > > via something like: > > > > LANG=C gcc $@

[C++ PATCH] Fix invalid structured binding range for parsing error recovery (PR c++/85194)

2018-04-04 Thread Jakub Jelinek
Hi! The maybe_range_for_decl argument is documented on cp_parser_simple_declaration as: If MAYBE_RANGE_FOR_DECL is not NULL, the pointed tree will be set to the parsed declaration if it is an uninitialized single declarator not followed by a `;', or to error_mark_node otherwise. Either

Re: [PATCH] Add -C when using -Wimplicit-fallthrough and --save-temps (PR preprocessor/78497).

2018-04-04 Thread Marek Polacek
On Tue, Apr 03, 2018 at 02:29:37PM +0200, Martin Liška wrote: > Hi. > > This helps the warning with --save-temps. Doing that one needs to preserve > comments > in preprocessed source file. Do we really want to only use -C when -Wimplicit-fallthrough is in effect? I mean, shouldn't we always

Re: [committed 2/2] wwwdocs: Document my gcc 8 changes for the website (v2)

2018-04-04 Thread David Malcolm
On Wed, 2018-04-04 at 21:02 +0200, Gerald Pfeifer wrote: > On Wed, 4 Apr 2018, David Malcolm wrote: > > I made this version using gcc-color-to-html.py from the previous > > patch, > > to turn the SGR codes into spans for use with our gcc.css. > > Nice. Out of curiosity, did you do this manually

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-04 Thread Richard Biener
On April 4, 2018 8:25:25 PM GMT+02:00, Peter Bergner wrote: >On 4/4/18 10:43 AM, Peter Bergner wrote: >> On 4/4/18 2:15 AM, Richard Biener wrote: >>> On Tue, 3 Apr 2018, Peter Bergner wrote: >>> On 4/3/18 1:40 PM, H.J. Lu wrote: > On Tue, Apr 3, 2018 at 11:36 AM,

C++ PATCH for c++/85006, concepts ICE with A return type

2018-04-04 Thread Jason Merrill
Here tsubst_pack_expansion assumes that we should have arguments for all packs if we're not in a template, but we might not if there's an auto pack. Tested x86_64-pc-linux-gnu, applying to trunk. commit 445cd04fd16f17dd499f2f7eb2ac8a723e9071a4 Author: Jason Merrill Date: Wed

C++ PATCH for c++/84221, bogus -Wunused with unused attribute on template

2018-04-04 Thread Jason Merrill
For bugs 54372 and 60063, we changed attributes used and unused to be applied immediately in a template even if what they apply to is dependent, to avoid bogus warnings from maybe_warn_unused_local_typedefs. But that's only an issue for TYPE_DECL, so we can use the normal logic for other things.

Re: [committed 2/2] wwwdocs: Document my gcc 8 changes for the website (v2)

2018-04-04 Thread Gerald Pfeifer
On Wed, 4 Apr 2018, David Malcolm wrote: > I made this version using gcc-color-to-html.py from the previous patch, > to turn the SGR codes into spans for use with our gcc.css. Nice. Out of curiosity, did you do this manually in the past? Gerald

Re: [PATCH 1/2] wwwdocs: Add bin/gcc-color-to-html.py

2018-04-04 Thread Gerald Pfeifer
On Wed, 4 Apr 2018, David Malcolm wrote: > Here's the new script I've been using for converting from > diagnostic-color.c output to HTML spans that use gcc.css, > via something like: > > LANG=C gcc $@ -fdiagnostics-color=always 2>&1 > | ./bin/gcc-color-to-html.py > > The script converts

C++ PATCH for c++/85200, ICE with constexpr if in generic lambda

2018-04-04 Thread Jason Merrill
Since, during partial instantiation of a generic lambda, we don't substitute into the body of a constexpr if, we don't do lambda capture as part of substitution. But extract_locals_r is supposed to do it as part of remembering the substitution context to be used later. As it turns out, this was

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-04 Thread Peter Bergner
On 4/4/18 10:43 AM, Peter Bergner wrote: > On 4/4/18 2:15 AM, Richard Biener wrote: >> On Tue, 3 Apr 2018, Peter Bergner wrote: >> >>> On 4/3/18 1:40 PM, H.J. Lu wrote: On Tue, Apr 3, 2018 at 11:36 AM, Peter Bergner wrote: > gcc/testsuite/ > PR

[wwwdocs] gcc-8/changes.html additions

2018-04-04 Thread Bernd Edlinger
Hi, this adds a few gcc command line options to gcc-8/changes.html which I added for gcc-8. I have validated as XHTML 1.0 Transitional. Is it OK for wwwdocs? Thanks Bernd. ? patch-changes.diff Index: htdocs/gcc-8/changes.html

Re: [PATCH, testsuite, 2/2] Add scan-ltrans-tree-dump

2018-04-04 Thread Bernhard Reutner-Fischer
On 4 April 2018 at 10:59, Tom de Vries wrote: > On 04/03/2018 07:49 PM, Bernhard Reutner-Fischer wrote: >>> >>> This patch adds scan-ltrans-tree-dump. >> >> >> Please check all error calls to talk about the correct function -- at >> least scan-ltrans-tree-dump-times is

Re: [PATCH] c/55976 -Werror=return-type should error on returning a value from a void function

2018-04-04 Thread Martin Sebor
On 04/04/2018 11:15 AM, Jakub Jelinek wrote: On Tue, Apr 03, 2018 at 01:36:13PM -0600, Martin Sebor wrote: On 04/03/2018 10:26 AM, dave.pa...@oracle.com wrote: This patch fixes handlng of -Werror=return-type. Currently, even with the flag specified, return type errors remain warnings.

[PATCH 1/2] wwwdocs: Add bin/gcc-color-to-html.py

2018-04-04 Thread David Malcolm
Here's the new script I've been using for converting from diagnostic-color.c output to HTML spans that use gcc.css, via something like: LANG=C gcc $@ -fdiagnostics-color=always 2>&1 | ./bin/gcc-color-to-html.py The script converts SGR_SEQ(COLOR_BOLD) to a rather than so that it can use

[committed 2/2] wwwdocs: Document my gcc 8 changes for the website (v2)

2018-04-04 Thread David Malcolm
This patch incorporates your review suggestions. Successfully checked as XHTML 1.0 Transitional. I've committed it to CVS. I made this version using gcc-color-to-html.py from the previous patch, to turn the SGR codes into spans for use with our gcc.css. It adds various entries to the stylesheet

[PATCH 0/2] wwwdocs: Updates for gcc 8 changes (v2)

2018-04-04 Thread David Malcolm
On Mon, 2018-03-19 at 00:02 +0100, Gerald Pfeifer wrote: > Hi David, > > On Fri, 16 Mar 2018, David Malcolm wrote: > > This patch kit is for the website; I generated it against a local > > git mirror of the CVS repo. > > > > It adds lots of examples of colorized output from GCC, which > > I

Re: [PATCH] c/55976 -Werror=return-type should error on returning a value from a void function

2018-04-04 Thread Jakub Jelinek
On Tue, Apr 03, 2018 at 01:36:13PM -0600, Martin Sebor wrote: > On 04/03/2018 10:26 AM, dave.pa...@oracle.com wrote: > > This patch fixes handlng of -Werror=return-type. Currently, even with > > the flag specified, return type errors remain warnings. > > > >

Re: [PATCH 1/3] improve detection of attribute conflicts (PR 81544)

2018-04-04 Thread Jakub Jelinek
On Wed, Apr 04, 2018 at 06:51:00PM +0200, Andreas Krebbel wrote: > > On targets enforcing a function alignment bigger than 4 bytes this triggers > > an error instead: > > > > +inline int ATTR ((aligned (4))) > > +finline_hot_noret_align (int); /* { dg-warning "ignoring attribute > > .aligned

New Ukrainian PO file for 'gcc' (version 8.1-b20180401)

2018-04-04 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'gcc' has been submitted by the Ukrainian team of translators. The file is available at: http://translationproject.org/latest/gcc/uk.po (This file,

Re: [PATCH, GCC/ARM] Fix PR85203: cmse_nonsecure_caller returns wrong result

2018-04-04 Thread Thomas Preudhomme
Hi Kyrill, On 04/04/18 18:19, Kyrill Tkachov wrote: Hi Thomas, On 04/04/18 18:03, Thomas Preudhomme wrote: Hi, __builtin_cmse_nonsecure_caller implementation returns true in almost all cases due to 2 separate bugs: * gen_addsi is used instead of gen_andsi to retrieve the lsb * the lsb

Re: [PATCH, GCC/ARM] Fix PR85203: cmse_nonsecure_caller returns wrong result

2018-04-04 Thread Kyrill Tkachov
Hi Thomas, On 04/04/18 18:03, Thomas Preudhomme wrote: Hi, __builtin_cmse_nonsecure_caller implementation returns true in almost all cases due to 2 separate bugs: * gen_addsi is used instead of gen_andsi to retrieve the lsb * the lsb boolean value is not negated but the specification [1] says

Re: [PATCH 1/3] improve detection of attribute conflicts (PR 81544)

2018-04-04 Thread Martin Sebor
On 04/04/2018 10:51 AM, Andreas Krebbel wrote: On 04/04/2018 06:16 PM, Andreas Krebbel wrote: On 10/03/2017 12:23 AM, Jeff Law wrote: On 09/20/2017 12:04 PM, Martin Sebor wrote: On 09/19/2017 03:00 PM, Joseph Myers wrote: On Tue, 19 Sep 2017, Martin Sebor wrote: In general, the data

Re: [PATCH] Fix libbacktrace zdebug decompression on big endian (PR other/85161)

2018-04-04 Thread Ian Lance Taylor
On Tue, Apr 3, 2018 at 9:08 AM Jakub Jelinek wrote: > As mentioned in the PR, GCC (and clang) predefines > {__BYTE_ORDER__,__ORDER_{LITTLE,BIG,PDP}_ENDIAN__} > macros, and {,sys/,machine/}endian.h headers predefine > {,__}{BYTE_ORDER,{LITTLE,BIG,PDP}_ENDIAN} > macros (depending

Re: [PATCH, GCC/ARM] Fix PR85203: cmse_nonsecure_caller returns wrong result

2018-04-04 Thread Thomas Preudhomme
Oops, forgot the link. On 04/04/18 18:03, Thomas Preudhomme wrote: Hi, __builtin_cmse_nonsecure_caller implementation returns true in almost all cases due to 2 separate bugs: * gen_addsi is used instead of gen_andsi to retrieve the lsb * the lsb boolean value is not negated but the

Re: [PATCH] c/55976 -Werror=return-type should error on returning a value from a void function

2018-04-04 Thread dave . pagan
Hi Martin, Hadn't thought about, but you're right ... it should be consistent. Currently, -Wno-return-type has no effect on this warning, but it should. Since this patch does fix the original problem, what do you recommend? Scrap this patch? Or let it proceed and submit a new bug noting the

[PATCH, GCC/ARM] Fix PR85203: cmse_nonsecure_caller returns wrong result

2018-04-04 Thread Thomas Preudhomme
Hi, __builtin_cmse_nonsecure_caller implementation returns true in almost all cases due to 2 separate bugs: * gen_addsi is used instead of gen_andsi to retrieve the lsb * the lsb boolean value is not negated but the specification [1] says the intrinsic should return true for a nonsecure

Re: [PATCH 1/3] improve detection of attribute conflicts (PR 81544)

2018-04-04 Thread Andreas Krebbel
On 04/04/2018 06:16 PM, Andreas Krebbel wrote: > On 10/03/2017 12:23 AM, Jeff Law wrote: >> On 09/20/2017 12:04 PM, Martin Sebor wrote: >>> On 09/19/2017 03:00 PM, Joseph Myers wrote: On Tue, 19 Sep 2017, Martin Sebor wrote: >> In general, the data structures where you need to ensure 

C++ PATCH for c++/85148, ICE with 'this' in array NSDMI

2018-04-04 Thread Jason Merrill
Here, when we're trying to find the matching object for a PLACEHOLDER_EXPR, we need to look through ARRAY_REF. Fixed by using handled_component_p in the assert. Tested x86_64-pc-linux-gnu, applying to trunk and 7. commit 012c92312a0713370b54acaf3c9c7df3a03cae31 Author: Jason Merrill

C++ PATCH for c++/85141, ICE with compound assignment and static member function

2018-04-04 Thread Jason Merrill
Here the RHS has function type, so the stabilize_expr call in cp_build_modify_expr was trying to generate a temporary of function type, which is nonsensical. Fixed by using decay_conversion instead of rvalue, to turn it into a pointer. Tested x86_64-pc-linux-gnu, applying to trunk. commit

Re: [PATCH] [PR c++/84979] improve auto handling in explicit tmpl args for concepts

2018-04-04 Thread Alexandre Oliva
On Apr 4, 2018, Jason Merrill wrote: >> else >> expr = lookup_template_function (expr, template_args); >> + >> + /* We may be repeating a check already done during parsing, but >> +if it was well-formed and passed then, it will pass again >> +now, and if

C++ PATCH for c++/85118, wrong error with generic non-capturing lambda

2018-04-04 Thread Jason Merrill
Another problem caused by my change to consider template conversion operators in calls to an object: in this case, the operator() is not a viable candidate, so we try to use the conversion operator. Which ends up trying to instantiate the operator() to determine its return type, which fails. So,

Re: [PATCH] [PR c++/85039] no type definitions in builtin offsetof

2018-04-04 Thread Alexandre Oliva
On Apr 4, 2018, Jason Merrill wrote: > On Tue, Apr 3, 2018 at 11:25 PM, Alexandre Oliva wrote: >> I still think we could attempt to retain the extension as it is, parsing >> types introduced in data member initializers within the scope of the >> class

Re: [PATCH 1/3] improve detection of attribute conflicts (PR 81544)

2018-04-04 Thread Andreas Krebbel
On 10/03/2017 12:23 AM, Jeff Law wrote: > On 09/20/2017 12:04 PM, Martin Sebor wrote: >> On 09/19/2017 03:00 PM, Joseph Myers wrote: >>> On Tue, 19 Sep 2017, Martin Sebor wrote: >>> > In general, the data structures where you need to ensure manually that if > > attribute A is listed in 

Re: [wwwdocs] gcc-8/changes.html additions

2018-04-04 Thread Martin Sebor
On 04/04/2018 01:43 AM, Jakub Jelinek wrote: Hi! Following patch documents store merging improvements, -fsanitize=builtin, -fsanitize=pointer-overflow and C++2A progress. Ok for wwwdocs? --- changes.html3 Apr 2018 06:52:04 - 1.51 +++ changes.html4 Apr 2018 07:41:06

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-04 Thread Peter Bergner
On 4/4/18 2:15 AM, Richard Biener wrote: > On Tue, 3 Apr 2018, Peter Bergner wrote: > >> On 4/3/18 1:40 PM, H.J. Lu wrote: >>> On Tue, Apr 3, 2018 at 11:36 AM, Peter Bergner wrote: gcc/testsuite/ PR rtl-optimization/84878 * gcc.dg/pr84878.c:

C++ PATCH for c++/85133, ICE with missing concept initializer

2018-04-04 Thread Jason Merrill
Making the concept always satisfied seems good for error recovery. Tested x86_64-pc-linux-gnu, applying to trunk. commit c2e6a2a7e163f285891620e64144b45e1418870a Author: Jason Merrill Date: Tue Apr 3 16:40:02 2018 -0400 PR c++/85133 - ICE with missing concept

[PATCH v2, rs6000] Tidy implementation of vec_ldl

2018-04-04 Thread Kelvin Nilsen
This is a second draft of a draft patch originally submitted on 3/29.  This patch corrects inconsistencies in the supported prototypes for the vec_ldl built-in function.  Specifically, it removes support for:   vector int vec_ldl (int, long int *)   vector unsigned int vec_ldl (int, unsigned

C++ PATCH for c++/85135, ICE with omitted template arguments

2018-04-04 Thread Jason Merrill
A deduced class type can't appear in a function return type; we already check for that in a leading return type, but we weren't checking in a trailing return type. This fixes that, and return error_mark_node. Tested x86_64-pc-linux-gnu, applying to trunk. commit

Re: Fix -Wstringop-overflow regression

2018-04-04 Thread Michael Matz
Hi, On Wed, 4 Apr 2018, Richard Biener wrote: > Bootstrapped and tested ...? Err, yes, on x86-64, with all languages and without regressions. > OK. r259083. Ciao, Michael.

Re: [PATCH] [PR c++/85039] no type definitions in builtin offsetof

2018-04-04 Thread Jason Merrill
On Tue, Apr 3, 2018 at 11:25 PM, Alexandre Oliva wrote: > On Apr 3, 2018, Alexandre Oliva wrote: > >> On Apr 2, 2018, Jason Merrill wrote: >>> On Sat, Mar 31, 2018 at 7:12 AM, Alexandre Oliva wrote: struct a {

Re: [C++ PATCH] PR c++/65923

2018-04-04 Thread Jason Merrill
On Wed, Apr 4, 2018 at 10:35 AM, Ville Voutilainen wrote: > On 3 April 2018 at 17:19, Ville Voutilainen > wrote: >> * parser.c (cp_parser_unqualified_id): Add a new parameter >> and check it for the literal diagnostic. > > > As

Re: [C++ PATCH] PR c++/65923

2018-04-04 Thread Ville Voutilainen
On 3 April 2018 at 17:19, Ville Voutilainen wrote: > * parser.c (cp_parser_unqualified_id): Add a new parameter > and check it for the literal diagnostic. As discussed on irc, we can indeed do better. With this approach, we look at function declarations

Re: [PATCH] [PR c++/84979] improve auto handling in explicit tmpl args for concepts

2018-04-04 Thread Jason Merrill
On Tue, Apr 3, 2018 at 10:38 PM, Alexandre Oliva wrote: > On Apr 3, 2018, Jason Merrill wrote: > >> On Tue, Apr 3, 2018 at 3:54 AM, Alexandre Oliva wrote: >>> On Apr 2, 2018, Jason Merrill wrote: >>> On Sat, Mar

[committed] Fix g++.dg/inherit/override-attribs.C on ia32 (PR testsuite/85189)

2018-04-04 Thread Jakub Jelinek
Hi! r258898 changed the wording and changed error to inform for the second message and adjusted lots of testcases, but has not adjusted this one. Fixed thusly, tested on x86_64-linux with -m32/-m64, committed to trunk. 2018-04-04 Jakub Jelinek PR testsuite/85189

Re: Fix -Wstringop-overflow regression

2018-04-04 Thread Richard Biener
On Wed, Apr 4, 2018 at 3:34 PM, Michael Matz wrote: > Hi, > > we shouldn't claim string overflows for character arrays at > end of structures; the code that tries to avoid these > accidentally passed the address of the accessed member to > array_at_struct_end_p(), but that one wants

Re: [C++ PATCH] Fix __direct_bases ICE (PR c++/85146, take 2)

2018-04-04 Thread Jakub Jelinek
On Wed, Apr 04, 2018 at 09:25:43AM -0400, Jason Merrill wrote: > > -calculate_bases (tree type) > > +calculate_bases (tree type, tsubst_flags_t complain) > > { > > - vec *vector = make_tree_vector(); > > + vec *vector = make_tree_vector (); > > While we're touching

Re: [PATCH] Disable anchors and msdata for ASAN test-case (PR sanirizer/85174).

2018-04-04 Thread Jakub Jelinek
On Wed, Apr 04, 2018 at 12:14:43PM +0200, Martin Liška wrote: > Hi. > > It's test-case workaround, tested on x86_64 and powerpc with both -m64 and > -m32. > > Ready for trunk? > Thanks, > Martin > > gcc/testsuite/ChangeLog: > > 2018-04-04 Martin Liska > > PR

Fix -Wstringop-overflow regression

2018-04-04 Thread Michael Matz
Hi, we shouldn't claim string overflows for character arrays at end of structures; the code that tries to avoid these accidentally passed the address of the accessed member to array_at_struct_end_p(), but that one wants the component_ref or array_ref itself. Needs updating of one testcase that

Re: [C++ PATCH] Fix __direct_bases ICE (PR c++/85146, take 2)

2018-04-04 Thread Jason Merrill
On Wed, Apr 4, 2018 at 5:28 AM, Jakub Jelinek wrote: > On Tue, Apr 03, 2018 at 12:23:11PM -0400, Jason Merrill wrote: >> On Tue, Apr 3, 2018 at 12:06 PM, Jakub Jelinek wrote: >> >> > From N2965 it is unclear to me what should the trait do on classes with >> >

[PATCH] libgo: Avoid clobbering shell history file in signal_cgo_test.go

2018-04-04 Thread Andreas Schwab
For some reason signal_cgo_test.go needs to run an interactive shell, but suppresses reading the startup files. This causes the shell history file to be clobbered, by using different history settings than usual. Avoid that by setting HOME to / so that the shell cannot write a history file.

Re: [PATCH][GCC][mid-end] Allow larger copies when target supports unaligned access [Patch (1/2)]

2018-04-04 Thread Peter Bergner
On 4/4/18 4:06 AM, Tamar Christina wrote: > Now that I know how the loads are done, I have a patch should be both correct > and generate better code in most cases. > It just calculates bitsize inside the loop and does the copying in the > largest mode possible that's equal or less than the bits

[PATCH] Fix PR85176, LTO with -g1

2018-04-04 Thread Richard Biener
This fixes an issue with LTO handling DINFO_LEVEL_TERSE where we do not generate DIEs for NAMESPACE_DECLs and thus reconstruction of the DIE tree from DECL_CONTEXT at LTRANS time fails. The fix is to skip NAMESPACE_DECL contexts like we do for TYPE contexts. [LTO with -g1] Bootstrapped on

[PATCH] Fix PR85191

2018-04-04 Thread Richard Biener
Typo... Committed as obvious. Richard. 2018-04-04 Richard Biener PR testsuite/85191 * lib/target-supports.exp (check_effective_target_vect_perm_short): Fix typo. Index: gcc/testsuite/lib/target-supports.exp

Re: [PATCH] Disable anchors and msdata for ASAN test-case (PR sanirizer/85174).

2018-04-04 Thread Martin Liška
On 04/04/2018 12:29 PM, Segher Boessenkool wrote: > On Wed, Apr 04, 2018 at 12:21:14PM +0200, Jakub Jelinek wrote: >> On Wed, Apr 04, 2018 at 12:14:43PM +0200, Martin Liška wrote: >>> It's test-case workaround, tested on x86_64 and powerpc with both -m64 and >>> -m32. >>> >>> 2018-04-04 Martin

Re: [PATCH, rs6000] Undefine vector, bool, pixel in xmmintrin.h

2018-04-04 Thread Jakub Jelinek
On Sun, Apr 01, 2018 at 08:24:32PM -0500, Bill Schmidt wrote: > I also updated the gcc.target/powerpc/powerpc.exp file to allow C++ > tests to be placed in that directory (with a *.C suffix). I think this is wrong. Historically, we've been putting target C++ tests into g++.dg/*/*.C with

Re: [PATCH] Disable anchors and msdata for ASAN test-case (PR sanirizer/85174).

2018-04-04 Thread Segher Boessenkool
On Wed, Apr 04, 2018 at 12:21:14PM +0200, Jakub Jelinek wrote: > On Wed, Apr 04, 2018 at 12:14:43PM +0200, Martin Liška wrote: > > It's test-case workaround, tested on x86_64 and powerpc with both -m64 and > > -m32. > > > > 2018-04-04 Martin Liska > > > > PR

[PATCH] Disable anchors and msdata for ASAN test-case (PR sanirizer/85174).

2018-04-04 Thread Martin Liška
Hi. It's test-case workaround, tested on x86_64 and powerpc with both -m64 and -m32. Ready for trunk? Thanks, Martin gcc/testsuite/ChangeLog: 2018-04-04 Martin Liska PR sanirizer/85174 * c-c++-common/asan/pointer-compare-1.c: Disable section anchors

Re: [PATCH] Prefer mempcpy to memcpy on x86_64 target (PR middle-end/81657).

2018-04-04 Thread Martin Liška
PING^1 On 03/29/2018 02:31 PM, Martin Liška wrote: > On 03/29/2018 02:25 PM, Jakub Jelinek wrote: >> On Thu, Mar 29, 2018 at 01:28:13PM +0200, Martin Liška wrote: >>> On 03/28/2018 06:36 PM, Jakub Jelinek wrote: On Wed, Mar 28, 2018 at 06:30:21PM +0200, Martin Liška wrote: > ---

[C++ PATCH] Fix __direct_bases ICE (PR c++/85146, take 2)

2018-04-04 Thread Jakub Jelinek
On Tue, Apr 03, 2018 at 12:23:11PM -0400, Jason Merrill wrote: > On Tue, Apr 3, 2018 at 12:06 PM, Jakub Jelinek wrote: > > > From N2965 it is unclear to me what should the trait do on classes with > > incomplete types, but given that __bases already returns an empty pack, > >

[patch, libfortran, committed] Implement stop_numeric for minimal targets

2018-04-04 Thread Thomas König
Hello world, the recent patch to make the gfortran and libgomp testsuites more standard conforming, by replacing CALL ABORT() with STOP N, led to numerous testsuite failures on nvptx because stop_numeric was not implemented in minimal.c. I have committed the patch below in r259072 as obvious

RE: [PATCH][GCC][mid-end] Allow larger copies when target supports unaligned access [Patch (1/2)]

2018-04-04 Thread Tamar Christina
> -Original Message- > From: Alan Modra > Sent: Tuesday, April 3, 2018 14:16 > To: Richard Biener > Cc: Peter Bergner ; Tamar Christina > ; gcc-patches@gcc.gnu.org; nd ; > l...@redhat.com;

Re: [wwwdocs]Mention -ftree-loop-distribution

2018-04-04 Thread Bin.Cheng
On Wed, Apr 4, 2018 at 8:08 AM, Gerald Pfeifer wrote: > On Tue, 3 Apr 2018, Bin Cheng wrote: >> Option -ftree-loop-distribution is improved and enabled by default at >> -O3 for GCC8. This patch describes the change, is it OK? > > Index: htdocs/gcc-8/changes.html >

Re: [PATCH, testsuite, 2/2] Add scan-ltrans-tree-dump

2018-04-04 Thread Tom de Vries
On 04/03/2018 07:49 PM, Bernhard Reutner-Fischer wrote: This patch adds scan-ltrans-tree-dump. Please check all error calls to talk about the correct function -- at least scan-ltrans-tree-dump-times is wrong. Hi, thanks for noticing that. I'll update the patches to fix that. But I wonder

New template for 'gcc' made available

2018-04-04 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. (If you have any questions, send them to .) A new POT file for textual domain 'gcc' has been made available to the language teams for translation. It is archived as:

[PATCH] Fix PR85168

2018-04-04 Thread Richard Biener
The following fixes a bad propagation of abnormals in VN valueization. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2018-04-04 Richard Biener PR tree-optimization/85168 * tree-ssa-sccvn.c

[wwwdocs] gcc-8/changes.html additions

2018-04-04 Thread Jakub Jelinek
Hi! Following patch documents store merging improvements, -fsanitize=builtin, -fsanitize=pointer-overflow and C++2A progress. Ok for wwwdocs? --- changes.html3 Apr 2018 06:52:04 - 1.51 +++ changes.html4 Apr 2018 07:41:06 - @@ -113,6 +113,21 @@ a work-in-progress.

Re: [PATCH, rtl] Fix PR84878: Segmentation fault in add_cross_iteration_register_deps

2018-04-04 Thread Richard Biener
On Tue, 3 Apr 2018, Peter Bergner wrote: > On 4/3/18 1:40 PM, H.J. Lu wrote: > > On Tue, Apr 3, 2018 at 11:36 AM, Peter Bergner wrote: > >> gcc/testsuite/ > >> PR rtl-optimization/84878 > >> * gcc.dg/pr84878.c: New test. > > > > Wrong test filename. > >

Re: [wwwdocs]Mention -ftree-loop-distribution

2018-04-04 Thread Gerald Pfeifer
On Tue, 3 Apr 2018, Bin Cheng wrote: > Option -ftree-loop-distribution is improved and enabled by default at > -O3 for GCC8. This patch describes the change, is it OK? Index: htdocs/gcc-8/changes.html === +Classical loop nest

Re: [wwwdocs] gcc-8/changes.html

2018-04-04 Thread Gerald Pfeifer
On Tue, 3 Apr 2018, Martin Liška wrote: > I would like to document features I prepared in time frame of GCC 8. A few observations in addition what Martin (S.) provided (Thanks!): Index: htdocs/gcc-8/changes.html === + GCOV tool can