Re: RFA: PATCH to restore old behavior of debug_vec_tree

2013-07-09 Thread Lawrence Crowl
by default and fails to handle many C++ tree nodes. Fixed by adding debug_raw for vectree,va_gc and changing debug_vec_tree to use that. OK for trunk? Looks good to me. -- Lawrence Crowl

Re: [c++-concepts] code review

2013-06-10 Thread Lawrence Crowl
to me. -- Lawrence Crowl

Re: [patch] Hash table changes from cxx-conversion branch - config part

2013-05-29 Thread Lawrence Crowl
On 5/21/13, Diego Novillo dnovi...@google.com wrote: On May 13, 2013 Lawrence Crowl cr...@googlers.com wrote: I still have not heard from i386 or ia64 folks. Anyone? The i386 bits look fine to me as well. Please wait 48 hours to give the i386 maintainers a chance to object. Committed

Re: [patch] Hash table changes from cxx-conversion branch - config part

2013-05-13 Thread Lawrence Crowl
I still have not heard from i386 or ia64 folks. Anyone? On 4/24/13, Lawrence Crowl cr...@googlers.com wrote: This patch is a consolodation of the hash_table patches to the cxx-conversion branch for files under gcc/config. Recipients: config/arm/arm.c - ni...@redhat.com, ramana.radhakrish

Re: [patch] Hash table changes from cxx-conversion branch

2013-04-25 Thread Lawrence Crowl
On 4/25/13, Richard Biener richard.guent...@gmail.com wrote: Thus, the patch is ok apart from the var-tracking.c bits which I defer to respective maintainers. Okay, I split out the var-tracking.c changes. I've committed the rest to trunk. -- Lawrence Crowl

Re: [patch] Hash table changes from cxx-conversion branch

2013-04-25 Thread Lawrence Crowl
On 4/25/13, Diego Novillo dnovi...@google.com wrote: On 2013-04-24 15:58 , Lawrence Crowl wrote: * var-tracking.c'emit_note_data_def.vars * var-tracking.c'shared_hash_def.htab * var-tracking.c'changed_variables Fold variable_htab_hash, variable_htab_eq, variable_htab_free into new struct

[patch] Hash table changes from cxx-conversion branch - config part

2013-04-24 Thread Lawrence Crowl
/ChangeLog 2013-04-24 Lawrence Crowl cr...@google.com * config/arm/t-arm: Update for below. * config/arm/arm.c (arm_libcall_uses_aapcs_base::libcall_htab): Change type to hash_table. Update dependent calls and types. * config/i386/t-cygming: Update for below

Re: Comments on the suggestion to use infinite precision math for wide int.

2013-04-08 Thread Lawrence Crowl
// zero extend See http://www.cplusplus.com/reference/type_traits/is_signed/. If you want to handle non-builtin types that are asigne dor unsigned, then you need to add a specialization for is_signed. -- Lawrence Crowl

Re: Comments on the suggestion to use infinite precision math for wide int.

2013-04-08 Thread Lawrence Crowl
operands to larger operands, so I think a reasonable definition is possible here. -- Lawrence Crowl

Re: Comments on the suggestion to use infinite precision math for wide int.

2013-04-08 Thread Lawrence Crowl
and the target machine. Yes, that's a correct understanding In essence, you have moved some of the optimization from the back end to the front end. Correct? -- Lawrence Crowl

Re: [patch] Hash table changes from cxx-conversion branch

2013-04-08 Thread Lawrence Crowl
Ping? On 3/31/13, Lawrence Crowl cr...@googlers.com wrote: On 3/28/13, Richard Biener richard.guent...@gmail.com wrote: On Mar 27, 2013 Lawrence Crowl cr...@googlers.com wrote: On 3/27/13, Richard Biener richard.guent...@gmail.com wrote: On Mar 23, 2013 Lawrence Crowl cr...@googlers.com

Re: [patch] Remove unused ivtype_map symbols from sese.[hc]

2013-04-02 Thread Lawrence Crowl
On 4/2/13, Richard Biener richard.guent...@gmail.com wrote: On Mon, Apr 1, 2013 at 12:19 AM, Lawrence Crowl cr...@googlers.com wrote: Remove unused symbols related to ivtype_map. This map does not appear to exist and I see no evidence of its removal in the ChangeLog. Tested on x86_64. Okay

[patch] Remove unused ivtype_map symbols from sese.[hc]

2013-03-31 Thread Lawrence Crowl
Remove unused symbols related to ivtype_map. This map does not appear to exist and I see no evidence of its removal in the ChangeLog. Tested on x86_64. Okay for trunk? Index: gcc/ChangeLog 2013-03-31 Lawrence Crowl cr...@google.com * sese.h (struct ivtype_map_elt_s): Remove unused

Re: [patch] Remove unused code from dse.c.

2013-03-30 Thread Lawrence Crowl
without the callback. Lawrence, that's the critical bit of information you failed to provide. Sorry. Patch approved, please install. Committed. -- Lawrence Crowl

[patch] Remove unused symbols.

2013-03-29 Thread Lawrence Crowl
(extern insert_loop_close_phis): Removed unused. (extern insert_guard_phis): Removed unused. (extern ivtype_map_elt_info): Removed unused. (new_ivtype_map_elt): Removed unused. * sese.c (ivtype_map_elt_info): Removed unused. 2013-03-28 Lawrence Crowl cr...@google.com

[patch] Remove unused code from dse.c.

2013-03-29 Thread Lawrence Crowl
that are then never read. Tested on x86-64. Index: gcc/ChangeLog 2013-03-29 Lawrence Crowl cr...@google.com * dse.c (clear_alias_sets): Remove never set. (disqualified_clear_alias_sets): Remove never set. (clear_alias_mode_pool): Remove never set. (dse_step0

Re: [patch] Remove unused code from dse.c.

2013-03-29 Thread Lawrence Crowl
On 3/29/13, Jeff Law l...@redhat.com wrote: On 03/29/2013 02:24 AM, Lawrence Crowl wrote: This patch has been in the hash-table branch for months. I thought it didn't quite meet the criteria for obvious, but it's close. In dse.c, remove alias hash tables that are never set. Remove

Re: [patch] Unified debug dump function names.

2013-03-28 Thread Lawrence Crowl
On 3/28/13, Richard Biener richard.guent...@gmail.com wrote: The patch is ok as-is. Committed. -- Lawrence Crowl

Re: [patch] Unified debug dump function names.

2013-03-27 Thread Lawrence Crowl
On 3/27/13, Richard Biener richard.guent...@gmail.com wrote: On Mar 27, 2013, Lawrence Crowl cr...@googlers.com wrote: Patch with rename to debug attached. Tested on x86_64. Add uniform debug dump function names. Add some overloaded functions that provide uniform debug dump function

Re: [patch] Hash table changes from cxx-conversion branch

2013-03-27 Thread Lawrence Crowl
On 3/27/13, Richard Biener richard.guent...@gmail.com wrote: On Mar 23, 2013 Lawrence Crowl cr...@googlers.com wrote: This patch is a consolodation of the hash_table patches to the cxx-conversion branch. Update various hash tables from htab_t to hash_table. Modify types and calls

Re: [patch] Unified debug dump function names.

2013-03-26 Thread Lawrence Crowl
On 3/26/13, Richard Biener richard.guent...@gmail.com wrote: On Mar 25, 2013 Lawrence Crowl cr...@googlers.com wrote: On 3/25/13, Richard Biener richard.guent...@gmail.com wrote: You add a not used new interface. What for? So that people can use it. For use from gdb only

Re: [patch] Unified debug dump function names.

2013-03-26 Thread Lawrence Crowl
On 3/26/13, Lawrence Crowl cr...@googlers.com wrote: On 3/26/13, Richard Biener richard.guent...@gmail.com wrote: On Mar 25, 2013 Lawrence Crowl cr...@googlers.com wrote: On 3/25/13, Richard Biener richard.guent...@gmail.com wrote: You add a not used new interface. What for? So

Re: [patch] Unified debug dump function names.

2013-03-25 Thread Lawrence Crowl
? -- Lawrence Crowl

Re: [patch] Unified debug dump function names.

2013-03-25 Thread Lawrence Crowl
On 3/25/13, Tom Tromey tro...@redhat.com wrote: Lawrence == Lawrence Crowl cr...@googlers.com writes: Lawrence This patch is somewhat different from the original plan at Lawrence gcc.gnu.org/wiki/cxx-conversion/debugging-dumps. The reason Lawrence is that gdb has an incomplete implementation

Re: [cxx-conversion] RFC - Helper types for building GIMPLE

2013-03-13 Thread Lawrence Crowl
*/ -- Lawrence Crowl

Re: [cxx-conversion] Add Record Builder Class

2013-02-14 Thread Lawrence Crowl
On 2/14/13, Richard Biener richard.guent...@gmail.com wrote: On Tue, Feb 12, 2013 at 8:47 PM, Lawrence Crowl cr...@google.com wrote: Add class record_builder to ease construction of records and unions. Use it in some appropriate places. tree -default_emutls_var_fields (tree type

Re: [cxx-conversion] Add Record Builder Class

2013-02-13 Thread Lawrence Crowl
On 2/13/13, Diego Novillo dnovi...@google.com wrote: On Tue, Feb 12, 2013 at 2:47 PM, Lawrence Crowl cr...@google.com wrote: @@ -182,24 +163,9 @@ default_emutls_var_init (tree to, tree d static tree get_emutls_object_type (void) { - tree type, type_name, field; - - type

Re: [cxx-conversion] Add Record Builder Class

2013-02-13 Thread Lawrence Crowl
On 2/13/13, Diego Novillo dnovi...@google.com wrote: Thanks. The patch is OK for the branch. You can address Nathan's review after he's back and gets a chance to look at it. Let me know when the patch is in. I've got another merge in process. Committed. -- Lawrence Crowl

[cxx-conversion] Add Record Builder Class

2013-02-12 Thread Lawrence Crowl
+ + #endif /* GCC_TREE_H */ -- Lawrence Crowl

Re: [PATCH 1/2] [asan] Allow creating/deleting hash table entries with new/delete

2013-01-28 Thread Lawrence Crowl
) +{ + delete p; +} /* Helpful type for a no-op remove. */ -- 1.7.11.7 -- Dodji -- Lawrence Crowl

Re: [cxx-conversion] Change uses of htab_t in gcc/config to hash_table.

2013-01-06 Thread Lawrence Crowl
); which is not as friendly. Agreed. Agreed. The current structure was handy in the conversion process. Now that the conversion is done, we could change the order. David On Tue, Dec 18, 2012 at 8:02 PM, Lawrence Crowl cr...@googlers.com wrote: Update various config htab_t uses to hash_table

[google 4_7] backport std::unique_ptrT[], D improvements

2013-01-03 Thread Lawrence Crowl
{ target *-*-* } 1776 } +// { dg-error static assertion failed { target *-*-* } 1778 } #include utility -- Lawrence Crowl

Re: [patch] std::unique_ptrT[], D improvements

2013-01-03 Thread Lawrence Crowl
only correct conversions. As Jonathan notes, Howard has objected to that part of the PR, so it's possible the eventual resolution will differ in that respect; I intend to pick up that discussion next week when I'm back from vacation. BTW, I've attached my latest set of tests. -- Lawrence Crowl

Re: [patch] std::unique_ptrT[], D improvements

2013-01-01 Thread Lawrence Crowl
On 12/28/12, Jonathan Wakely jwakely@gmail.com wrote: On 28 December 2012 01:51, Lawrence Crowl wrote: I'm not getting errors when converting from derived to base. E.g. the following compiles, when it should not. std::unique_ptrconst base [] acb_ad(new derived[3]); I get an error: shm

Re: [patch] std::unique_ptrT[], D improvements

2013-01-01 Thread Lawrence Crowl
On 1/1/13, Jonathan Wakely jwakely@gmail.com wrote: On 1 January 2013 20:40, Lawrence Crowl wrote: That was pilot error on my part. However, I've been having trouble when the argument to the constructor or reset has a conversion operator. The code does distinquish between a safe

Re: [patch] std::unique_ptrT[], D improvements

2012-12-27 Thread Lawrence Crowl
to Geoffrey and Lawrence for input and test cases. Tested x86_64-linux, committed to trunk. I'm not getting errors when converting from derived to base. E.g. the following compiles, when it should not. std::unique_ptrconst base [] acb_ad(new derived[3]); -- Lawrence Crowl

Re: [PATCH] Fix up sbitmap bitmap_{and,ior,xor} (PR target/55562)

2012-12-18 Thread Lawrence Crowl
) sbitmap_verify_popcount (dst); #endif - return anychange; + return changed != 0; } /* Return nonzero if A is a subset of B. */ -- Lawrence Crowl

[cxx-conversion] Change uses of htab_t in gcc/config to hash_table.

2012-12-18 Thread Lawrence Crowl
. */ -- Lawrence Crowl

[cxx-conversion] Convert remaining tree-parloops.c htab_t to hash_table.

2012-12-17 Thread Lawrence Crowl
); /* Parallelization will cause new function calls to be inserted through -- Lawrence Crowl

[cxx-conversion] Change tree-ssa-coalesce.c'coalesce_list_d.list to hash_table

2012-12-17 Thread Lawrence Crowl
); tree var2 = ssa_name (node-second_element); -- Lawrence Crowl

Re: [cxx-conversion] Change tree-ssa-coalesce.c'coalesce_list_d.list to hash_table

2012-12-17 Thread Lawrence Crowl
On 12/17/12, Richard Biener richard.guent...@gmail.com wrote: On Mon, Dec 17, 2012 at 8:36 PM, Lawrence Crowl cr...@googlers.com wrote: Change tree-ssa-coalesce.c'coalesce_list_d.list from htab_t to hash_table. Fold coalesce_pair_map_hash and coalesce_pair_map_eq into new struct

Re: [cxx-conversion] Convert tree-sra.c'candidates to hash_table

2012-12-16 Thread Lawrence Crowl
On 12/13/12, Martin Jambor mjam...@suse.cz wrote: On Thu, Dec 13, 2012 at 11:05:49AM -0800, Lawrence Crowl wrote: On 12/12/12, Jakub Jelinek ja...@redhat.com wrote: On Tue, Dec 11, 2012 at 02:44:41PM -0800, Lawrence Crowl wrote: +/* Hash a tree in a uid_decl_map. */ + +inline

Re: [cxx-conversion] Convert tree-sra.c'candidates to hash_table

2012-12-12 Thread Lawrence Crowl
On 12/12/12, Diego Novillo dnovi...@google.com wrote: On Dec 11, 2012 Lawrence Crowl cr...@googlers.com wrote: Convert tree-sra.c'candidates from htab_t to hash_table. Fold uid_decl_map_hash and uid_decl_map_eq into new struct uid_decl_hasher. This change moves the definitions from tree

[cxx-conversion] Convert tree-sra.c'candidates to hash_table

2012-12-11 Thread Lawrence Crowl
) $(GIMPLE_H) $(CGRAPH_H) $(TREE_FLOW_H) \ $(IPA_PROP_H) $(DIAGNOSTIC_H) statistics.h \ $(PARAMS_H) $(TARGET_H) $(FLAGS_H) \ $(DBGCNT_H) $(TREE_INLINE_H) $(GIMPLE_PRETTY_PRINT_H) -- Lawrence Crowl

[cxx-conversion] Convert various htab_t tables to hash_table

2012-12-11 Thread Lawrence Crowl
true if the loop body BODY includes any function calls. */ -- Lawrence Crowl

[cxx-conversion] Convert tree-vectorizer.h'_loop_vec_info::peeling_htab to hash_table

2012-12-11 Thread Lawrence Crowl
()) +LOOP_VINFO_PEELING_HTAB (loop_vinfo).create (1); vectype = STMT_VINFO_VECTYPE (stmt_info); nelements = TYPE_VECTOR_SUBPARTS (vectype); -- Lawrence Crowl

[cxx-conversion] Fix hash_table build problems with checking enabled.

2012-12-10 Thread Lawrence Crowl
)); + gcc_assert (hash (p1) == hash (p2)); #endif - return 1; + return true; } struct gimplify_ctx -- Lawrence Crowl

Re: [cxx-conversion] gimplify_ctx::temp_htab hash table

2012-12-04 Thread Lawrence Crowl
On 12/4/12, Diego Novillo dnovi...@google.com wrote: On Tue, Dec 4, 2012 at 4:23 AM, Richard Biener richard.guent...@gmail.com wrote: On Mon, Dec 3, 2012 at 9:14 PM, Lawrence Crowl cr...@googlers.com wrote: On 12/3/12, Diego Novillo dnovi...@google.com wrote: On 2012-12-01 20:44 , Lawrence

Re: [cxx-conversion] various hash tables, part 1/2

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo dnovi...@google.com wrote: On Sat, Dec 1, 2012 at 8:47 PM, Lawrence Crowl cr...@googlers.com wrote: +inline bool +attribute_hasher::equal (const value_type *spec, const compare_type *str) +{ + return (!strncmp (spec-name, str-str, str-length) I have a slight

Re: [cxx-conversion] various hash tables, part 1/2

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo dnovi...@google.com wrote: On 2012-12-03 14:24 , Lawrence Crowl wrote: -static int -htab_cu_eq (const void *of1, const void *of2) +inline bool +cu_hash_table_entry_hasher::equal (const value_type *entry1, + const compare_type *entry2

Re: [cxx-conversion] various hash tables, part 2/2

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo dnovi...@google.com wrote: On 2012-12-01 20:48 , Lawrence Crowl wrote: +inline bool +cselib_hasher::equal (const value_type *v, const compare_type *x_arg) +{ + struct elt_loc_list *l; + rtx x = CONST_CAST_RTX (x_arg); + enum machine_mode mode = GET_MODE (x

Re: [cxx-conversion] ggc-common hash tables

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo dnovi...@google.com wrote: On 2012-12-01 20:46 , Lawrence Crowl wrote: Index: gcc/ChangeLog 2012-11-30 Lawrence Crowl cr...@google.com * hash-table.h (class hash_table): Correct many methods with parameter types compare_type to the correct

Re: [cxx-conversion] tree-related hash tables

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo dnovi...@google.com wrote: On 2012-12-01 20:45 , Lawrence Crowl wrote: Index: gcc/tree-hasher.h === --- gcc/tree-hasher.h(revision 0) +++ gcc/tree-hasher.h(revision 0) @@ -0,0 +1,56

Re: [cxx-conversion] gimplify_ctx::temp_htab hash table

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo dnovi...@google.com wrote: On 2012-12-01 20:44 , Lawrence Crowl wrote: Index: gcc/gimple-fold.c === --- gcc/gimple-fold.c(revision 193902) +++ gcc/gimple-fold.c(working copy) @@ -30,6

Re: [cxx-conversion] LTO-related hash tables

2012-12-03 Thread Lawrence Crowl
On 12/3/12, Diego Novillo dnovi...@google.com wrote: On 2012-12-01 20:40 , Lawrence Crowl wrote: Change LTO-related hash tables from htab_t to hash_table: lto-streamer.h output_block::string_hash_table lto-streamer-in.c file_name_hash_table lto-streamer.c tree_htab The struct

[cxx-conversion] LTO-related hash tables

2012-12-01 Thread Lawrence Crowl
. Okay for branch? Index: gcc/ChangeLog 2012-11-30 Lawrence Crowl cr...@google.com * data-streamer.h (struct string_slot): Move to lto-streamer.h. (hash_string_slot_node): Move implementation into lto-streamer.h struct string_slot_hasher. (eq_string_slot_node

[cxx-conversion] graphite-related hash tables

2012-12-01 Thread Lawrence Crowl
unused: insert_loop_close_phis insert_guard_phis debug_ivtype_map ivtype_map_elt_info new_ivtype_map_elt Tested on x86-64. Okay for branch? Index: gcc/ChangeLog 2012-11-30 Lawrence Crowl cr...@google.com * graphite-htab.h: New. (typedef hash_table bb_pbb_hasher

[cxx-conversion] gimplify_ctx::temp_htab hash table

2012-12-01 Thread Lawrence Crowl
Change gimplify.c gimplify_ctx::temp_htab hash table from htab_t to hash_table. Move struct gimple_temp_hash_elt and struct gimplify_ctx to a new gimplify-ctx.h, because they are used few places. Tested on x86-64. Okay for branch? Index: gcc/ChangeLog 2012-11-30 Lawrence Crowl cr

[cxx-conversion] tree-related hash tables

2012-12-01 Thread Lawrence Crowl
dependences and because they are used in few places. Tested on x86-64. Okay for branch? Index: gcc/ChangeLog 2012-11-30 Lawrence Crowl cr...@google.com * tree-hasher.h: New. (struct int_tree_hasher): New. (typedef int_tree_htab_type): New. * tree-flow.h (extern

[cxx-conversion] ggc-common hash tables

2012-12-01 Thread Lawrence Crowl
to notice the change, but incorrect code will.) Tested on x86-64. Okay for branch? Index: gcc/ChangeLog 2012-11-30 Lawrence Crowl cr...@google.com * hash-table.h (class hash_table): Correct many methods with parameter types compare_type to the correct value_type

Re: [patch] Contribute performance comparison script.

2012-11-06 Thread Lawrence Crowl
On 11/6/12, Diego Novillo dnovi...@google.com wrote: On Nov 5, 2012 Lawrence Crowl cr...@googlers.com wrote: 2012-11-05 Lawrence Crowl cr...@google.com * compare_two_ftime_report_sets: New. OK. Thanks. Committed. -- Lawrence Crowl

[patch] Contribute performance comparison script.

2012-11-05 Thread Lawrence Crowl
on x86_64 builds. Okay for trunk? Index: contrib/ChangeLog 2012-11-05 Lawrence Crowl cr...@google.com * compare_two_ftime_report_sets: New. Index: contrib/compare_two_ftime_report_sets === --- contrib

Re: [patch] Apply conditional down cast to cgraph.h et.al.

2012-11-02 Thread Lawrence Crowl
On 11/2/12, Eric Botcazou ebotca...@adacore.com wrote: Index: gcc/ChangeLog 2012-10-31 Lawrence Crowl cr...@google.com * is-a.h: New. (is_a T (U*)): New. Test for is-a relationship. (as_a T (U*)): New. Treat as a derived type. (dyn_cast T (U*)): New. Conditionally

Re: [patch] Normalize more bitmap function names.

2012-11-01 Thread Lawrence Crowl
On 11/1/12, Diego Novillo dnovi...@google.com wrote: On 2012-10-31 13:41 , Lawrence Crowl wrote: This patch normalizes more bitmap function names. sbitmap.h TEST_BIT - bitmap_bit_p SET_BIT - bitmap_set_bit I wonder if it wouldn't it be more consistent if TEST_BIT became

Re: [patch] Normalize bitmap iteration.

2012-11-01 Thread Lawrence Crowl
On 11/1/12, Diego Novillo dnovi...@google.com wrote: On 2012-10-31 13:43 , Lawrence Crowl wrote: Rename the EXECUTE_IF_SET_IN_SBITMAP macro to EXECUTE_IF_SET_IN_BITMAP. Its implementation is now identical to that in bitmap.h. To prevent redefinition errors, both definitions are now

Re: [patch] Remove unused ebitmap and unused sbitmap functions.

2012-11-01 Thread Lawrence Crowl
On 11/1/12, Diego Novillo dnovi...@google.com wrote: On 2012-10-31 18:47 , Lawrence Crowl wrote: 2012-10-31 Lawrence Crowl cr...@google.com * ebitmap.h: Remove unused. * ebitmap.c: Remove unused. * Makefile.in: Remove ebitmap.h and ebitmap.c. * sbitmap.h

[patch] Normalize bitmap iteration.

2012-10-31 Thread Lawrence Crowl
declared in contexts where the bitmap type is not obvious. There are less than 40 uses of this type, so the burden to modify it when changing bitmap types is not large. Tested on x86-64, config-list.mk testing in progress. Okay for trunk? Index: gcc/ChangeLog 2012-10-31 Lawrence Crowl cr

[patch] Remove unused ebitmap and unused sbitmap functions.

2012-10-31 Thread Lawrence Crowl
to the implementation file: SBITMAP_SIZE_BYTES sbitmap_verify_popcount Tested on x86-64. Okay for trunk? Index: gcc/ChangeLog 2012-10-31 Lawrence Crowl cr...@google.com * ebitmap.h: Remove unused. * ebitmap.c: Remove unused. * Makefile.in: Remove ebitmap.h and ebitmap.c

Re: [patch] Unify bitmap interface.

2012-10-30 Thread Lawrence Crowl
and changed them as well. The only two sets of functions that will remain separate for now are the iterators and the bitmap creation routines, I think. Lawrence? The iterator functions have been unified, but not the iterator type names. -- Lawrence Crowl

Re: [patch] Apply conditional down cast to cgraph.h et.al.

2012-10-30 Thread Lawrence Crowl
On 10/30/12, Diego Novillo dnovi...@google.com wrote: On 2012-10-29 15:01 , Lawrence Crowl wrote: On 10/27/12, Marc Glisse marc.gli...@inria.fr wrote: On Fri, 26 Oct 2012, Lawrence Crowl wrote: 2012-10-26 Lawrence Crowl cr...@google.com missing '' Fixed. * is-a.h: New. (is_a T

Re: [patch] Apply conditional down cast to cgraph.h et.al.

2012-10-30 Thread Lawrence Crowl
On 10/30/12, Diego Novillo dnovi...@google.com wrote: On Tue, Oct 30, 2012 at 4:53 PM, Lawrence Crowl cr...@googlers.com wrote: On 10/30/12, Diego Novillo dnovi...@google.com wrote: So, to use these three functions, the user must define this single 'is_a_helper' routine? Nothing else? You

Re: GCC 4.8.0 Status Report (2012-10-29), Stage 1 to end soon

2012-10-30 Thread Lawrence Crowl
. Comments? -- Lawrence Crowl

Re: [patch] Unify bitmap interface.

2012-10-29 Thread Lawrence Crowl
On 10/29/12, Richard Biener richard.guent...@gmail.com wrote: On Oct 29, 2012 Diego Novillo dnovi...@google.com wrote: On Oct 25, 2012 Lawrence Crowl cr...@googlers.com wrote: The sbitmap non-bool returning bitwise operations have been merged with the bool versions. Sometimes this merge

Re: [patch] Apply conditional down cast to cgraph.h et.al.

2012-10-29 Thread Lawrence Crowl
On 10/27/12, Marc Glisse marc.gli...@inria.fr wrote: On Fri, 26 Oct 2012, Lawrence Crowl wrote: 2012-10-26 Lawrence Crowl cr...@google.com missing '' Fixed. * is-a.h: New. (is_a T (U*)): New. Test for is-a relationship. (as_a T (U*)): New. Treat as a derived type

Re: [patch] Unify bitmap interface.

2012-10-29 Thread Lawrence Crowl
On 10/29/12, Diego Novillo dnovi...@google.com wrote: On Oct 29, 2012 Lawrence Crowl cr...@googlers.com wrote: The sbitmap popcount function is only used in ebitmap, which is itself not used. If we do anything, removing them might be the thing to do. Yes, please. Separate patch, please

Re: Change hash_table for separate comparator, documentation, cleanups...

2012-10-26 Thread Lawrence Crowl
On 10/26/12, Richard Biener richard.guent...@gmail.com wrote: On Oct 25, 2012 Lawrence Crowl cr...@googlers.com wrote: Change hash_table to support a comparator type different from the value type stored in the hash table. The 'find' functions now may take a different type from the value

[patch] Apply conditional down cast to cgraph.h et.al.

2012-10-26 Thread Lawrence Crowl
to varpool_node_for_decl. Tested on x86_64. Okay for trunk? Index: gcc/ChangeLog 2012-10-26 Lawrence Crowl cr...@google.com * is-a.h: New. (is_a T (U*)): New. Test for is-a relationship. (as_a T (U*)): New. Treat as a derived type. (dyn_cast T (U*)): New

Re: [patch] Unify bitmap interface.

2012-10-26 Thread Lawrence Crowl
On 10/25/12, Lawrence Crowl cr...@googlers.com wrote: This patch implements the unification of the *bitmap interfaces as discussed. Essentially, we rename ebitmap and sbitmap functions to use the same names as the bitmap functions. This rename works because we can now overload on the bitmap

Change hash_table for separate comparator, documentation, cleanups...

2012-10-25 Thread Lawrence Crowl
typedefs value_type and compare_type instead of T. Change all users to match. Add usage documentation to hash-table.h. Tested on x86-64. Okay for trunk? Index: gcc/ChangeLog 2012-10-25 Lawrence Crowl cr...@google.com * hash-table.h: Add usage documentation. (template struct

Re: patch to fix constant math - 4th patch - the wide-int class.

2012-10-23 Thread Lawrence Crowl
. Lawrence? Yes, in C++11, wide_int::zero ({32, 32}) is possible using an implicit conversion to WIntSpec from an initializer_list. However, at present we are limited to C++03 to enable older compilers as boot compilers. -- Lawrence Crowl

Re: patch to fix constant math - 4th patch - the wide-int class.

2012-10-23 Thread Lawrence Crowl
. In the case of double int, the goal was to simplify use of the existing semantics. If you are changing the semantics, consider incorporating sign explicitly. -- Lawrence Crowl

Re: patch to fix constant math - 4th patch - the wide-int class.

2012-10-23 Thread Lawrence Crowl
On 10/23/12, Kenneth Zadeck zad...@naturalbridge.com wrote: On 10/23/2012 02:38 PM, Lawrence Crowl wrote: On 10/23/12, Kenneth Zadeck zad...@naturalbridge.com wrote: On 10/23/2012 10:12 AM, Richard Biener wrote: + inline bool minus_one_p () const; + inline bool zero_p () const; + inline

Re: [PATCH][RFC] Re-organize how we stream trees in LTO

2012-10-22 Thread Lawrence Crowl
be fine. -- Lawrence Crowl

Re: wide int patch #6: Replacement of hwi extraction from int-csts.

2012-10-22 Thread Lawrence Crowl
conversion operators to achieve the effect. However, we probably don't want to do so until we can make them explicit. Unfortunately, explicit conversion operators are not available until C++11. No, I don't want you to do the above transform with this patch ;) -- Lawrence Crowl

Re: Use conditional casting with symtab_node

2012-10-13 Thread Lawrence Crowl
On 10/12/12, Richard Biener richard.guent...@gmail.com wrote: On Oct 11, 2012 Xinliang David Li davi...@google.com wrote: On Oct 11, 2012 Lawrence Crowl cr...@googlers.com wrote: On 10/10/12, Xinliang David Li davi...@google.com wrote: In a different thread, I proposed the following

Re: Add usage documentation for hash_table

2012-10-13 Thread Lawrence Crowl
Descr, Allocator -::traverse (Argument argument) +hash_table Descr, Allocator::traverse (Argument argument) { size_t size = htab-size; if (elements () * 8 size size 32) -- Lawrence Crowl

Re: Use conditional casting with symtab_node

2012-10-11 Thread Lawrence Crowl
()) versus if (cgraph_node *q = p-cast_to cgraph_node * ()) I thought the latter would generate objections. Does anyone object to the extra typing? If not, I can make that change. -- Lawrence Crowl

Re: Convert more non-GTY htab_t to hash_table.

2012-10-09 Thread Lawrence Crowl
On 10/5/12, Diego Novillo dnovi...@google.com wrote: On Oct 3, 2012 Lawrence Crowl cr...@googlers.com wrote: Change more non-GTY hash tables to use the new type-safe template hash table. Constify member function parameters that can be const. Correct a couple of expressions in formerly

Re: Use conditional casting with symtab_node

2012-10-09 Thread Lawrence Crowl
On 10/5/12, Jan Hubicka hubi...@ucw.cz wrote: On Thu, Oct 4, 2012 at 8:16 PM, Diego Novillo dnovi...@google.com wrote: On Thu, Oct 4, 2012 at 2:14 PM, Lawrence Crowl cr...@googlers.com wrote: So, Jan Hubicka requested and approved the current spelling. What now? I don't think we

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Lawrence Crowl
On 10/5/12, Richard Guenther rguent...@suse.de wrote: On Thu, 4 Oct 2012, Lawrence Crowl wrote: On 10/4/12, Richard Guenther rguent...@suse.de wrote: On Tue, 2 Oct 2012, Lawrence Crowl wrote: On 10/2/12, Richard Guenther rguent...@suse.de wrote: On Mon, 1 Oct 2012, Lawrence Crowl wrote

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Lawrence Crowl
Could you please review the patch at http://www.mail-archive.com/gcc-patches@gcc.gnu.org/msg40961.html? On 10/3/12, Lawrence Crowl cr...@googlers.com wrote: Sorry, one more time with the right file contents. On 10/2/12, Richard Guenther rguent...@suse.de wrote: You are changing a hashtable

Re: Use conditional casting with symtab_node

2012-10-05 Thread Lawrence Crowl
that much attention to over the years. I just don't believe the 0.5% numbers. Then ask. Don't mock, please. -- Lawrence Crowl

Re: Convert more non-GTY htab_t to hash_table.

2012-10-05 Thread Lawrence Crowl
On 10/5/12, Jakub Jelinek ja...@redhat.com wrote: On Fri, Oct 05, 2012 at 01:59:18PM -0700, Lawrence Crowl wrote: With the constructor, you don't have to remember and you don't have to type more. If you have a variable, you know that it is properly initialized. But we really don't want

Re: Convert more non-GTY htab_t to hash_table.

2012-10-04 Thread Lawrence Crowl
On 10/4/12, Richard Guenther rguent...@suse.de wrote: On Tue, 2 Oct 2012, Lawrence Crowl wrote: On 10/2/12, Richard Guenther rguent...@suse.de wrote: On Mon, 1 Oct 2012, Lawrence Crowl wrote: Change more non-GTY hash tables to use the new type-safe template hash table. Constify member

Re: Convert more non-GTY htab_t to hash_table.

2012-10-03 Thread Lawrence Crowl
On 10/2/12, Ian Lance Taylor i...@google.com wrote: On Oct 2, 2012 Lawrence Crowl cr...@googlers.com wrote: On 10/2/12, Richard Guenther rguent...@suse.de wrote: You are changing a hashtable used by fold checking, did you test with fold checking enabled? I didn't know I had to do

Add myself to MAINTAINERS

2012-10-03 Thread Lawrence Crowl
...@cs.tu-berlin.de François-Xavier Coudertfxcoud...@gcc.gnu.org Cary Coutant ccout...@google.com +Lawrence Crowl cr...@google.com Ian Dall i

Re: Convert more non-GTY htab_t to hash_table.

2012-10-03 Thread Lawrence Crowl
On 10/2/12, Richard Guenther rguent...@suse.de wrote: On Mon, 1 Oct 2012, Lawrence Crowl wrote: Change more non-GTY hash tables to use the new type-safe template hash table. Constify member function parameters that can be const. Correct a couple of expressions in formerly uninstantiated

Re: Convert more non-GTY htab_t to hash_table.

2012-10-03 Thread Lawrence Crowl
parameters that can be const. Correct a couple of expressions in formerly uninstantiated templates. The new code is 0.362% faster in bootstrap, with a 99.5% confidence of being faster. Tested on x86-64. Okay for trunk? Index: gcc/java/ChangeLog 2012-10-01 Lawrence Crowl cr...@google.com

Re: Convert more non-GTY htab_t to hash_table.

2012-10-02 Thread Lawrence Crowl
On 10/2/12, Richard Guenther rguent...@suse.de wrote: On Mon, 1 Oct 2012, Lawrence Crowl wrote: Change more non-GTY hash tables to use the new type-safe template hash table. Constify member function parameters that can be const. Correct a couple of expressions in formerly uninstantiated

Re: Use conditional casting with symtab_node

2012-10-02 Thread Lawrence Crowl
: gcc/ChangeLog 2012-10-02 Lawrence Crowl cr...@google.com * cgraph.h (varpool_node): Rename to varpool_node_for_decl. Adjust callers to match. (symtab_node_def::try_function): New. Change most calls to symtab_function_p with calls to symtab_node_def

  1   2   3   >