Re: [vrp] use get_ptr_nonnull in tree-vrp

Hi Richard, On 12/10/16 23:24, Richard Biener wrote: On Wed, Oct 12, 2016 at 8:56 AM, kugan wrote: Hi, This patch uses get_ptr_nonnull in tree-vrp. Bootstrapped and regression tested this with other patched without any new regressions on x86_64-linux-gnu.

Re: [PATCH] Implement new hook for max_align_t_align

On 2016-10-12 2:01 PM, Florian Weimer wrote: On 10/12/2016 06:14 PM, Jeff Law wrote: If the issue is strictly limited to 32 bit hpux, then do we really care? Can we just deprecate that platform and thus make the issue go away? Are we talking about HP-XX or Linux on PA-RISC? The patch was

Go patch committed: copy string code from Go 1.7 runtime

This patch to the Go frontend and libgo copies the string code from the Go 1.7 runtime. This mainly replaces some C code with Go code. This adds compiler support for turning concatenating strings into a call to a runtime function that takes the appropriate number of arguments. This renames some

Re: Questionable code in gcov-io.c

On 10/12/16 11:04, Andreas Schwab wrote: Do we still need to call fstat? I don't think it can ever fail here. Update removing the fstat. Survived a profiled bootstrap, so I'll commit tomorrow, unless there are further comments. Thanks for spotting this! nathan 2016-10-12 Nathan

Re: New option -flimit-function-alignment

On 10/11/2016 10:14 PM, Bernd Schmidt wrote: On 10/11/2016 04:23 PM, Denys Vlasenko wrote: This is better than current behavior, but this is not what I want. 15-byte function does not need to be aligned to 16 bytes on a machine with 128-byte L1I cachelines. It needs to be aligned to 128 bytes

Re: [patch] aarch64-*-freebsd* support for gcc.

Hi Jeff, On 10.10.16 23:10, Jeff Law wrote: On 10/10/2016 03:07 PM, Andreas Tobler wrote: Hi all, the attached patch brings support for the aarch64-*-freebsd* target. Bootstraped and tested, results on the list. Not that many results due to board instabilities I lack a cavium ;) Ok for

Re: [RFC] Possible folding opportunities for string built-ins

On 10/12/2016 08:55 AM, Joseph Myers wrote: On Wed, 12 Oct 2016, Martin Liška wrote: Last question is whether one can aggressively fold strcasecmp in a host compiler? Or are there any situations where results depends on locale? There are the usual issues with Turkish locales having the

Re: [PATCH] Implement new hook for max_align_t_align

On 10/12/2016 10:17 AM, John David Anglin wrote: > On 2016-10-12 9:48 AM, Jason Merrill wrote: >> On Wed, Oct 12, 2016 at 4:02 AM, Jakub Jelinek wrote: >>> On Wed, Oct 12, 2016 at 09:52:04AM +0200, Florian Weimer wrote: dropping the alignment means that the padding before

Re: [PATCH, GCC] Move MEMMODEL_* and enum memmodel from coretypes.h to memmodel.h

On Wed, 12 Oct 2016, Thomas Preudhomme wrote: > This patch is a follow up of [1] which aims to have all memory model related > declarations in memmodel.h. To achieve that, this patch moves memory model > related declaration from coretypes.h into memmodel.h. Note that since > memmodel.h is now

[PATCH] Tweaks to print_rtx_function

On Wed, 2016-10-12 at 19:31 +0200, Bernd Schmidt wrote: > On 10/12/2016 07:48 PM, David Malcolm wrote: [...snip...] > > I think the only remaining item from our discussion above is what > > to do > > about the numbering of pseudos in the dumps (currently it just > > prints the regno > >

[PATCH 1/3] Remove support for obsolete x86 -malign-foo options

2016-09-27 Denys Vlasenko * config/i386/i386-common.c (ix86_handle_option): Remove support for obsolete -malign-loops, -malign-jumps and -malign-functions options. * config/i386/i386.opt: Likewise. Index: gcc/common/config/i386/i386-common.c

[PATCH 3/3] Extend -falign-FOO=N to N[,M[,N2[,M2]]]

falign-functions=N is too simplistic. Ingo Molnar ran some tests and it seems that on latest x86 CPUs, 64-byte alignment of functions runs fastest (he tried many other possibilites): this way, after a call CPU can fetch a lot of insns in the first cacheline fill. However, developers are less

[Visium] Fix gcc.dg/compat/scalar-by-value-4/scalar-return-4

There is a missing big-endian correction when types smaller than a word are passed through va_arg without promotion like _Complex char. Tested on visium-elf, applied on the mainline. 2016-10-12 Eric Botcazou * config/visium/visium.c (visium_gimplify_va_arg):

Re: [PATCH] 77864 Fix noexcept conditions for map/set default constructors

On 10/10/2016 23:01, Tim Song wrote: Trying again...with a few edits. On Mon, Oct 10, 2016 at 3:24 PM, François Dumont wrote: @@ -602,24 +612,32 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION struct _Rb_tree_impl : public _Node_allocator { _Key_compare

[PATCH 0/3] Extend -falign-FOO=N to N[,M[,N2[,M2]]] version 4

These patches are for this bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66240 "RFE: extend -falign-xyz syntax" The test program: int g(); int f(int i) { i *= 3; while (--i > 100) { L1:if (g()) goto L1; if (g()) goto L2; } return

[PATCH 2/3] Temporary remove "at least 8 byte alignment" code from x86

This change drops forced alignment to 8 if requested alignment is higher than 8: before the patch, -falign-functions=9 was generating .p2align 4,,8 .p2align 3 which means: "align to 16 if the skip is 8 bytes or less; else align to 8". After this change, ".p2align 3" is not

Re: [PATCH] 77864 Fix noexcept conditions for map/set default constructors

On Wed, Oct 12, 2016 at 4:36 PM, François Dumont wrote: > On 10/10/2016 23:01, Tim Song wrote: >> >> Trying again...with a few edits. >> >>> On Mon, Oct 10, 2016 at 3:24 PM, François Dumont >>> wrote: >>> >>> @@ -602,24 +612,32 @@

Re: [PATCH 01/16] read-md.c: Add various cleanups to ~rtx_reader

Sorry, haven't had time to read the full series yet, but: David Malcolm writes: > On Wed, 2016-10-05 at 17:51 +0200, Bernd Schmidt wrote: >> On 10/05/2016 06:14 PM, David Malcolm wrote: >> > The selftests for the RTL frontend require supporting multiple >> > reader instances

Re: [RFC][VRP] Improve intersect_ranges

Hi Richard, On 12/10/16 00:14, Richard Biener wrote: On Tue, Oct 11, 2016 at 2:57 AM, kugan wrote: Hi Richard, Hi Richard, On 10/10/16 20:13, Richard Biener wrote: On Sat, Oct 8, 2016 at 9:38 PM, kugan wrote: Hi

Re: [PATCH] Fold __builtin_memchr (version 3)

On Tue, Oct 11, 2016 at 11:38 AM, Martin Liška wrote: > One question that comes to my mind is whether there's a possibility > to fully test gimple folding of all cases if some of them are already > eaten by generic folding? The only way is to make GENERIC folding not trigger by

[Ada] Spurious errors on instances of formal packages with defaults.

This patch fixes spurious errors on instantiations of formal packages that have defaulted formals that include tagged private types and array types. The following must compile quietly: gcc -c lis3dsh_spi.ads --- with SPI_Bus_Driver; with LIS3DSH; package LIS3DSH_SPI is new LIS3DSH (IO =>

[Ada] Call memmove instead of memcpy in more cases

This changes the logic of Is_Non_Local_Array to return true for anything that is not a component or a slice of a local entity, for example a dereference, so as to generate a call to memmove instead of memcpy in more cases, e.g.: package P is type String_Access is access all String; type

Re: [PATCH] Introduce -Wimplicit-fallthrough={0,1,2,3,4,5}

On Wed, Oct 12, 2016 at 11:52:02AM +0200, Bernd Schmidt wrote: > On 10/12/2016 11:31 AM, Markus Trippelsdorf wrote: > >On 2016.10.12 at 00:34 +0200, Bernd Schmidt wrote: > >>It's a discussion we should have, but I agree it should be done > >>incrementally. I would argue for =1 as the default. > >

[diagnostic] fix formatting

I noticed some extraneous braces and extra long lines. Applied as obvious. nathan 2016-10-12 Nathan Sidwell * diagnostic.c (diagnostc_report_diagnostic): Fix formatting. Index: diagnostic.c === ---

Re: [PATCH] Add a helper function: create_tmp

On 10/11/2016 12:31 PM, Richard Biener wrote: > Hrm. Too easy to confuse with create_tmp_reg ... so maybe > create_tmp_reg_or_ssa_name? Yep, renamed function patch installed as r241030. Thanks, Martin

Re: [PATCH] print_rtx_function: integrate dumping of the CFG into the insn chain

On 10/12/2016 01:15 PM, David Malcolm wrote: +/* Determine if INSN is of a kind that can have a basic block. */ + +static bool +can_have_basic_block_p (const rtx_insn *insn) +{ + return GET_RTX_FORMAT (GET_CODE (insn))[2] == 'B'; +} Oof. I suppose they're all at least that long, but still -

Re: [PATCH] Introduce -Wimplicit-fallthrough={0,1,2,3,4,5}

On Wed, Oct 12, 2016 at 12:33:58PM +0200, Bernd Schmidt wrote: > On 10/12/2016 12:26 PM, Jakub Jelinek wrote: > >What do you mean at most? level 0 is the warning disabled, that is the > >default except for -Wextra. > > I think level 0 has to be on the table for -Wextra as well, depending on the

Re: [PATCH] Implement new hook for max_align_t_align

On Wed, Oct 12, 2016 at 09:52:04AM +0200, Florian Weimer wrote: > dropping the alignment means that the padding before the lock member > vanishes. Consequently, we have just created a silent ABI change in > application code, which is a big no-no. Sure, it would be an ABI change, but how many

Re: [PATCH GCC]New vectorization pattern turning cond_expr into max/min and plus/minus

On Tue, Oct 11, 2016 at 5:03 PM, Bin Cheng wrote: > Hi, > Given below test case, > int foo (unsigned short a[], unsigned int x) > { > unsigned int i; > for (i = 0; i < 1000; i++) > { > x = a[i]; > a[i] = (unsigned short)(x >= 32768 ? x - 32768 : 0); > }

Re: [PATCH] Fold __builtin_memchr (version 3)

On Tue, Oct 11, 2016 at 11:38 AM, Martin Liška wrote: > On 10/07/2016 01:01 PM, Richard Biener wrote: >> On Fri, Oct 7, 2016 at 10:41 AM, Martin Liška wrote: >>> Resending the patch, where I implemented folding in gimple-fold.c >>> >>> Patch can bootstrap on

Re: [PATCH GCC]Simplify (convert)(X op const) -> (convert)X op (convert)const by match

On Tue, Oct 11, 2016 at 11:34 PM, Marc Glisse wrote: > On Tue, 11 Oct 2016, Bin Cheng wrote: > >> We missed folding (convert)(X op const) -> (convert)X op (convert)const >> for unsigned narrowing because of reason reported at >>

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

On 12/10/16 10:57, Kyrill Tkachov wrote: On 11/10/16 20:19, Jakub Jelinek wrote: On Tue, Oct 11, 2016 at 01:11:04PM -0600, Martin Sebor wrote: Also, the pattern that starts with "/\+\+\+" looks like it's missing the ^ anchor. Presumably it should be "/^\+\+\+ \/testsuite\//". No, it will

[PATCH] print_rtx_function: integrate dumping of the CFG into the insn chain

On Fri, 2016-10-07 at 15:58 +0200, Bernd Schmidt wrote: > On 10/07/2016 03:26 PM, David Malcolm wrote: > > > > We could simply print the INSN_UID for CODE_LABELs; something like > > this > > (see the "(code_label 16" below): > > I think that should work. > > > You appear to have trimmed the

Re: [PATCH] Introduce -Wimplicit-fallthrough={0,1,2,3,4,5}

On Wed, Oct 12, 2016 at 12:36:29PM +0200, Markus Trippelsdorf wrote: > Here are some examples: > > /* Don't break */ > /* drop through */ //very popular > /* fall though */ > /* pass through... */ > /* break intentionally omitted */ > /* fallthough */ > /* Don't break, this is a

Re: [ipa-vrp] Use get/set_ptr_nonnull in ipa-vrp

> Hi, > > This patch uses the get/set_ptr_nonnull so that ipa-vrp also > propagates nonnull ranges for pinter. > > Bootstrapped and regression tested this with other patched without > any new regressions on x86_64-linux-gnu. > > Is this OK for trunk? > > Thanks, > Kugan > > > > >

Re: [PATCH] Implement new hook for max_align_t_align

On 10/12/2016 09:25 AM, Jakub Jelinek wrote: No, you can just drop the aligned attributes for HPUX 32-bit, basically introduce a new ABI. If needed, you could add new symbol versions for pthread_mutex_* etc. (though, if the current code doesn't care about the alignment, perhaps you could get

Re: [PATCH GCC]New vectorization pattern turning cond_expr into max/min and plus/minus

On Wed, Oct 12, 2016 at 10:29 AM, Bin.Cheng wrote: > On Wed, Oct 12, 2016 at 9:12 AM, Richard Biener > wrote: >> On Tue, Oct 11, 2016 at 5:03 PM, Bin Cheng wrote: >>> Hi, >>> Given below test case, >>> int foo (unsigned short

Re: [ARM] PR 67591 ARM v8 Thumb IT blocks are deprecated

Hi Kyrill, On 7 October 2016 at 17:00, Kyrill Tkachov wrote: > Hi Christophe, > > > On 07/09/16 21:05, Christophe Lyon wrote: >> >> Hi, >> >> The attached patch is a first part to solve PR 67591: it removes >> several occurrences of "IT blocks containing 32-bit Thumb

[PATCH] Add missing return to uninitialized_default_construct_n

This non-void function was missing a return statement. * include/bits/stl_uninitialized.h (__uninitialized_default_novalue_n_1): Add missing return. * testsuite/20_util/specialized_algorithms/memory_management_tools/ 1.cc: Check return values of

[PATCH] Remove 'return' from noreturn function

This just fixes a -Wsystem-headers warning, because this function is [[noreturn]]. * libsupc++/nested_exception.h (throw_with_nested): Remove return. Tested powerpc64le-linux, committed to trunk. commit 9720fce68641461a1d17bc42bc04d77f5cf18e0e Author: redi

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

On 11/10/16 20:19, Jakub Jelinek wrote: On Tue, Oct 11, 2016 at 01:11:04PM -0600, Martin Sebor wrote: Also, the pattern that starts with "/\+\+\+" looks like it's missing the ^ anchor. Presumably it should be "/^\+\+\+ \/testsuite\//". No, it will be almost never +++ /testsuite/ There needs

Re: [Patch 3/11] Implement TARGET_C_EXCESS_PRECISION for s390

On Wed, 12 Oct 2016, Andreas Krebbel wrote: > Regarding (c) imagemagick is also affected (it wasn't really clear from > my last email). Since it is a widely used lib I think this counts as a > blocker. The ABI relevant MagickRealType depends on the size of float_t: I think distributions manage

Re: [PATCH] Introduce -Wimplicit-fallthrough={0,1,2,3,4,5}

On 10/12/2016 12:36 PM, Markus Trippelsdorf wrote: Here are some examples: /* Don't break */ /* drop through */ //very popular /* fall though */ /* pass through... */ /* break intentionally omitted */ /* fallthough */ /* Don't break, this is a failed frame! */ /* leave break out

Re: [PATCH] Test folding of str{n}{case}cmp and memchr (version 3)

On Tue, Oct 11, 2016 at 11:38 AM, Martin Liška wrote: > Third iteration of tests, where I added both GENERIC and GIMPLE folding > tests. They should work already with -O1? Otherwise ok. Richard. > Martin

Re: [Patch 3/11] Implement TARGET_C_EXCESS_PRECISION for s390

On 10/07/2016 03:11 PM, Joseph Myers wrote: > On Fri, 7 Oct 2016, Andreas Krebbel wrote: > >> wrt (c): float_t appears to be more widely used than I expected. But the >> only hits which might indicate potential ABI problems where in clucene >> and libassa. (I've scanned the header files of

Re: [PATCH] Introduce -Wimplicit-fallthrough={0,1,2,3,4,5}

On 10/12/2016 11:31 AM, Markus Trippelsdorf wrote: On 2016.10.12 at 00:34 +0200, Bernd Schmidt wrote: It's a discussion we should have, but I agree it should be done incrementally. I would argue for =1 as the default. Here are some numbers for an allmodconfig Linux kernel on pcc64le:

Re: [PATCH] Introduce -Wimplicit-fallthrough={0,1,2,3,4,5}

On 2016.10.12 at 11:52 +0200, Bernd Schmidt wrote: > On 10/12/2016 11:31 AM, Markus Trippelsdorf wrote: > > On 2016.10.12 at 00:34 +0200, Bernd Schmidt wrote: > > > It's a discussion we should have, but I agree it should be done > > > incrementally. I would argue for =1 as the default. > > > >

Re: [PATCH] Introduce -Wimplicit-fallthrough={0,1,2,3,4,5}

On Wed, Oct 12, 2016 at 12:08:40PM +0200, Markus Trippelsdorf wrote: > On 2016.10.12 at 11:52 +0200, Bernd Schmidt wrote: > > On 10/12/2016 11:31 AM, Markus Trippelsdorf wrote: > > > On 2016.10.12 at 00:34 +0200, Bernd Schmidt wrote: > > > > It's a discussion we should have, but I agree it should

[Ada] Create a new internal profile

This new profile is not user visible and is the base to switch to the restricted tasking runtime. It replaces the Restricted profile for that purpose and is weaker than it. The Restricted profile remains unchanged. The purpose of that change is to lift some restrictions of the

Re: [PATCH] Introduce -Wimplicit-fallthrough={0,1,2,3,4,5}

On 10/12/2016 12:26 PM, Jakub Jelinek wrote: What do you mean at most? level 0 is the warning disabled, that is the default except for -Wextra. I think level 0 has to be on the table for -Wextra as well, depending on the signal-to-noise ratio of level 1. Collapsing 3-5 levels is a bad

[patch,avr] Introduce absdata attribute to allow LDS /STS on Tiny

This patch introduces a new variable attribute "absdata". Reduced Tiny cores have only a limited range of addresses 0x40..0xbf which can be handled by LDS / STS directly. The attribute allows the user to assert that it is legitimate to use absolute addressing for such addresses and that there

Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

On Tue, Oct 11, 2016 at 4:39 PM, Pierre-Marie de Rodat wrote: > On 09/28/2016 09:48 AM, Richard Biener wrote: >> >> Hmm, interesting approach. It might work reliably at this point of >> the compilation >> but we do actually recycle cgraph nodes. > > > Arf, what a pity. ;-) >

Re: [PATCH GCC]New vectorization pattern turning cond_expr into max/min and plus/minus

On Wed, Oct 12, 2016 at 9:12 AM, Richard Biener wrote: > On Tue, Oct 11, 2016 at 5:03 PM, Bin Cheng wrote: >> Hi, >> Given below test case, >> int foo (unsigned short a[], unsigned int x) >> { >> unsigned int i; >> for (i = 0; i < 1000; i++) >>

Re: [PATCH] Fold __builtin_str{n}{case}cmp functions (version 3)

On Tue, Oct 11, 2016 at 11:33 AM, Martin Liška wrote: > Changes from the previous version: > > 1) Handle BUILT_IN_STRNCMP with length == -1. > 2) Direct gimple stmts creation and usage gsi_replace_with_seq_vops. > (hope using of replace_call_with_value is fine if replacing with a

Re: [ARM] PR 67591 ARM v8 Thumb IT blocks are deprecated

On 12 October 2016 at 11:14, Kyrill Tkachov wrote: > > On 12/10/16 09:59, Christophe Lyon wrote: >> >> Hi Kyrill, >> >> On 7 October 2016 at 17:00, Kyrill Tkachov >> wrote: >>> >>> Hi Christophe, >>> >>> >>> On 07/09/16 21:05, Christophe

Re: [PATCH] Introduce -Wimplicit-fallthrough={0,1,2,3,4,5}

On 2016.10.12 at 00:34 +0200, Bernd Schmidt wrote: > On 10/11/2016 11:52 PM, Jakub Jelinek wrote: > > The following patch introduces difference warning levels for > > -Wimplicit-fallthrough warning, so projects can choose if they want to > > honor only attributes (-Wimplicit-fallthrough=5), or

PING! [Fortran, Patch, PR72832, v1] [6/7 Regression] [OOP] ALLOCATE with SOURCE fails to allocate requested dimensions

Ping! Updated patch with the comments gotten so far. Ok for trunk? - Andre On Fri, 2 Sep 2016 09:59:19 +0200 Andre Vehreschild wrote: > Hi all, > > attached patch fixes the issue raised by PR72832. The issue was that > the array descriptor of the SOURCE= in an ALLOCATE () was

Re: [PATCH] Introduce -Wimplicit-fallthrough={0,1,2,3,4,5}

On 2016.10.12 at 12:26 +0200, Jakub Jelinek wrote: > On Wed, Oct 12, 2016 at 11:52:02AM +0200, Bernd Schmidt wrote: > > On 10/12/2016 11:31 AM, Markus Trippelsdorf wrote: > > >On 2016.10.12 at 00:34 +0200, Bernd Schmidt wrote: > > >>It's a discussion we should have, but I agree it should be done >

[PATCH] Do not copy std:call_once arguments (LWG 2442)

This replaces the use of std::__bind_simple by direct calls to std::__invoke so that the arguments are not decay-copied. * doc/xml/manual/intro.xml: Document LWG 2442 status. * include/std/mutex [_GLIBCXX_HAVE_TLS] (__once_call_impl): Remove. [_GLIBCXX_HAVE_TLS]

Re: [PATCH] Fix PR77826

On Tue, 11 Oct 2016, Marc Glisse wrote: > On Tue, 11 Oct 2016, Richard Biener wrote: > > > > An example that regressed at -O (looking at the .optimized dump) > > > > > > int f(int a, unsigned b){ > > > a &= 1; > > > b &= 1; > > > return a > > > } > > > > Yeah, but it usually also shows a

Re: [PATCH v2] aarch64: Add split-stack initial support

On 11/10/16 20:39, Adhemerval Zanella wrote: diff --git a/gcc/testsuite/gcc.dg/split-3.c b/gcc/testsuite/gcc.dg/split-3.c index 64bbb8c..5ba7616 100644 --- a/gcc/testsuite/gcc.dg/split-3.c +++ b/gcc/testsuite/gcc.dg/split-3.c @@ -40,6 +40,7 @@ down (int i, ...) || va_arg (ap,

Re: [PATCH, PING] DWARF: space-optimize loc. descr. for integer literals on 32-bit targets

On Wed, Aug 31, 2016 at 1:41 PM, Pierre-Marie de Rodat wrote: > Hello, > > Ping for the patch submitted at > . Also, here’s the > update that Trevor suggested. Ok. Thanks, Richard. > Thanks! > > -- > Pierre-Marie de

Re: [ARM] PR 67591 ARM v8 Thumb IT blocks are deprecated

On 12/10/16 09:59, Christophe Lyon wrote: Hi Kyrill, On 7 October 2016 at 17:00, Kyrill Tkachov wrote: Hi Christophe, On 07/09/16 21:05, Christophe Lyon wrote: Hi, The attached patch is a first part to solve PR 67591: it removes several occurrences of "IT

[PATCH][AArch64] Add function comments to some prologue/epilogue helpers

Hi all, I'm looking at the aarch64 prologue and epilogue generation code and I noticed many of the helper functions don't have function comments so it makes it harder than it has to to understand what's going on. This patch adds function comments to some of them. I hope I understood the

Re: [PATCH] Introduce -Wimplicit-fallthrough={0,1,2,3,4,5}

On 10/12/2016 12:08 PM, Markus Trippelsdorf wrote: Actually looking more closely it appears that all of the 136 additional warnings for level 2 are bogus, too. Here is an example: switch (class) { case ATA_DEV_SEMB: class = ATA_DEV_ATA;/* some hard drives

Re: [PATCH, PING] DWARF: process all TYPE_DECL nodes when iterating on scopes

On 10/12/2016 10:15 AM, Richard Biener wrote: Ok. Thanks, Committed. Thank you! -- Pierre-Marie de Rodat

Re: [PATCH, PING] DWARF: space-optimize loc. descr. for integer literals on 32-bit targets

On 10/12/2016 10:13 AM, Richard Biener wrote: Ok. Thanks, Committed. Thank you! -- Pierre-Marie de Rodat

Re: [PATCH] Introduce -Wimplicit-fallthrough={0,1,2,3,4,5}

On 2016.10.12 at 12:54 +0200, Jakub Jelinek wrote: > On Wed, Oct 12, 2016 at 12:36:29PM +0200, Markus Trippelsdorf wrote: > > Here are some examples: > > > > /* Don't break */ > > /* drop through */ //very popular > > /* fall though */ > > /* pass through... */ > > /* break

Re: [tree-optimization/71947] Avoid unwanted propagations

On 10.10.2016 23:06, Jeff Law wrote: So if we have an equality conditional between A & B, we record into our const/copy tables A = B and B = A. This helps us discover some of the more obscure equivalences. But it also creates problems with an expression like A ^ B Where we might cprop the

Re: Questionable code in gcov-io.c

On 10/12/16 11:04, Andreas Schwab wrote: Do we still need to call fstat? I don't think it can ever fail here. You appear to be correct. nathan

[PATCH, GCC/testsuite/ARM] Enable mov?i_movw tests on ARM and big endian

Hi, As reported by Christophe Lyon, gcc.target/arm/movdi_movw test fails on big endian targets. This is because on big endian targets the low bits of a 64bit value would be in the highest numbered register of a pair rather than the lowest numbered register as on little endian targets. This

libgo patch committed: copy Go 1.7 runtime semaphore code

This patch to libgo copies the Go 1.7 runtime semaphore code into libgo, basically replacing sema.goc (written in C) with sema.go (writteh in Go). This triggered a check in releaseSudog that g.param not nil, because libgo uses the param field when starting a goroutine. Fixed by clearing g->param

Re: Questionable code in gcov-io.c

On 10/12/16 08:10, Marek Polacek wrote: While implementing a warning I noticed this in gcov-io.c: 187 else if (mode == 0) 188 { 189 struct stat st; 190 191 if (fstat (fd, ) < 0) 192 { 193 fclose (gcov_var.file); 194 gcov_var.file = 0; 195

Re: Questionable code in gcov-io.c

On 10/12/2016 02:10 PM, Marek Polacek wrote: While implementing a warning I noticed this in gcov-io.c: 187 else if (mode == 0) 188 { 189 struct stat st; 190 191 if (fstat (fd, ) < 0) 192 { 193 fclose (gcov_var.file); 194 gcov_var.file = 0;

Re: [PATCH][check_GNU_style.sh] More aggressively ignore dg-xxx directives

On 12/10/16 11:18, Kyrill Tkachov wrote: On 12/10/16 10:57, Kyrill Tkachov wrote: On 11/10/16 20:19, Jakub Jelinek wrote: On Tue, Oct 11, 2016 at 01:11:04PM -0600, Martin Sebor wrote: Also, the pattern that starts with "/\+\+\+" looks like it's missing the ^ anchor. Presumably it should

Re: Questionable code in gcov-io.c

On Okt 12 2016, Nathan Sidwell wrote: > @@ -182,9 +176,7 @@ gcov_open (const char *name, int mode) >return 0; > } > > - if (mode > 0) > -gcov_var.mode = 1; > - else if (mode == 0) > + if (mode == 0) > { >struct stat st; > > @@ -194,21 +186,20

Re: [PATCH, GCC/testsuite/ARM] Enable mov?i_movw tests on ARM and big endian

Sorry :-( Here you are. Cheers, Thomas On 12/10/16 16:25, Kyrill Tkachov wrote: On 12/10/16 16:21, Thomas Preudhomme wrote: Hi, As reported by Christophe Lyon, gcc.target/arm/movdi_movw test fails on big endian targets. This is because on big endian targets the low bits of a 64bit value

RE: [PATCH 4/4] [MIPS] Add tests for MSA

Hi, > -Original Message- > From: Matthew Fortune > Sent: 19 September 2016 15:46 > To: Robert Suchanek; catherine_mo...@mentor.com > Cc: gcc-patches@gcc.gnu.org > Subject: RE: [PATCH 4/4] [MIPS] Add tests for MSA > > Hi Robert, > > Sorry for the long delay. Just a couple of cleanup bits

Re: [PATCH, GCC/testsuite/ARM] Enable mov?i_movw tests on ARM and big endian

On 12/10/16 16:21, Thomas Preudhomme wrote: Hi, As reported by Christophe Lyon, gcc.target/arm/movdi_movw test fails on big endian targets. This is because on big endian targets the low bits of a 64bit value would be in the highest numbered register of a pair rather than the lowest numbered

libgo patch committed: Fixes for sparc64

This patch to libgo by James Clarke fixes libgo for sparc64. The getrandom syscall was being ignored because the file was named "sparc". The clone syscall apparently needs special attention on SPARC. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index:

Re: [tree-optimization/71947] Avoid unwanted propagations

Hi Jeff, On 10 October 2016 at 23:06, Jeff Law wrote: > > > So if we have an equality conditional between A & B, we record into our > const/copy tables A = B and B = A. > > This helps us discover some of the more obscure equivalences. But it also > creates problems with an

Re: Questionable code in gcov-io.c

On Wed, Oct 12, 2016 at 10:47:07AM -0400, Nathan Sidwell wrote: > On 10/12/16 09:43, Marek Polacek wrote: > > > > ITYM lines 197 -> 203. I.e. remove the entire if that;s inside the 'mode > > > == > > > 0' branch and make line 203 unconditional. > > > > Yes, sorry for sloppy wording. I'm

[PATCH] Define std::sample for C++17

I forgot that std::sample() was added to C++17, so it wasn't in our status table. It is now. I changed the testcase to use our iterator wrappers instead of containers, which found some bugs. I intend to go through other tests where I've used std::forward_list to get forward iterators, or stream

Re: [PATCH 4/6] shrink-wrap: Shrink-wrapping for separate components

On Mon, Oct 03, 2016 at 01:48:21PM +, Segher Boessenkool wrote: > This is the main substance of this patch series. I forgot to update the changelog before, what I committed is: * function.c (thread_prologue_and_epilogue_insns): Call try_shrink_wrapping_separate. Compute the

Re: [PATCH] Implement new hook for max_align_t_align

On 2016-10-12 9:48 AM, Jason Merrill wrote: On Wed, Oct 12, 2016 at 4:02 AM, Jakub Jelinek wrote: On Wed, Oct 12, 2016 at 09:52:04AM +0200, Florian Weimer wrote: dropping the alignment means that the padding before the lock member vanishes. Consequently, we have just

Re: PR35503 - warn for restrict pointer

On Sat, Oct 8, 2016 at 1:07 PM, Prathamesh Kulkarni wrote: > On 7 October 2016 at 17:49, David Malcolm wrote: >> On Fri, 2016-10-07 at 10:33 +0530, Prathamesh Kulkarni wrote: >>> On 22 September 2016 at 23:15, Joseph Myers

[PATCH] Fix PR77947

Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2016-10-12 Richard Biener PR debug/77947 * cgraphunit.c (analyze_functions): Preserve cgraph nodes function context. * g++.dg/torture/pr77947.C: New testcase. Index:

Re: Questionable code in gcov-io.c

On 10/12/16 09:43, Marek Polacek wrote: ITYM lines 197 -> 203. I.e. remove the entire if that;s inside the 'mode == 0' branch and make line 203 unconditional. Yes, sorry for sloppy wording. I'm testing a patch. Here's the patch I've tested (but not bootstrapped). As the incoming mode is

Re: [patch] Comment in rtl.h how rtx flags are dumped in rtl dumps.

On 10/12/2016 01:59 PM, Georg-Johann Lay wrote: This is a no-op change that just adds comments how the various RTX flags will appear in RTL dumps. Ok. Bernd

Re: [PATCH] Implement new hook for max_align_t_align

On 2016-10-12, at 4:02 AM, Jakub Jelinek wrote: >> Since this is PA-RISC, which is essentially dead (neither HPE nor Debian >> ship it anymore), I stand by my suggestion to bump the fundamental alignment > > Or just drop support for a dead arch? Hardware is still available on the second hand

[Ada] Crash on overloaded function call with limited view

This patch fixes a compiler abort on a call that is initially overloaded, when the resolved function returns the limited view of a type. The folllowing must compile quietly: gcc -c p.adb --- with R; package body P is function Get (A : Q.Ptr) return Integer is begin return

[Ada] Illegal overriding indicators not flagged for procedure named Initialize

In cases of dispatching operations with names Initialize, Adjust, and Finalize that will override an inherited procedure at the point of the full type but not at their point of declaration, the compiler was not properly flagging an overriding_indicator on such a procedure as illegal, because

Re: [PATCH] Fix PR77826

On Wed, 12 Oct 2016, Richard Biener wrote: So with doing the same on GENERIC I hit FAIL: g++.dg/cpp1y/constexpr-array4.C -std=c++14 (test for excess errors) with the pattern /* (T)(P + A) - (T)P -> (T) A */ (for add (plus pointer_plus) (simplify (minus (convert (add @0 @1))

Re: [BUILDROBOT] Selftest failed for i686-wrs-vxworks

Hi! On Wed, 5 Oct 2016 16:36:01 +0200, Bernd Schmidt wrote: > On 10/05/2016 04:14 PM, David Malcolm wrote: > > Thanks. I'm not able to formally approve these changes, but FWIW these > > patches look good to me (assuming usual testing). > > LGTM too, so OK. Without

Re: [PATCH] Fold __builtin_str{n}{case}cmp functions (version 3)

On 10/12/2016 10:30 AM, Richard Biener wrote: > On Tue, Oct 11, 2016 at 11:33 AM, Martin Liška wrote: >> Changes from the previous version: >> >> 1) Handle BUILT_IN_STRNCMP with length == -1. >> 2) Direct gimple stmts creation and usage gsi_replace_with_seq_vops. >> (hope using of

Re: Fix LTO_STREAMER_DEBUG build

Hi! On Thu, 29 Sep 2016 17:29:29 +0200, Richard Biener wrote: > On September 29, 2016 4:54:36 PM GMT+02:00, Thomas Schwinge > wrote: > >While working on something else, I found LTO_STREAMER_DEBUG broken. > >Enabling (#define)

Re: [PATCH] Implement new hook for max_align_t_align

On Wed, Oct 12, 2016 at 4:02 AM, Jakub Jelinek wrote: > On Wed, Oct 12, 2016 at 09:52:04AM +0200, Florian Weimer wrote: >> dropping the alignment means that the padding before the lock member >> vanishes. Consequently, we have just created a silent ABI change in >> application

Re: [RFC] Speed-up -fprofile-update=atomic

On 10/04/2016 11:45 AM, Richard Biener wrote: > On Thu, Sep 15, 2016 at 12:00 PM, Martin Liška wrote: >> On 09/07/2016 02:09 PM, Richard Biener wrote: >>> On Wed, Sep 7, 2016 at 1:37 PM, Martin Liška wrote: On 08/18/2016 06:06 PM, Richard Biener wrote: >

Re: Move OVERRIDE/FINAL from gcc/coretypes.h to include/ansidecl.h

On 10/10/2016 09:32 PM, Pedro Alves wrote: From: Pedro Alves Date: 2016-10-10 19:25:47 +0100 Move OVERRIDE/FINAL from gcc/coretypes.h to include/ansidecl.h So that GDB and other projects that share the top level can use them. Seems reasonable. OK unless someone objects by

Re: Move OVERRIDE/FINAL from gcc/coretypes.h to include/ansidecl.h

On 10/12/2016 03:01 PM, Bernd Schmidt wrote: > On 10/10/2016 09:32 PM, Pedro Alves wrote: >> From: Pedro Alves >> Date: 2016-10-10 19:25:47 +0100 >> >> Move OVERRIDE/FINAL from gcc/coretypes.h to include/ansidecl.h >> >> So that GDB and other projects that share the top level

  1   2   >