As mentioned in the PR, we should not suggest option that is not allowed.
Fixed by explicit removal of suggestions that are not acceptable.
Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
Ready to be installed?
Martin
>From 1a2d5614e9a0515659f50b457ef031c1f80f4a7c Mon
I followed up with the following patch, committed as revision 243841, removing
the old _gfortran_ftell and renaming the modern _gfortran_ftell2. It was
bootstrapped and regtested on x86_64-apple-darwin16.3.0.
This is the last item from https://gcc.gnu.org/wiki/LibgfortranAbiCleanup
The POSIX function strncasecmp() is used in three libgfortran files. It is
located in , but these files include (singular vs.
plural). Apparently most implementations (linux, darwin, …) are lenient and
allow that, but not mingw32, causing PR 70311
On Tue, Dec 20, 2016 at 10:32:26PM +0100, Jakub Jelinek wrote:
> On Tue, Dec 20, 2016 at 10:26:13PM +0100, Dominik Vogt wrote:
> > On Tue, Dec 20, 2016 at 11:57:52AM -0800, Mike Stump wrote:
> > > On Dec 20, 2016, at 6:10 AM, Dominik Vogt wrote:
> > > > Right, it gets
On 12/21/2016 11:00 AM, Jakub Jelinek wrote:
> On Wed, Dec 21, 2016 at 10:34:13AM +0100, Martin Liška wrote:
>> As mentioned in the PR, we should not suggest option that is not allowed.
>> Fixed by explicit removal of suggestions that are not acceptable.
>>
>> Patch can bootstrap on
> Catherine Moore writes:
> >
> > gcc/testsuite/ChangeLog:
> >
> > * gcc.target/mips/msa-builtins.c (dg-final): Tweak regex for the
> > 32-bit
> > insert.d case.
>
> Please change to:
> * gcc.target/mips-msa-builtins.c (msa_insert_d): Tweak expected
> output.
>
> Okay with that
On 20/12/16 17:30, Richard Biener wrote:
On December 20, 2016 5:01:19 PM GMT+01:00, Kyrill Tkachov
wrote:
Hi all,
The testcase in this patch generates bogus assembly for arm with -O1
-mfloat-abi=soft:
strdr4, [#0, r3]
This is due to non-canonical
On Wed, Dec 21, 2016 at 10:34:13AM +0100, Martin Liška wrote:
> As mentioned in the PR, we should not suggest option that is not allowed.
> Fixed by explicit removal of suggestions that are not acceptable.
>
> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>
> Ready
On Wed, Dec 21, 2016 at 12:05 PM, Andre Vehreschild wrote:
> Hi all,
>
> so I have learned that proposing to write "speaking code" is not very well
> taken.
If you want to make a patch introducing gfc_size_t_zero_node, go
ahead, at least I won't object. I don't think
The attached patch removes some unused headers from libgfortran sources. It
removes 320 assert.h, 31 stdlib.h, 12 string.h, 4 errno.h, and the occasional
math.h, unistd.h, and limits.h.
I have audited all files manually, checking for function calls. Patch was
bootstrapped and regtested on
On Wed, Dec 21, 2016 at 11:20:33AM +0100, Martin Liška wrote:
> I like your approach!
> make check -k -j10 RUNTESTFLAGS="dg.exp=spellcheck-options-*" works fine.
>
> Am I install the patch after it survives proper regression tests?
Ok.
Also, only related, seems we have misspelling candidates
Hi Janne,
> But yes, I'm still seeing the warning messages with -O1 for
> allocate_deferred_char_scalar_1.f03. AFAICT it's a bogus warning, but
> I don't know how to get rid of it..
No, that warning isn't at all bogus. The warning in fact is astonishingly
precise. When I remember correctly, then
Hi!
I'd like to ping the PR77830 fix for out of bounds constexpr stores:
https://gcc.gnu.org/ml/gcc-patches/2016-12/msg01319.html
Jakub
Hi all,
so I have learned that proposing to write "speaking code" is not very well
taken.
Anyway, there is a patch (in two parts) hanging about changing the character
length from int to size_t. It looks ok to me, but I do not have the privilege
to ok it. Furthermore am I still not convinced that
Hi Richard,
I occasionally found out a bug in my patch related to epilogue
vectorization without masking : need to put label before
initialization.
Could you please review and integrate it to trunk. Test-case is also attached.
Thanks ahead.
Yuri.
ChangeLog:
2016-12-21 Yuri Rumyantsev
On Wed, Dec 21, 2016 at 12:05 PM, FX wrote:
> The attached patch removes some unused headers from libgfortran sources. It
> removes 320 assert.h, 31 stdlib.h, 12 string.h, 4 errno.h, and the occasional
> math.h, unistd.h, and limits.h.
>
> I have audited all files manually,
On Tue, Dec 20, 2016 at 10:29 PM, Bernd Schmidt wrote:
> The problem here is that we don't have complete coverage of lea patterns for
> HImode/QImode: the combiner can't recognize a (plus (ashift reg 2) reg)
> pattern it builds.
>
> My first idea was to canonicalize ASHIFT by
On December 20, 2016 7:59:11 PM GMT+01:00, Jakub Jelinek
wrote:
>Hi!
>
>Similarly how we deal with bootstrapping libsanitizer only when
>doing bootstrap-{a,u}san bootstrap, this avoids bootstrapping libmpx
>if we don't need it for bootstrapping.
>
>Bootstrapped/regtested on
> Ok. Watch out for regressions on other targets though. I have more
> than once caused regressions by using some function that happened to
> be included in the existing headers on glibc, but needed some other
> header on other targets.
Committed:
On Wed, Dec 21, 2016 at 12:33 PM, Andre Vehreschild wrote:
> Hi Janne,
>
>> But yes, I'm still seeing the warning messages with -O1 for
>> allocate_deferred_char_scalar_1.f03. AFAICT it's a bogus warning, but
>> I don't know how to get rid of it..
>
> No, that warning isn't at all
> >> 2016-12-17 Simon Wright
> >>
> >>PR ada/78845
> >>* a-ngrear.adb (Inverse): call Unit_Matrix with First_1 set to
> >>A'First(2)
> >>and vice versa.
> >
> > Patch is OK, thanks.
>
> The same problem exists in Ada.Numerics.Generic_Complex_Arrays
>
The fix for PR 78757 was slightly too cautious, and covered only the
case of functions returning pointers to characters. By moving the
block above the if statement the DECL_EXPR is created also for
functions returning non-pointer characters.
Regtested on x86_64-pc-linux-gnu, Ok for trunk?
> 2016-12-21 Janne Blomqvist
>
> PR fortran/78867
> * trans-expr.c (gfc_conv_procedure_call): Emit DECL_EXPR also for
> non-pointer character results.
>
> testsuite ChangeLog:
>
> 2016-12-21 Janne Blomqvist
>
> PR fortran/78867
On Tue, Dec 20, 2016 at 12:26:41PM +0100, Martin Liška wrote:
> Ok, llvm folks are unwilling to accept the new API function, thus I've
> decided to come up
> with approach suggested by Jakub. Briefly, when expanding ASAN_POISON
> internal function,
> we create a new variable (with the same name
[PATCH, v2, rs6000] pr65479 Add -fasynchronous-unwind-tables when the
-fsanitize=address option is seen.
All feedback from the earlier version has been taken into account now.
This patch adds the -fasynchronous-unwind-tables option to compilations when
the -fsanitize=address option is seen but
> Now when I think about this some more, I have a vague recollection
> that a long time ago it used to be something like that. The problem
> is that MIN_EXPR will of course be
> NON-CONSTANT, so the memcpy call can't be inlined. Hence it was
> changed to two separate
http://gcc.gnu.org/r243854
Applied this patch as obvious. It adds some additional salt for
targets with reduced resources like require size32plus.
Johann
gcc/testsuite/
PR testsuite/52641
* gcc.dg/builtin-object-size-16.c (ia0, ia1, ia9): Handle case
where neither
Hi,
I have applied the following testsuite patch to fix one scan-assembler failure
in the testcase for the 'shared' attribute caused by backend change to enable
-fno-common by default.
Alexander
* gcc.target/nvptx/decl-shared.c (v_common): Add 'common' attribute to
explicitly
On Wed, Dec 21, 2016 at 1:50 PM, Andre Vehreschild wrote:
>> Here p is the character variable, and _p is the charlen. My guess is
>> that the problem is that with -O1 it sees that the second memmove
>> would overflow p, but it doesn't realize that branch is never taken.
>> Cranking
On 16/12/16 20:23 +, Jonathan Wakely wrote:
On 16/12/16 16:28 +0300, niXman wrote:
Jonathan Wakely 2016-12-16 16:04:
I don't think this is suitable for the branches, but could be applied
to trunk (as the patch was posted during stage 1, but I missed it).
Ok.
Does this require a
On Sat, Dec 17, 2016 at 01:19:41AM -0700, Jeff Law wrote:
> On 12/16/2016 12:29 AM, Trevor Saunders wrote:
> > On Thu, Dec 15, 2016 at 06:54:43PM -0700, Jeff Law wrote:
> > >unsigned cnt = 0;
> > > + bitmap live_bytes = NULL;
> > > + bitmap orig_live_bytes = NULL;
> > >
> > >*use_stmt =
> Here p is the character variable, and _p is the charlen. My guess is
> that the problem is that with -O1 it sees that the second memmove
> would overflow p, but it doesn't realize that branch is never taken.
> Cranking up the optimization level to -O2 and beyond makes it realize
> it, and thus
On 12/12/16 14:20, Andre Vieira (lists) wrote:
> On 21/06/16 15:16, Andre Vieira (lists) wrote:
>> Hello,
>>
>> After some changes to GCC this test no longer tests the desired code
>> generation behavior. The generated assembly is better than it used to
>> be, but it has become too smart. I add an
Hi Andre,
On 21/06/16 15:16, Andre Vieira (lists) wrote:
Hello,
After some changes to GCC this test no longer tests the desired code
generation behavior. The generated assembly is better than it used to
be, but it has become too smart. I add an extra parameter to make sure
GCC can't optimize
On 12.12.2016 17:54, Segher Boessenkool wrote:
On Mon, Dec 12, 2016 at 05:46:02PM +0100, Dominik Vogt wrote:
Patch with these changes and a fix because of not handling
VOIDmode attached. Bootstrapped and regression tested on s390 and
s390x.
Okay for trunk.
When did you see VOIDmode, btw?
On Wed, Dec 21, 2016 at 01:58:18PM +0100, Georg-Johann Lay wrote:
> $ avr-gcc
> /gnu/gcc.gnu.org/trunk/gcc/testsuite/gcc.c-torture/compile/pr26833.c -S
> -O1 -mmcu=avr4 -S -v
>
> /gnu/gcc.gnu.org/trunk/gcc/testsuite/gcc.c-torture/compile/pr26833.c: In
> function 'yasm_lc3b__parse_insn':
>
We shouldn't complain about friend temploids that we just haven't
instantiated yet.
Tested x86_64-pc-linux-gnu, applying to trunk.
commit a5742e86f3f8e1a2877b1dcf49403aaa8e7d0b86
Author: Jason Merrill
Date: Mon Dec 19 16:22:25 2016 -0500
PR c++/78749 - friend in
Right.. here is this updated chunk (otherwise no difference in the patch)
diff --git a/gcc/tree-chkp.c b/gcc/tree-chkp.c
index 2769682..6c7862c 100644
--- a/gcc/tree-chkp.c
+++ b/gcc/tree-chkp.c
@@ -3272,6 +3272,9 @@ chkp_may_narrow_to_field (tree field)
{
return DECL_SIZE (field) &&
On 12/20/2016 09:16 AM, Richard Biener wrote:
You do not handle memory or calls conservatively which means the existing
testcase only needs some obfuscation to become a problem again. To fix
that before /* Check that any SSA names used to define NAME is also fully
defined. */ bail out
On 12/20/2016 10:33 AM, Richard Biener wrote:
but for loops we can just continue and ignore this use. And
bitmap_set_bit
returns whether it set a bit, thus
if (bitmap_set_bit (visited_ssa, SSA_NAME_VERSION
(name)))
worklist.safe_push (name);
should work?
On Wed, Dec 21, 2016 at 09:29:26AM -0600, Bill Seurer wrote:
> [PATCH, v2, rs6000] pr65479 Add -fasynchronous-unwind-tables when the
> -fsanitize=address option is seen.
>
> All feedback from the earlier version has been taken into account now.
>
> This patch adds the
By this patch, I add a build-time option ` --with-unfused-madd4=yes/no’,
and runtime option -m(no-)unfused-madd4,
to disable generate madd.fmt instructions.
These 2 options is needed due to madd.fmt/msub.fmt on Loongson are broken,
which may generate wrong calculator result.
diff --git
OK.
On 12/20/2016 03:14 PM, Nathan Sidwell wrote:
On 12/20/2016 01:52 PM, Aldy Hernandez wrote:
int array[10] = { array[3]=5, 0x111, 0x222, 0x333 };
(gdb) x/4x
0x601040 : 0x0005 0x0111 0x0222
0x0005
That is, the array[3]=5 overwrites the last 0x333. I would
On Wed, Dec 21, 2016 at 12:29:37PM -0500, Aldy Hernandez wrote:
> > > int array[10] = { array[3]=5, 0x111, 0x222, 0x333 };
> > >
> > > (gdb) x/4x
> > > 0x601040 : 0x0005 0x0111 0x0222
> > > 0x0005
> > >
> > > That is, the array[3]=5 overwrites the last 0x333. I
On 12/21/2016 10:23 AM, Torsten Duwe wrote:
diff --git a/gcc/doc/extend.texi b/gcc/doc/extend.texi
index 1f303bc..a09851a 100644
--- a/gcc/doc/extend.texi
+++ b/gcc/doc/extend.texi
@@ -3076,6 +3076,17 @@ that affect more than one function.
This attribute should be used for debugging purposes
A couple of things I was missing from debug_tree output.
Tested x86_64-pc-linux-gnu, applying to trunk.
commit 1742299fdad0ac883636af88ea364eec5fec2687
Author: Jason Merrill
Date: Thu Dec 15 10:01:05 2016 -0500
Improve C++ debug_tree.
* ptree.c
On Tue, Dec 20, 2016 at 04:34:02PM +0300, Maxim Kuvyrkov wrote:
>
> Hi Bernd, thanks for reviewing this!
>
> Regarding the usefulness of this feature, it has been discussed here (2 years
> ago):
> http://gcc.gcc.gnu.narkive.com/JfWUDn8Y/rfc-kernel-livepatching-support-in-gcc
> .
>
> Kernel
On 02/18/2016 02:56 AM, Richard Biener wrote:
On Wed, Feb 17, 2016 at 5:10 PM, Jeff Law wrote:
On 02/17/2016 07:13 AM, Richard Biener wrote:
- /* Continue walking until we reach a kill. */
- while (!stmt_kills_ref_p (temp, ref));
+ /* Continue walking until we reach a
On 12/16/2016 12:29 AM, Trevor Saunders wrote:
On Thu, Dec 15, 2016 at 06:54:43PM -0700, Jeff Law wrote:
unsigned cnt = 0;
+ bitmap live_bytes = NULL;
+ bitmap orig_live_bytes = NULL;
*use_stmt = NULL;
+ /* REF is a memory write. Go ahead and get its base, size, extent
+
On 12/16/2016 06:57 AM, Richard Biener wrote:
Apart from what Trevor says about using sbitmaps (try to avoid the initial
zeroing please) and the missed freeing (you can use auto_[s]bitmap?)
some comments below.
New version uses sbitmaps and avoids zero-ing when we can.
+static void
On Tue, Dec 20, 2016 at 11:27:18AM -0600, Pat Haugen wrote:
> This patch attempts to fix problems with the first scheduling pass creating
> too much register pressure. It does this by enabling the target hook to
> compute the pressure classes for rs6000 target since the first thing I
> observed
2016-12-20 17:44 GMT+03:00 Alexander Ivchenko :
> 2016-11-26 0:28 GMT+03:00 Ilya Enkovich :
>> 2016-11-25 15:47 GMT+03:00 Alexander Ivchenko :
>>> Hi,
>>>
>>> The patch below addresses PR68270. could you please take a look?
>>>
>>>
Calling strip_inheriting_ctors on a FUNCTION_DECL was returning a
TEMPLATE_DECL; we should make sure we return the same tree code that
we started with.
Tested x86_64-pc-linux-gnu, applying to trunk.
commit f7ef6e8372fcb279349576f769fac34db70c87bf
Author: Jason Merrill
Date:
The first patch fixes some issues that I noticed in implementing P0522
with my earlier auto non-type parameters work.
The second patch uses deduction to confirm that a partial
specialization is more specialized than the primary template, which
catches some bugs in the testsuite that the existing
On 12/21/2016 11:54 AM, Yunqiang Su wrote:
By this patch, I add a build-time option ` --with-unfused-madd4=yes/no’,
and runtime option -m(no-)unfused-madd4,
to disable generate madd.fmt instructions.
Your patch also needs a documentation change so that the new
command-line option is listed in
Sandra Loosemore writes:
> On 12/21/2016 11:54 AM, Yunqiang Su wrote:
> > By this patch, I add a build-time option ` --with-unfused-madd4=yes/no',
> > and runtime option -m(no-)unfused-madd4,
> > to disable generate madd.fmt instructions.
>
> Your patch also needs a
On 12/16/2016 09:41 AM, Jakub Jelinek wrote:
On Fri, Dec 16, 2016 at 11:08:00AM +0100, Jakub Jelinek wrote:
Here is an untested proof of concept for:
1) keeping the warning in the FEs no matter what optimization level is on,
just making sure TREE_NO_WARNING is set on the CALL_EXPR if we've
The following patch fixes
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78580
The patch was successfully tested and bootstrapped on x86-64.
Committed to the trunk as rev. 243875.
Index: ChangeLog
===
--- ChangeLog (revision
OK.
On Tue, Dec 20, 2016 at 1:57 PM, Jakub Jelinek wrote:
> Hi!
>
> Recently DW_FORM_ref_sup (which is meant e.g. for dwz, gcc doesn't emit it)
> has been renamed to DW_FORM_ref_sup4 (and changed so that it is always 4
> byte) and DW_FORM_ref_sup8 (always 8 byte) has been
This patch addresses bug 61636, which is an ICE during generic lambda
instantiation due to unexpected this capture.
The problem is that a generic lambda's closure type is not a template,
only the function operator is. Thus this capture has to be determined
at parsing time (and anyway, it'd
On Wed, Dec 21, 2016 at 02:47:49PM -0700, Jeff Law wrote:
> It looks like you could avoid a lot of work in pass_post_ipa_warn::execute
> by checking if warnings were asked for outside the main loop. Presumably
> you wrote this with the check inside the loop with the expectation that
> other
OK.
On Tue, Dec 20, 2016 at 2:01 PM, Jakub Jelinek wrote:
> Hi!
>
> DECL_ANON_UNION_VAR_P vars are DECL_ARTIFICIAL, but we still to diagnose
> them if they shadow something. The DECL_ARTIFICIAL (x) check has been
> missing in older gcc releases, so we diagnosed that properly.
On 12/21/2016 03:11 PM, Jakub Jelinek wrote:
On Wed, Dec 21, 2016 at 02:47:49PM -0700, Jeff Law wrote:
It looks like you could avoid a lot of work in pass_post_ipa_warn::execute
by checking if warnings were asked for outside the main loop. Presumably
you wrote this with the check inside the
On Wed, Dec 21, 2016 at 03:13:29PM -0700, Jeff Law wrote:
> > > Also in pass_post_ipa_warn::execute, the BITMAP_FREE call is technically
> > > in
> > > a correct position, but it might be more maintainable long term if the
> > > allocation/deallocation occur at the same nesting level.
> >
> >
[PATCH] Add options to disable/enable madd.fmt/msub.fmt instructions
The build-time options are:
--with-unfused-madd4=yes/no
--without-unfused-madd4
The runtime options are:
-munfused-madd4
-mno-unfused-madd4
These options are needed due to madd.fmt/msub.fmt on some
platform is broken,
Hi,
> +On MIPS targets, set the @option{-mno-unfused-madd4} option by default.
> +On some platform, like Loongson 3A/3B 1000/2000/3000, madd.fmt/msub.fmt is
> +broken, which may which may generate wrong calculator result.
The Loongson 3A/3B 1000/2000/3000 madd.fmt/msub.fmt are fused madd
Hi,
The following patch fixes
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78879
There are some other invocations of unordered_remove in
tree-ssa-threadupdate.c, which may also need to be replaced
with ordered_remove.
Regards,
Yuan, Pengfei
2016-12-22 Yuan Pengfei
This is the first of the 4 part patchkit to address deficiencies in our
DSE implementation.
This patch addresses the P2 regression 33562 which has been a low
priority regression since gcc-4.3. To summarize, DSE no longer has the
ability to detect an aggregate store as dead if subsequent
This is V3 of the 4 series patchkit to address various DSE issues.
The various comments from the V2 patchkit have been addressed and I
believe the net result is cleaner and more compile-time efficient.
The major changes were a move to using sbitmaps, only allowing the live
sbitmap once per
This is the final patch in the kit to improve our DSE implementation.
It's based on a observation by Richi. Namely that a read from bytes of
memory that are dead can be ignored. By ignoring such reads we can
sometimes find additional stores that allow us to either eliminate or
trim an
This is the second patch in the kit to improve our DSE implementation.
This patch recognizes when a CONSTRUCTOR assignment could be trimmed at
the head or tail because those bytes are dead.
The first implementation of this turned the CONSTRUCTOR into a memset.
This version actually rewrites
2016-12-21 22:18 GMT+03:00 Alexander Ivchenko :
> Right.. here is this updated chunk (otherwise no difference in the patch)
>
> diff --git a/gcc/tree-chkp.c b/gcc/tree-chkp.c
> index 2769682..6c7862c 100644
> --- a/gcc/tree-chkp.c
> +++ b/gcc/tree-chkp.c
> @@ -3272,6 +3272,9 @@
On Wed, Dec 21, 2016 at 01:58:18PM +0100, Georg-Johann Lay wrote:
> On 12.12.2016 17:54, Segher Boessenkool wrote:
> >On Mon, Dec 12, 2016 at 05:46:02PM +0100, Dominik Vogt wrote:
> >>Patch with these changes and a fix because of not handling
> >>VOIDmode attached. Bootstrapped and regression
On 12/21/2016 11:28 AM, Jakub Jelinek wrote:
> On Wed, Dec 21, 2016 at 11:20:33AM +0100, Martin Liška wrote:
>> I like your approach!
>> make check -k -j10 RUNTESTFLAGS="dg.exp=spellcheck-options-*" works fine.
>>
>> Am I install the patch after it survives proper regression tests?
>
> Ok.
>
>
Bernd Edlinger wrote:
On 12/20/16 16:09, Wilco Dijkstra wrote:
> > As a result of your patches a few patterns are unused now. All the Thumb-2
> > iordi_notdi*
> > patterns cannot be used anymore. Also I think arm_cmpdi_zero never gets
> > used - a DI
>> mode compare with zero is always split
On 21.12.2016 15:42, Dominik Vogt wrote:
On Wed, Dec 21, 2016 at 01:58:18PM +0100, Georg-Johann Lay wrote:
On 12.12.2016 17:54, Segher Boessenkool wrote:
On Mon, Dec 12, 2016 at 05:46:02PM +0100, Dominik Vogt wrote:
Patch with these changes and a fix because of not handling
VOIDmode attached.
> > Yes, please resend an updated patch.
>
> The function Ada.Numerics.Generic_Real_Arrays.Inverse is required
> (ARM G.3.1(72)) to
> return a matrix with the bounds of the dimension indices swapped, i.e.
> result'Range(1) ==
> input'Range(2) and vice versa. The present code gets result'Range(1)
Sorry,
I put wrong test - fix it here.
2016-12-21 13:12 GMT+03:00 Yuri Rumyantsev :
> Hi Richard,
>
> I occasionally found out a bug in my patch related to epilogue
> vectorization without masking : need to put label before
> initialization.
>
> Could you please review and
On 12/21/2016 06:43 AM, Trevor Saunders wrote:
So a few interesting things have to be dealt if we want to make this change.
I already mentioned the need to bias based on ref->offset so that the range
of bytes we're tracking is represented 0..size.
While we know the length of the potential dead
Hi!
At least in my reading of the standard OpenMP 4.[05] does not disallow
explicit or implicit mapping of assumed-size arrays, but it is IMNSHO a
defect in the standard, it is something that can't be really supported
because the compiler does not know the size of the assumed size array.
What
81 matches
Mail list logo