Re: [PATCH] Add a few new contrib.texi entries, especially for people who perform GCC fuzzy testing and report bugs (take 2)

On 03/07/2018 03:24 PM, Jakub Jelinek wrote: On Wed, Mar 07, 2018 at 02:06:33PM +0100, Jakub Jelinek wrote: As appreciation of the hard work of people doing fuzzy testing of GCC and reporting high quality bugs, I'd like to list them in contrib.texi. This patch just lists them in the GCC

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

On 02/23/2018 01:13 PM, Jakub Jelinek wrote: > On Fri, Feb 23, 2018 at 12:57:14PM -0700, Martin Sebor wrote: >> + /* get_inner_reference is not expected to return null. */ >> + gcc_assert (base != NULL); >> + >>poly_int64 bytepos = exact_div (bitpos, BITS_PER_UNIT); >> >> - HOST_WIDE_INT

[PATCH 1/2] tree-if-conv.c: fix ICE seen with -fno-tree-forwprop (PR tree-optimization/84178)

PR tree-optimization/84178 reports a couple of source files that ICE inside ifcvt when compiled with -03 -fno-tree-forwprop (trunk and gcc 7). Both cases involve problems with ifcvt's per-BB gimplified predicates. Testcase 1 fails this assertion within release_bb_predicate during cleanup: 283

Re: [PATCH/RFC] tree-if-conv.c: fix two ICEs seen with -fno-tree-forwprop (PR tree-optimization/84178)

On Fri, 2018-02-16 at 12:48 +0100, Richard Biener wrote: > On Thu, Feb 15, 2018 at 11:07 PM, David Malcolm > wrote: > > On Fri, 2018-02-09 at 12:02 +0100, Richard Biener wrote: > > > On Thu, Feb 8, 2018 at 11:23 PM, David Malcolm > > om> > > > wrote: > >

[PATCH 2/2] ifcvt: unfixed testcase for 2nd issue within PR tree-optimization/84178

Here's a testcase for the 2nd issue within PR tree-optimization/84178. With -03 -fno-tree-forwprop, trunk and gcc 7 segfault inside update_ssa when called from version_loop_for_if_conversion when a loop is versioned. During loop_version, some blocks are duplicated, and this can duplicate SSA

Re: [SFN+LVU+IEPM v4 9/9] [IEPM] Introduce inline entry point markers

On 02/21/2018 03:11 AM, Alexandre Oliva wrote: > On Feb 15, 2018, Szabolcs Nagy wrote: > >> i see assembler slow downs with these location view patches >> i opened https://gcc.gnu.org/bugzilla/show_bug.cgi?id=84408 > > > [LVU] reset view at function entry, omit views at

Re: [C++ Patch/RFC] PR 71169 ("[7/8 Regression] ICE on invalid C++ code in pop_nested_class"), PR 71832 and more

On Wed, Mar 7, 2018 at 12:18 PM, Paolo Carlini wrote: > Hi, > > [snip the various clarifications] > > Il 7 Marzo 2018 17:57:07 CET, Jason Merrill ha scritto: >>My thought was that this patch adds a lot of managing of the flag in >>different places in

[PATCH] rs6000: -mreadonly-in-sdata (PR82411)

This adds a new option -mreadonly-in-sdata (on by default) that controls whether readonly data can be put in sdata. (For EABI this does nothing, readonly data is put in sdata2 as usual). Tested etc.; committing. Segher 2018-03-07 Segher Boessenkool *

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

On 02/23/2018 02:46 PM, Martin Sebor wrote: >> This doesn't address any of my concerns that it is completely random >> what {dst,src}ref->base is, apples and oranges; sometimes it is a pointer >> (e.g. the argument of the function), sometimes the ADDR_EXPR operand, >> sometimes the base of the

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

On 02/26/2018 10:32 AM, Martin Sebor wrote: > > PR tree-optimization/84526 - ICE in generic_overlap at > gcc/gimple-ssa-warn-restrict.c:927 since r257860 > > gcc/ChangeLog: > > PR tree-optimization/84526 > * gimple-ssa-warn-restrict.c (builtin_memref::set_base_and_offset): >

Re: [C++ Patch/RFC] PR 71169 ("[7/8 Regression] ICE on invalid C++ code in pop_nested_class"), PR 71832 and more

Hi, On 07/03/2018 21:23, Jason Merrill wrote: On Wed, Mar 7, 2018 at 12:18 PM, Paolo Carlini wrote: Hi, [snip the various clarifications] Il 7 Marzo 2018 17:57:07 CET, Jason Merrill ha scritto: My thought was that this patch adds a lot of

Re: C++ PATCH for c++/84036, ICE with variadic lambda capture

On Sun, Feb 11, 2018 at 8:21 PM, Jason Merrill wrote: > The old lambda model handled variadic capture by focusing on the > FIELD_DECL rather than trying to map between capture proxies. The new > model relies more on capture proxies, so it makes sense to use them > more for

[PATCH] avoid warning for memcpy to self (PR 83456)

I have become convinced that issuing -Wrestrict in gimple-fold for calls to memcpy() where the source pointer is the same as the destination causes more trouble than it's worth, especially when inlining is involved, as in: inline void bar (void *d, void *s, unsigned N) { if (s != d)

Re: Fix some _GLIBCXX_DEBUG pretty printer errors

On 7 March 2018 at 17:39, François Dumont wrote: > On 06/03/2018 22:21, Jonathan Wakely wrote: >> >> >>> @@ -575,10 +586,12 @@ class StdDebugIteratorPrinter: >>> # and return the wrapped iterator value. >>> def to_string (self): >>> base_type =

[PATCH] Fix switchconv ICE (PR tree-optimization/84740)

Hi! On the following testcase info.final_bb has only one PHI, the virtual one, so info.phi_count is 0. For info.phi_count == 0, we don't really create any arrays etc.; just returning early (before create_temp_arrays) would work, but would leave the useless GIMPLE_SWITCH in the IL and it would

[PATCH] __builtin_early_constant_p (PR c++/78420)

Hi! This is the implementation of __builtin_early_constant_p builtin which is at all optimization levels quite similar to __builtin_constant_p at -O0, except that the FE folding might be slightly different between -O0 and -O1+. In any case, the builtin is folded to 0 already during the FEs if

Re: [PATCH] Fix ICE for static vars in offloaded functions

On Wed, Mar 07, 2018 at 02:20:26PM +0100, Tom de Vries wrote: > Fix ICE for static vars in offloaded functions > > 2018-03-06 Tom de Vries > > PR lto/84592 > * varpool.c (varpool_node::get_create): Mark static variables in > offloaded functions as

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

Martin Sebor writes: > @@ -409,23 +412,33 @@ builtin_memref::set_base_and_offset (tree expr) >base = get_inner_reference (expr, , , _off, > , , , ); > > + /* get_inner_reference is not expected to return null. */ > + gcc_assert (base !=

[PATCH, rs6000] Fix PR83969: ICE in final_scan_insn, at final.c:2997

PR83969 shows another bug in mem_operand_gpr() (which implements the "Y" constraint) accepting reg+reg addresses.  This was fixed by adding a call to rs6000_offsettable_memref_p() to verify the address is a valid offsettable address.  Fixing that exposed a problem in the *movdi_internal64 pattern

[PATCH] Fix tail recursion (PR tree-optimization/84739)

Hi! Before Honza introduced recursive_call_p, this tree-tailcall.c snipped has been guarded with if (func == current_function_decl), so what we used for DECL_ARGUMENTS didn't really matter. But as it can now be some alias to it, we really want to check that the current function's arguments match

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

On 03/07/2018 04:04 PM, Richard Sandiford wrote: Martin Sebor writes: @@ -409,23 +412,33 @@ builtin_memref::set_base_and_offset (tree expr) base = get_inner_reference (expr, , , _off, , , , ); + /* get_inner_reference is not expected to

Re: [PATCH] Fix tail recursion (PR tree-optimization/84739)

On 03/07/2018 02:42 PM, Jakub Jelinek wrote: > Hi! > > Before Honza introduced recursive_call_p, this tree-tailcall.c snipped > has been guarded with if (func == current_function_decl), so what we used > for DECL_ARGUMENTS didn't really matter. But as it can now be some alias > to it, we really

Re: [RFA][PATCH][PR middle-end/61118] Improve tree CFG accuracy for setjmp/longjmp

On 3/7/18 12:01 AM, Jeff Law wrote: > I believe so by nature that the setjmp dominates the longjmp sites and > thus also dominates the dispatcher. But it's something I want to > explicitly check before resubmitting. Are we sure a setjmp has to dominate its longjmp sites? Couldn't you have

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

On 03/07/2018 12:37 PM, Jeff Law wrote: On 02/26/2018 10:32 AM, Martin Sebor wrote: PR tree-optimization/84526 - ICE in generic_overlap at gcc/gimple-ssa-warn-restrict.c:927 since r257860 gcc/ChangeLog: PR tree-optimization/84526 * gimple-ssa-warn-restrict.c

Re: [PATCH] Fix switchconv ICE (PR tree-optimization/84740)

On March 7, 2018 10:51:08 PM GMT+01:00, Jakub Jelinek wrote: >Hi! > >On the following testcase info.final_bb has only one PHI, the virtual >one, >so info.phi_count is 0. For info.phi_count == 0, we don't really >create any >arrays etc.; just returning early (before

Re: [C++ Patch/RFC] PR 71169 ("[7/8 Regression] ICE on invalid C++ code in pop_nested_class"), PR 71832 and more

Hi, [snip the various clarifications] Il 7 Marzo 2018 17:57:07 CET, Jason Merrill ha scritto: >My thought was that this patch adds a lot of managing of the flag in >different places in the parser, whereas looking for error_mark_node in >the template parms here would be just

Re: Fix some _GLIBCXX_DEBUG pretty printer errors

On 06/03/2018 22:21, Jonathan Wakely wrote: @@ -575,10 +586,12 @@ class StdDebugIteratorPrinter: # and return the wrapped iterator value. def to_string (self): base_type = gdb.lookup_type('__gnu_debug::_Safe_iterator_base') +itype = self.val.type.template_argument(0)

[PATCH][AArch64] PR target/84748: Mark *compare_cstore_insn as clobbering CC reg

Hi all, In this wrong-code PR the combine pass ends up moving a CC-using instruction past a *compare_cstore_insn insn_and_split. After reload the *compare_cstore_insn splitter ends up generating a SUBS instruction that clobbers the condition flags, and things go bad. The solution is simple,

Re: [PING] [PATCH] consider successor blocks when avoiding -Wstringop-truncation (PR 84468)

On 03/01/2018 02:17 PM, Martin Sebor wrote: > > I read you last reply as asking me to handle multiple edges. Sorry, I should have been clearer. You need to be prepared for the possibility of multiple edges and handle them in a conservatively correct way. The most likely way to get multiple

[PATCH] Ada: Fix s-oscons.ads generation

The $(GNATLIBCFLAGS) are already included in $(GNATLIBCFLAGS_FOR_C). We must call the C compiler with the right machine flags. So, add $(GNATLIBCFLAGS_FOR_C) to $(OSCONS_EXTRACT). For example, on a bi-arch compiler supporting 32-bit and 64-bit instruction sets we pick otherwise only one variant

Re: [AARCH64] Disable pc relative literal load irrespective of TARGET_FIX_ERR_A53_84341

On Wed, Mar 07, 2018 at 01:58:40AM +, Kugan Vivekanandarajah wrote: > Hi James, > > This patch has to be backported to gcc-7 branch as the build error for > 521.wrf with LTO is there too (for the same reason). This patch has > been on trunk for some time now. So, is this OK to backport this

Re: [PATCH] Fix aarch64_simd_reg_or_zero predicate (PR fortran/84565)

On Tue, Feb 27, 2018 at 02:22:22PM +, Richard Sandiford wrote: > Jakub Jelinek writes: > > Hi! > > > > The following testcase ICEs, because the aarch64_cmeqdf instruction > > starting with r256612 no longer accepts CONST0_RTX (E_DFmode) as > > valid argument, but the

Re: [patch] Fix PR target/84277

On Wed, Mar 7, 2018 at 10:28 AM, Eric Botcazou wrote: >> For the middle-end part I'd like to see output_function_exception_table take >> an enum with two members with appropriate name - I see there wasn't >> documentation for the function but your change doesn't make

Re: [RFC][PR82479] missing popcount builtin detection

On Tue, Mar 6, 2018 at 5:20 PM, Bin.Cheng wrote: > On Mon, Mar 5, 2018 at 3:24 PM, Richard Biener > wrote: >> On Thu, Feb 8, 2018 at 1:41 AM, Kugan Vivekanandarajah >> wrote: >>> Hi Richard, >>> >>> On 1

GCC 6 backports

Hi. Sending GCC 6 branch backports. Patches can bootstrap on ppc64le-redhat-linux and survives regression tests. I'm going to install the patches. Martin >From e65a740ebed1d27132352c4a55e0a2554eb34820 Mon Sep 17 00:00:00 2001 From: hubicka Date:

Re: [PATCH] Ada: Fix s-oscons.ads generation

> The $(GNATLIBCFLAGS) are already included in $(GNATLIBCFLAGS_FOR_C). > > We must call the C compiler with the right machine flags. So, add > $(GNATLIBCFLAGS_FOR_C) to $(OSCONS_EXTRACT). For example, on a bi-arch > compiler supporting 32-bit and 64-bit instruction sets we pick otherwise > only

[PATCH] Fix ICE for static vars in offloaded functions

Hi, if we compile the testcase pr84592-2.c from the patch: ... #include int main (void) { int n[1]; n[0] = 3; #pragma omp target { static int test[4] = { 1, 2, 3, 4 }; n[0] += test[n[0]]; } if (n[0] != 7) abort (); return 0; } ... for nvptx offloading, we run into

Re: [PATCH] Fix ICE for static vars in offloaded functions

On Wed, 7 Mar 2018, Jakub Jelinek wrote: > On Wed, Mar 07, 2018 at 02:20:26PM +0100, Tom de Vries wrote: > > Fix ICE for static vars in offloaded functions > > > > 2018-03-06 Tom de Vries > > > > PR lto/84592 > > * varpool.c (varpool_node::get_create): Mark

Re: [PATCH] Fix ICE for static vars in offloaded functions

On Wed, Mar 07, 2018 at 02:29:48PM +0100, Richard Biener wrote: > On Wed, 7 Mar 2018, Jakub Jelinek wrote: > > > On Wed, Mar 07, 2018 at 02:20:26PM +0100, Tom de Vries wrote: > > > Fix ICE for static vars in offloaded functions > > > > > > 2018-03-06 Tom de Vries > > >

[PATCH] Document gcov-io (PR gcov-profile/84735).

Hi. Attempt of the patch is to explain that consumers of gcov tool should use the intermediate format instead of reading of the profile files. The format change is documented. Ready for trunk? Thanks, Martin gcc/ChangeLog: 2018-03-07 Martin Liska PR

Re: [PATCH] Ada: Fix s-oscons.ads generation

> >>The $(GNATLIBCFLAGS) are already included in $(GNATLIBCFLAGS_FOR_C). > >> > >>We must call the C compiler with the right machine flags. So, add > >>$(GNATLIBCFLAGS_FOR_C) to $(OSCONS_EXTRACT). For example, on a > >>bi-arch > >>compiler supporting 32-bit and 64-bit instruction sets we pick >

[PATCH] Add a few new contrib.texi entries, especially for people who perform GCC fuzzy testing and report bugs (take 2)

On Wed, Mar 07, 2018 at 02:06:33PM +0100, Jakub Jelinek wrote: > As appreciation of the hard work of people doing fuzzy testing of > GCC and reporting high quality bugs, I'd like to list them in contrib.texi. > This patch just lists them in the GCC testing group, shall we have a special > sub-list

libgo patch committed: Use fence instruction before rdtsc

This libgo patch uses an appropriate fence instruction before the rdtsc instruction. This is required on some multicore implementations in order to consistent cycle counts on different cores. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index:

[PATCH][AARCH64]Fix immediate alternative of movhf_aarch64 pattern.

Hi all, For the immediate alternative, the constraint checks the operand with HF mode while SImode is provided to the output template generation function. Before the change, this inconsistency causes an ICE compiling the new test case in the patch. aarch64-none-elf regression test Okay. Okay

Re: [RFC][PR82479] missing popcount builtin detection

On Wed, Mar 7, 2018 at 8:26 AM, Richard Biener wrote: > On Tue, Mar 6, 2018 at 5:20 PM, Bin.Cheng wrote: >> On Mon, Mar 5, 2018 at 3:24 PM, Richard Biener >> wrote: >>> On Thu, Feb 8, 2018 at 1:41 AM, Kugan

Re: [PATCH] Ada: Fix s-oscons.ads generation

On 07/03/18 11:33, Arnaud Charlet wrote: The $(GNATLIBCFLAGS) are already included in $(GNATLIBCFLAGS_FOR_C). We must call the C compiler with the right machine flags. So, add $(GNATLIBCFLAGS_FOR_C) to $(OSCONS_EXTRACT). For example, on a bi-arch compiler supporting 32-bit and 64-bit

[PATCH] [ARC] Add/update combiner patterns.

From: claziss Hi Andrew, Please find the following patch which improves generating more instructions with .f flag (i.e., compare with zero). Ok to apply? Claudiu gcc/ 2018-01-26 Claudiu Zissulescu * config/arc/arc.md (add_shift): New

[PATCH] Add a few new contrib.texi entries, especially for people who perform GCC fuzzy testing and report bugs

Hi! As appreciation of the hard work of people doing fuzzy testing of GCC and reporting high quality bugs, I'd like to list them in contrib.texi. This patch just lists them in the GCC testing group, shall we have a special sub-list for the fuzzy testing? The patch also adds or updates a couple of

[Committed] GCC 6: S/390: Disable branch prediction

Bootstrapped and regression tested with z900 and z10 on s390x. gcc/ChangeLog: 2018-03-07 Andreas Krebbel Backport from mainline 2018-02-08 Andreas Krebbel * config/s390/s390-opts.h (enum indirect_branch):

Re: [PATCH] Document gcov-io (PR gcov-profile/84735).

On 03/07/2018 09:31 AM, Martin Liška wrote: Hi. Attempt of the patch is to explain that consumers of gcov tool should use the intermediate format instead of reading of the profile files. The format change is documented. ok -- Nathan Sidwell

Re: C++ PATCH for c++/84684, wrong caching when evaluating a constexpr function

On Tue, Mar 6, 2018 at 3:48 PM, Marek Polacek wrote: > On Tue, Mar 06, 2018 at 03:39:36PM -0500, Jason Merrill wrote: >> On Tue, Mar 6, 2018 at 1:13 PM, Marek Polacek wrote: >> > But I'm also wondering about massage_init_elt. It has >> > tree t =

Re: [PATCH] fix ICE in generic_overlap (PR 84526)

Ping: https://gcc.gnu.org/ml/gcc-patches/2018-02/msg01441.html Jeff, I know this is in your queue. I ping it because a bug with the same root cause was reported in RHBZ #1552639. On 02/26/2018 11:13 AM, Martin Sebor wrote: On 02/26/2018 10:39 AM, Jakub Jelinek wrote: On Mon, Feb 26, 2018 at

Re: [PR84620] output symbolic entry_view as data2, not addr

On Tue, Mar 6, 2018 at 2:28 AM, Jakub Jelinek wrote: > On Tue, Mar 06, 2018 at 03:13:11AM -0300, Alexandre Oliva wrote: >> Jakub wrote (in the BZ): >> >> > I meant to say: >> > The char * GTY ((tag ("dw_val_class_symview"))) val_symbolic_view; line >> > should come at the and of

libgo patch committed: push arena on AIX higher due to clashes

This libgo patch by Tony Reix changes the arena position on AIX higher to avoid clashes. Bootstrapped and ran Go testsuite on x86_64-pc-linux-gnu. Committed to mainline. Ian Index: gcc/go/gofrontend/MERGE === ---

Re: [PATCH] Fix ICE for static vars in offloaded functions

On 03/07/2018 02:29 PM, Richard Biener wrote: On Wed, 7 Mar 2018, Jakub Jelinek wrote: On Wed, Mar 07, 2018 at 02:20:26PM +0100, Tom de Vries wrote: Fix ICE for static vars in offloaded functions 2018-03-06 Tom de Vries PR lto/84592 * varpool.c

Re: [PATCH] Fix ICE for static vars in offloaded functions

On Wed, 7 Mar 2018, Tom de Vries wrote: > On 03/07/2018 02:29 PM, Richard Biener wrote: > > On Wed, 7 Mar 2018, Jakub Jelinek wrote: > > > > > On Wed, Mar 07, 2018 at 02:20:26PM +0100, Tom de Vries wrote: > > > > Fix ICE for static vars in offloaded functions > > > > > > > > 2018-03-06 Tom de

Re: [C++ Patch/RFC] PR 71169 ("[7/8 Regression] ICE on invalid C++ code in pop_nested_class"), PR 71832 and more

On Tue, Mar 6, 2018 at 5:00 PM, Paolo Carlini wrote: > On 06/03/2018 21:33, Jason Merrill wrote: >> >> Interesting, that seems like a promising idea. I'm not sure we need >> to do this based on an error in a default template arg, though; can we >> drop >> >> + ||

Re: [patch] Fix PR target/84277

On Tue, Mar 6, 2018 at 6:29 PM, Eric Botcazou wrote: >> this is the breakage of SEH on 64-bit Windows introduced by defaulting to >> the -freorder-blocks-and-partition optimization. It is fixed by: >> 1. Defining ASM_DECLARE_COLD_FUNCTION_NAME & >>

Re: [PATCH] Reject target_clones attribute in functions that can't be cloned (PR middle-end/84723)

On Tue, 6 Mar 2018, Jakub Jelinek wrote: > Hi! > > The following testcases show various reasons why a function definition > with target_clones attribute can't be cloned; instead of ICEing because > node->create_version_clone_with_body returns NULL and we dereference it, > this patch just

Re: [patch] Fix PR target/84277

> For the middle-end part I'd like to see output_function_exception_table take > an enum with two members with appropriate name - I see there wasn't > documentation for the function but your change doesn't make semantics more > clear, esp. > > - output_one_function_exception_table (0); > - if

Re: [PATCH] Add a few new contrib.texi entries, especially for people who perform GCC fuzzy testing and report bugs (take 2)

On Wed, 7 Mar 2018, Jakub Jelinek wrote: > Ok for trunk? > > 2018-03-07 Jakub Jelinek > > * doc/contrib.texi: Add entries for Martin Liska, David Malcolm, > Marek Polacek, extend Vladimir Makarov's, Jonathan Wakely's and > Volker Reichelt's entry and add

Re: [C++ Patch/RFC] PR 71169 ("[7/8 Regression] ICE on invalid C++ code in pop_nested_class"), PR 71832 and more

On Wed, Mar 7, 2018 at 10:55 AM, Paolo Carlini wrote: > Hi, > > On 07/03/2018 16:38, Jason Merrill wrote: >> >> On Tue, Mar 6, 2018 at 5:00 PM, Paolo Carlini >> wrote: >>> >>> On 06/03/2018 21:33, Jason Merrill wrote: Interesting,

Re: [PATCH] Fix reg-stack error-recovery ICE (PR inline-asm/84683)

On 03/06/2018 01:03 AM, Uros Bizjak wrote: > On Mon, Mar 5, 2018 at 9:42 PM, Jakub Jelinek wrote: >> Hi! >> >> If we discover some bad inline-asm during reg-stack processing and we >> error on those, we replace that inline-asm with a (use (const_int 0)) >> and therefore the

Re: [C++ Patch/RFC] PR 71169 ("[7/8 Regression] ICE on invalid C++ code in pop_nested_class"), PR 71832 and more

Hi, On 07/03/2018 16:38, Jason Merrill wrote: On Tue, Mar 6, 2018 at 5:00 PM, Paolo Carlini wrote: On 06/03/2018 21:33, Jason Merrill wrote: Interesting, that seems like a promising idea. I'm not sure we need to do this based on an error in a default template arg,