[PATCH][debug] Add -gforce-named-dies

2018-08-22 Thread Tom de Vries
[ was: Re: [RFC][debug] Add -greadable-dwarf ] On 08/21/2018 02:22 PM, Tom de Vries wrote: > Currently doing a bootstrap and reg-test on x86_64 of attached patch > with -gforce-named-dies enabled by default. That went well. There are some understandable failures in

Re: Walk pointer_to and reference_to chain in free_lang_data

2018-08-22 Thread Richard Biener
On Tue, 21 Aug 2018, Jan Hubicka wrote: > Hi, > extra sanity checking I am going to send in followup patch noticed that we > stream pointer types that was never seen by free_lang_data. This is because > they are referenced by TYPE_POINTER_TO list and are inserted into the gimple > statements

Re: [PATCH] Unconditionally use MAX_EXPR/MIN_EXPR for MAX/MIN intrinsics

2018-08-22 Thread Janne Blomqvist
On Sun, Aug 19, 2018 at 10:47 PM Thomas Koenig wrote: > Hi Janne, > > > On Fri, Aug 10, 2018 at 11:47 PM, Janne Blomqvist < > blomqvist.ja...@gmail.com > >> wrote: > > > >> For floating point types, the question is what MAX(a, NaN) or MIN(a, > >> NaN) should return (where "a" is a normal

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-22 Thread Richard Biener
On Wed, 22 Aug 2018, Bernd Edlinger wrote: > On 08/22/18 09:26, Richard Biener wrote: > > On Wed, 22 Aug 2018, Bernd Edlinger wrote: > > > >> On 08/21/18 10:59, Richard Biener wrote: > >>> On Tue, 21 Aug 2018, Bernd Edlinger wrote: > >>> > gcc -S -O2 -Wall -Wformat-overflow

Re: [PATCH v2][C][ADA] use function descriptors instead of trampolines in C

2018-08-22 Thread Uecker, Martin
Am Dienstag, den 21.08.2018, 21:34 + schrieb Joseph Myers: > On Tue, 21 Aug 2018, Uecker, Martin wrote: > > > > I don't see why this is target-specific (if it is, the documentation for  > > > users in invoke.texi should explain what targets it works for and what it  > > > doesn't work for)

Re: Walk pointer_to and reference_to chain in free_lang_data

2018-08-22 Thread Richard Biener
On Wed, 22 Aug 2018, Jan Hubicka wrote: > > On Tue, 21 Aug 2018, Jan Hubicka wrote: > > > > > Hi, > > > extra sanity checking I am going to send in followup patch noticed that we > > > stream pointer types that was never seen by free_lang_data. This is > > > because > > > they are referenced

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-22 Thread Bernd Edlinger
On 08/22/18 09:26, Richard Biener wrote: > On Wed, 22 Aug 2018, Bernd Edlinger wrote: > >> On 08/21/18 10:59, Richard Biener wrote: >>> On Tue, 21 Aug 2018, Bernd Edlinger wrote: >>> gcc -S -O2 -Wall -Wformat-overflow -ftrack-macro-expansion=0 -fshort-wchar builtin-sprintf-warn-20.c

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-22 Thread Richard Biener
On Wed, 22 Aug 2018, Bernd Edlinger wrote: > On 08/21/18 10:59, Richard Biener wrote: > > On Tue, 21 Aug 2018, Bernd Edlinger wrote: > > > >> gcc -S -O2 -Wall -Wformat-overflow -ftrack-macro-expansion=0 -fshort-wchar > >> builtin-sprintf-warn-20.c > >> builtin-sprintf-warn-20.c: In function

Re: Walk pointer_to and reference_to chain in free_lang_data

2018-08-22 Thread Jan Hubicka
> On Tue, 21 Aug 2018, Jan Hubicka wrote: > > > Hi, > > extra sanity checking I am going to send in followup patch noticed that we > > stream pointer types that was never seen by free_lang_data. This is because > > they are referenced by TYPE_POINTER_TO list and are inserted into the gimple > >

Re: Walk pointer_to and reference_to chain in free_lang_data

2018-08-22 Thread Jan Hubicka
> > tree type_decl = build_decl (input_location, TYPE_DECL, > > > >get_identifier ("__asan_global"), ret); > > > > DECL_IGNORED_P (type_decl) = 1; > > > > DECL_ARTIFICIAL

[PATCH] Fix PR86945

2018-08-22 Thread Richard Biener
The following fixes PR86945, single-case switch conversion to range check using signed arithmetic that can overflow. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2018-08-22 Richard Biener PR tree-optimization/86945 * tree-cfg.c

Only test STMT_VINFO_STRIDED_P for the first statement in a group

2018-08-22 Thread Richard Sandiford
get_load_store_type & co were testing STMT_VINFO_STRIDED_P on individual statements in a group instead of the first. This has no effect on its own, but is needed by a later patch. Tested on aarch64-linux-gnu (with and without SVE), aarch64_be-elf and x86_64-linux-gnu. OK to install? Richard

Make safe_iterator inline friends

2018-08-22 Thread François Dumont
Now that _Safe_iterator has been revisited I would like to cleanup its operators to make them globals and inline friends as much as possible. This patch transform operator-(const _Safe_iterator<>&, difference_type) and operator+(const _Safe_iterator<>&, difference_type) into global namespace

Re: Async I/O patch with compilation fix

2018-08-22 Thread Thomas Koenig
Hi David, This patch broke bootstrap on AIX again. This is completely unacceptable. Again, sorry for the breakage. I faced quite some challenges trying to get bootstrap to work on gcc119. Despite quite a few e-mails (plus hints in a PR) that I received, none of the hints for bootstrap I got

Re: [PATCH] Make strlen range computations more conservative

2018-08-22 Thread Jeff Law
On 08/22/2018 11:22 AM, Bernd Edlinger wrote: > On 08/22/18 18:05, Martin Sebor wrote: >> On 08/21/2018 10:05 PM, Bernd Edlinger wrote: >>> On 08/22/18 00:25, Jeff Law wrote: On 08/21/2018 02:43 AM, Richard Biener wrote: > On Mon, 20 Aug 2018, Bernd Edlinger wrote: [ snip. ]

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-22 Thread Bernd Edlinger
On 08/23/18 00:50, Jeff Law wrote: > On 08/22/2018 02:14 AM, Richard Biener wrote: >> On Wed, 22 Aug 2018, Bernd Edlinger wrote: >> >>> On 08/22/18 09:26, Richard Biener wrote: On Wed, 22 Aug 2018, Bernd Edlinger wrote: > On 08/21/18 10:59, Richard Biener wrote: >> On Tue, 21 Aug

Re: [PATCH] Signed zero for {max,min}val intrinsics

2018-08-22 Thread Jerry DeLisle
On 08/22/2018 01:06 PM, Janne Blomqvist wrote: The Fortran standard specifies (e.g. F2018 7.4.3.2) that intrinsic procedures shall treat positive and negative real zero as equivalent, unless it is explicitly specified otherwise. For {max,min}val there is no such explicit mention. Thus, remove

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-22 Thread Jeff Law
On 08/22/2018 05:22 PM, Bernd Edlinger wrote: > On 08/23/18 00:50, Jeff Law wrote: >> On 08/22/2018 02:14 AM, Richard Biener wrote: >>> On Wed, 22 Aug 2018, Bernd Edlinger wrote: >>> On 08/22/18 09:26, Richard Biener wrote: > On Wed, 22 Aug 2018, Bernd Edlinger wrote: > >> On

C++ PATCH for c++/87029, Implement -Wredundant-move

2018-08-22 Thread Marek Polacek
Now that we have -Wpessimizing-move implemented, it was fairly easy to extend it to -Wredundant-move, which warns about redundant calls to std::move; it's supposed to detect cases where the compiler is obliged to treat an object as if it were an rvalue, so calling std::move is pointless. Since we

Re: [PATCH] Make strlen range computations more conservative

2018-08-22 Thread Jeff Law
On 08/21/2018 10:15 PM, Bernd Edlinger wrote: > On 08/22/18 00:43, Jeff Law wrote: >> [ I'm still digesting, but saw something in this that ought to be broken >> out... ] >> >> On 08/19/2018 09:55 AM, Bernd Edlinger wrote: >>> diff -Npur gcc/tree-ssa-dse.c gcc/tree-ssa-dse.c >>> ---

[PATCH] Fix tests that fail in C++98 mode

2018-08-22 Thread Jonathan Wakely
* testsuite/23_containers/deque/capacity/max_size.cc: Fix test for C++98 mode. * testsuite/23_containers/deque/modifiers/assign/1.cc: Likewise. * testsuite/23_containers/list/modifiers/assign/1.cc: Likewise. *

Re: [PATCH] print full STRING_CST in Gimple dumps (PR 87052)

2018-08-22 Thread Richard Biener
On Wed, Aug 22, 2018 at 4:56 AM Martin Sebor wrote: > > In the discussion of the fallout from the enhancement for pr71625 > it was pointed out that STRING_CSts in Gimple dumps extend only > to the first nul and don't include any subsequent characters, > and that this makes the dumps harder to

Re: [PATCH, driver specs][1] Put -flto-partition= on the collect2 c/l

2018-08-22 Thread Iain Sandoe
> On 20 Aug 2018, at 11:01, Richard Biener wrote: > > On Sat, Aug 18, 2018 at 9:00 PM Iain Sandoe wrote: >> While working on the Darwin LTO issues I noticed that collect2 looks for >> "-flto-partition=none” in its command line option, but it doesn’t get passed. >> >> So - is the attached

[PATCH] combine: Do another check before splitting a parallel (PR86771)

2018-08-22 Thread Segher Boessenkool
When combine splits a resulting parallel into its two SETs, it has to place one at i2, and the other stays at i3. This does not work if the destination of the SET that will be placed at i2 is modified between i2 and i3. This patch fixes it. Tested on powerpc64-linux {-m32,-m64}, and the

[1/2] Fix bogus double reduction (PR 86725)

2018-08-22 Thread Richard Sandiford
This patch is the first part of the fix for PR 86725. We would treat x_1 in: outer1: x_1 = PHI ; ... inner: x_2 = ...x_1...; ... x_3 = ...; ... outer2: x_4 = PHI ; ... as a double reduction without checking what kind of statement x_2

Re: [2/2] Fix bogus inner induction (PR 86725)

2018-08-22 Thread Richard Biener
On Wed, Aug 22, 2018 at 11:34 AM Richard Sandiford wrote: > > This patch is the second part of the fix for PR 86725. The problem > in the original test is that for: > > outer1: > x_1 = PHI ; > ... > > inner: > x_2 = PHI ; > ... > x_3 = ...; > ... > > outer2: >

Re: Only test STMT_VINFO_STRIDED_P for the first statement in a group

2018-08-22 Thread Richard Biener
On Wed, Aug 22, 2018 at 11:27 AM Richard Sandiford wrote: > > get_load_store_type & co were testing STMT_VINFO_STRIDED_P on individual > statements in a group instead of the first. This has no effect on > its own, but is needed by a later patch. > > Tested on aarch64-linux-gnu (with and without

Re: [1/2] Fix bogus double reduction (PR 86725)

2018-08-22 Thread Richard Biener
On Wed, Aug 22, 2018 at 11:31 AM Richard Sandiford wrote: > > This patch is the first part of the fix for PR 86725. We would > treat x_1 in: > > outer1: > x_1 = PHI ; > ... > > inner: > x_2 = ...x_1...; > ... > x_3 = ...; > ... > > outer2: >

[PATCH, Darwin] Update LTO specs to match gcc/gcc.c

2018-08-22 Thread Iain Sandoe
Hi, I committed the following as obvious. thanks Iain 2018-08-22 Iain Sandoe gcc/ * config/darwin.h (LINK_COMMAND_SPEC_A): Sync LTO options with the sequence used in gcc/gcc.c. Index: gcc/config/darwin.h

Re: [PATCH, driver specs][3] Put -flto-partition= on the collect2 c/l

2018-08-22 Thread Iain Sandoe
> On 20 Aug 2018, at 11:01, Richard Biener wrote: > > On Sat, Aug 18, 2018 at 9:00 PM Iain Sandoe wrote: >> >> Hi >> >> While working on the Darwin LTO issues I noticed that collect2 looks for >> "-flto-partition=none” in its command line option, but it doesn’t get passed. >> >> So - is

Re: [PATCH] Call braced_list_to_string after array size is fixed

2018-08-22 Thread Bernd Edlinger
Hi, this is a minor update to the previous version, which does no longer try to fold the array initializer of VLAs, due to this initializer hitting an assertion in my varasm patch, I believe it is certainly not worth the risk to do that optimization with VLAs. Bootstrapped and reg-tested on

Re: [PATCH, driver specs][3] Put -flto-partition= on the collect2 c/l

2018-08-22 Thread Richard Biener
On Wed, Aug 22, 2018 at 3:06 PM Iain Sandoe wrote: > > > > On 20 Aug 2018, at 11:01, Richard Biener wrote: > > > > On Sat, Aug 18, 2018 at 9:00 PM Iain Sandoe wrote: > >> > >> Hi > >> > >> While working on the Darwin LTO issues I noticed that collect2 looks for > >> "-flto-partition=none” in

Re: [PATCH, driver specs][2] Put -flto-partition= on the collect2 c/l

2018-08-22 Thread Iain Sandoe
> On 20 Aug 2018, at 11:01, Richard Biener wrote: > > On Sat, Aug 18, 2018 at 9:00 PM Iain Sandoe wrote: >> >> I plan on making Darwin default to fno-lto for link unless there’s an >> “flto*” on the link line, since otherwise there’s a process launch for every >> object on the c/l to do

Re: [PATCH, driver specs][2] Put -flto-partition= on the collect2 c/l

2018-08-22 Thread Richard Biener
On Wed, Aug 22, 2018 at 2:56 PM Iain Sandoe wrote: > > > > On 20 Aug 2018, at 11:01, Richard Biener wrote: > > > > On Sat, Aug 18, 2018 at 9:00 PM Iain Sandoe wrote: > >> > > >> I plan on making Darwin default to fno-lto for link unless there’s an > >> “flto*” on the link line, since otherwise

Re: [Patch, Fortran, F08] PR 86888: allocatable components of indirectly recursive type

2018-08-22 Thread Paul Richard Thomas
Hi Janus, > the attached patch fixes the PR in the subject line in a rather > straightforward fashion. Pointer components of indirectly recursive > type are working already, as well as allocatable components of > directly recursive type. It seems this case was simply forgotten. That is correct.

Re: Make the vectoriser drop to strided accesses for stores with gaps

2018-08-22 Thread Richard Sandiford
Richard Biener writes: > On Fri, Jul 20, 2018 at 12:57 PM Richard Sandiford > wrote: >> >> We could vectorise: >> >> for (...) >>{ >> a[0] = ...; >> a[1] = ...; >> a[2] = ...; >> a[3] = ...; >> a += stride; >>} >> >> (including

Re: [PATCH] Make strlen range computations more conservative

2018-08-22 Thread Bernd Edlinger
Hi, this is an update (v5) of my patch: As discussed earlier, this version does no longer enable -fassume-zero-terminated-char-arrays with -Ofast. I am ready to remove the -fassume-zero-terminated-char-arrays altogether if we decide what to do with the code-gen test cases that still use it

Re: [PATCH, driver specs][1] Put -flto-partition= on the collect2 c/l

2018-08-22 Thread Richard Biener
On Wed, Aug 22, 2018 at 2:51 PM Iain Sandoe wrote: > > > > On 20 Aug 2018, at 11:01, Richard Biener wrote: > > > > On Sat, Aug 18, 2018 at 9:00 PM Iain Sandoe wrote: > > >> While working on the Darwin LTO issues I noticed that collect2 looks for > >> "-flto-partition=none” in its command line

[PATCH] Change AArch64 specific FMAX/FMIN tests into generic MAX_EXPR/MIN_EXPR tests

2018-08-22 Thread Szabolcs Nagy
gfortran now always uses MAX_EXPR/MIN_EXPR for MAX/MIN intrinsics, so the AArch64 specific FMAX/FMIN tests are no longer valid. 2018-08-22 Szabolcs Nagy * gfortran.dg/max_fmax_aarch64.f90: Rename to... * gfortran.dg/max_expr.f90: ...this. *

[PATCH][debug] Add -gdescriptive-dies

2018-08-22 Thread Tom de Vries
[ was: Re: [PATCH][debug] Add -gforce-named-dies ] On 08/22/2018 11:46 AM, Tom de Vries wrote: > On 08/22/2018 08:56 AM, Tom de Vries wrote: >> This is an undocumented developer-only option, because using this option may >> change behaviour of dwarf consumers, f.i., gdb shows the artificial >>

Re: [PATCH][Middle-end]patch for fixing PR 86519

2018-08-22 Thread Qing Zhao
thanks. now, I can repeat the failure. Qing > On Aug 21, 2018, at 7:25 PM, Paul Hua wrote: > > On Wed, Aug 22, 2018 at 2:15 AM Qing Zhao > wrote: >> >> >>> On Aug 21, 2018, at 8:07 AM, Paul Hua wrote: >>> >>> Hi, Qing, >>> >>> The cfarm machine gcc23 can build

Re: [PATCH] Check the STRING_CSTs in varasm.c

2018-08-22 Thread Bernd Edlinger
Hi, this is an updated version of my STRING_CSTs checking in varasm.c patch. It tries to answer the questions that were raised in th GO string literals thread. The answers are: a) strings with TYPE_SIZE_UNIT == NULL do exist, but only for STRING_CSTs in constructors of flexible array struct

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-22 Thread Bernd Edlinger
On 08/23/18 01:36, Jeff Law wrote: > On 08/22/2018 05:22 PM, Bernd Edlinger wrote: >> On 08/23/18 00:50, Jeff Law wrote: >>> On 08/22/2018 02:14 AM, Richard Biener wrote: On Wed, 22 Aug 2018, Bernd Edlinger wrote: > On 08/22/18 09:26, Richard Biener wrote: >> On Wed, 22 Aug 2018,

Re: [PATCH v3 01/10] Initial TI PRU GCC port

2018-08-22 Thread Dimitar Dimitrov
On Monday, 8/20/2018 11:12:23 EEST Jeff Law wrote: > On 08/15/2018 10:49 PM, Dimitar Dimitrov wrote: > > ChangeLog: > > > > 2018-07-27 Dimitar Dimitrov > > > > * configure: Regenerate. > > * configure.ac: Add PRU target. > > > > gcc/ChangeLog: > > > > 2018-07-27 Dimitar Dimitrov

Re: [PATCH] Add a character size parameter to c_strlen/get_range_strlen

2018-08-22 Thread Jeff Law
On 08/22/2018 02:14 AM, Richard Biener wrote: > On Wed, 22 Aug 2018, Bernd Edlinger wrote: > >> On 08/22/18 09:26, Richard Biener wrote: >>> On Wed, 22 Aug 2018, Bernd Edlinger wrote: >>> On 08/21/18 10:59, Richard Biener wrote: > On Tue, 21 Aug 2018, Bernd Edlinger wrote: > >>

Re: [PATCH] Make strlen range computations more conservative

2018-08-22 Thread Bernd Edlinger
On 08/23/18 00:57, Martin Sebor wrote: > On 08/22/2018 04:34 PM, Jeff Law wrote: >> On 08/22/2018 11:22 AM, Bernd Edlinger wrote: >>> On 08/22/18 18:05, Martin Sebor wrote: On 08/21/2018 10:05 PM, Bernd Edlinger wrote: > On 08/22/18 00:25, Jeff Law wrote: >> On 08/21/2018 02:43 AM,

Re: Make safe_iterator inline friends

2018-08-22 Thread Jonathan Wakely
On 22/08/18 23:08 +0200, François Dumont wrote: Only operator== and != remains outside _Safe_iterator because all my attempts to make them inline friends failed. I understand that an inline friend within a base class is not a very clean design. Compiler error was:

Re: [libiberty patch] Fix PGO bootstrap

2018-08-22 Thread Ian Lance Taylor via gcc-patches
On Wed, Aug 22, 2018 at 11:34 AM, Nathan Sidwell wrote: > Martin discovered that my recent pex-unix change broke profiled bootstrap, > and also confirmed this patch fixes the problem. > > The change is to break the two live ranges of 'bad_fn' into separate scoped > declarations each entirely

Re: patch to bug #86829

2018-08-22 Thread Jeff Law
On 08/22/2018 06:02 AM, Richard Biener wrote: > On Tue, Aug 21, 2018 at 11:27 PM Jeff Law wrote: >> >> On 08/21/2018 02:08 PM, Giuliano Augusto Faulin Belinassi wrote: Just as an example, compare the results for x = 0x1.fp1023 >>> >>> Thank you for your answer and the

Re: [PATCH] treat -Wxxx-larger-than=HWI_MAX special (PR 86631)

2018-08-22 Thread Martin Sebor
On 08/20/2018 06:14 AM, Richard Biener wrote: On Thu, Jul 26, 2018 at 10:52 PM Martin Sebor wrote: On 07/26/2018 08:58 AM, Martin Sebor wrote: On 07/26/2018 02:38 AM, Richard Biener wrote: On Wed, Jul 25, 2018 at 5:54 PM Martin Sebor wrote: On 07/25/2018 08:57 AM, Jakub Jelinek wrote:

Re: [PATCH] Make strlen range computations more conservative

2018-08-22 Thread Martin Sebor
On 08/22/2018 04:34 PM, Jeff Law wrote: On 08/22/2018 11:22 AM, Bernd Edlinger wrote: On 08/22/18 18:05, Martin Sebor wrote: On 08/21/2018 10:05 PM, Bernd Edlinger wrote: On 08/22/18 00:25, Jeff Law wrote: On 08/21/2018 02:43 AM, Richard Biener wrote: On Mon, 20 Aug 2018, Bernd Edlinger

Allow target to emit LTO early debug to a separate LTO file.

2018-08-22 Thread Iain Sandoe
Hi Tom, Richi, This is something I was experimenting with to try and solve platform problems with early debug. Not a “finished patch” (I’ve removed the Darwin back-end parts) but would like your comments on the central idea. This is to switch to the alternate LTO file (this process already

Re: [PATCH][Middle-end]patch for fixing PR 86519

2018-08-22 Thread Jeff Law
On 08/22/2018 11:05 AM, Qing Zhao wrote: > >> On Aug 22, 2018, at 10:50 AM, Rainer Orth >> wrote: >> >> Hi Qing, >> >>> From the comments you put into PR86519, for SPARC, looks like that only >>> 32-bit sparc has the problem. >>> sparcv9 does NOT have the same issue. >>> >>> I was trying to

Re: [PATCH] Check the STRING_CSTs in varasm.c

2018-08-22 Thread Bernd Edlinger
On 08/22/18 22:54, Martin Sebor wrote: > On 08/22/2018 08:27 AM, Bernd Edlinger wrote: >> Hi, >> >> >> this is an updated version of my STRING_CSTs checking in varasm.c >> patch. >> >> It tries to answer the questions that were raised in th GO string literals >> thread. >> >> The answers are: >>

[PATCH] Signed zero for {max,min}val intrinsics

2018-08-22 Thread Janne Blomqvist
The Fortran standard specifies (e.g. F2018 7.4.3.2) that intrinsic procedures shall treat positive and negative real zero as equivalent, unless it is explicitly specified otherwise. For {max,min}val there is no such explicit mention. Thus, remove code to handle signed zeros. Regtested on

[PATCH] PR libstdc++/78448 limit vector::max_size and deque::max_size

2018-08-22 Thread Jonathan Wakely
The container requirements imply that max_size() can't exceed the maximum value of the container's difference_type. Enforce this for std::vector and std::deque, and add checks to ensure the container doesn't grow larger than that. PR libstdc++/78448 * include/bits/deque.tcc

[PATCH] PR libstdc++/87061 remove pmr type aliases for COW strings

2018-08-22 Thread Jonathan Wakely
The pmr aliases for basic_string and match_results are incompatible with the gcc4-compatible ABI because the Copy-On-Write basic_string class doesn't support C++11 allocators. PR libstdc++/87061 * include/experimental/regex [!_GLIBCXX_USE_CXX11_ABI]

Re: [PATCH] Check the STRING_CSTs in varasm.c

2018-08-22 Thread Martin Sebor
On 08/22/2018 08:27 AM, Bernd Edlinger wrote: Hi, this is an updated version of my STRING_CSTs checking in varasm.c patch. It tries to answer the questions that were raised in th GO string literals thread. The answers are: a) strings with TYPE_SIZE_UNIT == NULL do exist, but only for

Re: [PATCH] Make strlen range computations more conservative

2018-08-22 Thread Bernd Edlinger
On 08/23/18 00:34, Jeff Law wrote: > On 08/22/2018 11:22 AM, Bernd Edlinger wrote: >> On 08/22/18 18:05, Martin Sebor wrote: >>> On 08/21/2018 10:05 PM, Bernd Edlinger wrote: On 08/22/18 00:25, Jeff Law wrote: > On 08/21/2018 02:43 AM, Richard Biener wrote: >> On Mon, 20 Aug 2018,

Re: [PATCH][debug] Add -gforce-named-dies

2018-08-22 Thread Tom de Vries
On 08/22/2018 08:56 AM, Tom de Vries wrote: > This is an undocumented developer-only option, because using this option may > change behaviour of dwarf consumers, f.i., gdb shows the artificial variables: > ... > (gdb) info locals > a = 0x7fffda90 "\005" > D.4278 = > ... I just found in the

VRP: make range_includes_zero_p handle value_ranges

2018-08-22 Thread Aldy Hernandez
On 08/21/2018 05:46 AM, Richard Biener wrote: On Wed, Aug 15, 2018 at 3:33 AM Aldy Hernandez wrote: Finally, my apologies for including a tiny change to the POINTER_PLUS_EXPR handling code as well. It came about the same set of auditing tests. Bah, please split up things here ;) I've

[PATCH] PR libstdc++/77854 document size_type for containers

2018-08-22 Thread Jonathan Wakely
PR libstdc++/77854 * doc/xml/manual/status_cxx1998.xml: Document size_type and difference_type for containers. * doc/html/*: Regenerate. Committed to trunk. commit 6477192f0b0c0c482f3d8e5ada1bcada0d200ddf Author: Jonathan Wakely Date: Wed Aug 22 13:08:56 2018

[PATCH] Fix PR86988

2018-08-22 Thread Richard Biener
Bootstrapped and tested on x86_64-unknown-linux-gnu, applied to trunk. Richard. 2018-08-22 Richard Biener PR tree-optimization/86988 * tree-vrp.c (vrp_prop::check_mem_ref): Bail out on VLAs. * g++.dg/pr86988.C: New testcase. diff --git

Re: patch to bug #86829

2018-08-22 Thread Richard Biener
On Tue, Aug 21, 2018 at 11:27 PM Jeff Law wrote: > > On 08/21/2018 02:08 PM, Giuliano Augusto Faulin Belinassi wrote: > >> Just as an example, compare the results for > >> x = 0x1.fp1023 > > > > Thank you for your answer and the counterexample. :-) > > > >> If we had useful range info

[2/2] Fix bogus inner induction (PR 86725)

2018-08-22 Thread Richard Sandiford
This patch is the second part of the fix for PR 86725. The problem in the original test is that for: outer1: x_1 = PHI ; ... inner: x_2 = PHI ; ... x_3 = ...; ... outer2: x_4 = PHI ; ... there are corner cases in which it is possible to classify the inner

Re: [PATCH][debug] Fix handling of vlas in lto

2018-08-22 Thread Richard Biener
On Tue, 21 Aug 2018, Tom de Vries wrote: > On 08/20/2018 03:09 PM, Richard Biener wrote: > > On Fri, 17 Aug 2018, Tom de Vries wrote: > > > >> I've rewritten the patch to work generically, not just for > >> DW_AT_upper_bound, > >> and to reuse the code already there in add_scalar_info. > >> >

Re: [PATCH] Change AArch64 specific FMAX/FMIN tests into generic MAX_EXPR/MIN_EXPR tests

2018-08-22 Thread Kyrill Tkachov
Hi all, On 22/08/18 15:57, Janne Blomqvist wrote: On Wed, Aug 22, 2018 at 4:16 PM, Szabolcs Nagy wrote: > gfortran now always uses MAX_EXPR/MIN_EXPR for MAX/MIN intrinsics, so the > AArch64 specific FMAX/FMIN tests are no longer valid. > > 2018-08-22 Szabolcs Nagy > > *

Re: [PATCH][Middle-end]patch for fixing PR 86519

2018-08-22 Thread Qing Zhao
Hi, Rainer, >From the comments you put into PR86519, for SPARC, looks like that only 32-bit >sparc has the problem. sparcv9 does NOT have the same issue. I was trying to find the string to represent 32-bit sparc target, but haven’t found it. my guess is: sparc32*-*-*, is this correct?

[PATCH] Improve checks in c_strlen (PR 87053)

2018-08-22 Thread Bernd Edlinger
Hi! This patch adds some more checks to c_getstr to fix PR middle-end/87053 wrong code bug. Unfortunately this patch alone is not sufficient to fix the problem, but also the patch for PR 86714 that hardens c_getstr is necessary to prevent the wrong folding. Bootstrapped and reg-tested on top

Re: [PATCH] Change AArch64 specific FMAX/FMIN tests into generic MAX_EXPR/MIN_EXPR tests

2018-08-22 Thread Janne Blomqvist
On Wed, Aug 22, 2018 at 4:16 PM, Szabolcs Nagy wrote: > gfortran now always uses MAX_EXPR/MIN_EXPR for MAX/MIN intrinsics, so the > AArch64 specific FMAX/FMIN tests are no longer valid. > > 2018-08-22 Szabolcs Nagy > > * gfortran.dg/max_fmax_aarch64.f90: Rename to... > *

Re: [PATCH] print full STRING_CST in Gimple dumps (PR 87052)

2018-08-22 Thread Martin Sebor
On 08/22/2018 06:48 AM, Richard Biener wrote: On Wed, Aug 22, 2018 at 4:56 AM Martin Sebor wrote: In the discussion of the fallout from the enhancement for pr71625 it was pointed out that STRING_CSts in Gimple dumps extend only to the first nul and don't include any subsequent characters, and

Re: [PATCH v2][C][ADA] use function descriptors instead of trampolines in C

2018-08-22 Thread Joseph Myers
On Wed, 22 Aug 2018, Uecker, Martin wrote: > Am Dienstag, den 21.08.2018, 21:34 + schrieb Joseph Myers: > > On Tue, 21 Aug 2018, Uecker, Martin wrote: > > > > > > I don't see why this is target-specific (if it is, the documentation > > > > for  > > > > users in invoke.texi should explain

Re: [PATCH][Middle-end]patch for fixing PR 86519

2018-08-22 Thread Rainer Orth
Hi Qing, > From the comments you put into PR86519, for SPARC, looks like that only > 32-bit sparc has the problem. > sparcv9 does NOT have the same issue. > > I was trying to find the string to represent 32-bit sparc target, but > haven’t found it. > > my guess is: sparc32*-*-*, is this

Re: Optimization in load_generic_interfaces()

2018-08-22 Thread Thomas Koenig
Hi Andrew, [please also copy in gcc-patches for patches] I'm continuing to look for optimizations to improve compile times for files which USE large numbers of modules containing large numbers of symbols. When the number of symbols becomes very large, find_symbol() becomes a slow- point,

Re: [PATCH] Make strlen range computations more conservative

2018-08-22 Thread Martin Sebor
On 08/21/2018 10:05 PM, Bernd Edlinger wrote: On 08/22/18 00:25, Jeff Law wrote: On 08/21/2018 02:43 AM, Richard Biener wrote: On Mon, 20 Aug 2018, Bernd Edlinger wrote: [ snip. ] Yes, I found some peanuts on my way. For instance this fix for PR middle-end/86121 survives bootstrap on it's

Re: [PATCH] Improve checks in c_strlen (PR 87053)

2018-08-22 Thread Martin Sebor
On 08/22/2018 08:41 AM, Bernd Edlinger wrote: Hi! This patch adds some more checks to c_getstr to fix PR middle-end/87053 wrong code bug. Unfortunately this patch alone is not sufficient to fix the problem, but also the patch for PR 86714 that hardens c_getstr is necessary to prevent the

Re: Optimization in load_generic_interfaces()

2018-08-22 Thread Andrew Benson
Hi Thomas, Thanks for the review and approval (and for reminding me to CC gcc-patches). I'm still working on getting my sourceware account for svn access set up, so I can't commit the patch myself yet. If you (or anyone else) wants to go ahead an commit it that would be good - otherwise I'll

Re: [PATCH] Make strlen range computations more conservative

2018-08-22 Thread Bernd Edlinger
On 08/22/18 18:05, Martin Sebor wrote: > On 08/21/2018 10:05 PM, Bernd Edlinger wrote: >> On 08/22/18 00:25, Jeff Law wrote: >>> On 08/21/2018 02:43 AM, Richard Biener wrote: On Mon, 20 Aug 2018, Bernd Edlinger wrote: >>> [ snip. ] >>> > Yes, I found some peanuts on my way. > >

Re: Optimization in load_generic_interfaces()

2018-08-22 Thread Andrew Benson
Hi Thomas, I have my sourceware account active now, so I should be able to commit this myself. I'll do so right away. Thanks, Andrew On Wednesday, August 22, 2018 5:43:30 PM PDT Thomas Koenig wrote: > Hi Andrew, > > [please also copy in gcc-patches for patches] > > > I'm continuing to look

Re: [PATCH][Middle-end]patch for fixing PR 86519

2018-08-22 Thread Qing Zhao
> On Aug 22, 2018, at 10:50 AM, Rainer Orth > wrote: > > Hi Qing, > >> From the comments you put into PR86519, for SPARC, looks like that only >> 32-bit sparc has the problem. >> sparcv9 does NOT have the same issue. >> >> I was trying to find the string to represent 32-bit sparc target,

Re: [Patch, Fortran, F08] PR 86888: allocatable components of indirectly recursive type

2018-08-22 Thread Janus Weil
Am Mi., 22. Aug. 2018 um 15:44 Uhr schrieb Paul Richard Thomas : > > > the attached patch fixes the PR in the subject line in a rather > > straightforward fashion. Pointer components of indirectly recursive > > type are working already, as well as allocatable components of > > directly recursive

[PATCH, rs6000] inline expansion of str[n]cmp using vec/vsx instructions

2018-08-22 Thread Aaron Sawdey
This patch teaches rs6000 inline expansion of strcmp/strncmp how to generate vector/vsx code for power8/power9 processors. Compares 16 bytes and longer are generated using the vector code, which is considerably faster than the gpr based code. Bootstrap/regtest passes on ppc64 (power8) and

Re: Optimization in load_generic_interfaces()

2018-08-22 Thread Andrew Benson
Committed as r263784. Thanks, Andrew On Wednesday, August 22, 2018 5:43:30 PM PDT Thomas Koenig wrote: > Hi Andrew, > > [please also copy in gcc-patches for patches] > > > I'm continuing to look for optimizations to improve compile times for > > files > > which USE large numbers of modules

[libiberty patch] Fix PGO bootstrap

2018-08-22 Thread Nathan Sidwell
Martin discovered that my recent pex-unix change broke profiled bootstrap, and also confirmed this patch fixes the problem. The change is to break the two live ranges of 'bad_fn' into separate scoped declarations each entirely within the child or the parent. While there, rename a local

[libiberty patch] Fix PGO bootstrap

2018-08-22 Thread Nathan Sidwell
Martin discovered that my recent pex-unix change broke profiled bootstrap, and also confirmed this patch fixes the problem. The change is to break the two live ranges of 'bad_fn' into separate scoped declarations each entirely within the child or the parent. While there, rename a local

Re: Async I/O patch with compilation fix

2018-08-22 Thread David Edelsohn
Thomas, This patch broke bootstrap on AIX again. This is completely unacceptable. In file included from */nasfarm/edelsohn/src/src/libgfortran/runtime/error.c:28*: */nasfarm/edelsohn/src/src/libgfortran/io/async.h:333:3:* *error: *unknown type name '*__gthread_cond_t*' 333 |

[PATCH] DWARF: Call set_indirect_string on DW_MACINFO_start_file

2018-08-22 Thread H.J. Lu
Since -gsplit-dwarf -g3 will output filename as indirect string, call set_indirect_string on DW_MACINFO_start_file for -gsplit-dwarf -g3. OK for trunk? H.J. -- PR debug/79342 * dwarf2out.c (save_macinfo_strings): Call set_indirect_string on DW_MACINFO_start_file for

Re: GCC fixinclude help

2018-08-22 Thread Bruce Korb
On 08/15/2018 02:34 PM, Albert Chin-A-Young wrote: Don't suppose you have time to help with: https://gcc.gnu.org/ml/gcc/2018-08/msg00102.html David Edelsohn is correct: 6. Now that you have the right things happening, synchronize the $(srcdir)/tests/base directory with the

PING^1: [PATCH] Set start_location to 0 if we ran out of line map space

2018-08-22 Thread H.J. Lu
PING. -- Forwarded message -- From: H.J. Lu Date: Wed, Aug 15, 2018 at 4:33 AM Subject: [PATCH] Set start_location to 0 if we ran out of line map space To: gcc-patches@gcc.gnu.org With profiledbootstrap and --with-build-config=bootstrap-lto, linemap_add may create a macro map