Re: [PATCH] Another fix for PR54838

2012-12-17 Thread Richard Biener
On Mon, Dec 17, 2012 at 1:21 AM, Marek Polacek pola...@redhat.com wrote: Here's a fix for the C++ TC part of this PR. The issue was that we had a loop with header and two latches, and via delete_basic_block we deleted both latches, but we weren't removing the loop properly. This ICEd later on

RE: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c

2012-12-17 Thread Joey Ye
-Original Message- From: H.J. Lu [mailto:hjl.to...@gmail.com] Sent: Saturday, December 15, 2012 01:20 To: Joey Ye Cc: gcc-patches@gcc.gnu.org; Joseph Prostko Subject: Re: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c Can't you do +# Disable jcr section if we're not

Re: [PATCH] Make some asan builtins tm_pure (PR sanitizer/55508)

2012-12-17 Thread Dmitry Vyukov
resend in plain text On Mon, Dec 17, 2012 at 1:50 PM, Dmitry Vyukov dvyu...@google.com wrote: On Fri, Dec 14, 2012 at 5:43 PM, Torvald Riegel trie...@redhat.com wrote: On Thu, 2012-12-13 at 10:02 +0100, Jakub Jelinek wrote: On Thu, Dec 13, 2012 at 10:38:13AM +0400, Dmitry Vyukov wrote:

Re: [PATCH] Another fix for PR54838

2012-12-17 Thread Marek Polacek
On Mon, Dec 17, 2012 at 10:27:54AM +0100, Richard Biener wrote: This looks like the wrong place to fix (the delete-basic-block cfghook tryings to fixup loops are incredibly fragile, because usually delete_basic_block is called because of another cfg manipulation takes place). That is, the

Re: [PATCH] Another fix for PR54838

2012-12-17 Thread Richard Biener
On Mon, Dec 17, 2012 at 11:16 AM, Marek Polacek pola...@redhat.com wrote: On Mon, Dec 17, 2012 at 10:27:54AM +0100, Richard Biener wrote: This looks like the wrong place to fix (the delete-basic-block cfghook tryings to fixup loops are incredibly fragile, because usually delete_basic_block is

[PATCH,ARM] Define simple_alu_shift value for type attribute

2012-12-17 Thread Greta Yorsh
The attribute type for UXTB, UXTH, SXTB, and SXTH is set to simple_alu_imm if tuning is for cortex-a7 and alu_shift otherwise (since r193996). The problem is that attributes should not depend on a specific CPU or tuning. To eliminate the dependency, this patch introduces a new value for type

[PATCH] Fix PR54781

2012-12-17 Thread Richard Biener
The following patch properly constrains inputs to refs_may_alias_p as coming from the RTL oracle. Instead of disallowing stuff this just leaves things through that it can handle (thus it should be more failsafe). The patch also removes some dead code. Bootstrap and regtest pending on

[PATCH] Fix PR55555

2012-12-17 Thread Richard Biener
The following patch fixes a miscompilation due to bogus loop iteration bound derived from array accesses in an inner loop. idx_infer_loop_bounds analyzes the evoultion of an SSA name with respect to a loop it is not defined in - which seems to lead to random weird behavior. The correct thing to

Re: [PATCH] Fix PR54781

2012-12-17 Thread Jakub Jelinek
On Mon, Dec 17, 2012 at 01:45:54PM +0100, Richard Biener wrote: --- 283,302 if (base == NULL_TREE) return false; ! /* The tree oracle doesn't like bases that are neither decls ! nor indirect references of SSA names. */ ! if (!DECL_P (base) !(TREE_CODE

Re: [PATCH] Fix PR54781

2012-12-17 Thread Richard Biener
On Mon, 17 Dec 2012, Jakub Jelinek wrote: On Mon, Dec 17, 2012 at 01:45:54PM +0100, Richard Biener wrote: --- 283,302 if (base == NULL_TREE) return false; ! /* The tree oracle doesn't like bases that are neither decls ! nor indirect references of SSA names.

Re: [PATCH,ARM] Define simple_alu_shift value for type attribute

2012-12-17 Thread Richard Earnshaw
On 17/12/12 10:37, Greta Yorsh wrote: The attribute type for UXTB, UXTH, SXTB, and SXTH is set to simple_alu_imm if tuning is for cortex-a7 and alu_shift otherwise (since r193996). The problem is that attributes should not depend on a specific CPU or tuning. To eliminate the dependency, this

Re: [PATCH][ARM][testsuite] Add testsuite options for AArch32 NEON

2012-12-17 Thread Richard Earnshaw
On 11/12/12 12:30, Kyrylo Tkachov wrote: Hi all, Since the new AArch32 NEON instructions in arm_neon.h are predicated on __ARM_ARCH 8 the testsuite add_options procedure should also include -march=armv8-a to make these instructions available. This makes the new vrnd* tests in

Re: [PATCH] Another fix for PR54838

2012-12-17 Thread Richard Biener
On Mon, Dec 17, 2012 at 11:26 AM, Richard Biener richard.guent...@gmail.com wrote: On Mon, Dec 17, 2012 at 11:16 AM, Marek Polacek pola...@redhat.com wrote: On Mon, Dec 17, 2012 at 10:27:54AM +0100, Richard Biener wrote: This looks like the wrong place to fix (the delete-basic-block cfghook

Re: [Patch AArch64] Add support for vectorizable standard math patterns.

2012-12-17 Thread Richard Earnshaw
On 27/11/12 20:47, Mike Stump wrote: On Nov 27, 2012, at 8:51 AM, James Greenhalgh james.greenha...@arm.com wrote: In particular, we add support for vectorizing across: ceil (), ceilf (), lceil (), We add testcases ensuring that each of the expected functions are vectorized. As the i386 and

Re: [PATCH] Another fix for PR54838

2012-12-17 Thread Marek Polacek
On Mon, Dec 17, 2012 at 11:26:23AM +0100, Richard Biener wrote: On Mon, Dec 17, 2012 at 11:16 AM, Marek Polacek pola...@redhat.com wrote: On Mon, Dec 17, 2012 at 10:27:54AM +0100, Richard Biener wrote: This looks like the wrong place to fix (the delete-basic-block cfghook tryings to fixup

Re: [RFA/4.7/ARM] Backport arm-*-linux-gnueabihf triplet support to 4.7

2012-12-17 Thread Richard Earnshaw
On 20/11/12 20:34, Matthew Gretton-Dann wrote: All, This patch backports Matthais Klose's arm*-*-linux-gnueabihf triplet support patch of 2012-10-15 to 4.7. The backport was not clean as 4.8 has obsoleted various arm*-*-* triplets which are valid in 4.7. I have tested this cross with

Re: [RFA/4.7/ARM] Backport arm-*-linux-gnueabihf triplet support to 4.7

2012-12-17 Thread Richard Earnshaw
On 21/11/12 11:48, Matthew Gretton-Dann wrote: On 21 November 2012 00:05, Matthias Klose d...@ubuntu.com wrote: looks fine, except one missing chunk from my original patch. maybe left out intentionally. Matthias Index: b/src/gcc/config.gcc

Re: [PATCH, ARM] Improved core - NEON extend

2012-12-17 Thread Richard Earnshaw
On 13/11/12 13:50, Ulrich Weigand wrote: Hello, here's another of Andrew's patches to improve NEON usage. This one was originally posted here: http://gcc.gnu.org/ml/gcc-patches/2012-02/msg01213.html The idea to improve SImode to DImode extends that also move from core registers to NEON

Re: [PATCH][Revisedx2] PR55679: skip invalid tests from r194458 on darwin

2012-12-17 Thread Jakub Jelinek
On Sun, Dec 16, 2012 at 04:19:11PM -0500, Jack Howarth wrote: 2012-12-16 Jack Howarth howa...@bromo.med.uc.edu PR sanitizer/55679 * g++.dg/asan/interception-test-1.C: Skip on darwin. * lib/target-supports.exp (check_effective_target_swapcontext): Use

Re: [PATCH, AArch64] Make zero_extends explicit for common SImode patterns

2012-12-17 Thread Richard Earnshaw
On 14/12/12 11:59, Ian Bolton wrote: Hi Richard, + add\\t%w0, %w2, %w, suxtSHORT:size ^^^ %w1 Got spot. I guess that pattern hasn't fired yet then! I'll fix it. Now fixed in v3. I should have said that I am indeed running with REE enabled. It has some impact

Re: [patch] libgcc unwind-arm.h: mark arguments as unused

2012-12-17 Thread Richard Earnshaw
On 10/12/12 07:13, Matthias Klose wrote: This was seen and fixed on trunk building libbacktrace on arm: http://gcc.gnu.org/ml/gcc-patches/2012-10/msg00628.html I see this now cross building libgo targeting arm on the 4.7 branch. Ok to backport to the 4.7 branch? Matthias unwind-arm.diff

Re: libgo patch committed: Update to current library

2012-12-17 Thread Rainer Orth
Ian Lance Taylor i...@google.com writes: I've updated libgo to the current master Go library sources. As usual this e-mail only includes patches to files that are substantially specific to gccgo. The bulk of the patch is available from the repository or from the master Go repository.

Re: [PATCH] validate_failures.py: Fix performance regression

2012-12-17 Thread Diego Novillo
On Thu, Dec 13, 2012 at 10:12 AM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: On Fri, Dec 07, 2012 at 10:31:57AM -0500, Diego Novillo wrote: On Thu, Dec 6, 2012 at 1:12 PM, Bernhard Reutner-Fischer rep.dot@gmail.com wrote: @@ -210,12 +211,12 @@ def IsInterestingResult(line):

Re: [ARM] Turning off 64bits ops in Neon and gfortran/modulo-scheduling problem

2012-12-17 Thread Richard Earnshaw
On 29/11/12 17:16, Christophe Lyon wrote: Hi, I have been working on a patch to avoid using Neon for 64 bits bitops when it's too expensive to move data between core and Neon registers. Benchmarking and validation look OK on the 4.7 branch (compiler configured for thumb and hard FP) -

Re: [PATCH][Revisedx2] PR55679: skip invalid tests from r194458 on darwin

2012-12-17 Thread Jack Howarth
On Mon, Dec 17, 2012 at 03:42:59PM +0100, Jakub Jelinek wrote: On Sun, Dec 16, 2012 at 04:19:11PM -0500, Jack Howarth wrote: 2012-12-16 Jack Howarth howa...@bromo.med.uc.edu PR sanitizer/55679 * g++.dg/asan/interception-test-1.C: Skip on darwin. * lib/target-supports.exp

[PING] Re: [PATCH] PR c++/53609 - Wrong argument deduction for pack expansion in argument pack

2012-12-17 Thread Dodji Seketeli
Ping? ---BeginMessage--- Jason Merrill ja...@redhat.com writes: On 12/08/2012 05:12 PM, Dodji Seketeli wrote: + else if (arg_from_pack_level_to_prune || has_empty_arg) +{ + /* ... we just return a pack expansion which pattern is PATTERN + into which ARGS has been substituted.

RE: [PATCH][ARM][testsuite] Add testsuite options for AArch32 NEON

2012-12-17 Thread Kyrylo Tkachov
-Original Message- From: Richard Earnshaw Sent: 17 December 2012 14:13 To: Kyrylo Tkachov Cc: gcc-patches@gcc.gnu.org; Ramana Radhakrishnan Subject: Re: [PATCH][ARM][testsuite] Add testsuite options for AArch32 NEON On 11/12/12 12:30, Kyrylo Tkachov wrote: Hi all, Since the

Re: [PATCH] Fix PR55555

2012-12-17 Thread Richard Biener
On Mon, 17 Dec 2012, Richard Biener wrote: The following patch fixes a miscompilation due to bogus loop iteration bound derived from array accesses in an inner loop. idx_infer_loop_bounds analyzes the evoultion of an SSA name with respect to a loop it is not defined in - which seems to

[PATCH] Fix recent warning about pending_assemble_externals_processed

2012-12-17 Thread Jan-Benedict Glaw
Hi! I'd like to apply the following patch to fix a warning: ../../../../gcc/gcc/varasm.c:2094:13: warning: ‘pending_assemble_externals_processed’ defined but not used [-Wunused-variable] (seen on microblaze-uclinux and pdp11-aout) introduced with a fix for PR middle-end/55709 and 52894:

Re: [PATCH] Fix recent warning about pending_assemble_externals_processed

2012-12-17 Thread John David Anglin
On 12/17/2012 11:42 AM, Jan-Benedict Glaw wrote: 2012-12-17 Jan-Benedict Glaw jbg...@lug-owl.de * gcc/varasm.c (pending_assemble_externals_processed): Guard with ASM_OUTPUT_EXTERNAL. This was fixed on trunk yesterday. The warning must be present on 4.6 and 4.7 but doesn't

Re: [PATCH] Fix recent warning about pending_assemble_externals_processed

2012-12-17 Thread Jan-Benedict Glaw
On Mon, 2012-12-17 12:24:58 -0500, John David Anglin dave.ang...@bell.net wrote: On 12/17/2012 12:08 PM, John David Anglin wrote: On 12/17/2012 11:42 AM, Jan-Benedict Glaw wrote: 2012-12-17 Jan-Benedict Glaw jbg...@lug-owl.de * gcc/varasm.c (pending_assemble_externals_processed):

Re: [google][4.7] Allow function reordering linker plugin to separate hot and cold code into different ELF segments

2012-12-17 Thread Sriraman Tallam
I have committed this patch. Thanks, -Sri. On Fri, Dec 14, 2012 at 4:16 PM, Rong Xu x...@google.com wrote: Looks good to me for google/gcc-4_7 branch. Thanks, -Rong On Fri, Dec 14, 2012 at 3:42 PM, Sriraman Tallam tmsri...@google.com wrote: Hi Rong, Please review this code. This

Re: PATCH: Remove AM_MAKEFLAGS from libsanitizer

2012-12-17 Thread H.J. Lu
On Wed, Dec 12, 2012 at 11:32 PM, Paolo Bonzini bonz...@gnu.org wrote: Il 13/12/2012 00:23, H.J. Lu ha scritto: On Wed, Dec 12, 2012 at 3:01 PM, H.J. Lu hjl.to...@gmail.com wrote: On Wed, Dec 12, 2012 at 2:13 PM, Paolo Bonzini bonz...@gnu.org wrote: Il 12/12/2012 19:11, H.J. Lu ha scritto:

Re: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c

2012-12-17 Thread H.J. Lu
On Mon, Dec 17, 2012 at 1:50 AM, Joey Ye joey...@arm.com wrote: Can't you do +# Disable jcr section if we're not building java +case ,${enable_languages}, in + *java*) +use_jcr_section=1 +;; + *) +use_jcr_section=0 +;; +esac in libgcc/configure.ac? BTW, checking

[cxx-conversion] Convert remaining tree-parloops.c htab_t to hash_table.

2012-12-17 Thread Lawrence Crowl
Change tree-parloops.c reduction and name_to_copy hash tables from htab_t to hash_table. Fold reduction_info_hash and reduction_info_eq into new struct reduction_hasher. Fold name_to_copy_elt_eq and name_to_copy_elt_hash into new struct name_to_copy_hasher. Update dependent types and calls.

Re: [PATCH] Fix recent warning about pending_assemble_externals_processed

2012-12-17 Thread Dominique Dhumieres
I have just built gcc 4.6.4 r194560 and I see the following warnings: ../../p6_work/gcc/varasm.c:2107:30: warning: 'pending_assemble_externals_set' defined but not used [-Wunused-variable] ../../p6_work/gcc/varasm.c:2112:13: warning: 'pending_assemble_externals_processed' defined but not used

[cxx-conversion] Change tree-ssa-coalesce.c'coalesce_list_d.list to hash_table

2012-12-17 Thread Lawrence Crowl
Change tree-ssa-coalesce.c'coalesce_list_d.list from htab_t to hash_table. Fold coalesce_pair_map_hash and coalesce_pair_map_eq into new struct coalesce_pair_hasher. Removed struct coalesce_pair_iterator, as did not meet the hash_table iterator interface and it provided no significant code

Re: [cxx-conversion] Change tree-ssa-coalesce.c'coalesce_list_d.list to hash_table

2012-12-17 Thread Richard Biener
On Mon, Dec 17, 2012 at 8:36 PM, Lawrence Crowl cr...@googlers.com wrote: Change tree-ssa-coalesce.c'coalesce_list_d.list from htab_t to hash_table. Fold coalesce_pair_map_hash and coalesce_pair_map_eq into new struct coalesce_pair_hasher. Removed struct coalesce_pair_iterator, as did not

Re: [cxx-conversion] Change tree-ssa-coalesce.c'coalesce_list_d.list to hash_table

2012-12-17 Thread Lawrence Crowl
On 12/17/12, Richard Biener richard.guent...@gmail.com wrote: On Mon, Dec 17, 2012 at 8:36 PM, Lawrence Crowl cr...@googlers.com wrote: Change tree-ssa-coalesce.c'coalesce_list_d.list from htab_t to hash_table. Fold coalesce_pair_map_hash and coalesce_pair_map_eq into new struct

Re: libgo patch committed: Update to current library

2012-12-17 Thread Ian Lance Taylor
On Mon, Dec 17, 2012 at 6:49 AM, Rainer Orth r...@cebitec.uni-bielefeld.de wrote: Ian Lance Taylor i...@google.com writes: I've updated libgo to the current master Go library sources. As usual this e-mail only includes patches to files that are substantially specific to gccgo. The bulk of

[v3 patch] remove __async_sfinae_helper

2012-12-17 Thread Jonathan Wakely
With the implementation of N3436 we no longer need the __async_sfinae_helper, as result_of does the same job on its own. * include/std/future (__async_sfinae_helper): Remove. Tested x86_64-linux, committed to trunk. commit 797f96cc81e09197bc377206319667c579ecb81b Author: Jonathan Wakely

[PATCH] Don't return original value from gen_lowpart_no_emit rtl hook (PR debug/55717)

2012-12-17 Thread Jakub Jelinek
Hi! If gen_lowpart_if_possible returns NULL, the default rtl_hooks.gen_lowpart_no_emit hook returns the original value, which is not of the desired mode. I bet in most passes for real insns such rtx is then meant to fail recog and thrown away, but for DEBUG_INSN modification that doesn't work,

[PATCH] fix 50148

2012-12-17 Thread Matt
Andrew attached a patch for this bug, which I am now hitting in trunk. Can someone please review and apply to trunk and 4.7 branch? Thanks! http://gcc.gnu.org/bugzilla/attachment.cgi?id=25070action=diff --- file_not_specified_in_diff +++ file_not_specified_in_diff @@ -1,2 +1,2 @@ ---

Re: [PATCH] fix 50148

2012-12-17 Thread Andrew Pinski
On Mon, Dec 17, 2012 at 3:28 PM, Matt m...@use.net wrote: Andrew attached a patch for this bug, which I am now hitting in trunk. Can someone please review and apply to trunk and 4.7 branch? No I did not attach this patch to the bug report. I commented on the patch though. Also this code

[patch] remove unused __gthread_cond_timedwait_recursive

2012-12-17 Thread Jonathan Wakely
libgcc/ghtr.h claims that __gthread_cond_timedwait_recursive should be defined to support the c++0x thread library, but that function isn't used or needed anywhere by libstdc++: std::condition_variable can only be used with std::mutex (i.e. a non-recursive mutex) and std::condition_variable_any

[patch,c++] Generate correct (i.e., const) debug entries for arrays declared const but not marked READONLY

2012-12-17 Thread t56xjcu6dh
An array declared const is marked not READONLY if (1) its initializer list involves a constructor call, or (2) it's a static class member with an initializer list. The array should have a debug information entry marking it as const, but it doesn't. (In case 2, the array might be marked

Re: [PATCH, libgcc] Make possible to disable JCR in crtstuff.c

2012-12-17 Thread H.J. Lu
On Mon, Dec 17, 2012 at 5:23 PM, Joseph Prostko joe.pros...@gmail.com wrote: On Mon, Dec 17, 2012 at 2:28 PM, H.J. Lu hjl.to...@gmail.com wrote: On Mon, Dec 17, 2012 at 1:50 AM, Joey Ye joey...@arm.com wrote: * libgcc/Makefile.in: Include TARGET_USE_JCR_SECTION in CFLAGS. *

[doc] doc/contrib.texi -- update Kaveh's entry

2012-12-17 Thread Gerald Pfeifer
Applied, based on a brief e-mail exchange with Kaveh. Gerald 2012-12-17 Gerald Pfeifer ger...@pfeifer.com * doc/contrib.texi (Contributors): Update Kaveh Ghazi's entry; remove broken link to Rutgers University. Index: doc/contrib.texi

Re: [patch] remove unused __gthread_cond_timedwait_recursive

2012-12-17 Thread Ian Lance Taylor
On Mon, Dec 17, 2012 at 3:41 PM, Jonathan Wakely jwakely@gmail.com wrote: libgcc/ghtr.h claims that __gthread_cond_timedwait_recursive should be defined to support the c++0x thread library, but that function isn't used or needed anywhere by libstdc++: std::condition_variable can only be