Re: [RFC][PR64946] "abs" vectorization fails for char/short types

2018-05-17 Thread Kugan Vivekanandarajah
Hi Richard, Thanks for the review. I am revising the patch based on Andrew's comments too. On 17 May 2018 at 20:36, Richard Biener wrote: > On Thu, May 17, 2018 at 4:56 AM Andrew Pinski wrote: > >> On Wed, May 16, 2018 at 7:14 PM, Kugan

[PATCH] refine -Wstringop-truncation and -Wsizeof-pointer-memaccess for strncat of nonstrings (PR 85602)

2018-05-17 Thread Martin Sebor
The -Wstringop-truncation and -Wsizeof-pointer-memaccess warnings I added and enhanced, respectively, in GCC 8 are arguably overly strict for source arguments declared with the nonstring attribute. For example, -Wsizeof-pointer-memaccess triggers for the strncat call below: __attribute__

Re: [C++ Patch] PR 84588 ("[8 Regression] internal compiler error: Segmentation fault (contains_struct_check())")​ (Take 2)

2018-05-17 Thread Paolo Carlini
Hi again, On 18/05/2018 02:31, Paolo Carlini wrote: Hi, On 18/05/2018 01:21, Jason Merrill wrote: On Thu, May 17, 2018 at 5:54 PM, Paolo Carlini wrote: On 17/05/2018 16:58, Jason Merrill wrote: On Thu, May 17, 2018 at 10:27 AM, Paolo Carlini

Re: [C++ Patch] PR 84588 ("[8 Regression] internal compiler error: Segmentation fault (contains_struct_check())")​ (Take 2)

2018-05-17 Thread Paolo Carlini
Hi, On 18/05/2018 01:21, Jason Merrill wrote: On Thu, May 17, 2018 at 5:54 PM, Paolo Carlini wrote: On 17/05/2018 16:58, Jason Merrill wrote: On Thu, May 17, 2018 at 10:27 AM, Paolo Carlini wrote: PS: maybe better using

Re: [PATCH] use string length to relax -Wstringop-overflow for nonstrings (PR 85623)

2018-05-17 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-05/msg00509.html On 05/10/2018 01:26 PM, Martin Sebor wrote: GCC 8.1 warns for unbounded (and some bounded) string comparisons involving arrays declared attribute nonstring (i.e., char arrays that need not be nul-terminated). For instance:

libcpp PATCH to avoid deprecated copy assignment

2018-05-17 Thread Jason Merrill
Another case of assignment from a value-initialized temporary, which in this case ought to be placement new. Tested x86_64-pc-linux-gnu, applying to trunk. commit ccd4031ebdabf02fe0d54bb43a68c0fa72ec2708 Author: Jason Merrill Date: Thu May 17 17:16:28 2018 -0400

Re: [C++ Patch] PR 84588 ("[8 Regression] internal compiler error: Segmentation fault (contains_struct_check())")​ (Take 2)

2018-05-17 Thread Jason Merrill
On Thu, May 17, 2018 at 5:54 PM, Paolo Carlini wrote: > On 17/05/2018 16:58, Jason Merrill wrote: >> >> On Thu, May 17, 2018 at 10:27 AM, Paolo Carlini >> wrote: >>> >>> PS: maybe better using function_declarator_p? >> >> I think so, yes. The

Re: [PATCH 2/2, RISC-V] Optimize switch with sign-extended index.

2018-05-17 Thread Jim Wilson
On Wed, May 2, 2018 at 3:05 PM, Jim Wilson wrote:> > * config/riscv/riscv.c (riscv_extend_comparands): In unsigned QImode > test, check for sign extended subreg and/or constant operands, and > do a sign extend in that case. > > gcc/testsuite/ >

Re: [PATCH 1/2, expr.c] Optimize switch with sign-extended index.

2018-05-17 Thread Jim Wilson
On Thu, May 17, 2018 at 12:25 AM, Eric Botcazou wrote: > The patch looks OK to me, modulo: > >> + && ! (INTVAL (range) & (HOST_WIDE_INT_1U << (width - 1 > > I'd use UINTVAL instead of INTVAL here. Thanks. Committed with that change. Jim

Re: [C++ Patch] PR 84588 ("[8 Regression] internal compiler error: Segmentation fault (contains_struct_check())")​ (Take 2)

2018-05-17 Thread Paolo Carlini
Hi, On 17/05/2018 16:58, Jason Merrill wrote: On Thu, May 17, 2018 at 10:27 AM, Paolo Carlini wrote: PS: maybe better using function_declarator_p? I think so, yes. The relevant rule seems to be "The declarator shall not specify a function or an array.", so let's

Re: [Patch] Do not call the linker if we are creating precompiled header files

2018-05-17 Thread Steve Ellcey
Ping. Steve Ellcey sell...@cavium.com On Wed, 2018-05-02 at 12:47 -0700, Steve Ellcey wrote: > This is a new version of a patch I sent out last year to stop gcc from > trying to do a link when creating precompiled headers and a linker > flag is also given. > > When I build and test GCC I also

Re: [PATCH , rs6000] Add missing builtin test cases, fix arguments to match specifications.

2018-05-17 Thread Carl Love
On Thu, 2018-05-17 at 15:31 -0500, Segher Boessenkool wrote: > Hi! > > On Wed, May 16, 2018 at 12:53:13PM -0700, Carl Love wrote: > > diff --git a/gcc/testsuite/gcc.target/powerpc/altivec-12.c > > b/gcc/testsuite/gcc.target/powerpc/altivec-12.c > > index b0267b5..1f3175f 100644 > > ---

Re: [PATCH , rs6000] Add missing builtin test cases, fix arguments to match specifications.

2018-05-17 Thread Peter Bergner
On 5/17/18 3:31 PM, Segher Boessenkool wrote: > On Wed, May 16, 2018 at 12:53:13PM -0700, Carl Love wrote: >> @@ -27,21 +27,21 @@ >> /* { dg-final { scan-assembler-times "vmulosb" 1 } } */ >> >> // For LE platforms P9 and later, we generate the lxv insn instead of >> lxvd2x. >> -/* { dg-final

Re: [PATCH , rs6000] Add missing builtin test cases, fix arguments to match specifications.

2018-05-17 Thread Segher Boessenkool
Hi! On Wed, May 16, 2018 at 12:53:13PM -0700, Carl Love wrote: > diff --git a/gcc/testsuite/gcc.target/powerpc/altivec-12.c > b/gcc/testsuite/gcc.target/powerpc/altivec-12.c > index b0267b5..1f3175f 100644 > --- a/gcc/testsuite/gcc.target/powerpc/altivec-12.c > +++

Cybersecurity Software Users Contact List

2018-05-17 Thread Meghan Hudson
Hi, Hope you having a great day! I just wanted to be aware if you would be interested in acquiring Cybersecurity Software Users Contact List for marketing your product or service. These are the fields that we provide for each contacts: Names, Title, Email, Contact Number, Company Name,

Re: [PATCH][AArch64] Unify vec_set patterns, support floating-point vector modes properly

2018-05-17 Thread James Greenhalgh
On Thu, May 17, 2018 at 09:26:37AM -0500, Kyrill Tkachov wrote: > > On 17/05/18 14:56, Kyrill Tkachov wrote: > > > > On 17/05/18 09:46, Kyrill Tkachov wrote: > >> > >> On 15/05/18 18:56, Richard Sandiford wrote: > >>> Kyrill Tkachov writes: > Hi all, > >

Re: [PATCH rs6000] Fix PR85698

2018-05-17 Thread Segher Boessenkool
On Thu, May 17, 2018 at 07:58:20PM +0200, Richard Biener wrote: > On May 17, 2018 6:04:36 PM GMT+02:00, Segher Boessenkool > wrote: > >On Thu, May 17, 2018 at 10:42:46AM -0500, Pat Haugen wrote: > >> The following patch fixes a problem that resulted in incorrect code

Documentation patch for -floop-interchange and -floop-unroll-and-jam.

2018-05-17 Thread Toon Moene
The documentation of both options is still inconsistent, in both the trunk and the gcc-8 branch. The following is my suggestion to clear this up (and move -floop-unroll-and-jam close to -floop-interchange. ChangeLog: 2018-05-17 Toon Moene * doc/invoke.texi: Move

Re: [PATCH rs6000] Fix PR85698

2018-05-17 Thread Richard Biener
On May 17, 2018 6:04:36 PM GMT+02:00, Segher Boessenkool wrote: >On Thu, May 17, 2018 at 10:42:46AM -0500, Pat Haugen wrote: >> The following patch fixes a problem that resulted in incorrect code >generation for the CPU2017 benchmark 525.x264_r. The fix correctly

Re: PING^1: [PATCH] C/C++: Add -Waddress-of-packed-member

2018-05-17 Thread H.J. Lu
On Mon, May 14, 2018 at 8:00 PM, Martin Sebor wrote: > On 05/14/2018 01:10 PM, H.J. Lu wrote: >> >> On Mon, May 14, 2018 at 10:40 AM, H.J. Lu wrote: >> >> $ cat c.i >> struct B { int i; }; >> struct C { struct B b; } __attribute__ ((packed));

Re: PR83648

2018-05-17 Thread H.J. Lu
On Mon, May 14, 2018 at 11:11 PM, Prathamesh Kulkarni wrote: > On 12 January 2018 at 18:26, Richard Biener wrote: >> On Fri, 12 Jan 2018, Prathamesh Kulkarni wrote: >> >>> On 12 January 2018 at 05:02, Jeff Law wrote: >>> > On

Re: [PATCH rs6000] Fix PR85698

2018-05-17 Thread Segher Boessenkool
On Thu, May 17, 2018 at 10:42:46AM -0500, Pat Haugen wrote: > The following patch fixes a problem that resulted in incorrect code > generation for the CPU2017 benchmark 525.x264_r. The fix correctly checks the > "dest" operand, which is the memory operand. > > Bootstrap/regtest on powerp64le

Re: [PATCH GCC][4/6]Support regional coalesce and live range computation

2018-05-17 Thread Bin.Cheng
On Thu, May 17, 2018 at 3:04 PM, Richard Biener wrote: > On Tue, May 15, 2018 at 5:44 PM Bin.Cheng wrote: > >> On Fri, May 11, 2018 at 1:53 PM, Richard Biener >> wrote: >> > On Fri, May 4, 2018 at 6:23 PM, Bin Cheng

[PATCH rs6000] Fix PR85698

2018-05-17 Thread Pat Haugen
The following patch fixes a problem that resulted in incorrect code generation for the CPU2017 benchmark 525.x264_r. The fix correctly checks the "dest" operand, which is the memory operand. Bootstrap/regtest on powerp64le and powerpc64 (-m32/-m64) with no new regressions. Ok for trunk? -Pat

[PATCH] PR libstdc++/85818 ensure path::preferred_separator is defined

2018-05-17 Thread Jonathan Wakely
Because path.cc is compiled with -std=gnu++17 the static constexpr data member is implicitly 'inline' and so no definition gets emitted unless it gets used in that translation unit. Other translation units built as C++11 or C++14 still require a namespace-scope definition of the variable, so mark

[PATCH] PR libstdc++/85812 fix memory leak in std::make_exception_ptr

2018-05-17 Thread Jonathan Wakely
As the PR points out, the constructor called in the placement new expression can throw, in which case the allocation would be leaked. Separating the two implementations makes it much easier to read what the code is doing. PR libstdc++/85812 * libsupc++/cxxabi_init_exception.h

Re: [PATCH][AArch64] Unify vec_set patterns, support floating-point vector modes properly

2018-05-17 Thread Wilco Dijkstra
Kyrill Tkachov wrote: > That patch would look like the attached. Is this preferable? > For the above example it generates the desired: > foo_v4sf: >   ldr s0, [x0] >   ldr s1, [x1, 8] >   ins v0.s[1], v1.s[0] >   ld1 {v0.s}[2], [x2] >   ld1 {v0.s}[3], [x3]

Re: Rb_tree constructor optimization

2018-05-17 Thread Jonathan Wakely
On 15/05/18 07:30 +0200, François Dumont wrote: Here it is again even more simplified. Should I backport the Debug mode fix to 8 branch ? Yes, please do backport the include/debug/* changes.     * include/bits/stl_tree.h     (_Rb_tree_impl(_Rb_tree_impl&&, _Node_allocator&&)): New.    

Re: [C++ Patch] PR 84588 ("[8 Regression] internal compiler error: Segmentation fault (contains_struct_check())")​ (Take 2)

2018-05-17 Thread Jason Merrill
On Thu, May 17, 2018 at 10:27 AM, Paolo Carlini wrote: > PS: maybe better using function_declarator_p? I think so, yes. The relevant rule seems to be "The declarator shall not specify a function or an array.", so let's check for arrays, too. Jason

Re: [PING] [PATCH] Avoid excessive function type casts with splay-trees

2018-05-17 Thread Bernd Edlinger
On 05/17/18 15:39, Richard Biener wrote: > On Thu, May 17, 2018 at 3:21 PM Bernd Edlinger > wrote: > >> Ping... > > So this makes all traditional users go through the indirect > splay_tree_compare_wrapper > and friends (which is also exported for no good reason?).

Re: [C++ Patch] PR 84588 ("[8 Regression] internal compiler error: Segmentation fault (contains_struct_check())")​ (Take 2)

2018-05-17 Thread Paolo Carlini
PS: maybe better using function_declarator_p??? I think I regression tested that variant too, at some point. Paolo.

Re: [PATCH][AArch64] Unify vec_set patterns, support floating-point vector modes properly

2018-05-17 Thread Kyrill Tkachov
On 17/05/18 14:56, Kyrill Tkachov wrote: On 17/05/18 09:46, Kyrill Tkachov wrote: On 15/05/18 18:56, Richard Sandiford wrote: Kyrill Tkachov writes: Hi all, We've a deficiency in our vec_set family of patterns. We don't support directly loading a vector

[C++ Patch] PR 84588 ("[8 Regression] internal compiler error: Segmentation fault (contains_struct_check())")​ (Take 2)

2018-05-17 Thread Paolo Carlini
Hi, thus I had to revert my first try, when it caused c++/85713. I added two testcases for the latter (the second one covering what I learned from yet another defective try which I attached to the trail of c++/84588 yesterday) and finally figured out that the problem was that I was

Re: [PING] [PATCH] Avoid excessive function type casts with splay-trees

2018-05-17 Thread Richard Biener
On Thu, May 17, 2018 at 4:04 PM Jakub Jelinek wrote: > On Thu, May 17, 2018 at 03:39:42PM +0200, Richard Biener wrote: > > On Thu, May 17, 2018 at 3:21 PM Bernd Edlinger < bernd.edlin...@hotmail.de> > > wrote: > > > > > Ping... > > > > So this makes all traditional users go

Re: [PATCH GCC][4/6]Support regional coalesce and live range computation

2018-05-17 Thread Richard Biener
On Tue, May 15, 2018 at 5:44 PM Bin.Cheng wrote: > On Fri, May 11, 2018 at 1:53 PM, Richard Biener > wrote: > > On Fri, May 4, 2018 at 6:23 PM, Bin Cheng wrote: > >> Hi, > >> Following Jeff's suggestion, I am now using

Re: [PING] [PATCH] Avoid excessive function type casts with splay-trees

2018-05-17 Thread Jakub Jelinek
On Thu, May 17, 2018 at 03:39:42PM +0200, Richard Biener wrote: > On Thu, May 17, 2018 at 3:21 PM Bernd Edlinger > wrote: > > > Ping... > > So this makes all traditional users go through the indirect > splay_tree_compare_wrapper > and friends (which is also exported

Re: [PATCH][AArch64] Unify vec_set patterns, support floating-point vector modes properly

2018-05-17 Thread Kyrill Tkachov
On 17/05/18 09:46, Kyrill Tkachov wrote: On 15/05/18 18:56, Richard Sandiford wrote: Kyrill Tkachov writes: Hi all, We've a deficiency in our vec_set family of patterns. We don't support directly loading a vector lane using LD1 for V2DImode and all the vector

Re: RFA (ipa-prop): PATCHes to avoid use of deprecated copy ctor and op=

2018-05-17 Thread Richard Biener
On Thu, May 17, 2018 at 3:25 PM Andreas Schwab wrote: > On Mai 17 2018, Jason Merrill wrote: > > On Thu, May 17, 2018 at 4:14 AM, Andreas Schwab wrote: > >> On Mai 16 2018, Andreas Schwab wrote: > >>> On Mai 15 2018, Jason

Re: [PING] [PATCH] Avoid excessive function type casts with splay-trees

2018-05-17 Thread Richard Biener
On Thu, May 17, 2018 at 3:21 PM Bernd Edlinger wrote: > Ping... So this makes all traditional users go through the indirect splay_tree_compare_wrapper and friends (which is also exported for no good reason?). And all users are traditional at the moment. So I wonder

Re: [PATCH] Add __attribute__((malloc) to allocator and remove unused code

2018-05-17 Thread Richard Biener
On Thu, May 17, 2018 at 1:42 PM Marc Glisse wrote: > On Thu, 17 May 2018, Richard Biener wrote: > > On Thu, May 17, 2018 at 1:14 PM Marc Glisse wrote: > > > >> On Thu, 17 May 2018, Jonathan Wakely wrote: > > > >>> On 17/05/18 12:54 +0200, Marc Glisse

Re: RFA (ipa-prop): PATCHes to avoid use of deprecated copy ctor and op=

2018-05-17 Thread Andreas Schwab
On Mai 17 2018, Jason Merrill wrote: > On Thu, May 17, 2018 at 4:14 AM, Andreas Schwab wrote: >> On Mai 16 2018, Andreas Schwab wrote: >>> On Mai 15 2018, Jason Merrill wrote: >>> commit

Re: [PATCH] Support lower and upper limit for -fdbg-cnt flag.

2018-05-17 Thread Richard Biener
On Wed, May 16, 2018 at 3:54 PM Martin Liška wrote: > On 05/16/2018 03:39 PM, Alexander Monakov wrote: > > On Wed, 16 May 2018, Martin Liška wrote: > >>> Hm, is the off-by-one in the new explanatory text really intended? I think > >>> the previous text was accurate, and the new

[PING] [PATCH] Avoid excessive function type casts with splay-trees

2018-05-17 Thread Bernd Edlinger
Ping... On 05/03/18 22:13, Bernd Edlinger wrote: > Hi, > > this is basically the same patch I posted a few months ago, > with a few formatting nits by Jakub fixed. > > Bootstrapped and reg-tested again with current trunk. > > Is it OK for trunk? > > > Bernd. > > On 12/15/17 11:44, Bernd

Re: RFA (ipa-prop): PATCHes to avoid use of deprecated copy ctor and op=

2018-05-17 Thread Jason Merrill
On Thu, May 17, 2018 at 4:14 AM, Andreas Schwab wrote: > On Mai 16 2018, Andreas Schwab wrote: >> On Mai 15 2018, Jason Merrill wrote: >> >>> commit 648ffd02e23ac2695de04ab266b4f8862df6c2ed >>> Author: Jason Merrill >>> Date:

Re: Use conditional internal functions in if-conversion

2018-05-17 Thread Richard Biener
On Wed, May 16, 2018 at 12:17 PM Richard Sandiford < richard.sandif...@linaro.org> wrote: > This patch uses IFN_COND_* to vectorise conditionally-executed, > potentially-trapping arithmetic, such as most floating-point > ops with -ftrapping-math. E.g.: > if (cond) { ... x = a + b; ... } >

Re: [wwwdocs] Add GCC 8 Fortran feature description

2018-05-17 Thread Damian Rouson
Thank you! Damian On May 17, 2018 at 12:32:19 AM, Thomas Koenig (tkoe...@netcologne.de) wrote: > Hi Damian, > > Partial support is provided for Fortran 2018 teams, which are > hierarchical > subsets of images that execute independently of other image subsets. > > > Committed. > >

[Patch, fortran] PR82923 - Automatic allocation of deferred length character using function result

2018-05-17 Thread Paul Richard Thomas
The ChangeLog and the comments in the patch tell all. Bootstrapped and regtested on FC27/x86_64. OK for 7-branch through to trunk? Paul 2018-05-17 Paul Thomas PR fortran/82923 * trans-array.c (gfc_alloc_allocatable_for_assignment): Set the charlen

[PATCH] Another DSE improvement and thinko fix

2018-05-17 Thread Richard Biener
The previous DSE improvements left us with skipping elements we could have possibly removed because I messed up the iterator increment upon removal. The following fixes this and also adds another pruning opportunity in case the only stmt feeded by the def is an already visited PHI. Bootstrap

[PATCH] Improve get_ref_base_and_extent with range-info

2018-05-17 Thread Richard Biener
The following makes use of range-info to improve the basic building block of the alias-oracle so we can tell that in a[0] = 1; for (int i = 5; i < 17; ++i) a[i] = i; a[0] = 2; the ao_ref for a[i] does not alias the a[0] acceses. Given range-info is not always going to improve things

[PATCH] Improve memset handling in value-numbering

2018-05-17 Thread Richard Biener
Noticed in PR63185. Bootstrapped and tested on x86_64-unknown-linux-gnu, applied. Richard. 2018-05-17 Richard Biener * tree-ssa-sccvn.c (vn_reference_lookup_3): Improve memset handling. * gcc.dg/tree-ssa/ssa-fre-63.c: New testcase. diff --git

Re: [PATCH] Add __attribute__((malloc) to allocator and remove unused code

2018-05-17 Thread Marc Glisse
On Thu, 17 May 2018, Richard Biener wrote: On Thu, May 17, 2018 at 1:14 PM Marc Glisse wrote: On Thu, 17 May 2018, Jonathan Wakely wrote: On 17/05/18 12:54 +0200, Marc Glisse wrote: On Mon, 14 May 2018, Jonathan Wakely wrote: As discussed at

Re: Implement SLP of internal functions

2018-05-17 Thread Richard Biener
On Wed, May 16, 2018 at 12:18 PM Richard Sandiford < richard.sandif...@linaro.org> wrote: > SLP of calls was previously restricted to built-in functions. > This patch extends it to internal functions. > Tested on aarch64-linux-gnu (with and without SVE), aarch64_be-elf > and x86_64-linux-gnu.

Re: PR83648

2018-05-17 Thread Richard Biener
On Thu, May 17, 2018 at 1:25 PM Prathamesh Kulkarni < prathamesh.kulka...@linaro.org> wrote: > On 15 May 2018 at 12:20, Richard Biener wrote: > > On Tue, 15 May 2018, Prathamesh Kulkarni wrote: > > > >> On 12 January 2018 at 18:26, Richard Biener wrote: >

Re: [PATCH] Add __attribute__((malloc) to allocator and remove unused code

2018-05-17 Thread Richard Biener
On Thu, May 17, 2018 at 1:14 PM Marc Glisse wrote: > On Thu, 17 May 2018, Jonathan Wakely wrote: > > On 17/05/18 12:54 +0200, Marc Glisse wrote: > >> On Mon, 14 May 2018, Jonathan Wakely wrote: > >> > >>> As discussed at

Re: PR83648

2018-05-17 Thread Prathamesh Kulkarni
On 15 May 2018 at 12:20, Richard Biener wrote: > On Tue, 15 May 2018, Prathamesh Kulkarni wrote: > >> On 12 January 2018 at 18:26, Richard Biener wrote: >> > On Fri, 12 Jan 2018, Prathamesh Kulkarni wrote: >> > >> >> On 12 January 2018 at 05:02, Jeff Law

Re: [PATCH] Add __attribute__((malloc) to allocator and remove unused code

2018-05-17 Thread Marc Glisse
On Thu, 17 May 2018, Jonathan Wakely wrote: On 17/05/18 12:54 +0200, Marc Glisse wrote: On Mon, 14 May 2018, Jonathan Wakely wrote: As discussed at https://gcc.gnu.org/ml/libstdc++/2018-01/msg00073.html we can simplify the allocator function for valarray memory. I also noticed that the

Re: [PATCH] Add __attribute__((malloc) to allocator and remove unused code

2018-05-17 Thread Jonathan Wakely
On 17/05/18 12:54 +0200, Marc Glisse wrote: On Mon, 14 May 2018, Jonathan Wakely wrote: As discussed at https://gcc.gnu.org/ml/libstdc++/2018-01/msg00073.html we can simplify the allocator function for valarray memory. I also noticed that the _Array(size_t) constructor is never used.

Re: [PATCH] Add __attribute__((malloc) to allocator and remove unused code

2018-05-17 Thread Marc Glisse
On Mon, 14 May 2018, Jonathan Wakely wrote: As discussed at https://gcc.gnu.org/ml/libstdc++/2018-01/msg00073.html we can simplify the allocator function for valarray memory. I also noticed that the _Array(size_t) constructor is never used. * include/bits/valarray_array.h

Re: [PATCH PR85793]Fix ICE by loading vector(1) scalara_type for 1 element-wise case

2018-05-17 Thread Richard Biener
On Thu, May 17, 2018 at 12:11 PM Bin.Cheng wrote: > On Thu, May 17, 2018 at 11:07 AM, Richard Biener > wrote: > > On Wed, May 16, 2018 at 5:13 PM Bin Cheng wrote: > > > >> Hi, > >> This patch fixes ICE by loading vector(1)

Re: Replace FMA_EXPR with one internal fn per optab

2018-05-17 Thread Richard Biener
On Thu, May 17, 2018 at 10:56 AM Richard Sandiford < richard.sandif...@linaro.org> wrote: > Richard Biener writes: > >> @@ -2698,23 +2703,26 @@ convert_mult_to_fma_1 (tree mul_result, > >> } > > > >> if (negate_p) > >> - mulop1 =

Re: Gimple FE support for internal functions

2018-05-17 Thread Richard Biener
On Thu, May 17, 2018 at 10:27 AM Richard Sandiford < richard.sandif...@linaro.org> wrote: > This patch gets the gimple FE to parse calls to internal functions. > The only non-obvious thing was how the functions should be written > to avoid clashes with real function names. One option would be to

Re: Allow gimple_build with internal functions

2018-05-17 Thread Richard Biener
On Thu, May 17, 2018 at 10:21 AM Richard Sandiford < richard.sandif...@linaro.org> wrote: > This patch makes the function versions of gimple_build and > gimple_simplify take combined_fns rather than built_in_codes, > so that they work with internal functions too. The old > gimple_builds were

Re: [PATCH][RFC] Radically simplify emission of balanced tree for switch statements.

2018-05-17 Thread Martin Liška
On 01/15/2018 12:22 AM, Bernhard Reutner-Fischer wrote: > Can you please post CSiBE numbers? Ideally throwing in gcc-3.4.6 numbers too? > > thanks, Hi. I've just retested the patch and looks fine. There are numbers of CSiBE. I'm sorry I don't have such old version of GCC:

Re: [RFC][PR64946] "abs" vectorization fails for char/short types

2018-05-17 Thread Richard Biener
On Thu, May 17, 2018 at 4:56 AM Andrew Pinski wrote: > On Wed, May 16, 2018 at 7:14 PM, Kugan Vivekanandarajah > wrote: > > As mentioned in the PR, I am trying to add ABSU_EXPR to fix this > > issue. In the attached patch, in

[PATCH 07/14] Covert ipa-pure-const.c to symbol_summary.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-04-24 Martin Liska * ipa-pure-const.c (struct funct_state_d): Do it class instead of struct. (class funct_state_summary_t): New function_summary class. (has_function_state): Remove. (get_function_state): Likewise.

[PATCH][arm][2/2] Remove support for -march=armv3 and older

2018-05-17 Thread Kyrill Tkachov
Hi all, We deprecated architecture versions earlier than Armv4T in GCC 6 [1]. This patch removes support for architectures lower than Armv4. That is the -march values armv2, armv2a, armv3, armv3m are removed with this patch. I did not remove armv4 because it's a bit more involved code-wise and

[PATCH][arm][1/2] Remove support for deprecated -march=armv5 and armv5e

2018-05-17 Thread Kyrill Tkachov
Hi all, The -march=armv5 and armv5e options have been deprecated in GCC 7 [1]. This patch removes support for them. It's mostly mechanical stuff. The functionality that was previously gated on arm_arch5 is now gated on arm_arch5t and the functionality that was gated on arm_arch5e is now gated on

[PATCH 08/14] Convert IPA CP to symbol_summary.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-04-24 Martin Liska * ipa-cp.c (ipcp_store_bits_results): Use ipcp_transformation_sum. (ipcp_store_vr_results): Likewise. * ipa-prop.c (ipcp_grow_transformations_if_necessary): Renamed to ...

[PATCH 02/14] Code refactoring for call_summary.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-04-24 Martin Liska * symbol-summary.h (release): Move definition out of class declaration. (symtab_removal): Likewise. (symtab_duplication): Likewise. --- gcc/symbol-summary.h | 123

[PATCH 04/14] Add {symbol,call}_summary::get method and use it in HSA.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-04-24 Martin Liska * hsa-common.h (enum hsa_function_kind): Rename HSA_NONE to HSA_INVALID. (hsa_function_summary::hsa_function_summary): Use the new enum value. (hsa_gpu_implementation_p): Use hsa_summaries::get.

[PATCH 00/14] Finish transition of {symbol,call}_summary.

2018-05-17 Thread marxin
Hi. Following patch series finishes transition of IPA summary info that is assigned either to cgraph_node or to cgraph_edge. Instead of using a vector indexed with uid, we use summaries that are internally implemented as hash_map. Doing the transition we can remove summary_uid and uid property

Re: [PATCH PR85793]Fix ICE by loading vector(1) scalara_type for 1 element-wise case

2018-05-17 Thread Bin.Cheng
On Thu, May 17, 2018 at 11:07 AM, Richard Biener wrote: > On Wed, May 16, 2018 at 5:13 PM Bin Cheng wrote: > >> Hi, >> This patch fixes ICE by loading vector(1) scalar_type if it's 1 > element-wise for VMAT_ELEMENTWISE. >> Bootstrap and test on

[PATCH 14/14] Come up with cgraph_node::get_uid and make cgraph_node::uid private.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-04-24 Martin Liska * cgraph.c (function_version_hasher::hash): Use cgraph_node::get_uid (). (function_version_hasher::equal): * cgraph.h (cgraph_node::get_uid): New method. * ipa-inline.c (update_caller_keys): Use

[PATCH 12/14] Port edge_growth_cache to call_summary.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-04-24 Martin Liska * ipa-inline-analysis.c (inline_edge_removal_hook): Remove. (initialize_growth_caches): Remove. (free_growth_caches): Likewise. (do_estimate_edge_time): Use edge_growth_cache.

[PATCH 03/14] Rename get methods in symbol-summary.h to get_create.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-04-24 Martin Liska * config/i386/i386.c (ix86_can_inline_p): Use get_create instead of get. * hsa-common.c (hsa_summary_t::link_functions): Likewise. (hsa_register_kernel): Likewise. * hsa-common.h

[PATCH 11/14] Port IPA CP to edge_clone_summaries.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-04-24 Martin Liska * ipa-cp.c (class edge_clone_summary): New summary. (grow_edge_clone_vectors): Remove. (ipcp_edge_duplication_hook): Remove. (class edge_clone_summary_t): New call_summary class.

[PATCH 05/14] Use summaries->get where possible. Small refactoring of multiple calls.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-04-24 Martin Liska * ipa-fnsummary.c (dump_ipa_call_summary): Use ::get method. (analyze_function_body): Extract multiple calls of get_create. * ipa-inline-analysis.c (simple_edge_hints): Likewise. * ipa-inline.c

[PATCH 10/14] Add call_summary::get method and m_initialize_when_cloning.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-04-24 Martin Liska * symbol-summary.h (get): New function. (call_summary::m_initialize_when_cloning): New class member. --- gcc/symbol-summary.h | 66 +++- 1 file changed, 50 insertions(+),

[PATCH 06/14] Use symtab_summary in ipa-reference.c.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-04-24 Martin Liska * ipa-reference.c (remove_node_data): Remove. (duplicate_node_data): Likewise. (class ipa_ref_var_info_summary_t): New class. (class ipa_ref_opt_summary_t): Likewise. (get_reference_vars_info): Use

[PATCH 01/14] Code refactoring of symtab_summary.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-04-24 Martin Liska * symbol-summary.h (function_summary): Move constructor implementation out of class declaration. (release): Likewise. (symtab_insertion): Likewise. (symtab_removal): Likewise.

[PATCH 13/14] Make cgraph_edge::uid really unique.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-04-24 Martin Liska * cgraph.c (symbol_table::create_edge): Always assign a new unique number. (symbol_table::free_edge): Do not recycle numbers. * cgraph.h (cgraph_edge::get): New method. * symbol-summary.h

[PATCH 09/14] Remove cgraph_node::summary_uid and make cgraph_node::uid really unique.

2018-05-17 Thread marxin
gcc/ChangeLog: 2018-05-16 Martin Liska * cgraph.c (cgraph_node::remove): Do not recycle uid. * cgraph.h (symbol_table::release_symbol): Do not pass uid. (symbol_table::allocate_cgraph_symbol): Do not set uid. * passes.c (uid_hash_t): Record

Re: [PATCH PR85793]Fix ICE by loading vector(1) scalara_type for 1 element-wise case

2018-05-17 Thread Richard Biener
On Wed, May 16, 2018 at 5:13 PM Bin Cheng wrote: > Hi, > This patch fixes ICE by loading vector(1) scalar_type if it's 1 element-wise for VMAT_ELEMENTWISE. > Bootstrap and test on x86_64 and AArch64 ongoing. Is it OK? OK. Richard. > Thanks, > bin > 2018-05-16 Bin Cheng

Re: [PATCH, aarch64] Patch to update pipeline descriptions in thunderx2t99.md

2018-05-17 Thread Richard Earnshaw (lists)
On 09/05/18 23:37, Steve Ellcey wrote: > On Fri, 2018-05-04 at 14:05 -0700, Andrew Pinski wrote: >>   >>>    (thunderx2t99_loadpair): Fix cpu unit ordering. >> I think the original ordering was correct.  The address calculation >> happens before the actual load. >> thunderx2t99_asimd_load1_ldp

Re: [RFC][PR82479] missing popcount builtin detection

2018-05-17 Thread Bin.Cheng
On Thu, May 17, 2018 at 2:39 AM, Kugan Vivekanandarajah wrote: > Hi Richard, > > On 6 March 2018 at 02:24, Richard Biener wrote: >> On Thu, Feb 8, 2018 at 1:41 AM, Kugan Vivekanandarajah >> wrote:

Re: [PATCH][GCC][AArch64] Correct 3 way XOR instructions adding missing patterns.

2018-05-17 Thread Kyrill Tkachov
Hi Tamar, On 30/04/18 15:12, Tamar Christina wrote: Hi All, This patch adds the missing neon intrinsics for all 128 bit vector Integer modes for the three-way XOR and negate and xor instructions for Arm8.2-a to Armv8.4-a. Bootstrapped and regtested on aarch64-none-linux-gnue and no issues.

Re: [PATCH][AARCH64][PR target/84882] Add mno-strict-align

2018-05-17 Thread Kyrill Tkachov
Hi Sudi, On 27/03/18 13:58, Sudakshina Das wrote: Hi This patch adds the no variant to -mstrict-align and the corresponding function attribute. To enable the function attribute, I have modified aarch64_can_inline_p () to allow checks even when the callee function has no attribute. The need for

Re: [patch AArch64] Do not perform a vector splat for vector initialisation if it is not useful

2018-05-17 Thread Richard Earnshaw (lists)
On 16/05/18 09:37, Kyrill Tkachov wrote: > > On 15/05/18 10:58, Richard Biener wrote: >> On Tue, May 15, 2018 at 10:20 AM Kyrill Tkachov >> >> wrote: >> >>> Hi all, >>> This is a respin of James's patch from: >>

Re: Replace FMA_EXPR with one internal fn per optab

2018-05-17 Thread Richard Sandiford
Richard Biener writes: >> @@ -2698,23 +2703,26 @@ convert_mult_to_fma_1 (tree mul_result, >> } > >> if (negate_p) >> - mulop1 = force_gimple_operand_gsi (, >> - build1 (NEGATE_EXPR, >> -

Re: [PATCH][AArch64] Unify vec_set patterns, support floating-point vector modes properly

2018-05-17 Thread Kyrill Tkachov
On 15/05/18 18:56, Richard Sandiford wrote: Kyrill Tkachov writes: Hi all, We've a deficiency in our vec_set family of patterns. We don't support directly loading a vector lane using LD1 for V2DImode and all the vector floating-point modes. We do do it

Re: [PATCH] PR gcc/84923 - gcc.dg/attr-weakref-1.c failed on aarch64

2018-05-17 Thread Richard Biener
On Thu, 17 May 2018, Kyrill Tkachov wrote: > Hi, > > Given this is a midend change it's a good idea to CC some of the maintainers > of that area. > I've copied richi and Honza. The patch is ok for trunk (it's actually mine...) and for the branch after a while. Thanks, Richard. > Thanks, >

Re: [PATCH ARM] Fix armv8-m multilib build failure with stdint.h

2018-05-17 Thread Kyrill Tkachov
On 16/05/18 10:22, Jérôme Lambourg wrote: Hello Kyrill, Thanks for the patch! To validate it your changes you can also look at the disassembly of the cmse.c binary in the build tree. If the binary changes with your patch then that would indicate some trouble. Good idea. So I just did that

Gimple FE support for internal functions

2018-05-17 Thread Richard Sandiford
This patch gets the gimple FE to parse calls to internal functions. The only non-obvious thing was how the functions should be written to avoid clashes with real function names. One option would be to go the magic number of underscores route, but we already do that for built-in functions, and it

Allow gimple_build with internal functions

2018-05-17 Thread Richard Sandiford
This patch makes the function versions of gimple_build and gimple_simplify take combined_fns rather than built_in_codes, so that they work with internal functions too. The old gimple_builds were unused, so no existing callers need to be updated. Tested on aarch64-linux-gnu (with and without

Re: [PATCH] PR gcc/84923 - gcc.dg/attr-weakref-1.c failed on aarch64

2018-05-17 Thread Kyrill Tkachov
Hi, Given this is a midend change it's a good idea to CC some of the maintainers of that area. I've copied richi and Honza. Thanks, Kyrill On 17/05/18 05:35, vladimir.mezent...@oracle.com wrote: Ping. -Vladimir On 05/10/2018 11:30 PM, vladimir.mezent...@oracle.com wrote: > From: Vladimir

Re: RFA (ipa-prop): PATCHes to avoid use of deprecated copy ctor and op=

2018-05-17 Thread Andreas Schwab
On Mai 16 2018, Andreas Schwab wrote: > On Mai 15 2018, Jason Merrill wrote: > >> commit 648ffd02e23ac2695de04ab266b4f8862df6c2ed >> Author: Jason Merrill >> Date: Tue May 15 20:46:54 2018 -0400 >> >> * cp-tree.h (cp_expr):

Re: [PATCH 1/2, expr.c] Optimize switch with sign-extended index.

2018-05-17 Thread Eric Botcazou
> The following patch implements this optimization. It checks for a range > that does not have the sign-bit set, and an index value that is already > sign extended, and then does a sign extend instead of an zero extend. > > This has been tested with a riscv{32,64}-{elf,linux} builds and

Re: [PATCH, 2/2][nvptx, PR83589] Workaround for branch-around-nothing JIT bug

2018-05-17 Thread Thomas Schwinge
Hi! On Wed, 24 Jan 2018 14:56:28 +0100, Tom de Vries wrote: > On 01/24/2018 12:03 PM, Jakub Jelinek wrote: > > On Wed, Jan 24, 2018 at 11:41:45AM +0100, Tom de Vries wrote: > >> +/* Insert a dummy ptx insn when encountering a branch to a label with no > >> ptx > >> +

Re: [wwwdocs] Add GCC 8 Fortran feature description

2018-05-17 Thread Thomas Koenig
Hi Damian,     Partial support is provided for Fortran 2018 teams, which are hierarchical     subsets of images that execute independently of other image subsets. Committed. Regards Thomas

Re: [patch][i386] Goldmont Plus -march/-mtune options

2018-05-17 Thread Uros Bizjak
On Wed, May 16, 2018 at 3:37 PM, Makhotina, Olga wrote: > Hi, > > This patch implements Goldmont Plus -march/-mtune. > > 2018-05-16 Olga Makhotina > > gcc/ > > * config.gcc: Support "goldmont-plus". > *

  1   2   >