[C++ Patch] PR 60383

2014-03-13 Thread Paolo Carlini
(for example, it aligns our diagnostic to that of current clang) Tested x86_64-linux. Thanks, Paolo. /cp 2014-03-13 Paolo Carlini paolo.carl...@oracle.com PR c++/60383 * pt.c (maybe_process_partial_specialization): Check return value

[C++ Patch] PR 59571

2014-03-17 Thread Paolo Carlini
processing_template_decl, actually checking if type and expr are dependent? Does this kind of audit make sense for next Stage 1? /cp 2014-03-17 Paolo Carlini paolo.carl...@oracle.com PR c++/59571 * typeck2.c (check_narrowing): Use fold_non_dependent_expr_sfinae. /testsuite

[C++ testcases] PR 54250, PR 60305

2014-03-18 Thread Paolo Carlini
Hi, I'm adding the below testcases for bugs already fixed in mainline and 4.8.x. Thanks, Paolo. // 2014-03-18 Paolo Carlini paolo.carl...@oracle.com PR c++/54250 * g++.dg/cpp0x/lambda/lambda-ice12.C: New. Index: g++.dg/cpp0x/constexpr-ice14.C

[C++ Patch / RFC] PR 51474

2014-03-18 Thread Paolo Carlini
Hi, the attached is slightly larger than my last ones but, assuming the analysis is correct, should be pretty safe, it avoids a segfault: in fact, for a pure virtual called from a NSDMI, current_function_decl is null and the existing warning about *structors breaks. I'm reading 12.7/4 and I

[C++ Patch] PR 60384

2014-03-19 Thread Paolo Carlini
(with TREE_TYPE an error_mark_node, like TREE_TYPE (x) in the case at issue). Thus the additional check I'm suggesting. Tested x86_64-linux. Thanks, Paolo. // /cp 2014-03-19 Paolo Carlini paolo.carl...@oracle.com PR c++/60384 * name-lookup.c

Re: PR libstdc++/60587

2014-03-19 Thread Paolo Carlini
Hi On 19/mar/2014, at 23:28, Jonathan Wakely jwak...@redhat.com wrote: On 19/03/14 21:39 +, Jonathan Wakely wrote: I think the safe thing to do is (as I suggested at the time) to have a trait saying which iterator types refer to contiguous memory. Our debug mode only supports our own

[C++ testcases, committed] Adjust two recent C++1y testcases to use 'target c++1y'

2014-03-21 Thread Paolo Carlini
Hi, I'm committing this as obvious. Thanks, Paolo. 2014-03-21 Paolo Carlini paolo.carl...@oracle.com * g++.dg/cpp1y/pr60033.C: Use target c++1y. * g++.dg/cpp1y/pr60393.C: Likewise. Index: g++.dg/cpp1y/pr60033.C

Re: sort_heap complexity guarantee

2014-10-22 Thread Paolo Carlini
Hi, On 10/22/2014 11:05 PM, François Dumont wrote: + VERIFY( counter_type::less_compare_count = 2.0 * std::log2(nb_values) ); Nit: log2 isn't in C89, thus we shouldn't use it unconditionally, ie, if the test isn't guarded by { dg-require-cmath }. Thus, either the latter, or just express

[v3] Minor atomic tweaks

2014-10-24 Thread Paolo Carlini
Hi, tested x86_64-linux. Thanks, Paolo. /// 2014-10-24 Paolo Carlini paolo.carl...@oracle.com * include/bits/atomic_base.h: Avoid including stdbool.h. * include/std/atomic: When __cplusplus 201103L skip the rest of the header. * testsuite

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

2014-11-04 Thread Paolo Carlini
.. thanks a lot Jon! (after all this parallel mode is still useful for something ;) Paolo.

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

2014-11-04 Thread Paolo Carlini
Hi again, On 11/04/2014 05:34 AM, Jonathan Wakely wrote: On 04/11/14 03:41 +, Jonathan Wakely wrote: On 03/11/14 22:07 +, Jonathan Wakely wrote: On 3 November 2014 17:51, Paolo Carlini paolo.carl...@oracle.com wrote: .. other than the above issue, I see a segmentation fault

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

2014-11-04 Thread Paolo Carlini
.. and also: performance/ext/pb_ds/priority_queue_text_pop_mem.cc .../libstdc++-v3/scripts/check_performance: line 41: 16905 Segmentation fault ./$EXE_NAME tmp.$FILE_NAME Paolo.

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

2014-11-04 Thread Paolo Carlini
Hi, On 11/04/2014 04:32 PM, Jonathan Wakely wrote: Not a big deal of course, but unfortunately today I'm seeing *two* segfaults for pb_ds: performance/ext/pb_ds/multimap_text_insert_mem_large.cc .../libstdc++-v3/scripts/check_performance: line 41: 16173 Segmentation fault ./$EXE_NAME

Re: [PATCH] Fix dump scan in test devirt-40.C

2014-11-04 Thread Paolo Carlini
Hi, On 11/04/2014 04:37 PM, Martin Jambor wrote: Hi, since revision 216728, testsuite/g++.dg/ipa/devirt-40.C is failing because although the tested-for devirtualization does happen, it is probably being done earlier and the string we are trying to match is not emitted. But the important thing

Re: libstdc++ testsuite make targets check-parallel and check-performance don't work anymore

2014-11-04 Thread Paolo Carlini
On 11/04/2014 04:46 PM, Paolo Carlini wrote: Hi, On 11/04/2014 04:32 PM, Jonathan Wakely wrote: Not a big deal of course, but unfortunately today I'm seeing *two* segfaults for pb_ds: performance/ext/pb_ds/multimap_text_insert_mem_large.cc .../libstdc++-v3/scripts/check_performance: line 41

[C++ Patch] PR 63265

2014-11-10 Thread Paolo Carlini
picked are the same already used by clang. Tested x86_64-linux. In case, what about 4.9? Thanks, Paolo. // 2014-11-10 Paolo Carlini paolo.carl...@oracle.com PR c++/63265 * c-family/c.opt ([Wshift-count-negative, Wshift-count-overflow]): Add

Re: [C++ Patch] PR 63265

2014-11-10 Thread Paolo Carlini
Hi, On 11/10/2014 06:16 PM, Jason Merrill wrote: On 11/10/2014 12:16 PM, Jason Merrill wrote: I don't think we want to suppress this warning in general. The problem in this PR is that the warning code is failing to recognize that the first operand is constant false. But adding the warning

[Patch] Add -Wshift-count-negative and -Wshift-count-overflow

2014-11-10 Thread Paolo Carlini
Hi again, thus the below only adds the warnings. Would be mainline only of course. Thanks! Paolo. 2014-11-10 Paolo Carlini paolo.carl...@oracle.com * doc/invoke.texi ([-Wshift-count-negative, -Wshift-count-overflow]): Add. /c-family 2014-11-10

Re: [PATCH] c++98/mt_allcoator.cc: Fix assumption sizeof(void *) == sizeof(size_t)

2014-11-10 Thread Paolo Carlini
Hi, On 11/10/2014 07:34 PM, Jonathan Wakely wrote: On 10/11/14 12:01 -0600, Joel Sherrill wrote: cc'ing since both lists should be included. The m32c has 24-bit pointers and 16-bit size_t. This changes pushing a pointer through a size_t to pushing it through a uintptr_t. I'm OK with this

Re: [PATCH. libstdc++] Use the correct C++14 __cplusplus value (201402L). Added C++1z to the preprocessor.

2014-08-26 Thread Paolo Carlini
Hi, On 08/26/2014 10:56 AM, Rainer Orth wrote: bits/c++config... Which won't help users seeing them in the headers. Maybe the issue could be avoided by chosing names that make it clear that they are g++/libstdc++ specific, not generic? Sure, whatever works, the names were tentative, for the

Re: [C++ RFH/Patch] PR 52892 (and others)

2014-08-26 Thread Paolo Carlini
Hi, On 08/26/2014 08:58 PM, Jason Merrill wrote: On 08/26/2014 12:01 PM, Paolo Carlini wrote: the difference, for the latter and for more complex cases, is that adjust_temp_type calls cp_fold_convert which ends up returning a NOP_EXPR (eg, build in fold_convert_loc). Perhaps we should

Re: [C++ RFH/Patch] PR 52892 (and others)

2014-08-27 Thread Paolo Carlini
Hi again, On 08/26/2014 08:58 PM, Jason Merrill wrote: On 08/26/2014 12:01 PM, Paolo Carlini wrote: the difference, for the latter and for more complex cases, is that adjust_temp_type calls cp_fold_convert which ends up returning a NOP_EXPR (eg, build in fold_convert_loc). Perhaps we should

Re: [C++ RFH/Patch] PR 52892 (and others)

2014-08-27 Thread Paolo Carlini
.. two additional remarks (maybe obvious, I don't know): - It also appears to work - for sure for all the tests in c++/52892 + the tests in c++/52282 not involving data members (eg, the original one) - simply unconditionally calling STRIP_NOPS right after the cxx_eval_constant_expression at

Re: [C++ RFH/Patch] PR 52892 (and others)

2014-08-27 Thread Paolo Carlini
Hi, On 08/27/2014 04:19 PM, Jason Merrill wrote: On 08/27/2014 04:41 AM, Paolo Carlini wrote: .. two additional remarks (maybe obvious, I don't know): - It also appears to work - for sure for all the tests in c++/52892 + the tests in c++/52282 not involving data members (eg, the original one

[C++ Patch] PR 58102 aka DR 1405

2014-09-01 Thread Paolo Carlini
Hi, I think that in order to implement the resolution we simply have to remove the check. Tested x86_64-linux. Thanks, Paolo. // /cp 2014-09-01 Paolo Carlini paolo.carl...@oracle.com DR 1405 PR c++/58102 * semantics.c

[C++ Patch] DR 1453

2014-09-02 Thread Paolo Carlini
Hi, while looking into c++/58102 and DR 1405 I noticed that we don't implement DR 1453 either, sort of dual issue with volatile instead of mutable. Tested x86_64-linux. Thanks, Paolo. /cp 2014-09-02 Paolo Carlini paolo.carl...@oracle.com DR 1453

Re: [C++ Patch] PR 58102 aka DR 1405

2014-09-02 Thread Paolo Carlini
Hi, On 09/02/2014 04:11 PM, Jason Merrill wrote: On 09/01/2014 09:47 AM, Paolo Carlini wrote: -constexpr A b = a;// { dg-error mutable } +constexpr A b = a; This is wrong; we still need to get an error here. Hum, interesting. Neither current EDG nor current clang error out

Re: [C++ Patch] PR 58102 aka DR 1405

2014-09-02 Thread Paolo Carlini
Hi, On 09/02/2014 04:28 PM, Jason Merrill wrote: On 09/02/2014 10:17 AM, Paolo Carlini wrote: Let's see if I can tease the case out... I think you need to leave that hunk alone, and instead fix the new testcase by treating = {} more like {}, just as we already don't require a copy

Re: [C++ Patch] PR 58102 aka DR 1405

2014-09-02 Thread Paolo Carlini
Hi again, On 09/02/2014 04:28 PM, Jason Merrill wrote: On 09/02/2014 10:17 AM, Paolo Carlini wrote: Let's see if I can tease the case out... I think you need to leave that hunk alone, and instead fix the new testcase by treating = {} more like {}, just as we already don't require a copy

Re: [C++ Patch] PR 58102 aka DR 1405

2014-09-03 Thread Paolo Carlini
Hi, On 09/02/2014 05:45 PM, Jason Merrill wrote: On 09/02/2014 11:07 AM, Paolo Carlini wrote: Anyway, what about the below? Certainly works for the tests which we have got. Hmm. This is definitely an improvement, as it allows a subset of a non-volatile glvalue of literal type that refers

Re: [C++ Patch] Add default arguments to cp_parser_assignment_expression and cp_parser_constant_expression

2014-09-10 Thread Paolo Carlini
Hi, On 08/19/2014 02:18 PM, Paolo Carlini wrote: Hi, two more functions. Tested x86_64-linux. I'm pinging this. https://gcc.gnu.org/ml/gcc-patches/2014-08/msg01853.html Frankly, the cp_parser_constant_expression bits seem rather straightforward to me. As regards

[C++ Patch] PR 61489

2014-09-10 Thread Paolo Carlini
, Paolo. / /cp 2014-09-10 Paolo Carlini paolo.carl...@oracle.com PR c++/61489 * typeck2.c (process_init_constructor_record): Do not warn about missing field initializer if EMPTY_CONSTRUCTOR_P (init). /testsuite 2014-09-10 Paolo Carlini paolo.carl

Re: [C++ Patch] PR 61489

2014-09-11 Thread Paolo Carlini
Hi, On 09/11/2014 05:06 PM, Jason Merrill wrote: Do we need a documentation update? I agree. Something like the below would do? Thanks, Paolo. 2014-09-11 Paolo Carlini paolo.carl...@oracle.com PR c++/61489 * doc/invoke.texi ([-Wmissing-field-initializers

Re: [C++14 PATCH] Minor cleanup, don't run tests for which compilation is enough.

2014-09-14 Thread Paolo Carlini
Hi, On 09/14/2014 07:44 PM, Ville Voutilainen wrote: Tested on Linux-x64. Thanks. In such cases you can as well remove the main: then is also immediately obvious the the testcase is a dg-do compile. Paolo.

Re: [PATCH. libstdc++] Use the correct C++14 __cplusplus value (201402L). Added C++1z to the preprocessor.

2014-09-15 Thread Paolo Carlini
Hi again, On 08/26/2014 10:54 AM, Paolo Carlini wrote: Hi, On 08/26/2014 10:52 AM, Jonathan Wakely wrote: That seems like a good idea, but I'm not convinced there's any benefit in Ed's changes to do: -#if __cplusplus 201103L +#if __cplusplus = 201402L It seems like unnecessary churn to me

Re: [PATCH] Avoid inter-test dependencies in gfortran.dg (PR fortran/56408)

2014-09-16 Thread Paolo Carlini
Hi, On 09/16/2014 10:42 AM, Jakub Jelinek wrote: On Tue, Sep 16, 2014 at 08:28:48AM +, VandeVondele Joost wrote: +dg-test $gfortran_test_path/[lindex $args 1] $gfortran_aux_module_flags +# cleanup-modules isn't intentionally invoked here. should this be 'is intentionally not

[C++ Patch] PR 62232

2014-09-17 Thread Paolo Carlini
Hi, clang recently, in 3.5.0 if I remember correctly, stopped -Wnon-virtual-dtor warning for final classes. I think it makes sense to do the same. Tested x86_64-linux. Thanks, Paolo. 7 /cp 2014-09-17 Paolo Carlini paolo.carl...@oracle.com PR c++/62232

Re: [C++ Patch] PR 62232

2014-09-19 Thread Paolo Carlini
Hi, On 09/19/2014 08:03 AM, Gerald Pfeifer wrote: Hi Paolo, On Wed, 17 Sep 2014, Paolo Carlini wrote: clang recently, in 3.5.0 if I remember correctly, stopped -Wnon-virtual-dtor warning for final classes. I think it makes sense to do the same. mind adding a note to wwwdocs/htdocs/gcc-5

[C++ Patch/RFC] PR 62219

2014-09-19 Thread Paolo Carlini
Hi, I had a quick look at this issue and it immediately reminded me c++/60605, which Jason fixed by handling local functions at the beginning of check_default_tmpl_args. In the present case of: template class = void struct S { friend void foo( S ) { [](){}; } }; it occurs to me

Re: [C++ Patch/RFC] PR 62219

2014-09-19 Thread Paolo Carlini
Hi, On 09/19/2014 07:32 PM, Jason Merrill wrote: On 09/19/2014 11:40 AM, Paolo Carlini wrote: if (TREE_CODE (CP_DECL_CONTEXT (decl)) == FUNCTION_DECL - || (TREE_CODE (decl) == FUNCTION_DECL DECL_LOCAL_FUNCTION_P (decl))) + || (TREE_CODE (decl) == FUNCTION_DECL

[C++ Patch] PR 61857

2014-09-23 Thread Paolo Carlini
, at the end of g++.old-deja/g++.other/crash28.C. In fact, the context is slightly different, because in cp_parser_skip_to_closing_square_bracket we are in error recovery. I suppose we can further investigate this later... /cp 2014-09-23 Paolo Carlini paolo.carl...@oracle.com PR c++/61857

Re: RFA: PATCH to build_array_type_1 for c++/55032 (array template argument)

2012-12-06 Thread Paolo Carlini
.. looks like the patch fixes c++/55245 too. Thanks! Paolo.

Re: C++ PATCH for c++/55058 (lost cv-quals with typedef in template)

2012-12-07 Thread Paolo Carlini
On 12/06/2012 11:14 PM, Jason Merrill wrote: When we look through a typedef, we need to keep any cv-quals that were added to it. Thanks! Patch fixes also c++/54975, but it didn't look (to me ;) as an obvious duplicate, thus before closing it, I'm also going to add the testcase. Thanks again,

Re: C++ PATCH for c++/54325 (wrong error initializing abstract base class)

2012-12-07 Thread Paolo Carlini
enough... Thanks! Paolo. /// 2012-12-07 Paolo Carlini paolo.carl...@oracle.com * tree.c (build_aggr_init_expr): Remove tsubst_flags_t parameter. (build_cplus_new): Adjust. * cp-tree.h: Adjust declaration. * init.c (build_value_init): Adjust

Re: [patch, libstdc++ testsuite] Shrink tests for simulator

2012-12-13 Thread Paolo Carlini
Hi, On 12/13/2012 07:42 PM, Steve Ellcey wrote: I have been running the libstdc++ testsuite using the gnu simulator for my mips-mti-elf target. Some of the tests fail due to the amount of memory they need and I would like to 'shrink' them when run on a simulator using the same technique I see

Re: [patch libstdc++]: Fix LLP64 pointer-size issues for cxxabi, eh_alloc, and hash_bytes

2012-12-21 Thread Paolo Carlini
Hi, On 12/21/2012 08:59 AM, Kai Tietz wrote: Index: libsupc++/cxxabi.h === --- libsupc++/cxxabi.h (Revision 194655) +++ libsupc++/cxxabi.h (Arbeitskopie) @@ -356,7 +356,7 @@ namespace __cxxabiv1 { public: const

Re: [patch libstdc++]: Fix LLP64 pointer-size issues for cxxabi, eh_alloc, and hash_bytes

2012-12-21 Thread Paolo Carlini
Hi, On 12/21/2012 10:16 AM, Kai Tietz wrote: Well, I thought it is always present for gcc due gstdint.h header, As far as I know, that project isn't finished yet, there are still targets which neither provide the header, neither GCC synthetizes it. See also dg-require-effective-target

Re: [patch libstdc++]: Fix LLP64 pointer-size issues for cxxabi, eh_alloc, and hash_bytes

2012-12-21 Thread Paolo Carlini
On 12/21/2012 10:36 AM, Kai Tietz wrote: well, issue isn't that 'long' is always 'ptrdiff_t'. But then, if we just change the type without paying attention to size (and alignment) aren't we looking for BIG ABI trouble?!? Paolo.

Re: [patch libstdc++]: Fix LLP64 pointer-size issues for cxxabi, eh_alloc, and hash_bytes

2012-12-21 Thread Paolo Carlini
On 12/21/2012 10:59 AM, Kai Tietz wrote: Hello, I changed type in __base_class_type_info to wide-enough type only for llp64 target. By this we have no (new) side-effects to other targets. Thanks. This is something I can approve at once. Paolo.

Re: C++ PATCH for c++/54325 (wrong error initializing abstract base class)

2012-12-22 Thread Paolo Carlini
Hi, Jason Merrill ja...@redhat.com ha scritto: On 12/21/2012 06:38 AM, Paolo Carlini wrote: I was looking a bit more into this Bug, and something seems still weird about the testcase in Comment #1 of the audit trail, which we also didn't reject with 4.6.x: What's weird about it? Well, we

Re: C++ PATCH for c++/54325 (wrong error initializing abstract base class)

2012-12-24 Thread Paolo Carlini
On 12/24/2012 05:56 AM, Jason Merrill wrote: On 12/22/2012 06:02 PM, Paolo Carlini wrote: Well, we still reject it after the patch My 4.7 and trunk compilers both accept it (with -std=c++11, of course). I just updated and rebuilt my 4.7 for you (which definitely I didn't hack over the next

Re: C++ PATCH for c++/54325 (wrong error initializing abstract base class)

2012-12-24 Thread Paolo Carlini
... to explain more concretely what I mean, if I *brutally* hack mainline per the below, then the testcase is accepted. Paolo. // Index: call.c === --- call.c (revision 194659) +++ call.c (working copy)

Re: [C++ Patch] PR 54526 (again)

2013-01-03 Thread Paolo Carlini
Hi, On 01/02/2013 11:07 AM, Jakub Jelinek wrote: Hi! On Sun, Oct 28, 2012 at 12:27:40PM +0100, Paolo Carlini wrote: --- gcc/cp/parser.c (revision 192887) +++ gcc/cp/parser.c (working copy) @@ -12655,9 +12655,8 @@ cp_parser_template_id (cp_parser *parser, /* Otherwise, emit

Re: [C++ Patch] PR 54526 (again)

2013-01-04 Thread Paolo Carlini
Hi, On 01/03/2013 10:56 PM, Jason Merrill wrote: On 01/03/2013 05:44 AM, Paolo Carlini wrote: + /* C++11 - 2.5 p3, bullet 2. */ Please flesh out this comment some more. Ok, I extended it like this. Thanks, Paolo. / Index: gcc/cp/parser.c

Re: [committed, libstdc++] Fix a couple of copyright typos

2013-01-06 Thread Paolo Carlini
As per the subject, although I'd love to hear about this imaginary 2010. :-) Well, in physics imaginary time is a pretty useful abstraction, eg, you can easily switch between statistical mechanics and quantum field theory in interesting calculations :-) Paolo

[C++ Patch] PR 55801

2013-01-08 Thread Paolo Carlini
this is finish_id_expression (a bit earlier), where we already use error_operand_p, by not calling at all get_tls_wrapper_fn on such a decl. Tested x86_64-linux. Thanks, Paolo. / /cp 2013-01-08 Paolo Carlini paolo.carl...@oracle.com PR c++/55801 * semantics.c

Re: [C++ Patch] PR 55801

2013-01-08 Thread Paolo Carlini
Hi, On 01/08/2013 09:00 PM, Jason Merrill wrote: I think I'd rather handle this by returning false from var_needs_tls_wrapper. Ah Ok. Then what about the below? Thanks, Paolo. // /cp 2013-01-09 Paolo Carlini paolo.carl...@oracle.com PR c++/55801 * decl2

[C++ doc patch, trivial] PR 56067

2013-01-22 Thread Paolo Carlini
Hi, barring objections, I'm going to commit as obvious the below, which removes a left over bit of documentation, thus completing http://gcc.gnu.org/viewcvs?view=revisionrevision=97318 Thanks, Paolo. 2013-01-22 Paolo Carlini paolo.carl...@oracle.com PR c

[Patch / RFC] PR C++/55944

2013-01-22 Thread Paolo Carlini
Hi, today I had a look to this PR, maybe it's simple enough to be fixed at this time. The issue is that we ICE in check_initializer in: init = build_functional_cast (type, init, tf_none); - if (init != error_mark_node) + if (TREE_CODE (init) == TARGET_EXPR)

[v3] libstdc++/56085

2013-01-24 Thread Paolo Carlini
Hi, tested x86_64-linux, committed mainline and 4_7-branch. Thanks, Paolo. /// 2013-01-24 Paolo Carlini paolo.carl...@oracle.com PR libstdc++/56085 * include/std/complex (pow(const complex, int)): Avoid __n signed overflow. Index: include/std

Re: RFA: Update copyright in libstdc++-v3

2013-02-03 Thread Paolo Carlini
Hi, Tested on x86_64-linux-gnu, including with a -D_GLIBCXX_DEBUG run. OK to install? Ok, thanks! Paolo

[v3] libstdc++/56202

2013-02-04 Thread Paolo Carlini
Hi, tested x96_64-linux, committed to mainline. Thanks, Paolo. / 2013-02-04 Manuel López-Ibáñez m...@gcc.gnu.org Paolo Carlini paolo.carl...@oracle.com PR libstdc++/56202 * include/bits/random.tcc (binomial_distribution:: _M_waiting

Re: [v3] libstdc++/56202

2013-02-04 Thread Paolo Carlini
... committed this follow up. See Audit trail for details. Paolo. // 2013-02-04 Manuel López-Ibáñez m...@gcc.gnu.org Paolo Carlini paolo.carl...@oracle.com PR libstdc++/56202 (again) * include/bits/random.tcc (binomial_distribution

Re: [PATCH] Add missing explicit instantiation for std::lower_bound template

2013-02-05 Thread Paolo Carlini
Hi Dodji, On 02/04/2013 04:53 PM, Dodji Seketeli wrote: Hello, Since commit r195676[1], it looks like libstdc++-v3/src/c++11/hashtable_c++0x.cc is missing an explicit instantiation for std::lower_bound. This leads to libstdc++.so having the symbol for that (missing) instantiation be

[v3] Fix libstdc++/56282

2013-02-11 Thread Paolo Carlini
Hi, no real reason to add this tiny bit of C++11, and the related export ungliness, at this late stage in the 4.8 release process. I would say, let's just do it in the next ABI. Committed. Thanks, Paolo. / 2013-02-11 Paolo Carlini paolo.carl...@oracle.com

Re: [PATCH, libstdc++] Fix 22_locale/time_get/get_weekday/char/38081-[12].cc tests for glibc 2.17

2013-02-11 Thread Paolo Carlini
Hi, On 02/11/2013 04:33 PM, Julian Brown wrote: Hi, It seems that glibc 2.17 changes the abbreviated names of weekdays for ru_RU locales by removing an extraneous ., as described in: http://sourceware.org/bugzilla/show_bug.cgi?id=10873 An earlier patch (circa glibc 2.14) changed (IIUC!)

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-11 Thread Paolo Carlini
Hi, On 02/11/2013 06:33 PM, Jason Merrill wrote: While I was going over the C++11 status page, I noticed that quick_exit is implemented by glibc, it just needed to be added to the libstdc++ cstdlib header. Does this configury/feature macro handling look right? Is this enough testcase? Is

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-11 Thread Paolo Carlini
.. also, I think we should have #if __cplusplus = 201103L protecting these functions too, exactly like all the other C++11 bits. Eg, I don't think we should unconditionally, ie in C++03 mode too, declare at_quick_exit and quick_exit in namespace std. I can tweak things for the two issues I

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-11 Thread Paolo Carlini
On 02/11/2013 07:54 PM, Benjamin De Kosnik wrote: I can tweak things for the two issues I noticed. Thanks. It seems like this is still 4.8 material to me. Great. I'll take care of that later today. I'm also going to make sure the new testcase doesn't spuriously fail if the functions aren't

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-11 Thread Paolo Carlini
... this is what I committed. Thanks, Paolo. / 2013-02-11 Paolo Carlini paolo.carl...@oracle.com * include/c_std/cstdlib (at_quick_exit, quick_exit): Do not declare. * include/c_global/cstdlib (at_quick_exit, quick_exit): Declare only in C++11 mode

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-12 Thread Paolo Carlini
On 02/12/2013 12:26 PM, domi...@lps.ens.fr wrote: The test fails on x86_64-apple-darwin10 with FAIL: 18_support/quick_exit/quick_exit.cc (test for excess errors) Excess errors: /opt/gcc/work/libstdc++-v3/testsuite/18_support/quick_exit/quick_exit.cc:36:3: error: 'at_quick_exit' is not a member

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-12 Thread Paolo Carlini
On 02/12/2013 12:32 PM, Paolo Carlini wrote: On 02/12/2013 12:26 PM, domi...@lps.ens.fr wrote: The test fails on x86_64-apple-darwin10 with FAIL: 18_support/quick_exit/quick_exit.cc (test for excess errors) Excess errors: /opt/gcc/work/libstdc++-v3/testsuite/18_support/quick_exit/quick_exit.cc

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-12 Thread Paolo Carlini
On 02/12/2013 12:40 PM, domi...@lps.ens.fr wrote: IIRC I have already asked a similar question about atan2, erf, ... which don't appear in the std namespace on darwin. You should check whether darwin by chance uses by default c_std instead of c_global. The former doesn't provide C++11

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-12 Thread Paolo Carlini
On 02/12/2013 01:47 PM, domi...@lps.ens.fr wrote: But the last time I checked, modern darwin defined _GLIBCXX_USE_C99_MATH_TR1, no problems. AFAICT this is true, but I think darwin10 was released in 2011 so I doubt it has any support for c++11. Anyway, about the cstdlib issue the below makes

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-13 Thread Paolo Carlini
Hi, On 02/13/2013 03:38 PM, Jason Merrill wrote: On 02/12/2013 07:55 AM, Paolo Carlini wrote: Again, the current status is in a sense good because when the _GLIBCXX_HAVE_AT_QUICK_EXIT and _GLIBCXX_HAVE_QUICK_EXIT are defined, thus the system has the functions in its c library, including

Re: Keep the macro complex in C++03

2013-02-13 Thread Paolo Carlini
Hi, 2013-02-13 Marc Glisse marc.gli...@inria.fr PR libstdc++/56111 * include/std/complex (complex): Undefine. * include/c_compatibility/complex.h (complex): Only undefine if complex has been included. * testsuite/26_numerics/complex/56111.cc: New testcase.

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-14 Thread Paolo Carlini
Hi Rainer, On 02/14/2013 04:45 PM, Rainer Orth wrote: Jason Merrill ja...@redhat.com writes: While I was going over the C++11 status page, I noticed that quick_exit is implemented by glibc, it just needed to be added to the libstdc++ cstdlib header. The test fails on Solaris 9: FAIL:

Re: RFA: v3 PATCH to add on_quick_exit/quick_exit to std

2013-02-14 Thread Paolo Carlini
... or the below, just in case an interesting system provides the *quick_exit functions but doesn't define _GLIBCXX_USE_C99. Paolo. /// Index: testsuite/18_support/quick_exit/quick_exit.cc === ---

Re: avoid useless if-before-free tests

2011-03-07 Thread Paolo Carlini
On 03/05/2011 03:05 PM, Jim Meyering wrote: diff --git a/libstdc++-v3/libsupc++/del_opnt.cc b/libstdc++-v3/libsupc++/del_opnt.cc index 75051d5..29eab10 100644 --- a/libstdc++-v3/libsupc++/del_opnt.cc +++ b/libstdc++-v3/libsupc++/del_opnt.cc @@ -31,6 +31,5 @@ extern C void free (void *);

[v3] libstdc++/48038

2011-03-09 Thread Paolo Carlini
Hi, tested x86_64-linux multilib + debug-mode, committed to mainline (see Audit trail for details) Thanks, Paolo. 2011-03-09 Paolo Carlini paolo.carl...@oracle.com * testsuite/util/testsuite_rvalref.h: Minor tweaks. 2011-03-09 Jonathan Wakely r

Re: [PATCH][bug 48123] Install cpu_defines.h for freestanding C++ library.

2011-03-15 Thread Paolo Carlini
Hi, Hi, This patch fixes the problem in bug 48123. The problem is that some headers include c++config.h, which in turn includes cpu_defines.h but cpu_defines.h is not installed. This has been broken for a long time. Patch was tested by bootstrapping on x86_64 and building a cross-gcc

Re: [v3] Regenerate Solaris 2 baselines for GCC 4.6.0 release

2011-03-15 Thread Paolo Carlini
On 03/15/2011 08:05 PM, Benjamin Kosnik wrote: I've also changed the bad_function_call exports to not be in libsupc++, or the freestanding version. (ie to GLIBCXX from CXXABI). I think this was probably a simple thinko, right Paolo? Yes, as far as I can see now. Sorry about that and thanks for

Re: [v3] Regenerate Solaris 2 baselines for GCC 4.6.0 release

2011-03-15 Thread Paolo Carlini
... and I suppose the thinko alone should be fixed in 4_6-branch too, right? Paolo.

[v3] Start random dists values testing

2011-03-18 Thread Paolo Carlini
the other discrete distributions will be pretty straightforward; for the continuous ones we'll need an integration routine (I hope something simpler than gsl_integration_qags will be enough). Tested x86_64-linux, committed to mainline. Paolo. 2011-03-18 Paolo Carlini

Re: [libstdc++] Split testsuite/decimal/mixed-mode_neg.cc (issue4273077)

2011-03-18 Thread Paolo Carlini
On 03/18/2011 06:16 PM, dnovi...@google.com wrote: Paolo, Splitting this test fixes the failures I described in http://gcc.gnu.org/ml/libstdc++/2011-03/msg00076.html OK for trunk? Sure, it's Ok. A nit, however: we have been using quite consistently the *_neg suffix for such kind of testcases,

Re: [libstdc++] Split testsuite/decimal/mixed-mode_neg.cc (issue4273077)

2011-03-18 Thread Paolo Carlini
On 03/18/2011 06:29 PM, Diego Novillo wrote: Will do. Thanks. Sorry again - otherwise I have to do it myself anyway: why don't you split it a more meaningful way, like splitting out all the comparisons? That would avoid the naming issue in the first place. Thanks, Paolo.

Re: [libstdc++] Split testsuite/decimal/mixed-mode_neg.cc (issue4273077)

2011-03-18 Thread Paolo Carlini
Hi, Like this? Tested on my insanely deep tree and on mainline on x86_64. Sure. Thanks, Paolo

Re: [v3] Start random dists values testing

2011-03-19 Thread Paolo Carlini
Hi, The test compiles and runs if I add -D_GLIBCXX_USE_C99_MATH_TR1: Unfortunately I cannot debug the issue over the next few hours. If you are willing to further help I suggest checking why the dg-require I addes and used exactly because of that doesn't automatically skip the testcase on

Re: [v3] Start random dists values testing

2011-03-19 Thread Paolo Carlini
... turns out, something insane is going on with name: if I use *c99_math anywhere the dg-require is totally ignored. For the time being I'm simply renaming everything per the below. Paolo. // 2011-03-19 Paolo Carlini paolo.carl...@oracle.com * testsuite/lib/libstdc

Re: [Patch] [libstdc++] [C++0x] Export std::string base object move constructor.

2011-03-22 Thread Paolo Carlini
Hi, After a bit of poking around with nm in various objects I determined that the baseline_symbols files define what should be exported. The following grep+sed combo adds the necessary export for any architecture that exports the C1 constructor symbol. grep _ZNSsC1EOSs

Re: [Patch] [libstdc++] [C++0x] Export std::string base object move constructor.

2011-03-22 Thread Paolo Carlini
Hi, On Tue, Mar 22, 2011 at 01:10:14PM -, Adam Butcher wrote: After a bit of poking around with nm in various objects I determined that the baseline_symbols files define what should be exported. The following grep+sed combo adds the necessary export for any architecture that exports the C1

Re: [Patch] [libstdc++] [C++0x] Export std::string base object move constructor.

2011-03-22 Thread Paolo Carlini
Il 22/03/11 14.52, Paolo Carlini ha scritto: Jakub, such a patch would be ok with me, if isn't too late, but, frankly I don't see why we are not seeing the issue in the existing cons/char/moveable.cc, maybe it's something sensitive to inlining decisions (yes a testcase is welcome

[v3] Implement DR 1401

2011-03-22 Thread Paolo Carlini
Hi, tested x86_64-darwin, committed to mainline. Paolo. /// 2011-03-22 Paolo Carlini paolo.carl...@oracle.com * include/bits/shared_ptr.h (operator, operator=, operator=): Add, per DR 1401. (operator==, operator!=, operator): Fix per the letter of DR 1401

[v3] Fix negative_binomial_distribution

2011-03-24 Thread Paolo Carlini
Hi, this does fix a bad thinko of mine in negative_binomial_distribution (the fix will certainly go in 4.6.1, unless Jakub wants it now) + I'm adding basic statistical tests (adapted from GSL) for all the other discrete distributions. Thanks, Paolo. // 2011-03-24 Paolo Carlini

Re: [patch] Fix two C++ errors in libstdc++. (issue4341041)

2011-03-31 Thread Paolo Carlini
Hi, I think this is a candidate to backport to libstdc++-4.6.1. exception_ptr.h needs the forward declaration because it's included fromtypeinfo beforetypeinfo defines std::type_info. before going ahead with the patch - I'm not at all sure it's enough, for exception itself for example - I

Re: [patch] Fix two C++ errors in libstdc++. (issue4341041)

2011-03-31 Thread Paolo Carlini
On 03/31/2011 09:41 PM, Paolo Carlini wrote: I think this is a candidate to backport to libstdc++-4.6.1. exception_ptr.h needs the forward declaration because it's included fromtypeinfo beforetypeinfo defines std::type_info. before going ahead with the patch - I'm not at all sure it's enough

Re: [patch] Import iota and is_sorted from std to __gnu_cxx in C++0x mode. (issue4384043)

2011-04-06 Thread Paolo Carlini
Hi, I think this is a candidate to backport to libstdc++-4.6.1. Ok mainline and 4_6-branch if testing passes. Thanks, Paolo

[v3] Actually run some tests in parallel-mode for check-parallel

2011-04-11 Thread Paolo Carlini
Hi, noticed last week. Enabling the tests is also useful to have a clearer picture of which parallel-mode std algorithms need to be fixed vs C++0x. Tested x86_64-linux check-parallel, committing to mainline. Paolo. // 2011-04-11 Paolo Carlini paolo.carl...@oracle.com

[v3] libstdc++/48566

2011-04-12 Thread Paolo Carlini
/unordered_set/requirements/iterator_null_neg.cc (working copy) @@ -1,6 +1,6 @@ // 2005-09-10 Paolo Carlini pcarl...@suse.de // -// Copyright (C) 2005, 2009 Free Software Foundation, Inc. +// Copyright (C) 2005, 2009, 2011 Free Software Foundation, Inc. // // This file is part of the GNU ISO C

Re: [v3] Re-implement is_constructible, add is_default_constructible, is_destructible, fix PR 48526

2011-04-14 Thread Paolo Carlini
On 04/14/2011 10:32 AM, Magnus Fromreide wrote: This is just a nit, but why do you remove the /// is_function comments? Because was on the forward declaration, not on the implementation itself, where I wanted it. Paolo.

<    1   2   3   4   5   6   7   8   9   10   >