Re: [PATCH, GCC/ARM] Fix PR85261: ICE with FPSCR setter builtin

2018-04-11 Thread Kyrill Tkachov
Hi Thomas, On 09/04/18 15:29, Thomas Preudhomme wrote: Hi Ramana, On 06/04/18 17:17, Thomas Preudhomme wrote: > > > On 06/04/18 17:08, Ramana Radhakrishnan wrote: >> On 06/04/2018 16:54, Thomas Preudhomme wrote: >>> Instruction pattern for setting the FPSCR expects the input value to be >>> in

Re: [wwwdocs] Document libstdc++ changes in GCC 8

2018-04-11 Thread Jonathan Wakely
On 11 April 2018 at 07:42, Bernd Edlinger wrote: >> Let me know if I've forgotten anything we should document. > > Not your fault, but -Wclass-memaccess comes rather often and is not in the > changes. And not a libstdc++ change :-) Thee are lots of things missing, I'm only adding what I

Re: [PATCH] Fix __atomic to not implement atomic loads with CAS.

2018-04-11 Thread Tom de Vries
On 01/30/2017 07:54 PM, Torvald Riegel wrote: This patch fixes the __atomic builtins to not implement supposedly lock-free atomic loads based on just a compare-and-swap operation. Hi, The internals doc still lists CAS (

[PATCH] Invoke maybe_warn_nonstring_arg for strcpy/stpcpy builtins.

2018-04-11 Thread Andreas Krebbel
c-c++-common/attr-nonstring-3.c fails on IBM Z. The reason appears to be that we provide builtin implementations for strcpy and stpcpy. The warnings currently will only be emitted when expanding these as normal calls. Bootstrapped and regression tested on x86_64 and s390x. Ok? gcc/ChangeLog:

Re: [AARCH64] Neon vld1_*_x3, vst1_*_x2 and vst1_*_x3 intrinsics

2018-04-11 Thread Sameera Deshpande
On 10 April 2018 at 20:07, Sudakshina Das wrote: > Hi Sameera > > > On 10/04/18 11:20, Sameera Deshpande wrote: >> >> On 7 April 2018 at 01:25, Christophe Lyon >> wrote: >>> >>> Hi, >>> >>> 2018-04-06 12:15 GMT+02:00 Sameera Deshpande >>>

Re: [PATCH] Clean up attribute value comparison in lto-symtab.c.

2018-04-11 Thread Jakub Jelinek
On Wed, Apr 11, 2018 at 11:26:26AM +0200, Martin Liška wrote: > This is a small clean-up which Jakub suggested. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Martin > > > gcc/lto/ChangeLog: > > 2018-04-11 Martin Liska

Re: [PATCH] sched-deps: respect deps->readonly in macro-fusion (PR 84566)

2018-04-11 Thread Andrey Belevantsev
On 10.04.2018 13:40, Alexander Monakov wrote: > Hi, > > this fixes a simple "regression" under the qsort_chk umbrella: sched-deps > analysis has deps->readonly flag, but macro-fusion code does not respect it > and mutates instructions. This breaks an assumption in sel_rank_for_schedule > and

[PATCH] libgcc/CET: Skip signal frames when unwinding shadow stack

2018-04-11 Thread H.J. Lu
When -fcf-protection -mcet is used, I got FAIL: g++.dg/eh/sighandle.C (gdb) bt #0 _Unwind_RaiseException (exc=exc@entry=0x416ed0) at /export/gnu/import/git/sources/gcc/libgcc/unwind.inc:140 #1 0x77d9936b in __cxxabiv1::__cxa_throw (obj=, tinfo=0x403dd0 , dest=0x0) at

[wwwdocs] [COMMITTED] ARC gcc8 changes entry

2018-04-11 Thread Claudiu Zissulescu
Hi, Please find the ARC's gcc8 changes entry section as committed to wwwdocs. Thank you, Claudiu changes.patch Description: changes.patch

Re: [PATCH] Invoke maybe_warn_nonstring_arg for strcpy/stpcpy builtins.

2018-04-11 Thread Jakub Jelinek
On Wed, Apr 11, 2018 at 09:48:05AM +0200, Andreas Krebbel wrote: > c-c++-common/attr-nonstring-3.c fails on IBM Z. The reason appears to be > that we provide builtin implementations for strcpy and stpcpy. The > warnings currently will only be emitted when expanding these as normal > calls. > >

Re: [PATCH] Improve IPA-CP handling of self-recursive calls

2018-04-11 Thread Jan Hubicka
2018-04-08 Martin Jambor PR ipa/84149 * ipa-cp.c (propagate_vals_across_pass_through): Expand comment. (cgraph_edge_brings_value_p): New parameter dest_val, check if it is not the same as the source val. (cgraph_edge_brings_value_p):

Re: [PATCH] Fix -gsplit-dwarf ICE (PR debug/85302)

2018-04-11 Thread Richard Biener
On Tue, 10 Apr 2018, Jakub Jelinek wrote: > Hi! > > The r257510 change broke -gsplit-dwarf support by introducing a circular > dependency. Before that revision index_location_lists used to do: > /* Don't index an entry that has already been indexed >or won't be

[PATCH] Use --push-state --as-needed and --pop-state instead of --as-needed and --no-as-needed for libgcc

2018-04-11 Thread Jakub Jelinek
Hi! As discussed, using --as-needed and --no-as-needed is dangerous, because it results in --no-as-needed even for libraries after -lgcc_s, even when the default is --as-needed or --as-needed has been specified earlier on the command line. If the linker supports --push-state/--pop-state, we

Re: [PATCH] Fix some broadcasts in -masm=intel mode (PR target/85281)

2018-04-11 Thread Kirill Yukhin
Hello Jakub! On 09 апр 20:29, Jakub Jelinek wrote: > Hi! > > As the following testcase shows, we emit an incorrect PTR prefix in a > vpbroadcastb instruction in -masm=intel mode; gas accepts and the manual > documents that the input operand is xmm2/m8 for vpbroadcastb and > xmm2/m16 for

[PATCH] Clean up attribute value comparison in lto-symtab.c.

2018-04-11 Thread Martin Liška
Hi. This is a small clean-up which Jakub suggested. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Martin gcc/lto/ChangeLog: 2018-04-11 Martin Liska * lto-symtab.c (lto_symtab_merge_p): Use attribute_value_equal

Re: [AARCH64] Neon vld1_*_x3, vst1_*_x2 and vst1_*_x3 intrinsics

2018-04-11 Thread Sudakshina Das
Hi Sameera On 11/04/18 09:04, Sameera Deshpande wrote: On 10 April 2018 at 20:07, Sudakshina Das wrote: Hi Sameera On 10/04/18 11:20, Sameera Deshpande wrote: On 7 April 2018 at 01:25, Christophe Lyon wrote: Hi, 2018-04-06 12:15 GMT+02:00

Re: [nvptx] propagating conditionals in worker-vector partitioned loops

2018-04-11 Thread Tom de Vries
On 10/27/2016 12:29 AM, Cesar Philippidis wrote: Currently, the nvptx backend is only neutering the worker axis when propagating variables used in conditional expressions across the worker and vector axes. That's a problem with the worker-state spill and fill propagation implementation because

Re: [PATCH PR85190]Adjust pointer for aligned access

2018-04-11 Thread Richard Biener
On Tue, Apr 10, 2018 at 6:28 PM, Bin.Cheng wrote: > On Tue, Apr 10, 2018 at 3:58 PM, Bin.Cheng wrote: >> On Tue, Apr 10, 2018 at 2:26 PM, Jakub Jelinek wrote: >>> On Tue, Apr 10, 2018 at 09:55:35AM +, Bin Cheng wrote: Hi

Re: [PATCH, GCC/ARM] Fix PR85203: cmse_nonsecure_caller returns wrong result

2018-04-11 Thread Thomas Preudhomme
Hi Kyrill, One week went by so I've committed the change to GCC 7 as announced. Best regards, Thomas On 05/04/18 16:36, Kyrill Tkachov wrote: On 05/04/18 16:13, Thomas Preudhomme wrote: Hi Kyrill, On 04/04/18 18:20, Thomas Preudhomme wrote: Hi Kyrill, On 04/04/18 18:19, Kyrill Tkachov

Re: [PATCH] sched-rgn: run add_branch_dependencies for sel-sched (PR 84301)

2018-04-11 Thread Andrey Belevantsev
On 10.04.2018 14:09, Alexander Monakov wrote: > Hi, > > The add_branch_dependencies function is fairly unusual in that it creates > dependence edges "out of thin air" for all sorts of instructions preceding > BB end. I think that is really unfortunate (explicit barriers in RTL would > be more

[og7] Backport "[nvptx] Fix neutering of bb with only cond jump"

2018-04-11 Thread Tom de Vries
[ was: Re: [gomp4] propagating conditionals in worker-vector partitioned loops ] On 10/28/2016 06:33 PM, Cesar Philippidis wrote: I've applied the patch to gomp-4_0-branch to correct an issue involving the propagation of variables used in conditional expressions to worker and vector

[og7] backported "[nvptx, PR84041] Add memory_barrier insn"

2018-04-11 Thread Tom de Vries
On 04/09/2018 03:19 PM, Tom de Vries wrote: Hi, we've been having hanging OpenMP tests for nvptx offloading: for-{3,5,6}.c and the corresponding C++ test-cases. The failures have now been analyzed down to gomp_ptrlock_get in libgomp/config/nvptx/ptrlock.h: ...  static inline void

[PATCH] Fix PR85339, bogus early debug

2018-04-11 Thread Richard Biener
The following fixes the missing .debug_line in the early LTO debug DWARF which makes all DW_AT_decl_file invalid. LTO bootstrapped on x86_64-unknown-linux-gnu, LTO bootstrap with -g3 still running, so is regtesting. I verified it works with thin and fat LTO and that the early DWARF has a proper

Re: [PATCH] Invoke maybe_warn_nonstring_arg for strcpy/stpcpy builtins.

2018-04-11 Thread Andreas Krebbel
On 04/11/2018 10:02 AM, Jakub Jelinek wrote: > On Wed, Apr 11, 2018 at 09:48:05AM +0200, Andreas Krebbel wrote: >> c-c++-common/attr-nonstring-3.c fails on IBM Z. The reason appears to be >> that we provide builtin implementations for strcpy and stpcpy. The >> warnings currently will only be

Re: [PATCH PR85190]Adjust pointer for aligned access

2018-04-11 Thread Bin.Cheng
On Wed, Apr 11, 2018 at 10:46 AM, Richard Biener wrote: > On Tue, Apr 10, 2018 at 6:28 PM, Bin.Cheng wrote: >> On Tue, Apr 10, 2018 at 3:58 PM, Bin.Cheng wrote: >>> On Tue, Apr 10, 2018 at 2:26 PM, Jakub Jelinek

Re: [AARCH64] Neon vld1_*_x3, vst1_*_x2 and vst1_*_x3 intrinsics

2018-04-11 Thread Sameera Deshpande
On 11 April 2018 at 15:53, Sudakshina Das wrote: > Hi Sameera > > > On 11/04/18 09:04, Sameera Deshpande wrote: >> >> On 10 April 2018 at 20:07, Sudakshina Das wrote: >>> >>> Hi Sameera >>> >>> >>> On 10/04/18 11:20, Sameera Deshpande wrote: On

[PATCH 0/2] MIPS/GCC/testsuite: Fixes for data-sym-pool.c

2018-04-11 Thread Maciej W. Rozycki
Hi, Paul has recently reported a regression test failure with data-sym-pool.c at -O0 in his configuration. After some tweaking I was able to reproduce it with mine. I also realised we need an n64 variant, hence this has become a mini patch series. As these changes are test suite updates

[PATCH 1/2] MIPS/GCC/testsuite: Fix data-sym-pool.c for SVR4 model at -O0

2018-04-11 Thread Maciej W. Rozycki
With GCC configurations using the SVR4 rather than the PLT dynamic executable model and the o32 ABI with the data-sym-pool.c test case code like below is produced: .file 1 "data-sym-pool.c" .section .mdebug.abi32 .previous .nanlegacy .module fp=xx

Re: [PATCH] Make redirection only for target_clones (PR ipa/85329).

2018-04-11 Thread Martin Liška
On 04/11/2018 03:12 PM, Martin Liška wrote: > Hi. > > Following restricts cgraph redirection done in multiple_target.c just > to clones that are created in the IPA pass. > > Patch can bootstrap on x86_64-linux-gnu and survives regression tests. > > Ready to be installed? > Martin > >

[PATCH] Make redirection only for target_clones (PR ipa/85329).

2018-04-11 Thread Martin Liška
Hi. Following restricts cgraph redirection done in multiple_target.c just to clones that are created in the IPA pass. Patch can bootstrap on x86_64-linux-gnu and survives regression tests. Ready to be installed? Martin gcc/ChangeLog: 2018-04-11 Martin Liska PR

Re: [PATCH, rs6000] PR85321 improve documentation of -mcall and -mtraceback=

2018-04-11 Thread Segher Boessenkool
Hi! On Tue, Apr 10, 2018 at 06:49:55PM -0500, Aaron Sawdey wrote: > Another update to document -mcall- and -mtraceback= options. Cleanup to > remove -mabi={no-,}spe from the RS/6000 and PowerPC section. And a trim > to the help text for -mblock-compare-* and -mstring-compare-inline- > limit so

Re: [PATCH] Fix PR85339, bogus early debug

2018-04-11 Thread Jason Merrill
OK. On Wed, Apr 11, 2018 at 7:09 AM, Richard Biener wrote: > > The following fixes the missing .debug_line in the early LTO debug > DWARF which makes all DW_AT_decl_file invalid. > > LTO bootstrapped on x86_64-unknown-linux-gnu, LTO bootstrap with -g3 > still running, so is

Re: [PATCH] Fix VEC_PERM_EXPR folding (PR tree-optimization/85331)

2018-04-11 Thread Richard Biener
On Wed, 11 Apr 2018, Jakub Jelinek wrote: > Hi! > > We ICE on the following testcase, because VEC_PERM_EXPR indexes are supposed > to be clamped into the 0 .. 2 * nelts - 1 range, but if some index is very > large constant (larger or equal than HOST_WIDE_INT_1 << 33), then clamp > doesn't

[PATCH] Fix non-AVX512VL handling of lo extraction from AVX512F xmm16+ (PR target/85328)

2018-04-11 Thread Jakub Jelinek
Hi! In lots of patterns we assume that we never see xmm16+ hard registers with 128-bit and 256-bit vector modes when not -mavx512vl, because HARD_REGNO_MODE_OK refuses those. Unfortunately, as this testcase and patch shows, the vec_extract_lo* splitters work as a loophole around this, we happily

[PATCH] Fix VEC_PERM_EXPR folding (PR tree-optimization/85331)

2018-04-11 Thread Jakub Jelinek
Hi! We ICE on the following testcase, because VEC_PERM_EXPR indexes are supposed to be clamped into the 0 .. 2 * nelts - 1 range, but if some index is very large constant (larger or equal than HOST_WIDE_INT_1 << 33), then clamp doesn't actually perform any clamping. This is because

Re: [PATCH PR85190]Adjust pointer for aligned access

2018-04-11 Thread Richard Biener
On Wed, Apr 11, 2018 at 3:15 PM, Bin.Cheng wrote: > On Wed, Apr 11, 2018 at 10:46 AM, Richard Biener > wrote: >> On Tue, Apr 10, 2018 at 6:28 PM, Bin.Cheng wrote: >>> On Tue, Apr 10, 2018 at 3:58 PM, Bin.Cheng

[PATCH 2/2] MIPS/GCC/testsuite: Fix data-sym-pool.c for n64 code

2018-04-11 Thread Maciej W. Rozycki
With the soft-float n64 ABI and the data-sym-pool.c test case code like below is produced: .file 1 "data-sym-pool.c" .section .mdebug.abi64 .previous .nanlegacy .module softfloat .module oddspreg .abicalls .option pic0

Re: [PATCH] sched-rgn: run add_branch_dependencies for sel-sched (PR 84301)

2018-04-11 Thread Vladimir Makarov
On 04/11/2018 06:15 AM, Andrey Belevantsev wrote: On 10.04.2018 14:09, Alexander Monakov wrote: Hi, The add_branch_dependencies function is fairly unusual in that it creates dependence edges "out of thin air" for all sorts of instructions preceding BB end. I think that is really unfortunate

Re: [PATCH] sched-deps: respect deps->readonly in macro-fusion (PR 84566)

2018-04-11 Thread Vladimir Makarov
On 04/11/2018 06:19 AM, Andrey Belevantsev wrote: On 10.04.2018 13:40, Alexander Monakov wrote: Hi, this fixes a simple "regression" under the qsort_chk umbrella: sched-deps analysis has deps->readonly flag, but macro-fusion code does not respect it and mutates instructions. This breaks an

Re: [doc PATCH] fix up C++ option references (PR 71283)

2018-04-11 Thread Jason Merrill
On 04/05/2018 07:28 PM, Martin Sebor wrote: Attached is the final version of the patch to adjust the lists of options (C++ Language Options and -Wall) to include missing C++ options, reference the forms of options that aren't the default, and use TexInfo tables for the lists of options in -Wall

Re: [PATCH] Use --push-state --as-needed and --pop-state instead of --as-needed and --no-as-needed for libgcc

2018-04-11 Thread Matthias Klose
On 11.04.2018 12:31, Jakub Jelinek wrote: > Hi! > > As discussed, using --as-needed and --no-as-needed is dangerous, because > it results in --no-as-needed even for libraries after -lgcc_s, even when the > default is --as-needed or --as-needed has been specified earlier on the > command line. >

Re: [AARCH64] Neon vld1_*_x3, vst1_*_x2 and vst1_*_x3 intrinsics

2018-04-11 Thread Sudakshina Das
Hi Sameera On 11/04/18 13:05, Sameera Deshpande wrote: On 11 April 2018 at 15:53, Sudakshina Das wrote: Hi Sameera On 11/04/18 09:04, Sameera Deshpande wrote: On 10 April 2018 at 20:07, Sudakshina Das wrote: Hi Sameera On 10/04/18 11:20, Sameera

Re: [PATCH] Fix PR85339, bogus early debug

2018-04-11 Thread Jakub Jelinek
On Wed, Apr 11, 2018 at 01:09:39PM +0200, Richard Biener wrote: > 2018-04-11 Richard Biener > > PR lto/85339 > * dwarf2out.c (dwarf2out_finish): Remove DW_AT_stmt_list attribute > from early DWARF output. > (dwarf2out_early_finish): Output line info

Re: [PATCH] [PR c++/85039] no type definitions in builtin offsetof

2018-04-11 Thread Jason Merrill
On Thu, Apr 5, 2018 at 9:33 AM, Jason Merrill wrote: > On Wed, Apr 4, 2018 at 12:25 PM, Alexandre Oliva wrote: >> On Apr 4, 2018, Jason Merrill wrote: >> >>> On Tue, Apr 3, 2018 at 11:25 PM, Alexandre Oliva wrote:

Re: [C++ Patch] PR 70808 ("Spurious -Wzero-as-null-pointer-constant for nullptr_t")

2018-04-11 Thread Jakub Jelinek
On Tue, Apr 10, 2018 at 08:57:22PM +0200, Paolo Carlini wrote: > 2018-04-10 Paolo Carlini > > PR c++/70808 > * g++.dg/warn/Wzero-as-null-pointer-constant-7.C: New. The testcase FAILs in -std=c++98 mode for obvious reasons. I've committed following after

Re: [PATCH][explow] PR target/85173: validize memory before passing it on to target probe_stack

2018-04-11 Thread Uros Bizjak
On Tue, Apr 10, 2018 at 11:14 AM, Uros Bizjak wrote: > On Tue, Apr 10, 2018 at 10:45 AM, Richard Earnshaw (lists) > wrote: > Alpha should be fixed -- the docs clearly state that the operand is "the memory reference in the stack that needs to

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-11 Thread Jakub Jelinek
On Tue, Apr 10, 2018 at 11:50:44PM +0200, Thomas Koenig wrote: > Hi Jakub, > > > > The new test FAILs everywhere, gfortran.dg doesn't have infrastructure to > > run -fopenmp, -fopenacc nor -ftree-parallelize-loops= tests. > > You need to put such tests into libgomp/testsuite/libgomp.fortran/ >

[PATCH] Fix non-AVX512VL handling of lo extraction from AVX512F xmm16+ (PR target/85328, take 2)

2018-04-11 Thread Jakub Jelinek
On Wed, Apr 11, 2018 at 03:27:28PM +0200, Jakub Jelinek wrote: > In lots of patterns we assume that we never see xmm16+ hard registers > with 128-bit and 256-bit vector modes when not -mavx512vl, because > HARD_REGNO_MODE_OK refuses those. > Unfortunately, as this testcase and patch shows, the

Re: RFC: Disable asan tests under ulimit -v

2018-04-11 Thread Jason Merrill
On Tue, Apr 3, 2018 at 1:23 PM, Jason Merrill wrote: > On Tue, Apr 3, 2018 at 12:56 PM, Jason Merrill wrote: >> On Mon, Mar 26, 2018 at 4:01 PM, Jason Merrill wrote: >>> >>> On Mon, Mar 26, 2018 at 2:55 PM, Andreas Schwab

Re: [C++ Patch] PR 70808 ("Spurious -Wzero-as-null-pointer-constant for nullptr_t")

2018-04-11 Thread Paolo Carlini
Hi, On 11/04/2018 17:57, Jakub Jelinek wrote: On Tue, Apr 10, 2018 at 08:57:22PM +0200, Paolo Carlini wrote: 2018-04-10 Paolo Carlini PR c++/70808 * g++.dg/warn/Wzero-as-null-pointer-constant-7.C: New. The testcase FAILs in -std=c++98 mode for

Re: RFC: Disable asan tests under ulimit -v

2018-04-11 Thread Jason Merrill
On Wed, Apr 11, 2018 at 2:07 PM, Jakub Jelinek wrote: > On Wed, Apr 11, 2018 at 01:59:40PM -0400, Jason Merrill wrote: >> And this one puts the check in asan_init rather than its users. OK? > > tsan tests have the same problem. Hmm, tsan tests work fine for me under ulimit -v.

Re: RFC: Disable asan tests under ulimit -v

2018-04-11 Thread Jakub Jelinek
On Wed, Apr 11, 2018 at 01:59:40PM -0400, Jason Merrill wrote: > And this one puts the check in asan_init rather than its users. OK? tsan tests have the same problem. Wouldn't it be better to have a helper procedure for this and use it next to if [check_effective_target_fsanitize_address] { or

Re: [doc PATCH] fix up C++ option references (PR 71283)

2018-04-11 Thread Martin Sebor
On 04/11/2018 09:44 AM, Jason Merrill wrote: On 04/05/2018 07:28 PM, Martin Sebor wrote: Attached is the final version of the patch to adjust the lists of options (C++ Language Options and -Wall) to include missing C++ options, reference the forms of options that aren't the default, and use

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-11 Thread Thomas Koenig
Am 11.04.2018 um 17:44 schrieb Jakub Jelinek: On Tue, Apr 10, 2018 at 11:50:44PM +0200, Thomas Koenig wrote: Hi Jakub, The new test FAILs everywhere, gfortran.dg doesn't have infrastructure to run -fopenmp, -fopenacc nor -ftree-parallelize-loops= tests. You need to put such tests into

Re: RFC: C++ PATCH for c++/69763, making C++ alignof match C _Alignof

2018-04-11 Thread Jason Merrill
On Tue, Apr 10, 2018 at 1:12 PM, Jason Merrill wrote: > But really this is beside the point: the x86 ABI says that the > alignment of double is 4, so alignof(double) should be 4 regardless of > what GCC wants to do internally. And I think the same is true of > __alignof__.

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-11 Thread Jakub Jelinek
On Wed, Apr 11, 2018 at 08:18:35PM +0200, Thomas Koenig wrote: > Am 11.04.2018 um 17:44 schrieb Jakub Jelinek: > > On Tue, Apr 10, 2018 at 11:50:44PM +0200, Thomas Koenig wrote: > > > Hi Jakub, > > > > > > > > > > The new test FAILs everywhere, gfortran.dg doesn't have infrastructure > > > > to

Re: [wwwdocs] document new options in gcc-8/changes.html

2018-04-11 Thread Martin Sebor
Ping: https://gcc.gnu.org/ml/gcc-patches/2018-04/msg00219.html There's one outstanding typo that Paolo noticed since I posted the update. I'll fix that before committing. On 04/04/2018 04:28 PM, Martin Sebor wrote: Attached is an updated diff rebased on top of the latest revision of the file.

Re: [PATCH] sel-sched: run cleanup_cfg just before loop_optimizer_init (PR 84659)

2018-04-11 Thread Alexander Monakov
As noted in PR 85354, we cannot simply invoke cfg_cleanup after dominators are computed, because they may become invalid but neither freed nor recomputed, so this trips checking in flow_loops_find. We can move cleanup_cfg earlier (and run it for all sel-sched invocations, not only when

Re: [PATCH] Invoke maybe_warn_nonstring_arg for strcpy/stpcpy builtins.

2018-04-11 Thread Martin Sebor
On 04/11/2018 06:47 AM, Andreas Krebbel wrote: On 04/11/2018 10:02 AM, Jakub Jelinek wrote: On Wed, Apr 11, 2018 at 09:48:05AM +0200, Andreas Krebbel wrote: c-c++-common/attr-nonstring-3.c fails on IBM Z. The reason appears to be that we provide builtin implementations for strcpy and stpcpy.

Re: [PATCH] Use --push-state --as-needed and --pop-state instead of --as-needed and --no-as-needed for libgcc

2018-04-11 Thread Jakub Jelinek
On Wed, Apr 11, 2018 at 06:07:17PM +0200, Matthias Klose wrote: > On 11.04.2018 12:31, Jakub Jelinek wrote: > > Hi! > > > > As discussed, using --as-needed and --no-as-needed is dangerous, because > > it results in --no-as-needed even for libraries after -lgcc_s, even when the > > default is

Re: [patch, fortran] Remove parallell annotation from DO CONCURRENT

2018-04-11 Thread Thomas Koenig
Am 11.04.2018 um 20:33 schrieb Jakub Jelinek: I have attached updated patch which moves the test case to gfortran.dg/gomp (where it actually passes). How could it pass there? dg-do run tests don't belong into g*.dg/gomp/, nothing adds the -B etc. options needed to find libgomp.spec or

Re: [PATCH] Handle empty infinite loops in OpenACC for PR84955

2018-04-11 Thread Cesar Philippidis
On 04/09/2018 04:31 AM, Richard Biener wrote: > On Fri, 6 Apr 2018, Jakub Jelinek wrote: > >> On Fri, Apr 06, 2018 at 06:48:52AM -0700, Cesar Philippidis wrote: >>> 2018-04-06 Cesar Philippidis >>> >>> PR middle-end/84955 >>> >>> gcc/ >>> * cfgloop.c

[PATCH] Fix copyprop_hardreg_forward_1 (PR rtl-optimization/85342)

2018-04-11 Thread Jakub Jelinek
Hi! When switching regcprop.c to use validate_* and apply_change_group, I have added code to restore recog_data.operands[i] if they have been replaced after apply_change_group failure. That is bogus though, when apply_change_group fails, recog_data.insn is NULL and rest of recog_data structure

Re: RFC: Disable asan tests under ulimit -v

2018-04-11 Thread Jakub Jelinek
On Wed, Apr 11, 2018 at 02:28:09PM -0400, Jason Merrill wrote: > On Wed, Apr 11, 2018 at 2:07 PM, Jakub Jelinek wrote: > > On Wed, Apr 11, 2018 at 01:59:40PM -0400, Jason Merrill wrote: > >> And this one puts the check in asan_init rather than its users. OK? > > > > tsan tests

Re: [wwwdocs] document new options in gcc-8/changes.html

2018-04-11 Thread Jason Merrill
OK. On Wed, Apr 11, 2018 at 3:13 PM, Martin Sebor wrote: > Ping: https://gcc.gnu.org/ml/gcc-patches/2018-04/msg00219.html > > There's one outstanding typo that Paolo noticed since I posted > the update. I'll fix that before committing. > > > On 04/04/2018 04:28 PM, Martin

Re: [doc PATCH] fix up C++ option references (PR 71283)

2018-04-11 Thread Jason Merrill
On Wed, Apr 11, 2018 at 1:51 PM, Martin Sebor wrote: > On 04/11/2018 09:44 AM, Jason Merrill wrote: >> On 04/05/2018 07:28 PM, Martin Sebor wrote: >>> >>> Attached is the final version of the patch to adjust the lists >>> of options (C++ Language Options and -Wall) to include

Re: [wwwdocs] Document libstdc++ changes in GCC 8

2018-04-11 Thread Bernd Edlinger
> Let me know if I've forgotten anything we should document. Not your fault, but -Wclass-memaccess comes rather often and is not in the changes. Bernd.

Re: [wwwdocs] document new options in gcc-8/changes.html

2018-04-11 Thread Martin Sebor
On 04/04/2018 05:03 PM, Paolo Carlini wrote: Hi Martin On 05/04/2018 00:28, Martin Sebor wrote: + implementations do suppresses the warning. suppress I was about to fix this but re-reading the full sentence made me realize it's correct as is: Note that due to GCC bug 82944, defining