Hi,
2018-04-08 22:59 GMT+02:00 Dan Little :
> A good practice that I've seen many projects use is that one is not allowed
> to merge their own PRs without a review. So even a core-committer would go
> though the same steps regardless of "write access." That's particularly
> helpful when a project
Hi,
2018-04-08 23:01 GMT+02:00 Even Rouault :
> It is up to you, and your confidence in your change. There can be 3
> strategies:
> * directly push to origin (https://github.com/OSGeo gdal)
> * do a pull request if Iyou want other people to have a chance to review and/
> or have CI tests running
> Do you mean [1]? My name seems to be already there.
>
Yes, but we've added a new git related section at the top of the file. Your
name is in the old SVN section.
> Ma
>
> [1] https://github.com/OSGeo/gdal/blob/master/gdal/COMMITTERS
--
Spatialys - Geospatial professional services
http://w
Hi Even,
2018-04-08 22:40 GMT+02:00 Even Rouault :
> Yep, just ask as your did.
> I've just sent you an invite.
thanks!
> Please also add yourself in the new section of COMMITTERS where we list folks
> with git push rights
Do you mean [1]? My name seems to be already there.
Ma
[1] https://git
> Question: So _core_ GDAL developers (with write access) should also
> create PR? Than wait for feedback and any many cases apply PR on their
> own?
It is up to you, and your confidence in your change. There can be 3
strategies:
* directly push to origin (https://github.com/OSGeo gdal)
* do a pu
Hi,
2018-04-08 22:38 GMT+02:00 Dan Little :
> With GitHub, you usually do a personal fork and then submit a pull request.
> Not quite as easy as direct commits to the main repository but standard
> practice.
really? I thought that PR is mechanism for those who haven't write
permission to the repo
On dimanche 8 avril 2018 22:36:27 CEST Martin Landa wrote:
> Hi,
>
> is there any policy of assigning write access to GH repository for
> those of developers who had such permission for old SVN repo?
Hi Martin,
Yep, just ask as your did.
I've just sent you an invite.
Please also add yourself in
Hi,
is there any policy of assigning write access to GH repository for
those of developers who had such permission for old SVN repo?
I would like to fix [1], do I need to express my interest for write
access explicitly somehow?
Thanks, Martin
[1] https://github.com/OSGeo/gdal/issues/365
--
Ma