Re: [gem5-dev] Review Request 2636: mem: fix prefetcher bug regarding write buffer hits

2015-02-06 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2636/#review5849 --- It think there are more (and bigger issues) at play here. I'd suggest to

[gem5-dev] Cron m5test@zizzer /z/m5/regression/do-regression quick

2015-02-06 Thread Cron Daemon via gem5-dev
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/minor-timing passed. *

Re: [gem5-dev] Review Request 2637: mem: clean up write buffer check in Cache::handleSnoop()

2015-02-06 Thread Andreas Hansson via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2637/#review5848 --- Ship it! Ship It! - Andreas Hansson On Feb. 6, 2015, 12:38 a.m.,

[gem5-dev] Review Request 2641: base: add new ChunkGenerator method to identify last chunk

2015-02-06 Thread Brandon Potter via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2641/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2640: cpu: remove conditional check (count 0) on o3 IQ squashes

2015-02-06 Thread Brandon Potter via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2640/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 2642: syscall_emul: fix warning with wrong syscall name and nix extra whitespace

2015-02-06 Thread Gabe Black via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2642/#review5862 --- Ship it! Ship It! - Gabe Black On Feb. 6, 2015, 10:07 p.m., Brandon

[gem5-dev] Review Request 2643: syscall_emul: update getrlimit to warn (instead of std::cerr) and return

2015-02-06 Thread Brandon Potter via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2643/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2645: syscall_emul: implement clock_gettime system call

2015-02-06 Thread Brandon Potter via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2645/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] changeset in gem5: cpu: Idle CPU status logic revised

2015-02-06 Thread Alexandru Dutu via gem5-dev
changeset 94901e131a7f in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=94901e131a7f description: cpu: Idle CPU status logic revised This patch sets the CPU status to idle when the last active thread gets suspended. diffstat: src/cpu/o3/cpu.cc | 7

[gem5-dev] Review Request 2638: config: optionally embed environment variables onto SE-mode application stack

2015-02-06 Thread Brandon Potter via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2638/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2642: syscall_emul: fix warning with wrong syscall name and nix extra whitespace

2015-02-06 Thread Brandon Potter via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2642/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 2644: syscall_emul: update x86 syscall table with additional definitions (through Linux 3.13)

2015-02-06 Thread Brandon Potter via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2644/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 2636: mem: fix prefetcher bug regarding write buffer hits

2015-02-06 Thread Andreas Hansson via gem5-dev
On Feb. 6, 2015, 8:18 a.m., Andreas Hansson wrote: It think there are more (and bigger issues) at play here. I'd suggest to try this out with: http://reviews.gem5.org/r/2626/ If you run it with -p, prefetches enabled, it doesn't take many seconds before it hits an assert. We're

Re: [gem5-dev] Review Request 2637: mem: clean up write buffer check in Cache::handleSnoop()

2015-02-06 Thread Andreas Hansson via gem5-dev
On Feb. 6, 2015, 8:16 a.m., Andreas Hansson wrote: Ship It! Andreas Hansson wrote: Here it would be good to test with the new memtest: http://reviews.gem5.org/r/2612/ Note that the caches suffer from message deadlock at the moment, and the test dies very quickly. I

Re: [gem5-dev] Review Request 2626: config: Add memcheck stress test

2015-02-06 Thread Steve Reinhardt via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2626/#review5855 --- So would this replace memtest.py? If so, then factoring out the common

Re: [gem5-dev] Review Request 2626: config: Add memcheck stress test

2015-02-06 Thread Andreas Hansson via gem5-dev
On Feb. 6, 2015, 5:10 p.m., Steve Reinhardt wrote: So would this replace memtest.py? If so, then factoring out the common code would not be an issue. If not, why not? The two are complementary: memtest.py uses MemTest and only tests false sharing, with some progress detection built in

Re: [gem5-dev] Review Request 2626: config: Add memcheck stress test

2015-02-06 Thread Andreas Hansson via gem5-dev
On Feb. 6, 2015, 5:10 p.m., Steve Reinhardt wrote: So would this replace memtest.py? If so, then factoring out the common code would not be an issue. If not, why not? Andreas Hansson wrote: The two are complementary: memtest.py uses MemTest and only tests false

Re: [gem5-dev] Review Request 2626: config: Add memcheck stress test

2015-02-06 Thread Steve Reinhardt via gem5-dev
On Feb. 6, 2015, 9:10 a.m., Steve Reinhardt wrote: So would this replace memtest.py? If so, then factoring out the common code would not be an issue. If not, why not? Andreas Hansson wrote: The two are complementary: memtest.py uses MemTest and only tests false

Re: [gem5-dev] Review Request 2636: mem: fix prefetcher bug regarding write buffer hits

2015-02-06 Thread Steve Reinhardt via gem5-dev
On Feb. 6, 2015, 12:18 a.m., Andreas Hansson wrote: It think there are more (and bigger issues) at play here. I'd suggest to try this out with: http://reviews.gem5.org/r/2626/ If you run it with -p, prefetches enabled, it doesn't take many seconds before it hits an assert. We're

Re: [gem5-dev] Review Request 2637: mem: clean up write buffer check in Cache::handleSnoop()

2015-02-06 Thread Steve Reinhardt via gem5-dev
On Feb. 6, 2015, 12:16 a.m., Andreas Hansson wrote: Ship It! Andreas Hansson wrote: Here it would be good to test with the new memtest: http://reviews.gem5.org/r/2612/ Note that the caches suffer from message deadlock at the moment, and the test dies very quickly. I

Re: [gem5-dev] Review Request 2626: config: Add memcheck stress test

2015-02-06 Thread Steve Reinhardt via gem5-dev
On Feb. 6, 2015, 9:10 a.m., Steve Reinhardt wrote: So would this replace memtest.py? If so, then factoring out the common code would not be an issue. If not, why not? Andreas Hansson wrote: The two are complementary: memtest.py uses MemTest and only tests false

Re: [gem5-dev] Review Request 2626: config: Add memcheck stress test

2015-02-06 Thread Steve Reinhardt via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2626/#review5860 --- Ship it! Minor optional comments below... configs/example/memcheck.py

Re: [gem5-dev] Review Request 2612: config: Revamp memtest to allow testers on any level

2015-02-06 Thread Steve Reinhardt via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2612/#review5861 --- Ship it! configs/example/memtest.py