Re: [gem5-dev] Review Request 2996: cpu: Add per-thread monitors

2015-08-20 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2996/#review7020 --- At a first glance this patch seems to make all the modifications that

Re: [gem5-dev] Review Request 3037: ruby: Move Rubys cache class from Cache.py to RubyCache.py

2015-08-20 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3037/#review7022 --- Ship it! Ship It! - Steve Reinhardt On Aug. 17, 2015, 1:16 a.m.,

Re: [gem5-dev] Review Request 3045: mem: Use C++11 delegating constructors for Request

2015-08-20 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3045/#review7024 --- Ship it! Ship It! - Tony Gutierrez On Aug. 19, 2015, 2:06 a.m.,

Re: [gem5-dev] SMT support: last call for feedback

2015-08-20 Thread Dutu, Alexandru
Hi Curtis, Can you please hold a bit on pushing these? I do have some patches on related topic which got ship it, though they still have some issues with long regressions in Full System mode (initially all my modifications were intended for SE mode). I suspect one of your patches will help

Re: [gem5-dev] Review Request 2999: cpu, isa, mem: Adds per-thread wakeup logic

2015-08-20 Thread Alexandru Dutu
On July 30, 2015, 11:59 p.m., Steve Reinhardt wrote: so what is the difference between xc-getCpuPtr()-wakeup(xc-threadId()); and xc-activate(); ? I think we need to clarify whether or not these are equivalent, and if so, why we need both, and if not, what the differences

Re: [gem5-dev] Review Request 3044: mem: Reflect that packet address and size are always valid

2015-08-20 Thread Andreas Hansson
On Aug. 19, 2015, 2:56 p.m., Steve Reinhardt wrote: src/mem/packet.hh, line 580 http://reviews.gem5.org/r/3044/diff/1/?file=49083#file49083line580 Looks like you need to update this comment. I assume that no one ever used the capability described here? Indeed, it was never

[gem5-dev] VNC server on X86 - crashes gem5 on attach/detach

2015-08-20 Thread Cagdas Dirik (cdirik)
Hi all, We have been trying to setup tests with a debian 6 image with gnome, and we need UI/desktop environment. Our image works fine with VirtualBox and Qemu. However we cannot get it booting successfully in gem5. Not sure if it hangs on boot, or it boots fine but we just cannot see the

Re: [gem5-dev] Review Request 3015: ruby: improved component mapping

2015-08-20 Thread Joel Hestness
On Aug. 14, 2015, 12:42 a.m., Brad Beckmann wrote: Nilay, you cannot just eliminate RubySlicc_ComponentMapping files without having a lot discussion on gem5-dev on the implications. Component mapping functions are very complicated and error prone. The simple protocols and

[gem5-dev] Cron m5test@zizzer /z/m5/regression/do-regression quick

2015-08-20 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/60.rubytest/alpha/linux/rubytest-ruby passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/simple-timing-ruby passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/minor-timing passed. *

Re: [gem5-dev] Review Request 2995: config, cpu: Add SMT support to Atomic and Timing CPUs

2015-08-20 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2995/#review7018 --- I have mixed feelings about this patch---on the one hand, the uniformity

Re: [gem5-dev] Review Request 2972: tests: Add tests for the Learning gem5 scripts

2015-08-20 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2972/#review7019 --- Would it make sense (or is it not possible) to put the scripts in a