Re: [gem5-dev] Review Request 2986: Simple HMC Model

2015-09-14 Thread Erfan Azarkhish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2986/ --- (Updated Sept. 14, 2015, 1:17 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2993: Serial Link model for the HMC

2015-09-14 Thread Erfan Azarkhish
Dear All, I have updated the serial link model to be able to regulate bandwidth and make sure it does not exceed its theoretical limit (Number of Lanes X Clock Frequency). I measure peak bandwidth over epochs of T (periodically), and if the peak bandwidth exceeds the theoretical max value, I

Re: [gem5-dev] Review Request 2993: Serial Link model for the HMC

2015-09-14 Thread Erfan Azarkhish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2993/ --- (Updated Sept. 14, 2015, 1:17 p.m.) Review request for Default. Repository: gem5

[gem5-dev] Review Request 3111: ruby: fix message buffer init order

2015-09-14 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3111/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3111: ruby: fix message buffer init order

2015-09-14 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3111/#review7171 --- Tony, expand the review description and add the problem that you are

[gem5-dev] changeset in gem5: ruby: slicc: remove member buffer_expr from V...

2015-09-14 Thread Nilay Vaish
changeset 12c36d719139 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=12c36d719139 description: ruby: slicc: remove member buffer_expr from Var class This was added by changeset 51f40b101a56. Instead, buffer_expr would now be associated with the

Re: [gem5-dev] Review Request 3111: ruby: fix message buffer init order

2015-09-14 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3111/ --- (Updated Sept. 14, 2015, 10:37 a.m.) Review request for Default. Repository:

Re: [gem5-dev] Review Request 3111: ruby: fix message buffer init order

2015-09-14 Thread Tony Gutierrez
> On Sept. 14, 2015, 8:35 a.m., Nilay Vaish wrote: > > src/mem/ruby/network/Network.hh, line 75 > > > > > > These functions need not be virtual now. Yep. Will remove that. > On Sept. 14, 2015, 8:35 a.m., Nilay Vaish

[gem5-dev] Review Request 3113: ruby: allows multiple instances of ruby to be invoked

2015-09-14 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3113/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

2015-09-14 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2965/#review7175 --- Any last comments? I plan to ship this before the EoD today. - Tony

Re: [gem5-dev] O3 coalescing (was Re: Review Request 2787: ruby: Fixed pipeline squashes caused by aliased requests)

2015-09-14 Thread Beckmann, Brad
Hi All, At the bottom of Steve's message, he wrote " If pushing coalescing up into the LSQ doesn't let us remove it from the cache model, it doesn't seem like a big win to me. I understand that it would be a win on the Ruby side, given the current situation there, but that raises the question

[gem5-dev] Review Request 3112: slicc: export uint64_t instead of uint64

2015-09-14 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3112/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3112: slicc: export uint64_t instead of uint64

2015-09-14 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3112/ --- (Updated Sept. 14, 2015, 10:50 a.m.) Review request for Default. Repository:

Re: [gem5-dev] Review Request 2993: Serial Link model for the HMC

2015-09-14 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2993/#review7173 --- Hi Erfan, I was thinking of something much simpler for the bandwidth

Re: [gem5-dev] Review Request 3112: slicc: export uint64_t instead of uint64

2015-09-14 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3112/#review7174 --- Ship it! Ship It! - Nilay Vaish On Sept. 14, 2015, 5:50 p.m., Tony

[gem5-dev] [PATCH] IDE Disk: Handle bad IDE image size

2015-09-14 Thread Dongxue Zhang
From fb2ffe9552e166d751586c90669bde92249470bd Mon Sep 17 00:00:00 2001 From: Elta Era Date: Mon, 14 Sep 2015 15:33:07 +0800 Subject: [PATCH] IDE Disk: Handle bad IDE image size Handle bad IDE disk image size 0. When image size is 0, gem5 will cause an exception with log