Re: [gem5-dev] Review Request 2993: mem: Add a serial link model for HMC

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2993/#review7371 --- Format this patch again. Read the following page:

[gem5-dev] changeset in gem5: ruby: profiler: provide the number of vnets t...

changeset 9261e98e4501 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=9261e98e4501 description: ruby: profiler: provide the number of vnets through ruby system The aim is to ultimately do away with the static function

[gem5-dev] changeset in gem5: ruby: remove unused functionalRead() function.

changeset 60d4dfa3241a in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=60d4dfa3241a description: ruby: remove unused functionalRead() function. Not required since functional reads cannot rely on messages that are inflight. diffstat:

[gem5-dev] changeset in gem5: ruby: garnet: flexible: refactor flit

changeset 1151cfea92e3 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=1151cfea92e3 description: ruby: garnet: flexible: refactor flit diffstat: src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc | 2 +-

Re: [gem5-dev] Review Request 3151: mem: Clarify cache MSHR handling on fill

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3151/#review7372 --- Ship it! Ship It! - Nilay Vaish On Oct. 13, 2015, 4:49 p.m., Andreas

Re: [gem5-dev] Review Request 3132: misc: Separate stats file is generated for SystemC-gem5 co-simulation

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3132/#review7369 --- Format this patch again. Read the following page:

[gem5-dev] Review Request 3153: mem: Order packet queue only on matching addresses

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3153/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3152: mem: Enforce packet order on the cache response path

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3152/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3151: mem: Clarify cache MSHR handling on fill

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3151/#review7361 --- src/mem/cache/cache.cc (line 1268)

Re: [gem5-dev] Review Request 3152: mem: Enforce packet order on the cache response path

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3152/#review7362 --- I am not really aware of the protocol used by the classic side. But

Re: [gem5-dev] Review Request 3153: mem: Order packet queue only on matching addresses

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3153/#review7364 --- src/mem/packet_queue.cc (lines 138 - 172)

Re: [gem5-dev] Review Request 3151: mem: Clarify cache MSHR handling on fill

> On Oct. 13, 2015, 3:58 p.m., Nilay Vaish wrote: > > src/mem/cache/cache.cc, line 1272 > > > > > > Why do you need to call it again? You already called it once above. > > Andreas Hansson wrote: > It is called on a

Re: [gem5-dev] Review Request 3151: mem: Clarify cache MSHR handling on fill

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3151/ --- (Updated Oct. 13, 2015, 4:49 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3151: mem: Clarify cache MSHR handling on fill

> On Oct. 13, 2015, 3:58 p.m., Nilay Vaish wrote: > > src/mem/cache/cache.cc, line 1272 > > > > > > Why do you need to call it again? You already called it once above. It is called on a different packet here. > On Oct.

Re: [gem5-dev] Review Request 3151: mem: Clarify cache MSHR handling on fill

> On Oct. 13, 2015, 3:58 p.m., Nilay Vaish wrote: > > src/mem/cache/cache.cc, line 1272 > > > > > > Why do you need to call it again? You already called it once above. > > Andreas Hansson wrote: > It is called on a

Re: [gem5-dev] Review Request 3153: mem: Order packet queue only on matching addresses

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3153/ --- (Updated Oct. 13, 2015, 11:18 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3153: mem: Order packet queue only on matching addresses

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3153/#review7367 --- Ship it! src/mem/packet_queue.cc (lines 138 - 141)

Re: [gem5-dev] Review Request 3153: mem: Order packet queue only on matching addresses

> On Oct. 13, 2015, 11:44 p.m., Nilay Vaish wrote: > > src/mem/packet_queue.cc, lines 159-162 > > > > > > These lines can be dropped. I'll leave the decision to you. It's the common case, so I'd say let's keep it. -