Re: [gem5-dev] Review Request 3683: config: Break out base options for usage with NULL ISA

2016-10-20 Thread Jieming Yin
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3683/#review8958 --- Thanks for breaking out the configs. Seems only garnet_synth_traffic.py

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-20 Thread Alec Roelke
> On Oct. 20, 2016, 2:35 p.m., Jason Lowe-Power wrote: > > Sorry for the slow reviewing. I have a few minor changes. > > > > First, when I apply the patch, I get a number of errors from the style > > checker. Make sure you're using the most up-to-date version of gem5 when > > you rebase your

Re: [gem5-dev] Review Request 3674: syscall_emul: [patch 8/22] refactor process class

2016-10-20 Thread Brandon Potter
> On Oct. 19, 2016, 6:23 p.m., Steve Reinhardt wrote: > > src/sim/aux_vector.cc, line 42 > > > > > > why do we need to include process.hh here? "process.hh" is included because it defines the namespace that it needs for

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-20 Thread Steve Reinhardt
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3624/#review8952 --- Looks good overall! Just a few minor nits, really.

Re: [gem5-dev] Review Request 3646: gpu-compute, hsail: call discardFetch() from the WF

2016-10-20 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3646/#review8955 --- Ship it! Ship It! - Alexandru Dutu On Oct. 7, 2016, 8:53 p.m., Tony

Re: [gem5-dev] Review Request 3652: gpu-compute: use the GPUISA object to advance the PC

2016-10-20 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3652/#review8954 --- Ship it! src/gpu-compute/fetch_unit.cc (line 282)

Re: [gem5-dev] Review Request 3655: gpu-compute, hsail: make the PC a byte address, not an instruction index

2016-10-20 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3655/#review8953 --- Ship it! Looks good to me. - Alexandru Dutu On Oct. 10, 2016, 6:34

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

2016-10-20 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3671/#review8951 --- Ship it! Ship It! - Michael LeBeane On Oct. 19, 2016, 7:27 p.m.,

Re: [gem5-dev] Review Request 3658: gpu-compute: support in-order data delivery in GM pipe

2016-10-20 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3658/#review8950 --- Ship it! Neat refactoring! Other than the python arg name, this looks

Re: [gem5-dev] Review Request 3679: style: [patch 12/22] fix preliminary style issues for subsequent fault patch

2016-10-20 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3679/#review8949 --- Ship it! Ship It! - Alexandru Dutu On Oct. 17, 2016, 4:11 p.m.,

Re: [gem5-dev] Review Request 3671: syscall_emul: [patch 5/22] remove LiveProcess class and use Process instead

2016-10-20 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3671/#review8948 --- Ship it! Ship It! - Alexandru Dutu On Oct. 19, 2016, 7:27 p.m.,

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

2016-10-20 Thread Anastasiia Butko
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/#review8947 --- Ship it! Ship It! - Anastasiia Butko On Oct. 20, 2016, 4:39 p.m.,

Re: [gem5-dev] Review Request 3675: syscall_emul: [patch 9/22] remove unused global variable (num_processes)

2016-10-20 Thread Alexandru Dutu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3675/#review8946 --- Ship it! Ship It! - Alexandru Dutu On Oct. 17, 2016, 3:25 p.m.,

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

2016-10-20 Thread Anastasiia Butko
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/ --- (Updated Oct. 20, 2016, 4:39 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] AArch64 patch: making guarded insts microcoded

2016-10-20 Thread Fernando Endo
Hi Giacomo, Thanks for your suggestion. Regarding a different decoder flavour, I could not find the commit d3d15974, is it in the gem5 repo? Regards, -- Fernando A. Endo, Post-doc INRIA Rennes-Bretagne Atlantique France 2016-10-14 17:02 GMT+02:00 Giacomo Gabrielli

Re: [gem5-dev] Review Request 3624: arch: [Patch 1/5] Added RISC-V base instruction set RV64I

2016-10-20 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3624/#review8945 --- Sorry for the slow reviewing. I have a few minor changes. First, when I

Re: [gem5-dev] Review Request 3683: config: Break out base options for usage with NULL ISA

2016-10-20 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3683/#review8944 --- Ship it! This is fine with me. However, I think this is just bandaging

Re: [gem5-dev] Review Request 3666: arm, config: added support for ex5 model of big.LITTLE

2016-10-20 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3666/#review8943 --- Ship it! IMO, we don't need the results in the commit message. Unless

Re: [gem5-dev] Review Request 3527: misc: prepare the TLM sources for the addition of a TLM->Gem5 Master Port

2016-10-20 Thread Matthias Jung
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3527/#review8942 --- Ship it! Ship It! - Matthias Jung On Juli 13, 2016, 12:55 nachm.,

[gem5-dev] Review Request 3683: config: Break out base options for usage with NULL ISA

2016-10-20 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3683/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2016-10-20 Thread Cron Daemon
* build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/o3-timing: passed.* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-timing: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing: passed. *