[gem5-dev] Review Request 3708: commit 752c67b134f4cb0b7ca68a907c39a5a482de30b3

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3708/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3688/#review9096 --- Ship it! Ship It! - Tony Gutierrez On Oct. 27, 2016, 12:45 a.m.,

Re: [gem5-dev] Review Request 3705: dev: Fix buffer length when unserializing an eth pkt

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3705/#review9095 --- do we need a checkpoint updater, or does the call to paramIn return 0 if

Re: [gem5-dev] Review Request 3688: alpha: Remove ALPHA tru64 support and associated tests

> On Nov. 14, 2016, 5:41 p.m., Brandon Potter wrote: > > src/arch/alpha/kernel_stats.cc, line 185 > > > > > > I think that all that the stats do is record mode switches between user > > and kernel space. There's a small

Re: [gem5-dev] Review Request 3705: dev: Fix buffer length when unserializing an eth pkt

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3705/#review9093 --- Ship it! Ship It! - Brandon Potter On Nov. 15, 2016, 9:22 p.m.,

Re: [gem5-dev] Review Request 3707: syscall_emul: return -errno on a failed close call

> On Nov. 16, 2016, 6:19 p.m., Jason Lowe-Power wrote: > > BTW, how are you finding all these bugs? Do you have some test suite you're > > running which exercises all of these syscalls? No, I don't have a test suite for it. It's not really a bug in that it wouldn't do the "right" thing

Re: [gem5-dev] Review Request 3705: dev: Fix buffer length when unserializing an eth pkt

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3705/#review9091 --- Ship it! Ship It! - Tony Gutierrez On Nov. 15, 2016, 1:22 p.m.,

Re: [gem5-dev] Review Request 3707: syscall_emul: return -errno on a failed close call

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3707/#review9090 --- Ship it! BTW, how are you finding all these bugs? Do you have some test

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3676/ --- (Updated Nov. 16, 2016, 5:59 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

> On Oct. 19, 2016, 7:29 p.m., Steve Reinhardt wrote: > > src/sim/fd_array.hh, line 74 > > > > > > Why doesn't a process that shares the same file descriptors just share > > the whole FDArray object? This internal shared

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

> On Oct. 19, 2016, 7:29 p.m., Steve Reinhardt wrote: > > src/sim/fd_array.hh, line 140 > > > > > > Can't these be static variables and not per-instance? I don't see where > > they're modified after they're constructed. I

Re: [gem5-dev] Review Request 3702: syscall_emul: [PATCH 21/22] rewrite code related to system call exits

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3702/ --- (Updated Nov. 16, 2016, 4:44 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3700: syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode

> On Nov. 14, 2016, 7:29 p.m., Michael LeBeane wrote: > > src/sim/se_signal.hh, line 39 > > > > > > LiveProcess is gone now, right? I'd originally fixed this in http://reviews.gem5.org/r/3702/. I moved the changes into

Re: [gem5-dev] Review Request 3706: style: local variable name correction

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3706/#review9085 --- Ship it! Ship It! - Tony Gutierrez On Nov. 16, 2016, 8:24 a.m.,

Re: [gem5-dev] Review Request 3707: syscall_emul: return -errno on a failed close call

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3707/#review9084 --- Ship it! Ship It! - Tony Gutierrez On Nov. 16, 2016, 8:25 a.m.,

Re: [gem5-dev] Review Request 3700: syscall_emul: [PATCH 19/22] adds basic signaling mechanism to SE mode

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3700/ --- (Updated Nov. 16, 2016, 4:36 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3699: syscall_emul: [PATCH 18/22] refactor and add functionality for dup, dup2, and pipe

> On Nov. 14, 2016, 7:36 p.m., Michael LeBeane wrote: > > src/sim/syscall_emul.cc, line 236 > > > > > > These style changes seem out-of-scope. Separated into patch: http://reviews.gem5.org/r/3706/. > On Nov. 14, 2016,

[gem5-dev] Review Request 3707: syscall_emul: return -errno on a failed close call

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3707/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3706: style: local variable name correction

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3706/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

* build/HSAIL_X86/tests/opt/quick/se/04.gpu/x86/linux/gpu-ruby-GPU_RfO: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/tru64/minor-timing: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: passed. *