[gem5-dev] changeset in gem5: gpu-compute: init valid field of GpuTlbEntry ...

2016-11-21 Thread Tony Gutierrez
changeset 499071baed7b in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=499071baed7b description: gpu-compute: init valid field of GpuTlbEntry in default ctor valid field for GpuTlbEntry is not set in the default ctor, which can lead to strange

Re: [gem5-dev] Review Request 3741: ruby: add default ctor for MachineID type

2016-11-21 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3741/#review9147 --- Ship it! Ship It! - Joe Gross On Nov. 21, 2016, 1:24 p.m., Tony

Re: [gem5-dev] Review Request 3742: ruby: Fix overflow reported by ASAN in MessageBuffer.

2016-11-21 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3742/#review9146 --- Ship it! Ship It! - Joe Gross On Nov. 21, 2016, 4:32 p.m., Matthew

Re: [gem5-dev] Review Request 3742: ruby: Fix overflow reported by ASAN in MessageBuffer.

2016-11-21 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3742/#review9145 --- Ship it! Ship It! - Jason Lowe-Power On Nov. 21, 2016, 10:32 p.m.,

Re: [gem5-dev] Review Request 3742: ruby: Fix overflow reported by ASAN in MessageBuffer.

2016-11-21 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3742/#review9144 --- Ship it! Ship It! - Tony Gutierrez On Nov. 21, 2016, 2:32 p.m.,

Re: [gem5-dev] Review Request 3742: ruby: Fix overflow reported by ASAN in MessageBuffer.

2016-11-21 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3742/#review9143 --- Ship it! Ship It! - Brad Beckmann On Nov. 21, 2016, 10:32 p.m.,

[gem5-dev] Review Request 3742: ruby: Fix overflow reported by ASAN in MessageBuffer.

2016-11-21 Thread Matthew Poremba
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3742/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3739: gpu-compute: init valid field of GpuTlbEntry in default ctor

2016-11-21 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3739/#review9142 --- Ship it! This fixed a ubsan error I was seeing. - Joe Gross On Nov.

Re: [gem5-dev] Review Request 3721: x86: fix issue with casting in Cvtf2i

2016-11-21 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3721/#review9141 --- Ship it! This fixes some errors I was seeing when running with

Re: [gem5-dev] Review Request 3721: x86: fix issue with casting in Cvtf2i

2016-11-21 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3721/#review9139 --- Thoughts? I would like to ship this today. - Tony Gutierrez On Nov.

Re: [gem5-dev] Review Request 3692: gpu-compute: fix segfault when constructing GPUExecContext

2016-11-21 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3692/#review9138 --- Any other thoughts? Plan on shipping this today. - Tony Gutierrez On

[gem5-dev] Review Request 3741: ruby: add default ctor for MachineID type

2016-11-21 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3741/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3676: syscall_emul: [patch 10/22] refactor fdentry and add fdarray class

2016-11-21 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3676/#review9137 --- src/sim/process.cc (line 228)

Re: [gem5-dev] Review Request 3720: syscall_emul: implement fallocate

2016-11-21 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3720/ --- (Updated Nov. 21, 2016, 7:20 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3718: syscall_emul: extend sysinfo system call to include mem_unit

2016-11-21 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3718/#review9136 --- Ship it! Ship It! - Jason Lowe-Power On Nov. 17, 2016, 8:27 p.m.,

Re: [gem5-dev] Review Request 3718: syscall_emul: extend sysinfo system call to include mem_unit

2016-11-21 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3718/#review9135 --- Ship it! src/sim/syscall_emul.hh (line 780)

Re: [gem5-dev] Review Request 3719: syscall_emul: add support for x86 statfs system calls

2016-11-21 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3719/#review9134 --- Ship it! Ship It! - Michael LeBeane On Nov. 17, 2016, 8:26 p.m.,

[gem5-dev] Review Request 3740: commit 8606171b2c2e65d0b9931ccb4bd2ebc533c55d60

2016-11-21 Thread Rahul Thakur
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3740/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 3720: syscall_emul: implement fallocate

2016-11-21 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3720/#review9133 --- Ship it! src/sim/syscall_emul.cc (line 956)

Re: [gem5-dev] Review Request 3705: dev: Fix buffer length when unserializing an eth pkt

2016-11-21 Thread Michael LeBeane
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3705/ --- (Updated Nov. 21, 2016, 6:57 p.m.) Review request for Default. Changes ---

Re: [gem5-dev] Review Request 3717: hsail: disable asserts to allow immediate operands i.e. 0 with loads

2016-11-21 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3717/ --- (Updated Nov. 21, 2016, 6:52 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3738: Ruby: Initialize MessageSizeType of SequencerMsg to Request_Control

2016-11-21 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3738/#review9132 --- As this is a simple bug fix, I pushed it out right away. You can close

Re: [gem5-dev] Review Request 3739: gpu-compute: init valid field of GpuTlbEntry in default ctor

2016-11-21 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3739/ --- (Updated Nov. 21, 2016, 10:46 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3727: cpu: disallow speculative update of the conditional branch predictor tables (o3)

2016-11-21 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3727/#review9130 --- Ship it! Seems reasonable to me, though I'm no branch predictor expert.

[gem5-dev] Review Request 3739: gpu-compute: init valid field of GpuTlbEntry in default ctor

2016-11-21 Thread Tony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3739/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] RISC-V Patches

2016-11-21 Thread stever
Can I pipe up and tell you I agree? I also think it’s better to get the basic support implemented and then expand it incrementally. Many thanks to Alec for all the effort, and also to Jason for the shepherding. Steve From: Jason Lowe-Power Sent: Monday, November 21, 2016 9:08 AM To: gem5

Re: [gem5-dev] Review Request 3714: hsail: add a wavesize case statement to register operand code

2016-11-21 Thread Brandon Potter
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3714/ --- (Updated Nov. 21, 2016, 6:34 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Patches of TAGE branch predictor

2016-11-21 Thread Arthur Perais
I suppose it was called by the InOrder CPU once upon a time. Now the Minor CPU uses the same branch prediction code as the o3 CPU, which may have led to the current inconsistencies in how branch predictors handle out-of-order mispredictions (or not :)). I've submitted a patch regarding this

Re: [gem5-dev] Review Request 3693: riscv: [Patch 7/5] Corrected LRSC semantics

2016-11-21 Thread Tony Gutierrez
> On Nov. 2, 2016, 12:38 p.m., Alec Roelke wrote: > > This doesn't work with the O3 CPU model; I wrote a simple program that > > performs a lr.w followed by sc.w that works with the atomic-simple, > > timing-simple, and minor CPU models, but with the O3 model I get this error: > > > >

Re: [gem5-dev] RISC-V Patches

2016-11-21 Thread Alec Roelke
Hi Jason, I had removed the tests from the regression patch that fail due to the error I pointed out in my initial message because I didn't think it was appropriate to include failing tests in a gem5 release, and had planned to add them when the bug was fixed. I'm pretty busy at the moment with

[gem5-dev] ReviewBoard full text search

2016-11-21 Thread Jason Lowe-Power
Hi all, Is there any reason we don't have full text search enabled on reviewboard? Did we accidentally overlook it, or does it strain our server too much? Something else? https://www.reviewboard.org/docs/manual/dev/users/searching/full-text-search/ I've been bitten many time by knowing

Re: [gem5-dev] RISC-V Patches

2016-11-21 Thread Jason Lowe-Power
Hi Alec, These are ready according to me. Unless someone has an objection, I'll push them on Friday (assuming I can get up after all the food on Thursday). Note: All of the tests are passing for me with minor changes in the instruction rates, etc. Thanks again for these patches. I think that

Re: [gem5-dev] Patches of TAGE branch predictor

2016-11-21 Thread Jason Lowe-Power
Hi Fernando, I don't know what he original use of predictInOrder was, but you're right, it doesn't look like it's in use now. You may be able to figure out what it was used for by inferring its function from the code. Jason On Sun, Nov 13, 2016 at 2:37 PM Jason Lowe-Power

Re: [gem5-dev] Status of RISC-V patches

2016-11-21 Thread Jason Lowe-Power
Hi Andreas, I don't think it's surprising, but I like this idea. I think it's much more maintainable going forward than what we've been doing. Does this have any bearing on the RISC-V patches? I was hoping we would be able to get Alec's stuff pushed in soon. I don't want to hold things up for

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

2016-11-21 Thread Cron Daemon
* build/HSAIL_X86/tests/opt/quick/se/04.gpu/x86/linux/gpu-ruby-GPU_RfO: CHANGED! * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing: passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic: passed. *