[gem5-dev] Change in gem5/gem5[develop]: arch-riscv: Fix disassembling of CSR instructions

2020-08-18 Thread Ian Jiang (Gerrit) via gem5-dev
Ian Jiang has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32814 ) Change subject: arch-riscv: Fix disassembling of CSR instructions .. arch-riscv: Fix disassembling of CSR instructions The

[gem5-dev] Change in gem5/gem5[develop]: arch: Create a base class for decoders.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32897 ) Change subject: arch: Create a base class for decoders. .. arch: Create a base class for decoders. This base

[gem5-dev] Change in gem5/gem5[develop]: arch,cpu,sim: Get rid of the microcode ROM stub code.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32899 ) Change subject: arch,cpu,sim: Get rid of the microcode ROM stub code. .. arch,cpu,sim: Get rid of the microcode

[gem5-dev] Change in gem5/gem5[develop]: cpu: Don't construct and then copy the decoder in SimpleThread.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32900 ) Change subject: cpu: Don't construct and then copy the decoder in SimpleThread. .. cpu: Don't construct and

[gem5-dev] Change in gem5/gem5[develop]: x86: Style fix in the decoder class.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32894 ) Change subject: x86: Style fix in the decoder class. .. x86: Style fix in the decoder class. Change-Id:

[gem5-dev] Change in gem5/gem5[develop]: x86: Use default initializers to simplify the decoder constructor.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32895 ) Change subject: x86: Use default initializers to simplify the decoder constructor. .. x86: Use default

[gem5-dev] Change in gem5/gem5[develop]: cpu,arch: Delegate fetching ROM microops to the decoder.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32898 ) Change subject: cpu,arch: Delegate fetching ROM microops to the decoder. .. cpu,arch: Delegate fetching ROM

[gem5-dev] Change in gem5/gem5[develop]: x86: Fix some style issues in the microcode ROM class.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32896 ) Change subject: x86: Fix some style issues in the microcode ROM class. .. x86: Fix some style issues in the

[gem5-dev] Change in gem5/gem5[develop]: base: Add a "callable" method to the Value stats class.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32901 ) Change subject: base: Add a "callable" method to the Value stats class. .. base: Add a "callable" method to the

[gem5-dev] Change in gem5/gem5[develop]: gpu-compute,mem-ruby: replace ACQUIRE and RELEASE request flags

2020-08-18 Thread Bradford Beckmann (Gerrit) via gem5-dev
Hello Tuan Ta, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/32859 to review the following change. Change subject: gpu-compute,mem-ruby: replace ACQUIRE and RELEASE request flags

[gem5-dev] Change in gem5/gem5[develop]: mem-ruby: remove gmTokenPort from GPUCoalescer

2020-08-18 Thread Bradford Beckmann (Gerrit) via gem5-dev
Bradford Beckmann has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32862 ) Change subject: mem-ruby: remove gmTokenPort from GPUCoalescer .. mem-ruby: remove gmTokenPort from

[gem5-dev] Change in gem5/gem5[develop]: mem-ruby: fix integration issues between GCN3 and VIPER

2020-08-18 Thread Bradford Beckmann (Gerrit) via gem5-dev
Hello Tuan Ta, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/32858 to review the following change. Change subject: mem-ruby: fix integration issues between GCN3 and VIPER

[gem5-dev] Change in gem5/gem5[develop]: configs, mem: Fixes for apu_se.py

2020-08-18 Thread Bradford Beckmann (Gerrit) via gem5-dev
Hello Tony Gutierrez, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/32856 to review the following change. Change subject: configs, mem: Fixes for apu_se.py ..

[gem5-dev] Change in gem5/gem5[develop]: config: fix python compatibility issue in viper_ruby_test

2020-08-18 Thread Bradford Beckmann (Gerrit) via gem5-dev
Hello Tuan Ta, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/32857 to review the following change. Change subject: config: fix python compatibility issue in viper_ruby_test

[gem5-dev] Change in gem5/gem5[develop]: configs,mem-ruby: Remove old GPU ptls

2020-08-18 Thread Bradford Beckmann (Gerrit) via gem5-dev
Hello Tony Gutierrez, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/32860 to review the following change. Change subject: configs,mem-ruby: Remove old GPU ptls ..

[gem5-dev] Change in gem5/gem5[develop]: mem-ruby: temp fixes for coalescer integration

2020-08-18 Thread Bradford Beckmann (Gerrit) via gem5-dev
Bradford Beckmann has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32861 ) Change subject: mem-ruby: temp fixes for coalescer integration .. mem-ruby: temp fixes for coalescer

[gem5-dev] Change in gem5/gem5[develop]: scons: Borrow distcc setup from amd-master

2020-08-18 Thread Bradford Beckmann (Gerrit) via gem5-dev
Hello Matthew Poremba, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/32854 to review the following change. Change subject: scons: Borrow distcc setup from amd-master

[gem5-dev] Change in gem5/gem5[develop]: configs,gpu-compute,mem-ruby: connect gmTokenPorts in apu_se

2020-08-18 Thread Kyle Roarty (Gerrit) via gem5-dev
Kyle Roarty has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32677 ) Change subject: configs,gpu-compute,mem-ruby: connect gmTokenPorts in apu_se .. configs,gpu-compute,mem-ruby: connect

[gem5-dev] Change in gem5/gem5[develop]: misc: Rename CallbackQueue2 to CallbackQueue.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32651 ) Change subject: misc: Rename CallbackQueue2 to CallbackQueue. .. misc: Rename CallbackQueue2 to CallbackQueue. Now that the

[gem5-dev] Change in gem5/gem5[develop]: base: Get rid the Callback type.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32650 ) Change subject: base: Get rid the Callback type. .. base: Get rid the Callback type. This leaves only the

[gem5-dev] Change in gem5/gem5[develop]: dev: Replace the Callback class with lambdas in ARM's flash devices.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32648 ) Change subject: dev: Replace the Callback class with lambdas in ARM's flash devices. .. dev: Replace the Callback class

[gem5-dev] Change in gem5/gem5[develop]: dev: Replace Callback in the virtio device with a lambda.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32649 ) Change subject: dev: Replace Callback in the virtio device with a lambda. .. dev: Replace Callback in the virtio device with

[gem5-dev] Change in gem5/gem5[develop]: gpu-compute: Create CU's ports in the standard way

2020-08-18 Thread Anthony Gutierrez (Gerrit) via gem5-dev
Hello Tony Gutierrez, I'd like you to do a code review. Please visit https://gem5-review.googlesource.com/c/public/gem5/+/32836 to review the following change. Change subject: gpu-compute: Create CU's ports in the standard way

[gem5-dev] Change in gem5/gem5[develop]: arch-riscv, arch-x86: convert tlb to new style stats

2020-08-18 Thread Emily Brickey (Gerrit) via gem5-dev
Emily Brickey has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32835 ) Change subject: arch-riscv, arch-x86: convert tlb to new style stats .. arch-riscv, arch-x86: convert tlb to

[gem5-dev] Change in gem5/gem5[develop]: dev: Use lambdas instead of the Callback type for serial devices.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32647 ) Change subject: dev: Use lambdas instead of the Callback type for serial devices. .. dev: Use lambdas instead of the

[gem5-dev] Change in gem5/gem5[develop]: misc: Make the stats callbacks use CallbackQueue2.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32645 ) Change subject: misc: Make the stats callbacks use CallbackQueue2. .. misc: Make the stats callbacks use CallbackQueue2.

[gem5-dev] Change in gem5/gem5[develop]: sim: Delete the unused PowerStateDumpCallback.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32646 ) Change subject: sim: Delete the unused PowerStateDumpCallback. .. sim: Delete the unused PowerStateDumpCallback. Issue-on:

[gem5-dev] Change in gem5/gem5[develop]: configs: Add import for FileSystemConfig in GPU_VIPER.py

2020-08-18 Thread Matt Sinclair (Gerrit) via gem5-dev
Matt Sinclair has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32675 ) Change subject: configs: Add import for FileSystemConfig in GPU_VIPER.py .. configs: Add import for FileSystemConfig in

[gem5-dev] Change in gem5/gem5[develop]: configs: Replace DirMem w/RubyDirectoryMemory, set addr_ranges

2020-08-18 Thread Anthony Gutierrez (Gerrit) via gem5-dev
Anthony Gutierrez has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32674 ) Change subject: configs: Replace DirMem w/RubyDirectoryMemory, set addr_ranges .. configs: Replace DirMem

[gem5-dev] Change in gem5/gem5[develop]: arch-mips, arch-power: removed unused stats

2020-08-18 Thread Emily Brickey (Gerrit) via gem5-dev
Emily Brickey has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32834 ) Change subject: arch-mips, arch-power: removed unused stats .. arch-mips, arch-power: removed unused stats

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: convert tlb to new style stats

2020-08-18 Thread Emily Brickey (Gerrit) via gem5-dev
Emily Brickey has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32794 ) Change subject: arch-arm: convert tlb to new style stats .. arch-arm: convert tlb to new style stats Change-Id:

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: Rename SelfDebug member variables

2020-08-18 Thread Giacomo Travaglini (Gerrit) via gem5-dev
Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32775 ) Change subject: arch-arm: Rename SelfDebug member variables .. arch-arm: Rename SelfDebug member variables *

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: Remove setters from SoftwareStep

2020-08-18 Thread Giacomo Travaglini (Gerrit) via gem5-dev
Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32774 ) Change subject: arch-arm: Remove setters from SoftwareStep .. arch-arm: Remove setters from SoftwareStep

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: Early checking if debug is enabled in TLB

2020-08-18 Thread Giacomo Travaglini (Gerrit) via gem5-dev
Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32776 ) Change subject: arch-arm: Early checking if debug is enabled in TLB .. arch-arm: Early checking if debug is enabled

[gem5-dev] Change in gem5/gem5[develop]: misc: Make registerExitCallback use CallbackQueue2.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32644 ) Change subject: misc: Make registerExitCallback use CallbackQueue2. .. misc: Make registerExitCallback use CallbackQueue2.

[gem5-dev] Change in gem5/gem5[develop]: mem: Use the new type of CallbackQueue in the MemBackdoor.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32643 ) Change subject: mem: Use the new type of CallbackQueue in the MemBackdoor. .. mem: Use the new type of CallbackQueue in the

[gem5-dev] Change in gem5/gem5[develop]: base: Add a new type of CallbackQueue.

2020-08-18 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/32642 ) Change subject: base: Add a new type of CallbackQueue. .. base: Add a new type of CallbackQueue. This type is templated on

[gem5-dev] Decoder cache hit rate

2020-08-18 Thread Gabe Black via gem5-dev
Hi folks. I thought I'd do a quick measurement of the effectiveness of the various caches which cache StaticInsts from the decoder using X86. For SE mode, I did a very simple run of hello world. For such a short program, the hit rate was pretty low and I don't think representative. To get

[gem5-dev] Change in gem5/gem5[develop]: arch-riscv: Fix disassembling of CSR instructions

2020-08-18 Thread Ian Jiang (Gerrit) via gem5-dev
Ian Jiang has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/32814 ) Change subject: arch-riscv: Fix disassembling of CSR instructions .. arch-riscv: Fix disassembling of CSR