Re: [gem5-dev] Review Request 3800: x86: fix Mul1u instruction

2017-05-15 Thread Joe Gross
> On Feb. 4, 2017, 10:21 a.m., Jason Lowe-Power wrote: > > Lol, that code is hard to understand. But, LGTM. > > > > What are you using to test this? Any chance you can commit the test so we > > don't accidentally break this again in the future? > > Tony Gutierrez wrote: > This bug was

Re: [gem5-dev] Review Request 3779: proto: Fix warnings for protoc v3

2017-01-19 Thread Joe Gross
machine. - Joe Gross On Jan. 10, 2017, 5:01 a.m., Nikos Nikoleris wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3778: Fix order of object construction in the CxxConfigManager

2017-01-18 Thread Joe Gross
just fine. - Joe Gross On Jan. 9, 2017, 7:53 a.m., Christian Menard wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3769: python: Don't use Swig to cast stats

2016-12-21 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3769/#review9224 --- Ship it! Ship It! - Joe Gross On Dec. 20, 2016, 2:08 a.m., Andreas

Re: [gem5-dev] Review Request 3768: sim: Remove redundant export_method_cxx_predecls

2016-12-21 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3768/#review9223 --- Ship it! Ship It! - Joe Gross On Dec. 20, 2016, 2:07 a.m., Andreas

[gem5-dev] Review Request 3745: scons: fix how flags are passed to the compiler when more than one sanitizer at a time is enabled

2016-11-23 Thread Joe Gross
- src/SConscript 9e5050028323260c6d2211d7158ac4a4145ed8bc Diff: http://reviews.gem5.org/r/3745/diff/ Testing --- local build Thanks, Joe Gross ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3741: ruby: add default ctor for MachineID type

2016-11-21 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3741/#review9147 --- Ship it! Ship It! - Joe Gross On Nov. 21, 2016, 1:24 p.m., Tony

Re: [gem5-dev] Review Request 3742: ruby: Fix overflow reported by ASAN in MessageBuffer.

2016-11-21 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3742/#review9146 --- Ship it! Ship It! - Joe Gross On Nov. 21, 2016, 4:32 p.m., Matthew

Re: [gem5-dev] Review Request 3739: gpu-compute: init valid field of GpuTlbEntry in default ctor

2016-11-21 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3739/#review9142 --- Ship it! This fixed a ubsan error I was seeing. - Joe Gross On Nov

Re: [gem5-dev] Review Request 3721: x86: fix issue with casting in Cvtf2i

2016-11-21 Thread Joe Gross
with sanitizers. - Joe Gross On Nov. 17, 2016, 2:54 p.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3709: ruby: Fix potential bugs in garnet2.0

2016-11-17 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3709/#review9114 --- Ship it! Ship It! - Joe Gross On Nov. 17, 2016, 12:39 a.m., Jieming

[gem5-dev] Review Request 3657: configs: add an option to set the deadlock timeouts for the TCPs and SQCs

2016-11-11 Thread Joe Gross
/ruby/GPU_VIPER.py b29aca3fcb75f5ad92429001ab11c65b2f9635b0 configs/ruby/GPU_VIPER_Baseline.py b29aca3fcb75f5ad92429001ab11c65b2f9635b0 configs/ruby/GPU_VIPER_Region.py b29aca3fcb75f5ad92429001ab11c65b2f9635b0 Diff: http://reviews.gem5.org/r/3657/diff/ Testing --- Thanks, Joe Gross

Re: [gem5-dev] Review Request 3692: gpu-compute: fix segfault when constructing GPUExecContext

2016-11-11 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3692/#review9044 --- Ship it! This fixed some problems I've seen when running. - Joe Gross

Re: [gem5-dev] Review Request 3446: hsail, gpu-compute: fixes to appease clang++

2016-10-24 Thread Joe Gross
. - Joe Gross On April 13, 2016, 10:09 a.m., Tony Gutierrez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3604: base: Output all AddrRange parameters to config.ini

2016-10-14 Thread Joe Gross
> On Aug. 17, 2016, 5:35 a.m., Andreas Hansson wrote: > > No objections. We have been thinking of making this simpler, by creating a > > notion of PortGroups, and let the group be responsible for any > > hash/interleaving. Until we actually get to the point of implementing this > > I agree

Re: [gem5-dev] Review Request 3659: stats: Add more information to uninitialized error

2016-10-13 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3659/#review8841 --- Ship it! Ship It! - Joe Gross On Oct. 11, 2016, 9:45 a.m., Jason

Re: [gem5-dev] Review Request 3664: ruby: make a RequestDesc class instead of std::pair

2016-10-13 Thread Joe Gross
code. src/mem/ruby/system/GPUCoalescer.hh (line 298) <http://reviews.gem5.org/r/3664/#comment7617> good idea, this seems like very convoluted code - Joe Gross On Oct. 13, 2016, 4:24 p.m., Tony Gutierrez

[gem5-dev] Review Request 3656: dram: add DDR3-1866/2400

2016-10-10 Thread Joe Gross
b29aca3fcb75f5ad92429001ab11c65b2f9635b0 Diff: http://reviews.gem5.org/r/3656/diff/ Testing --- Thanks, Joe Gross ___ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev

Re: [gem5-dev] Review Request 3600: mem: Modify drain to ensure banks and power are idled

2016-09-01 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3600/#review8702 --- Ship it! Ship It! - Joe Gross On Aug. 11, 2016, 4:08 a.m., Curtis

Re: [gem5-dev] Review Request 3599: mem: Sort memory commands and update DRAMPower

2016-09-01 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3599/#review8701 --- Ship it! Ship It! - Joe Gross On Aug. 11, 2016, 4:07 a.m., Curtis

Re: [gem5-dev] Review Request 3596: mem: make DDR4 x16

2016-08-24 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3596/#review8677 --- Ship it! Ship It! - Joe Gross On Aug. 11, 2016, 4:07 a.m., Curtis

Re: [gem5-dev] Review Request 3597: mem: add DRAM powerdown timing

2016-08-24 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3597/#review8676 --- Ship it! Ship It! - Joe Gross On Aug. 11, 2016, 4:07 a.m., Curtis

Re: [gem5-dev] Review Request 3498: tests: Split test results into running and verification

2016-06-15 Thread Joe Gross
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3498/#review8412 --- Ship it! Ship It! - Joe Gross On June 6, 2016, 11:50 a.m., Andreas

Re: [gem5-dev] Review Request 3500: tests: Add a test command to get test status as an exit code

2016-06-15 Thread Joe Gross
results. - Joe Gross On June 6, 2016, 11:50 a.m., Andreas Sandberg wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem

Re: [gem5-dev] Review Request 3273: [mq]: jkalamat/wfSizeParam.patch

2016-02-16 Thread Joe Gross
modifications to my own branch using the same API calls and it all works just fine. - Joe Gross On Feb. 16, 2016, 9:56 a.m., John Kalamatianos wrote: > > --- > This is an automatically generated e-mail. To reply, visi

[gem5-dev] changeset in gem5: sim: support for distcc pump server settings

2015-11-15 Thread Joe Gross
changeset 47e2adf7fb1a in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=47e2adf7fb1a description: sim: support for distcc pump server settings diffstat: SConstruct | 9 + 1 files changed, 5 insertions(+), 4 deletions(-) diffs (19 lines): diff -r

[gem5-dev] changeset in gem5: ruby: add BoolVec

2015-11-14 Thread Joe Gross
changeset fa3e56b6e0b6 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=fa3e56b6e0b6 description: ruby: add BoolVec The BoolVec typedef and insertion operator overload function simplify usage of vectors of type bool diffstat: