Re: [gem5-dev] Review Request 2779: ruby: re-added the addressToInt slicc interface function

2015-05-20 Thread Jason Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2779/#review6369 --- Ship it! Assuming you add the assert in the comment above, it looks

Re: [gem5-dev] Review Request 2779: ruby: re-added the addressToInt slicc interface function

2015-05-18 Thread Brad Beckmann
On May 12, 2015, 3:48 a.m., Nilay Vaish wrote: This patch is incorrect on a couple of counts. We are not in 32-bit world. Secondly, you should expose the getAddress() function as we expose functions related to other classes. Brad Beckmann wrote: This comment is dissappointing

Re: [gem5-dev] Review Request 2779: ruby: re-added the addressToInt slicc interface function

2015-05-18 Thread Nilay Vaish
On Mon, 18 May 2015, Brad Beckmann wrote: On May 12, 2015, 3:48 a.m., Nilay Vaish wrote: This patch is incorrect on a couple of counts. We are not in 32-bit world. Secondly, you should expose the getAddress() function as we expose functions related to other classes. Brad Beckmann

Re: [gem5-dev] Review Request 2779: ruby: re-added the addressToInt slicc interface function

2015-05-13 Thread Brad Beckmann
On May 12, 2015, 3:48 a.m., Nilay Vaish wrote: This patch is incorrect on a couple of counts. We are not in 32-bit world. Secondly, you should expose the getAddress() function as we expose functions related to other classes. This comment is dissappointing and unprofessional. I'm

[gem5-dev] Review Request 2779: ruby: re-added the addressToInt slicc interface function

2015-05-11 Thread Anthony Gutierrez
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2779/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 2779: ruby: re-added the addressToInt slicc interface function

2015-05-11 Thread Nilay Vaish
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2779/#review6132 --- This patch is incorrect on a couple of counts. We are not in 32-bit