Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Jan. 6, 2016, 1:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Jan. 6, 2016, 9:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Jan. 6, 2016, 9:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Jan. 6, 2016, 1:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Jan. 6, 2016, 1:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Jan. 6, 2016, 9:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Jan. 6, 2016, 9:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Jan. 6, 2016, 1:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Jan. 6, 2016, 9:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Nov. 12, 2015, 2:17 p.m., Tony Gutierrez wrote: > > src/base/types.hh, line 203 > > > > > > Joel's comment from 3185: > > > > I'm a little confused about the need for this. Is it not possible to > > just set

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Jan. 6, 2016, 9:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Jan. 6, 2016, 1:39 p.m., Andreas Hansson wrote: > > I still find that the design needs a far better explanation, and at least > > one simple example. I would suggest implementing the SwapReq as an atomic > > op (as I guess it is our only example). Also, surely we need to impose > >

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3205/ --- (Updated Jan. 6, 2016, 12:28 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3205/#review7813 --- I still find that the design needs a far better explanation, and at

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3205/ --- (Updated Jan. 6, 2016, 1:12 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Dec. 27, 2015, 2:33 a.m., Andreas Hansson wrote: > > I think I addressed all of the issues, and I would like to ship this in the next day or two. Thanks. - Tony --- This is an automatically generated e-mail. To reply, visit:

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Dec. 27, 2015, 2:33 a.m., Andreas Hansson wrote: > > src/mem/request.hh, line 434 > > > > > > We really need to use delegating constructors for these kinds of > > things. This is just silly :-) Agreed, but that is an

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Dec. 24, 2015, 9:18 a.m., Andreas Hansson wrote: > > This is a major change to the memory system, and I find the description > > rather misleading. It would be good to get some more examples, and make > > sure that this works as a general solution for "in-memory-system > > operations".

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Nov. 12, 2015, 10:17 p.m., Tony Gutierrez wrote: > > src/base/types.hh, line 203 > > > > > > Joel's comment from 3185: > > > > I'm a little confused about the need for this. Is it not possible to > > just set

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3205/#review7767 --- src/base/types.hh (line 203)

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Dec. 24, 2015, 1:18 a.m., Andreas Hansson wrote: > > This is a major change to the memory system, and I find the description > > rather misleading. It would be good to get some more examples, and make > > sure that this works as a general solution for "in-memory-system > > operations".

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3205/#review7750 --- This is a major change to the memory system, and I find the description

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Dec. 24, 2015, 1:18 a.m., Andreas Hansson wrote: > > src/mem/request.hh, line 718 > > > > > > Why? That seems very odd You're right, that may be dropped. - Tony

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

> On Nov. 12, 2015, 2:17 p.m., Tony Gutierrez wrote: > > src/base/types.hh, line 203 > > > > > > Joel's comment from 3185: > > > > I'm a little confused about the need for this. Is it not possible to > > just set

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3205/ --- (Updated Dec. 23, 2015, 10:34 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3205/#review7737 --- Any more comments on this? We're planning on shipping in by the end of

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3205/ --- (Updated Dec. 23, 2015, 10:28 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3205/#review7563 --- src/base/types.hh (line 203)

[gem5-dev] Review Request 3205: mem: support for gpu-style RMWs in ruby

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3205/ --- Review request for Default. Repository: gem5 Description --- Changeset