Re: [gem5-dev] Review Request 3337: gpu-compute: fix uninitialized value error.

2016-02-26 Thread Andreas Hansson
> On Feb. 23, 2016, 8:23 a.m., Andreas Hansson wrote: > > It would be good if someone could run this with ubsan and asan. > > > > Also, if we all agree that 'gpu-compute' is indeed the most sensible > > keyword we should add it to the list. Something shorted and snappier would > > be nice,

Re: [gem5-dev] Review Request 3337: gpu-compute: fix uninitialized value error.

2016-02-25 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3337/#review8040 --- Ship it! Thanks! That looks better now :) - Jason Lowe-Power On Feb.

Re: [gem5-dev] Review Request 3337: gpu-compute: fix uninitialized value error.

2016-02-25 Thread Marc Orr
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3337/ --- (Updated Feb. 25, 2016, 9:26 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3337: gpu-compute: fix uninitialized value error.

2016-02-25 Thread Marc Orr
> On Feb. 23, 2016, 8:23 a.m., Andreas Hansson wrote: > > It would be good if someone could run this with ubsan and asan. > > > > Also, if we all agree that 'gpu-compute' is indeed the most sensible > > keyword we should add it to the list. Something shorted and snappier would > > be nice,

Re: [gem5-dev] Review Request 3337: gpu-compute: fix uninitialized value error.

2016-02-25 Thread Marc Orr
> On Feb. 23, 2016, 2:54 p.m., Jason Lowe-Power wrote: > > src/arch/hsail/insts/mem_impl.hh, line 245 > > > > > > if (mask[lane] && m->addr[lane] < w->privSizePerItem)? > > > > Or am I missing something here?

Re: [gem5-dev] Review Request 3337: gpu-compute: fix uninitialized value error.

2016-02-23 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3337/#review8023 --- src/arch/hsail/insts/mem_impl.hh (line 244)

Re: [gem5-dev] Review Request 3337: gpu-compute: fix uninitialized value error.

2016-02-23 Thread Andreas Hansson
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3337/#review8022 --- It would be good if someone could run this with ubsan and asan. Also,

Re: [gem5-dev] Review Request 3337: gpu-compute: fix uninitialized value error.

2016-02-22 Thread Brad Beckmann
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3337/#review8021 --- Ship it! Ship It! - Brad Beckmann On Feb. 23, 2016, 12:39 a.m., Marc

[gem5-dev] Review Request 3337: gpu-compute: fix uninitialized value error.

2016-02-22 Thread Marc Orr
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3337/ --- Review request for Default. Repository: gem5 Description --- Changeset