Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-20 Thread Radhika Jagtap
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3502/#review8425 --- src/mem/cache/tags/base.cc (line 59)

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-20 Thread Radhika Jagtap
> On June 17, 2016, 7:57 a.m., Pierre-Yves Péneau wrote: > > I don't like the variable names, I think it's confusing especially in the > > Python part which is the user part. "lookup_latency" does not clearly > > refer to the tag lookup action , and "ram_latency" is also not very clear. > >

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-17 Thread Sophiane SENNI
> On juin 17, 2016, 7:57 matin, Pierre-Yves Péneau wrote: > > I don't like the variable names, I think it's confusing especially in the > > Python part which is the user part. "lookup_latency" does not clearly > > refer to the tag lookup action , and "ram_latency" is also not very clear. > >

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-17 Thread Pierre-Yves Péneau
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3502/#review8419 --- I don't like the variable names, I think it's confusing especially in

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-16 Thread Sophiane SENNI
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3502/ --- (Updated June 16, 2016, 6:55 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-16 Thread Sophiane SENNI
> On juin 16, 2016, 2:37 après-midi, Jason Lowe-Power wrote: > > Hi Sophiane, > > > > Thanks for the contribution. It looks like some of the patch doesn't apply > > cleanly in reviewboard. Did you use the hg postreview extension? It may > > also help to use the "-o" option on the extension. >

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-16 Thread Sophiane SENNI
> On juin 16, 2016, 2:37 après-midi, Jason Lowe-Power wrote: > > Hi Sophiane, > > > > Thanks for the contribution. It looks like some of the patch doesn't apply > > cleanly in reviewboard. Did you use the hg postreview extension? It may > > also help to use the "-o" option on the extension. >

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-16 Thread Jason Lowe-Power
> On June 16, 2016, 2:37 p.m., Jason Lowe-Power wrote: > > Hi Sophiane, > > > > Thanks for the contribution. It looks like some of the patch doesn't apply > > cleanly in reviewboard. Did you use the hg postreview extension? It may > > also help to use the "-o" option on the extension. > > >

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-16 Thread Sophiane SENNI
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3502/ --- (Updated juin 16, 2016, 3:27 après-midi) Review request for Default. Repository:

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-16 Thread Sophiane SENNI
> On juin 16, 2016, 2:37 après-midi, Jason Lowe-Power wrote: > > Hi Sophiane, > > > > Thanks for the contribution. It looks like some of the patch doesn't apply > > cleanly in reviewboard. Did you use the hg postreview extension? It may > > also help to use the "-o" option on the extension. >

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-16 Thread Sophiane SENNI
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3502/ --- (Updated June 16, 2016, 3:15 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-16 Thread Sophiane SENNI
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3502/ --- (Updated June 16, 2016, 3:14 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-16 Thread Jason Lowe-Power
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3502/#review8413 --- Hi Sophiane, Thanks for the contribution. It looks like some of the

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-16 Thread Sophiane SENNI
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3502/ --- (Updated juin 16, 2016, 1:37 après-midi) Review request for Default. Repository:

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-15 Thread Sophiane SENNI
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3502/ --- (Updated juin 15, 2016, 2:43 après-midi) Review request for Default. Repository:

Re: [gem5-dev] Review Request 3502: cache: Split the hit latency into tag lookup latency and RAM access latency

2016-06-15 Thread Sophiane SENNI
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3502/ --- (Updated June 15, 2016, 2:34 p.m.) Review request for Default. Summary (updated)