---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3502/#review8425
---
src/mem/cache/tags/base.cc (line 59)
> On June 17, 2016, 7:57 a.m., Pierre-Yves Péneau wrote:
> > I don't like the variable names, I think it's confusing especially in the
> > Python part which is the user part. "lookup_latency" does not clearly
> > refer to the tag lookup action , and "ram_latency" is also not very clear.
> >
> On juin 17, 2016, 7:57 matin, Pierre-Yves Péneau wrote:
> > I don't like the variable names, I think it's confusing especially in the
> > Python part which is the user part. "lookup_latency" does not clearly
> > refer to the tag lookup action , and "ram_latency" is also not very clear.
> >
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3502/#review8419
---
I don't like the variable names, I think it's confusing especially in
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3502/
---
(Updated June 16, 2016, 6:55 p.m.)
Review request for Default.
Repository: gem5
> On juin 16, 2016, 2:37 après-midi, Jason Lowe-Power wrote:
> > Hi Sophiane,
> >
> > Thanks for the contribution. It looks like some of the patch doesn't apply
> > cleanly in reviewboard. Did you use the hg postreview extension? It may
> > also help to use the "-o" option on the extension.
>
> On juin 16, 2016, 2:37 après-midi, Jason Lowe-Power wrote:
> > Hi Sophiane,
> >
> > Thanks for the contribution. It looks like some of the patch doesn't apply
> > cleanly in reviewboard. Did you use the hg postreview extension? It may
> > also help to use the "-o" option on the extension.
>
> On June 16, 2016, 2:37 p.m., Jason Lowe-Power wrote:
> > Hi Sophiane,
> >
> > Thanks for the contribution. It looks like some of the patch doesn't apply
> > cleanly in reviewboard. Did you use the hg postreview extension? It may
> > also help to use the "-o" option on the extension.
> >
>
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3502/
---
(Updated juin 16, 2016, 3:27 après-midi)
Review request for Default.
Repository:
> On juin 16, 2016, 2:37 après-midi, Jason Lowe-Power wrote:
> > Hi Sophiane,
> >
> > Thanks for the contribution. It looks like some of the patch doesn't apply
> > cleanly in reviewboard. Did you use the hg postreview extension? It may
> > also help to use the "-o" option on the extension.
>
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3502/
---
(Updated June 16, 2016, 3:15 p.m.)
Review request for Default.
Repository: gem5
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3502/
---
(Updated June 16, 2016, 3:14 p.m.)
Review request for Default.
Repository: gem5
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3502/#review8413
---
Hi Sophiane,
Thanks for the contribution. It looks like some of the
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3502/
---
(Updated juin 16, 2016, 1:37 après-midi)
Review request for Default.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3502/
---
(Updated juin 15, 2016, 2:43 après-midi)
Review request for Default.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/3502/
---
(Updated June 15, 2016, 2:34 p.m.)
Review request for Default.
Summary (updated)
16 matches
Mail list logo