Re: [gem5-dev] Review Request 2319: Mem: adding architectural page table support for SE mode

2014-08-28 Thread Andreas Sandberg via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2319/#review5313 --- Ship it! Ship It! - Andreas Sandberg On Aug. 25, 2014, 10:10 p.m.,

Re: [gem5-dev] Review Request 2319: Mem: adding architectural page table support for SE mode

2014-08-25 Thread Alexandru Dutu via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2319/ --- (Updated Aug. 25, 2014, 9:10 p.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 2319: Mem: adding architectural page table support for SE mode

2014-08-14 Thread Andreas Sandberg via gem5-dev
--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2319/#review5246 --- src/arch/x86/pagetable.hh http://reviews.gem5.org/r/2319/#comment4785

Re: [gem5-dev] Review Request 2319: Mem: adding architectural page table support for SE mode

2014-08-14 Thread Alexandru Dutu via gem5-dev
On Aug. 14, 2014, 9:22 a.m., Andreas Sandberg wrote: src/arch/x86/pagetable.hh, line 169 http://reviews.gem5.org/r/2319/diff/1/?file=40442#file40442line169 I'd prefer to see this refactored so that the X86 architectural page table inherits from the multi-level page table instead.