Re: [gem5-dev] Review Request 2787: ruby: Fixed pipeline squashes caused by aliased requests

> On May 29, 2015, 3:01 p.m., Joel Hestness wrote: > > src/mem/ruby/system/Sequencer.cc, line 532 > > > > > > The Sequencer should not be handling stores in this manner. This > > effectively coalesces and completes

[gem5-dev] changeset in gem5: mem: Tidy up CacheSet

changeset 8539728fd457 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=8539728fd457 description: mem: Tidy up CacheSet Minor tweaks and house keeping. diffstat: src/mem/cache/tags/cacheset.hh | 15 --- 1 files changed, 4 insertions(+), 11

[gem5-dev] changeset in gem5: mem: Avoid setting markPending if not needed

changeset 61b329833f74 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=61b329833f74 description: mem: Avoid setting markPending if not needed In cases where a newly added target does not have any upstream MSHR to mark as downstreamPending, remember

[gem5-dev] changeset in gem5: sim: Fix time unit in abort message

changeset 31ab5ca6836d in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=31ab5ca6836d description: sim: Fix time unit in abort message diffstat: src/sim/init_signals.cc | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diffs (12 lines): diff -r 95eb22928d0f

[gem5-dev] changeset in gem5: mem: Tidy up the snoop state-transition logic

changeset 4d8b7783a692 in /z/repo/gem5 details: http://repo.gem5.org/gem5?cmd=changeset;node=4d8b7783a692 description: mem: Tidy up the snoop state-transition logic Remove broken and unused option to pass dirty data on non-exclusive snoops. Also beef up the comments a bit.

Re: [gem5-dev] Review Request 2525: x86: Add a cirrus graphics adapter to x86 systems.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2525/#review7115 --- sorry, one more thing src/dev/cirrus.hh (line 48)

Re: [gem5-dev] including reviewboard URL in commit message?

No strong opinion in either direction. I have not experienced a situation where it was needed, but I also do not think it is too much to ask. Andreas On 04/09/2015 18:34, "gem5-dev on behalf of Gutierrez, Anthony" wrote: >I like

Re: [gem5-dev] including reviewboard URL in commit message?

I like the idea as well. Without giving it any thought myself, is there anyway to automate this? Jason On Fri, Sep 4, 2015 at 12:35 PM Gutierrez, Anthony < anthony.gutier...@amd.com> wrote: > I like that idea. Or at least the review number, for brevity's sake. > > -Original Message- >

Re: [gem5-dev] Review Request 2525: x86: Add a cirrus graphics adapter to x86 systems.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2525/#review7114 --- Looks good other than the one minor thing below. src/dev/cirrus.cc

Re: [gem5-dev] Review Request 2511: dev: cirrus: Add a simplified device model for the cirrus graphics device.

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2511/#review7116 --- Ship it! Is there any value in making it conditional? - Steve

[gem5-dev] including reviewboard URL in commit message?

Hi everyone, Just a thought: should we require commit messages to include the URL of the corresponding reviewboard posting? I think that would be useful in tying the discussion to the commit. Apologies if someone suggested this before and I missed it. Steve

Re: [gem5-dev] Review Request 2965: rename System.{hh, cc} to RubySystem.{hh, cc}

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/2965/#review7117 --- Ship it! I had been putting off this review since it touched so many

Re: [gem5-dev] including reviewboard URL in commit message?

To be concrete, Andreas, I saw your commit of the "Avoid setting markPending" changeset, and I thought "gee, I wonder how long that was on reviewboard, and whether it got any ship-its, because I don't recall reviewing it". I was able to find it by searching my email for "markPending" to see the

Re: [gem5-dev] Review Request 3083: ruby: slicc: remove nextLineHack from Type.py

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3083/#review7119 --- Ship it! Ship It! - Brad Beckmann On Sept. 2, 2015, 12:52 a.m.,

Re: [gem5-dev] Review Request 2787: ruby: Fixed pipeline squashes caused by aliased requests

> On Aug. 30, 2015, 6:01 p.m., Joel Hestness wrote: > > Hi guys, > > > > I'm not sure of the status of or plans for this patch, but I wanted to test > > it out and provide some feedback. I've merged and tested this with the > > current gem5 head (11061). First, there are a number of things

Re: [gem5-dev] Review Request 3083: ruby: slicc: remove nextLineHack from Type.py

> On Sept. 2, 2015, 7:41 p.m., Jason Lowe-Power wrote: > > Do you know what this was used for? I've never encountered this, but it > > probably had a good reason to be there at some point... > > Nilay Vaish wrote: > None of the current protocols use it. The line has seen not any changes

Re: [gem5-dev] Review Request 3006: ruby: simple network: store Switch* in PerfectSwitch and Throttle

> On Sept. 2, 2015, 12:52 a.m., Nilay Vaish wrote: > > Does any one has any comments on this patch? I don't have any problems with this patch, but I'm curious what is the motivation? - Brad --- This is an automatically generated

[gem5-dev] Review Request 3098: ruby: sequencer: add secondary request type to SequencerRequest

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3098/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3096: ruby: sequencer: combined read and write request tables

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3096/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3099: ruby: sequencer: coalesce requests

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3099/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3094: ruby: sequencer: remove commented out function printProgress()

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3094/ --- Review request for Default. Repository: gem5 Description --- Changeset

[gem5-dev] Review Request 3095: ruby: remove unused function removeRequest()

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3095/ --- Review request for Default. Repository: gem5 Description --- Changeset

Re: [gem5-dev] Review Request 2787: ruby: Fixed pipeline squashes caused by aliased requests

> On Aug. 30, 2015, 6:01 p.m., Joel Hestness wrote: > > Hi guys, > > > > I'm not sure of the status of or plans for this patch, but I wanted to test > > it out and provide some feedback. I've merged and tested this with the > > current gem5 head (11061). First, there are a number of things

Re: [gem5-dev] Review Request 2787: ruby: Fixed pipeline squashes caused by aliased requests

> On Aug. 30, 2015, 6:01 p.m., Joel Hestness wrote: > > Hi guys, > > > > I'm not sure of the status of or plans for this patch, but I wanted to test > > it out and provide some feedback. I've merged and tested this with the > > current gem5 head (11061). First, there are a number of things

Re: [gem5-dev] Review Request 3006: ruby: simple network: store Switch* in PerfectSwitch and Throttle

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3006/ --- (Updated Sept. 5, 2015, 12:38 a.m.) Review request for Default. Repository: gem5

Re: [gem5-dev] Review Request 3006: ruby: simple network: store Switch* in PerfectSwitch and Throttle

> On Sept. 2, 2015, 12:52 a.m., Nilay Vaish wrote: > > Does any one has any comments on this patch? > > Brad Beckmann wrote: > I don't have any problems with this patch, but I'm curious what is the > motivation? I have updated the patch description. - Nilay

Re: [gem5-dev] Review Request 3002: ruby: slicc: fix naming of variables

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3002/ --- (Updated Sept. 5, 2015, 12:50 a.m.) Review request for Default. Repository: gem5

[gem5-dev] Cron <m5test@zizzer> /z/m5/regression/do-regression quick

* build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/minor-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/o3-timing passed. * build/ALPHA/tests/opt/quick/se/00.hello/alpha/linux/simple-atomic passed. *