[gem5-dev] Change in gem5/gem5[develop]: stdlib,mem-ruby: CHI support in components

2021-11-04 Thread Jason Lowe-Power (Gerrit) via gem5-dev
Jason Lowe-Power has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/52463 ) Change subject: stdlib,mem-ruby: CHI support in components .. stdlib,mem-ruby: CHI support in components

[gem5-dev] Re: Build failed in Jenkins: nightly #27

2021-11-04 Thread Gabe Black via gem5-dev
Oh, yes, that does look very suspicious. I'll have to take a closer look at that! Gabe On Thu, Nov 4, 2021 at 3:02 PM Jason Lowe-Power wrote: > Glad you asked! I didn't look closely enough at the output. > > Here's an error that looks suspicious (The whole file is attached.) > >

[gem5-dev] Change in gem5/gem5[develop]: arch-gcn3,arch-vega: Don't write exec in v_cmp_f_i32

2021-11-04 Thread Kyle Roarty (Gerrit) via gem5-dev
Kyle Roarty has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/52445 ) Change subject: arch-gcn3,arch-vega: Don't write exec in v_cmp_f_i32 .. arch-gcn3,arch-vega: Don't write exec in

[gem5-dev] Change in gem5/gem5[develop]: mem-cache: Ensure all fields of the CacheBlk class are initialized.

2021-11-04 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/52404 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mem-cache: Ensure all fields of the CacheBlk class

[gem5-dev] Change in gem5/gem5[develop]: stdlib: Fix resource downloader download to cwd upon failure

2021-11-04 Thread Bobby R. Bruce (Gerrit) via gem5-dev
Bobby R. Bruce has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/52423 ) Change subject: stdlib: Fix resource downloader download to cwd upon failure .. stdlib: Fix resource

[gem5-dev] Re: Build failed in Jenkins: nightly #27

2021-11-04 Thread Jason Lowe-Power via gem5-dev
Glad you asked! I didn't look closely enough at the output. Here's an error that looks suspicious (The whole file is attached.) build/ARM_clang/cpu/o3/dyn_inst.hh:252:29: runtime error: constructor call on misaligned address 0x1c1ed9ac for type 'gem5::PhysRegId *', which requires 8 byte

[gem5-dev] Re: Build failed in Jenkins: nightly #27

2021-11-04 Thread Gabe Black via gem5-dev
Did you find anything with ASAN? Gabe On Thu, Nov 4, 2021, 12:59 PM Gabe Black wrote: > I don't know if they do, and frankly even the unique_ptr change could > since that could fix heap corruption, even though it's unlikely since I > don't think this regression uses any of that code (except

[gem5-dev] default m5ops_base to off on x86

2021-11-04 Thread Gabe Black via gem5-dev
Hey folks. One of the last things to sort out before I'd consider the gem5 mutli-ISA support at least usable is that the m5ops_base config parameter defaults to zero, except if you're on x86 where it defaults to 0x. I think it would make sense to instead default it to 0 all the time,

[gem5-dev] Re: Build failed in Jenkins: nightly #27

2021-11-04 Thread Gabe Black via gem5-dev
I don't know if they do, and frankly even the unique_ptr change could since that could fix heap corruption, even though it's unlikely since I don't think this regression uses any of that code (except maybe VIO). We don't actually *know* that that change is at fault, even though I agree that it

[gem5-dev] Re: preview branch for mutli-ISA gem5?

2021-11-04 Thread Gabe Black via gem5-dev
To be clear, I'm not suggesting a branch that gets merged with develop at some intersection point, I'm just suggesting a branch where the changes are all stacked together so they're easy to try out. There are too many interactions between these changes and the rest of gem5 to expect there not to

[gem5-dev] Change in gem5/gem5[develop]: mem-cache: Don't generate debug output unless you're going to use it.

2021-11-04 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/52405 ) ( 1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mem-cache: Don't generate debug output unless

[gem5-dev] Change in gem5/gem5[develop]: misc: Add 'stdlib' tag to MAINTAINERS.yaml

2021-11-04 Thread Bobby R. Bruce (Gerrit) via gem5-dev
Bobby R. Bruce has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/51791 ) Change subject: misc: Add 'stdlib' tag to MAINTAINERS.yaml .. misc: Add 'stdlib' tag to MAINTAINERS.yaml This tag is

[gem5-dev] Re: preview branch for mutli-ISA gem5?

2021-11-04 Thread Bobby Bruce via gem5-dev
I think it's a great idea and we should probably do it more often for this big long changes we don't want to straddle a release. -- Dr. Bobby R. Bruce Room 3050, Kemper Hall, UC Davis Davis, CA, 95616 web: https://www.bobbybruce.net On Thu, Nov 4, 2021 at 7:42 AM Jason Lowe-Power via gem5-dev

[gem5-dev] Re: Build failed in Jenkins: nightly #27

2021-11-04 Thread Jason Lowe-Power via gem5-dev
Hey Gabe, Do these fix the nightly regression? If not, we may need to back out "4fe56ff72 - (3 months ago) arch-arm,cpu: Replace rename modes with split reg/elem register files." until we have a fix. Cheers, Jason On Thu, Nov 4, 2021 at 12:13 AM Gabe Black wrote: > Valgrind hasn't finished,

[gem5-dev] Re: preview branch for mutli-ISA gem5?

2021-11-04 Thread Jason Lowe-Power via gem5-dev
Seems like a good idea to me! I like the idea of having more feature branches for long-lived relation chains. Given the timing, it seems like it would be a good idea to hold off integrating this until gem5 22.0. If we have a branch we can test for a while, it will be less likely to break our

[gem5-dev] Build failed in Jenkins: nightly #32

2021-11-04 Thread jenkins-no-reply--- via gem5-dev
See Changes: [giacomo.travaglini] arch: Fix serialization/deserialization of Vector registers [Bobby R. Bruce] python: Remove incorrect usage of typing 'Optional' [Bobby R. Bruce] tests: Removing Atomic CPU with Ruby tests

[gem5-dev] Re: Build failed in Jenkins: nightly #27

2021-11-04 Thread Gabe Black via gem5-dev
Valgrind hasn't finished, but what it found so far is attached. I went through it and have the following changes which should address these uninitialized accesses, and an inefficiency in the cache it found by accident. https://gem5-review.googlesource.com/c/public/gem5/+/52403

[gem5-dev] Change in gem5/gem5[develop]: dev-arm: Ensure all fields of GicV2 are initialized.

2021-11-04 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/52406 ) Change subject: dev-arm: Ensure all fields of GicV2 are initialized. .. dev-arm: Ensure all fields of GicV2 are

[gem5-dev] Change in gem5/gem5[develop]: mem-cache: Don't generate debug output unless you're going to use it.

2021-11-04 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/52405 ) Change subject: mem-cache: Don't generate debug output unless you're going to use it. .. mem-cache: Don't

[gem5-dev] Change in gem5/gem5[develop]: mem-cache: Ensure all fields of the CacheBlk class are initialized.

2021-11-04 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/52404 ) Change subject: mem-cache: Ensure all fields of the CacheBlk class are initialized. .. mem-cache: Ensure all

[gem5-dev] Change in gem5/gem5[develop]: dev-arm: Set default initial values in GenericTimer::CoreTimers.

2021-11-04 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/52403 ) Change subject: dev-arm: Set default initial values in GenericTimer::CoreTimers. .. dev-arm: Set default

[gem5-dev] preview branch for mutli-ISA gem5?

2021-11-04 Thread Gabe Black via gem5-dev
Hey folks, I'm not quite ready for it yet, but I'm getting close to having everything at least written for a multi-ISA version of gem5. What do you think about having a preview branch on gerrit? I can create one pretty easily, I just want to make sure that's appropriate and something other people