On Wed, 29 Apr 2015, Beckmann, Brad wrote:
My main objection to the change is that it is not worth the time. It is
taking a sledgehammer to a bug that only requires a minor tweak. There
is a lot of downstream code that will be impacted by a change that
doesn't provide any real benefit. To
Replies below:
-Original Message-
From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Nilay Vaish
Sent: Thursday, April 30, 2015 8:20 AM
To: gem5 Developer List
Subject: Re: [gem5-dev] Review Request 2749: cpu: testers: rubytest: fix the
test
On Wed, 29 Apr 2015, Beckmann
On Tue, 28 Apr 2015, Beckmann, Brad wrote:
The tester has always been a single object (since 1999!). The tester
works in a coordinated fashion to instigate races. It does not operate
as separate independent objects.
Brad, even if it has been a single object for a long time, I still
or
multiple RubyTesters.
Brad
-Original Message-
From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Nilay Vaish
Sent: Wednesday, April 29, 2015 1:35 PM
To: gem5 Developer List
Subject: Re: [gem5-dev] Review Request 2749: cpu: testers: rubytest: fix the
test
On Tue, 28 Apr 2015
On Mon, 27 Apr 2015, Brad Beckmann wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2749/#review6088
---
Responding to Nilay's
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2749/#review6091
---
Brad's comment aside, is there really a need for a Ruby-specific tester
On Mon, 27 Apr 2015, Steve Reinhardt wrote:
I appreciate Nilay's desire to not have the tester configuration diverge
from the simulation configuration. However, the general impression I get
here is that we're making the C++ more complicated in order to avoid
changes to the Python. Given that
not need to be Ruby specific, but it is
quite powerful.
Brad
-Original Message-
From: gem5-dev [mailto:gem5-dev-boun...@gem5.org] On Behalf Of Nilay Vaish
Sent: Tuesday, April 28, 2015 11:50 AM
To: gem5 Developer List
Subject: Re: [gem5-dev] Review Request 2749: cpu: testers: rubytest: fix
On Mon, 27 Apr 2015, Brad Beckmann wrote:
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2749/#review6086
---
Why make such a large and
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2749/#review6086
---
Why make such a large and ugly change to fix a seemingly simple problem
I appreciate Nilay's desire to not have the tester configuration diverge
from the simulation configuration. However, the general impression I get
here is that we're making the C++ more complicated in order to avoid
changes to the Python. Given that the point of putting the configuration in
python
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2749/#review6088
---
Responding to Nilay's comments over email:
I think it would be best if
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.gem5.org/r/2749/
---
Review request for Default.
Repository: gem5
Description
---
Changeset
13 matches
Mail list logo
